)]}'
{"os_brick/executor.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"203ac221efc31081415cd258a81ebc83e185fe84","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @staticmethod"},{"line_number":36,"context_line":"    def safe_decode(string):"},{"line_number":37,"context_line":"        return string and encodeutils.safe_decode(string, errors\u003d\u0027ignore\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @classmethod"},{"line_number":40,"context_line":"    def make_putils_error_safe(cls, exc):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_10d59d42","line":37,"updated":"2016-07-28 09:44:59.000000000","message":"Will it return True or False value? Please, add unit test for this method","commit_id":"916c06dd93142b547697a4ce5c3696090e2230c6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1c5f2622230c9cc6ff88e58defbb5e4b77d168e1","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @staticmethod"},{"line_number":36,"context_line":"    def safe_decode(string):"},{"line_number":37,"context_line":"        return string and encodeutils.safe_decode(string, errors\u003d\u0027ignore\u0027)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @classmethod"},{"line_number":40,"context_line":"    def make_putils_error_safe(cls, exc):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_b8fef335","line":37,"in_reply_to":"bacf61ea_10d59d42","updated":"2016-07-29 12:44:32.000000000","message":"It will not return a boolean value, it will return None, empty string, or a safe decoded string depending on the value of string.\n\nThis method is already being tested on newly added test_executor tests, as we check returned stdin and stderr which is always calling safe_decode method (L51-52).","commit_id":"916c06dd93142b547697a4ce5c3696090e2230c6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c524dfc665d18057265959737d0dc5bcc87f69ca","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            return result"},{"line_number":54,"context_line":"        except putils.ProcessExecutionError as e:"},{"line_number":55,"context_line":"            self.make_putils_error_safe(e)"},{"line_number":56,"context_line":"            raise e"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def set_execute(self, execute):"},{"line_number":59,"context_line":"        self.__execute \u003d execute"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_0530c59d","line":56,"range":{"start_line":56,"start_character":17,"end_line":56,"end_character":19},"updated":"2016-08-12 20:37:31.000000000","message":"Should just be \"raise\", not \"raise e\".","commit_id":"d39993fbdfbb81c2c82bc345d4cf0b2379cbb52d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ae8a34f8677e2c3351486776debf79255468b032","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            return result"},{"line_number":54,"context_line":"        except putils.ProcessExecutionError as e:"},{"line_number":55,"context_line":"            self.make_putils_error_safe(e)"},{"line_number":56,"context_line":"            raise e"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def set_execute(self, execute):"},{"line_number":59,"context_line":"        self.__execute \u003d execute"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_af024007","line":56,"range":{"start_line":56,"start_character":17,"end_line":56,"end_character":19},"in_reply_to":"3ac371cc_d9bcaa6e","updated":"2016-08-16 12:11:56.000000000","message":"Well, the problem is it won\u0027t actually have the same effect as the traceback gets modified by doing \u0027raise e\u0027 instead of just \u0027raise\u0027.\n\nhttp://paste.openstack.org/show/558362/\n\nMaybe not a big deal here, but I think if something goes wrong it would be useful to know exactly where the issue occurred.","commit_id":"d39993fbdfbb81c2c82bc345d4cf0b2379cbb52d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"49e7c54c8050f57fbe90f7faaf94476675dc03d3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            return result"},{"line_number":54,"context_line":"        except putils.ProcessExecutionError as e:"},{"line_number":55,"context_line":"            self.make_putils_error_safe(e)"},{"line_number":56,"context_line":"            raise e"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def set_execute(self, execute):"},{"line_number":59,"context_line":"        self.__execute \u003d execute"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_d9bcaa6e","line":56,"range":{"start_line":56,"start_character":17,"end_line":56,"end_character":19},"in_reply_to":"9ad45d7e_0530c59d","updated":"2016-08-16 11:52:21.000000000","message":"I would usually agree, but I think this case is slightly different, because we are actually modifying the exception instance stored in e.\n\nIt is true that it will have the same effect just writing \"raise\", but I want to make it explicit, since we are making changes to the instance.  I believe it makes it easier to follow the code.\n\nI will change it if you have strong feelings about this.","commit_id":"d39993fbdfbb81c2c82bc345d4cf0b2379cbb52d"}]}
