)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f8b662ba1315fb09a44df79f2d7764231df69898","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Raunak Kumar \u003crkumar@nimblestorage.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-15 09:11:36 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Closes-Bug: 1592520"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I22ca3c98534bacdc57c76dbc7b1e17d547117deb"},{"line_number":10,"context_line":"If queuing is enabled on multipath, queuing needs to be disabled before"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fad55976_1f515763","line":7,"updated":"2016-07-15 16:15:55.000000000","message":"Please provide a description of what the patch does as the first line.\n\nSee https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure for more info.","commit_id":"8f194e50672fb8b93ba098e714e340e62adbcc6f"}],"os_brick/initiator/linuxscsi.py":[{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"5f055b309ebddabbcf24dd6c2065e28773c8ab4b","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            LOG.warning(_LW(\"Failed to flush IO buffers prior to removing \""},{"line_number":153,"context_line":"                            \"device: %(code)s\"), {\u0027code\u0027: exc.exit_code})"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @utils.retry(exceptions\u003dexception.VolumePathNotRemoved, retries\u003d3,"},{"line_number":156,"context_line":"                 backoff_rate\u003d2)"},{"line_number":157,"context_line":"    def flush_multipath_device(self, device):"},{"line_number":158,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fad55976_9ebb7f0e","line":155,"updated":"2016-07-15 21:03:22.000000000","message":"Where would this VolumePathNotRemoved exception get raised?","commit_id":"2a80700d17d5129cb31260b9c5cbf2ad45957bfe"},{"author":{"_account_id":16668,"name":"Raunak Kumar","email":"rkumar@nimblestorage.com","username":"rkumar"},"change_message_id":"7d32121b0182b93b175a88ce21d56994640d1449","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            LOG.warning(_LW(\"Failed to flush IO buffers prior to removing \""},{"line_number":153,"context_line":"                            \"device: %(code)s\"), {\u0027code\u0027: exc.exit_code})"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @utils.retry(exceptions\u003dexception.VolumePathNotRemoved, retries\u003d3,"},{"line_number":156,"context_line":"                 backoff_rate\u003d2)"},{"line_number":157,"context_line":"    def flush_multipath_device(self, device):"},{"line_number":158,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fad55976_5e090731","line":155,"in_reply_to":"fad55976_9ebb7f0e","updated":"2016-07-15 22:16:26.000000000","message":"To the volume driver","commit_id":"2a80700d17d5129cb31260b9c5cbf2ad45957bfe"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"dc8dc42516e41dd9862ba3606b89fe12e16cb9f5","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        try:"},{"line_number":159,"context_line":"            LOG.debug(\"disable queueing on multipath device %s\", device)"},{"line_number":160,"context_line":"            self._execute(\u0027dmsetup\u0027, \u0027message\u0027, device, \u00270\u0027,"},{"line_number":161,"context_line":"                          \u0027\"fail_if_no_path\"\u0027,"},{"line_number":162,"context_line":"                          run_as_root\u003dTrue,"},{"line_number":163,"context_line":"                          root_helper\u003dself._root_helper)"},{"line_number":164,"context_line":"            LOG.debug(\"Flush multipath device %s\", device)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_50b5997b","line":161,"updated":"2016-07-21 20:14:30.000000000","message":"By definition, this message will cause all existing queued IO to fail and cause errors.   \n\nAccording to the docs :\n\"This command immediately causes all queued I/O to fail.\"","commit_id":"2a80700d17d5129cb31260b9c5cbf2ad45957bfe"},{"author":{"_account_id":16668,"name":"Raunak Kumar","email":"rkumar@nimblestorage.com","username":"rkumar"},"change_message_id":"7559defe9d04b872eae8b58dffb50cfbfeca01ba","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        try:"},{"line_number":159,"context_line":"            LOG.debug(\"disable queueing on multipath device %s\", device)"},{"line_number":160,"context_line":"            self._execute(\u0027dmsetup\u0027, \u0027message\u0027, device, \u00270\u0027,"},{"line_number":161,"context_line":"                          \u0027\"fail_if_no_path\"\u0027,"},{"line_number":162,"context_line":"                          run_as_root\u003dTrue,"},{"line_number":163,"context_line":"                          root_helper\u003dself._root_helper)"},{"line_number":164,"context_line":"            LOG.debug(\"Flush multipath device %s\", device)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_0e03c60e","line":161,"in_reply_to":"dada55a8_50b5997b","updated":"2016-07-22 18:58:23.000000000","message":"Ok, i was thinking of an alternative as follows :\n1. Suspend the dm device by dmsetup suspend /dev/dm-x\n2. Check for inflight i/o\u0027s at /sys/block/dm-x/inflight unless it is zero (back off 3 times)\n3. Disable queuing on the device \n4. Flush the device.\n\nLet me know if this would take care of your concerns","commit_id":"2a80700d17d5129cb31260b9c5cbf2ad45957bfe"}]}