)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"be0520569fe1c2d5b1f2d26b190e4531f4702287","unresolved":false,"context_lines":[{"line_number":10,"context_line":"cluster has a different name, the backup manager won\u0027t be able"},{"line_number":11,"context_line":"to connect to the ceph cluster."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This fix creates temporary ceph conf file to inlclude mon_hosts and"},{"line_number":14,"context_line":"client section for cinder user to specify keyring path, the same conf"},{"line_number":15,"context_line":"file will be passed to linux rbd initiator to connect to ceph cluster"},{"line_number":16,"context_line":"and the temp file will be deleted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3ac371cc_f21f31b5","line":13,"range":{"start_line":13,"start_character":46,"end_line":13,"end_character":53},"updated":"2016-08-19 10:04:36.000000000","message":"include","commit_id":"fd0ce55ac4c63c7f7a8219ad2275e3844fe67cf1"}],"os_brick/initiator/connectors/rbd.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"40a37b8aae856e905dbe3caca9f603f16608e0ce","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            msg \u003d _(\"Connect volume failed, malformed connection properties\")"},{"line_number":67,"context_line":"            raise exception.BrickException(msg\u003dmsg)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        rbd_client \u003d linuxrbd.RBDClient(user, pool, conffile\u003dstr(conf),"},{"line_number":70,"context_line":"                                        rbd_cluster_name\u003dstr(cluster_name))"},{"line_number":71,"context_line":"        rbd_volume \u003d linuxrbd.RBDVolume(rbd_client, volume)"},{"line_number":72,"context_line":"        rbd_handle \u003d linuxrbd.RBDVolumeIOWrapper("}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_0ceff7e9","line":69,"range":{"start_line":69,"start_character":61,"end_line":69,"end_character":64},"updated":"2016-08-04 13:56:23.000000000","message":"Doesn\u0027t appear it\u0027s necessary to convert to a string.","commit_id":"270d863676e6e7f8d3baf35d9a772d6c24d8c031"},{"author":{"_account_id":20585,"name":"Naga Venkata","email":"naga.b@hpe.com","username":"naga"},"change_message_id":"a7fe6765baf7781c2938cbea77f8c5f4363d3966","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            msg \u003d _(\"Connect volume failed, malformed connection properties\")"},{"line_number":67,"context_line":"            raise exception.BrickException(msg\u003dmsg)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        rbd_client \u003d linuxrbd.RBDClient(user, pool, conffile\u003dstr(conf),"},{"line_number":70,"context_line":"                                        rbd_cluster_name\u003dstr(cluster_name))"},{"line_number":71,"context_line":"        rbd_volume \u003d linuxrbd.RBDVolume(rbd_client, volume)"},{"line_number":72,"context_line":"        rbd_handle \u003d linuxrbd.RBDVolumeIOWrapper("}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_cc267fcd","line":69,"range":{"start_line":69,"start_character":61,"end_line":69,"end_character":64},"in_reply_to":"bacf61ea_0c91b7f1","updated":"2016-08-04 14:05:14.000000000","message":"no, it comes as unicode type","commit_id":"270d863676e6e7f8d3baf35d9a772d6c24d8c031"},{"author":{"_account_id":20585,"name":"Naga Venkata","email":"naga.b@hpe.com","username":"naga"},"change_message_id":"5dc55856cc949589b61c1db6c3eae838e4afb35e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            msg \u003d _(\"Connect volume failed, malformed connection properties\")"},{"line_number":67,"context_line":"            raise exception.BrickException(msg\u003dmsg)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        rbd_client \u003d linuxrbd.RBDClient(user, pool, conffile\u003dstr(conf),"},{"line_number":70,"context_line":"                                        rbd_cluster_name\u003dstr(cluster_name))"},{"line_number":71,"context_line":"        rbd_volume \u003d linuxrbd.RBDVolume(rbd_client, volume)"},{"line_number":72,"context_line":"        rbd_handle \u003d linuxrbd.RBDVolumeIOWrapper("}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_6cd313d6","line":69,"range":{"start_line":69,"start_character":61,"end_line":69,"end_character":64},"in_reply_to":"bacf61ea_0ceff7e9","updated":"2016-08-04 14:01:58.000000000","message":"it should be string, https://github.com/ceph/ceph/blob/v0.94.7/src/pybind/rados.py#L224 this expects conffile and clustername as string.","commit_id":"270d863676e6e7f8d3baf35d9a772d6c24d8c031"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"71c6f8f24140ab2833b1bf102bce38dd23b9e5da","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            msg \u003d _(\"Connect volume failed, malformed connection properties\")"},{"line_number":67,"context_line":"            raise exception.BrickException(msg\u003dmsg)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        rbd_client \u003d linuxrbd.RBDClient(user, pool, conffile\u003dstr(conf),"},{"line_number":70,"context_line":"                                        rbd_cluster_name\u003dstr(cluster_name))"},{"line_number":71,"context_line":"        rbd_volume \u003d linuxrbd.RBDVolume(rbd_client, volume)"},{"line_number":72,"context_line":"        rbd_handle \u003d linuxrbd.RBDVolumeIOWrapper("}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_0c91b7f1","line":69,"range":{"start_line":69,"start_character":61,"end_line":69,"end_character":64},"in_reply_to":"bacf61ea_6cd313d6","updated":"2016-08-04 14:03:20.000000000","message":"My point is there doesn\u0027t appear to be a way where it won\u0027t already be a string, so no need to call str() on it.","commit_id":"270d863676e6e7f8d3baf35d9a772d6c24d8c031"},{"author":{"_account_id":20585,"name":"Naga Venkata","email":"naga.b@hpe.com","username":"naga"},"change_message_id":"f441e5679b6ca8744b4586bbb0774827ab9a9b05","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            msg \u003d _(\"Connect volume failed, malformed connection properties\")"},{"line_number":67,"context_line":"            raise exception.BrickException(msg\u003dmsg)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        rbd_client \u003d linuxrbd.RBDClient(user, pool, conffile\u003dstr(conf),"},{"line_number":70,"context_line":"                                        rbd_cluster_name\u003dstr(cluster_name))"},{"line_number":71,"context_line":"        rbd_volume \u003d linuxrbd.RBDVolume(rbd_client, volume)"},{"line_number":72,"context_line":"        rbd_handle \u003d linuxrbd.RBDVolumeIOWrapper("}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_a711a454","line":69,"range":{"start_line":69,"start_character":61,"end_line":69,"end_character":64},"in_reply_to":"bacf61ea_cc267fcd","updated":"2016-08-04 14:06:19.000000000","message":"please have a look at https://review.openstack.org/#/c/350994/","commit_id":"270d863676e6e7f8d3baf35d9a772d6c24d8c031"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"c6e53010c5815db85899eca585cd0e4b2260962d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            msg \u003d _(\"Connect volume failed, malformed connection properties\")"},{"line_number":86,"context_line":"            raise exception.BrickException(msg\u003dmsg)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        conf \u003d self._create_ceph_conf(monitor_ips, str(cluster_name), user)"},{"line_number":89,"context_line":"        rbd_client \u003d linuxrbd.RBDClient(user, pool, conffile\u003dconf,"},{"line_number":90,"context_line":"                                        rbd_cluster_name\u003dstr(cluster_name))"},{"line_number":91,"context_line":"        rbd_volume \u003d linuxrbd.RBDVolume(rbd_client, volume)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_65dc3275","line":88,"range":{"start_line":88,"start_character":20,"end_line":88,"end_character":37},"updated":"2016-08-19 00:26:50.000000000","message":"please make sure mon ports are also included so that in the case where deployment customized ceph mon ports can also be supported.","commit_id":"c7af0c0356b301e8418368659c58bc602a36d1c2"}]}
