)]}'
{"os_brick/initiator/connector.py":[{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"887ba3d50e5db5d6bc0e597b6195a68b433dc926","unresolved":false,"context_lines":[{"line_number":146,"context_line":"}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# Mapping for the S390X platform"},{"line_number":149,"context_line":"_connector_mapping_linux_s390x \u003d _connector_mapping_linux.copy()"},{"line_number":150,"context_line":"_connector_mapping_linux_s390x[initiator.FIBRE_CHANNEL] \u003d\\"},{"line_number":151,"context_line":"    \u0027os_brick.initiator.connectors.fibre_channel_s390x.\u0027 \\"},{"line_number":152,"context_line":"    \u0027FibreChannelConnectorS390X\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_db021809","line":149,"updated":"2016-09-23 13:47:37.000000000","message":"please add the following protocols:\n\ninitiator.DRBD\ninitiator.NFS\ninitiator.ISCSI:\ninitiator.FIBRE_CHANNEL:\ninitiator.LOCAL:\ninitiator.RBD:\ninitiator.GPFS:","commit_id":"6fe6a6fb0290c88b4f99503f2b2162b124090869"},{"author":{"_account_id":19991,"name":"Arne Recknagel","email":"arne.recknagel@hotmail.com","username":"arecknag"},"change_message_id":"fb4d7727e03a06fe5e43799016e63c43cdeac628","unresolved":false,"context_lines":[{"line_number":146,"context_line":"}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# Mapping for the S390X platform"},{"line_number":149,"context_line":"_connector_mapping_linux_s390x \u003d _connector_mapping_linux.copy()"},{"line_number":150,"context_line":"_connector_mapping_linux_s390x[initiator.FIBRE_CHANNEL] \u003d\\"},{"line_number":151,"context_line":"    \u0027os_brick.initiator.connectors.fibre_channel_s390x.\u0027 \\"},{"line_number":152,"context_line":"    \u0027FibreChannelConnectorS390X\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_98da164b","line":149,"in_reply_to":"5a8bc5a2_3045a0b2","updated":"2016-09-27 06:31:56.000000000","message":"I think it\u0027s best to maintain a separate list, following the example of the linux and windows mapping. The change is reflected in patch set 2.","commit_id":"6fe6a6fb0290c88b4f99503f2b2162b124090869"},{"author":{"_account_id":11433,"name":"Stefan Amann","email":"stefan.amann@de.ibm.com","username":"StefanAmann"},"change_message_id":"e695b0dd128a862b7221a70f9d7831f73c03982d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# Mapping for the S390X platform"},{"line_number":149,"context_line":"_connector_mapping_linux_s390x \u003d _connector_mapping_linux.copy()"},{"line_number":150,"context_line":"_connector_mapping_linux_s390x[initiator.FIBRE_CHANNEL] \u003d\\"},{"line_number":151,"context_line":"    \u0027os_brick.initiator.connectors.fibre_channel_s390x.\u0027 \\"},{"line_number":152,"context_line":"    \u0027FibreChannelConnectorS390X\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_d634affc","line":149,"in_reply_to":"5a8bc5a2_bbd38c37","updated":"2016-09-23 14:15:38.000000000","message":"Yes.. I copied them. Actually, I copied those I know to work on s390x. I hope my list to be complete. But am not 100% sure. Other vendors may have ported their products to our platform, too. And I may have missed them. What is more risky? Adding protocols which are then not supported, or missing protocols? Any suggestion is highly appreciated...","commit_id":"6fe6a6fb0290c88b4f99503f2b2162b124090869"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"51d134e7c29f8bfa1676716f7a3e72047c6a44f8","unresolved":false,"context_lines":[{"line_number":146,"context_line":"}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# Mapping for the S390X platform"},{"line_number":149,"context_line":"_connector_mapping_linux_s390x \u003d _connector_mapping_linux.copy()"},{"line_number":150,"context_line":"_connector_mapping_linux_s390x[initiator.FIBRE_CHANNEL] \u003d\\"},{"line_number":151,"context_line":"    \u0027os_brick.initiator.connectors.fibre_channel_s390x.\u0027 \\"},{"line_number":152,"context_line":"    \u0027FibreChannelConnectorS390X\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_3045a0b2","line":149,"in_reply_to":"5a8bc5a2_d634affc","updated":"2016-09-26 08:42:50.000000000","message":"@Stefan: The point is, that Arnes code copies the whole list of supported types and then just replaces the one that is different on s390 Linux..With this approach, s390 linux is a special case of linux. So all of the items you proposed are already included.\n\nBut as the Linux list comprises much more connectors than s390 seems to support (along your list), my feeling is to maintain a dedicated list for s390 (instead of inheriting everything from linux). Doing so the code is very clear about what is supported and what not.\n\nthe alternative would be to inherit from Linux, but remove all not supported connectors. Such code is ugly to read and to maintain (e.g. if a new connector gets added one day)","commit_id":"6fe6a6fb0290c88b4f99503f2b2162b124090869"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"663fa582a0b915b27cb96118c797586e02e91689","unresolved":false,"context_lines":[{"line_number":146,"context_line":"}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# Mapping for the S390X platform"},{"line_number":149,"context_line":"_connector_mapping_linux_s390x \u003d _connector_mapping_linux.copy()"},{"line_number":150,"context_line":"_connector_mapping_linux_s390x[initiator.FIBRE_CHANNEL] \u003d\\"},{"line_number":151,"context_line":"    \u0027os_brick.initiator.connectors.fibre_channel_s390x.\u0027 \\"},{"line_number":152,"context_line":"    \u0027FibreChannelConnectorS390X\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_bbd38c37","line":149,"in_reply_to":"5a8bc5a2_db021809","updated":"2016-09-23 13:52:43.000000000","message":"Looks like all of those are added from copying the linux connector mapping.\n\nThat raises an interesting point though. Are there any in the linux mapping that should be removed for s390x? Doing things this way adds the risk that a new connector can be added to linux that indirectly impacts s390x.","commit_id":"6fe6a6fb0290c88b4f99503f2b2162b124090869"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8a1c574b42608c7e7465af9febbd5a5a17ee0faa","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# Mapping for the S390X platform"},{"line_number":149,"context_line":"_connector_mapping_linux_s390x \u003d _connector_mapping_linux.copy()"},{"line_number":150,"context_line":"_connector_mapping_linux_s390x[initiator.FIBRE_CHANNEL] \u003d\\"},{"line_number":151,"context_line":"    \u0027os_brick.initiator.connectors.fibre_channel_s390x.\u0027 \\"},{"line_number":152,"context_line":"    \u0027FibreChannelConnectorS390X\u0027"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_80dc9d13","line":150,"range":{"start_line":150,"start_character":57,"end_line":150,"end_character":58},"updated":"2016-09-23 13:40:28.000000000","message":"Please reformat this to get rid of the \\ for spanning lines.","commit_id":"6fe6a6fb0290c88b4f99503f2b2162b124090869"},{"author":{"_account_id":19991,"name":"Arne Recknagel","email":"arne.recknagel@hotmail.com","username":"arecknag"},"change_message_id":"fb4d7727e03a06fe5e43799016e63c43cdeac628","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# Mapping for the S390X platform"},{"line_number":149,"context_line":"_connector_mapping_linux_s390x \u003d _connector_mapping_linux.copy()"},{"line_number":150,"context_line":"_connector_mapping_linux_s390x[initiator.FIBRE_CHANNEL] \u003d\\"},{"line_number":151,"context_line":"    \u0027os_brick.initiator.connectors.fibre_channel_s390x.\u0027 \\"},{"line_number":152,"context_line":"    \u0027FibreChannelConnectorS390X\u0027"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_386bc286","line":150,"range":{"start_line":150,"start_character":57,"end_line":150,"end_character":58},"in_reply_to":"5a8bc5a2_80dc9d13","updated":"2016-09-27 06:31:56.000000000","message":"Done","commit_id":"6fe6a6fb0290c88b4f99503f2b2162b124090869"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"0da35cd427c75892db6f3611f0b18ed43d8f0a1a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        \u0027os_brick.initiator.connectors.fibre_channel_s390x.\u0027"},{"line_number":152,"context_line":"        \u0027FibreChannelConnectorS390X\u0027,"},{"line_number":153,"context_line":"    initiator.DRBD:"},{"line_number":154,"context_line":"        \u0027os_brick.initiator.connectors.drbd.DRBDConnector\u0027,"},{"line_number":155,"context_line":"    initiator.NFS:"},{"line_number":156,"context_line":"        \u0027os_brick.initiator.connectors.remotefs.RemoteFsConnector\u0027,"},{"line_number":157,"context_line":"    initiator.ISCSI:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_05a3f600","line":154,"updated":"2016-09-26 12:00:16.000000000","message":"what about referencing the linux connectors here?\n\n  initiator.DRBD: _connector_mapping_linux[initiator.DRBD],","commit_id":"478fe381893f98e35eb430add2a5585951d43b69"},{"author":{"_account_id":19991,"name":"Arne Recknagel","email":"arne.recknagel@hotmail.com","username":"arecknag"},"change_message_id":"844ca40e4ec6a2666c7381124006daaaa3ed6544","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        \u0027os_brick.initiator.connectors.fibre_channel_s390x.\u0027"},{"line_number":152,"context_line":"        \u0027FibreChannelConnectorS390X\u0027,"},{"line_number":153,"context_line":"    initiator.DRBD:"},{"line_number":154,"context_line":"        \u0027os_brick.initiator.connectors.drbd.DRBDConnector\u0027,"},{"line_number":155,"context_line":"    initiator.NFS:"},{"line_number":156,"context_line":"        \u0027os_brick.initiator.connectors.remotefs.RemoteFsConnector\u0027,"},{"line_number":157,"context_line":"    initiator.ISCSI:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_2e228a52","line":154,"in_reply_to":"5a8bc5a2_05a3f600","updated":"2016-09-27 06:59:22.000000000","message":"Can certainly be done to highlight which initiators actually do differ from the linux ones. Would like more input which is better design-wise.","commit_id":"478fe381893f98e35eb430add2a5585951d43b69"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"45f8eb2b8b1072afa5a7b2cbc730c2b3b6404ef1","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        \u0027os_brick.initiator.connectors.fibre_channel_s390x.\u0027"},{"line_number":152,"context_line":"        \u0027FibreChannelConnectorS390X\u0027,"},{"line_number":153,"context_line":"    initiator.DRBD:"},{"line_number":154,"context_line":"        \u0027os_brick.initiator.connectors.drbd.DRBDConnector\u0027,"},{"line_number":155,"context_line":"    initiator.NFS:"},{"line_number":156,"context_line":"        \u0027os_brick.initiator.connectors.remotefs.RemoteFsConnector\u0027,"},{"line_number":157,"context_line":"    initiator.ISCSI:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_b5684b89","line":154,"in_reply_to":"5a8bc5a2_2e228a52","updated":"2016-09-27 22:31:20.000000000","message":"I don\u0027t think this needs to be changed.  It is consistent with what other mappings are being done.","commit_id":"478fe381893f98e35eb430add2a5585951d43b69"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"0da35cd427c75892db6f3611f0b18ed43d8f0a1a","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        \u0027os_brick.initiator.connectors.gpfs.GPFSConnector\u0027,"},{"line_number":165,"context_line":"}"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Mapping for the windows connectors"},{"line_number":169,"context_line":"_connector_mapping_windows \u003d {"},{"line_number":170,"context_line":"    initiator.ISCSI:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_576cd834","line":167,"updated":"2016-09-26 12:00:16.000000000","message":"nit: added space","commit_id":"478fe381893f98e35eb430add2a5585951d43b69"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"45f8eb2b8b1072afa5a7b2cbc730c2b3b6404ef1","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        \u0027os_brick.initiator.connectors.gpfs.GPFSConnector\u0027,"},{"line_number":165,"context_line":"}"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Mapping for the windows connectors"},{"line_number":169,"context_line":"_connector_mapping_windows \u003d {"},{"line_number":170,"context_line":"    initiator.ISCSI:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_756ec397","line":167,"in_reply_to":"5a8bc5a2_4ec35689","updated":"2016-09-27 22:31:20.000000000","message":"Should get this fixed.","commit_id":"478fe381893f98e35eb430add2a5585951d43b69"},{"author":{"_account_id":19991,"name":"Arne Recknagel","email":"arne.recknagel@hotmail.com","username":"arecknag"},"change_message_id":"844ca40e4ec6a2666c7381124006daaaa3ed6544","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        \u0027os_brick.initiator.connectors.gpfs.GPFSConnector\u0027,"},{"line_number":165,"context_line":"}"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Mapping for the windows connectors"},{"line_number":169,"context_line":"_connector_mapping_windows \u003d {"},{"line_number":170,"context_line":"    initiator.ISCSI:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_4ec35689","line":167,"in_reply_to":"5a8bc5a2_576cd834","updated":"2016-09-27 06:59:22.000000000","message":"Will be included in the next patch","commit_id":"478fe381893f98e35eb430add2a5585951d43b69"}]}