)]}'
{"os_brick/initiator/linuxrbd.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e0e655bd4ed1714cf22fd8fb3c17c6627cd9b5e0","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        self.client \u003d client"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def close(self):"},{"line_number":116,"context_line":"        try:"},{"line_number":117,"context_line":"            self.image.close()"},{"line_number":118,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_0b60f434","line":115,"updated":"2016-09-28 18:41:58.000000000","message":"Do we really need close method if this class provides context manager API?","commit_id":"aad7028dbfbfc1145313479d02486511b3339b58"},{"author":{"_account_id":20403,"name":"Cheng Li","email":"shcli@cn.ibm.com","username":"Cheng"},"change_message_id":"0635c411e1b3e36bdace76705c7c77e76f050dc0","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        self.client \u003d client"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def close(self):"},{"line_number":116,"context_line":"        try:"},{"line_number":117,"context_line":"            self.image.close()"},{"line_number":118,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_caad1833","line":115,"in_reply_to":"3a98d1f4_0b60f434","updated":"2016-09-29 02:34:50.000000000","message":"We have __exit__ method which closes connection to ceph, but we don\u0027t have \"with context\" to call this method. So I think we have to call close to close connection.","commit_id":"aad7028dbfbfc1145313479d02486511b3339b58"}]}
