)]}'
{"os_brick/initiator/connectors/rbd.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3719f9f77e9db800e085cc12294d72d00763af73","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            fd, ceph_conf_path \u003d tempfile.mkstemp()"},{"line_number":67,"context_line":"            monitors \u003d [\"[%s]:%s\" % (ip, port) for ip, port"},{"line_number":68,"context_line":"                        in zip(monitor_ips, monitor_ports)]"},{"line_number":69,"context_line":"            mon_hosts \u003d \"mon_host \u003d %s\" % (\u0027,\u0027.join(monitors))"},{"line_number":70,"context_line":"            client_section \u003d \"[client.%s]\" % user"},{"line_number":71,"context_line":"            keyring \u003d (\"keyring \u003d /etc/ceph/%s.client.%s.keyring\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_fe6675eb","line":68,"updated":"2016-11-10 20:57:49.000000000","message":"Shouldn\u0027t this only be placed in brackets if \"ip\" is IPv6?\n\n(i.e. check if it contains a colon?)","commit_id":"851bb71265c8221b9e190d2b7908e117416eaa5f"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"c33587c197cc4244dcf22223957267b66ed7523d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            fd, ceph_conf_path \u003d tempfile.mkstemp()"},{"line_number":67,"context_line":"            monitors \u003d [\"[%s]:%s\" % (ip, port) for ip, port"},{"line_number":68,"context_line":"                        in zip(monitor_ips, monitor_ports)]"},{"line_number":69,"context_line":"            mon_hosts \u003d \"mon_host \u003d %s\" % (\u0027,\u0027.join(monitors))"},{"line_number":70,"context_line":"            client_section \u003d \"[client.%s]\" % user"},{"line_number":71,"context_line":"            keyring \u003d (\"keyring \u003d /etc/ceph/%s.client.%s.keyring\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_fe24b50d","line":68,"in_reply_to":"9a629dbe_7e88a571","updated":"2016-11-10 21:14:11.000000000","message":"Yeah, I can do this.  it would be a conditional applied to each member of the \u0027monitor_ips\u0027 collection.\n\nWhat\u0027s your take?","commit_id":"851bb71265c8221b9e190d2b7908e117416eaa5f"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"4e22f0edc7d7d4c4f0b1e80bac95f2a80aeef9b6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            fd, ceph_conf_path \u003d tempfile.mkstemp()"},{"line_number":67,"context_line":"            monitors \u003d [\"[%s]:%s\" % (ip, port) for ip, port"},{"line_number":68,"context_line":"                        in zip(monitor_ips, monitor_ports)]"},{"line_number":69,"context_line":"            mon_hosts \u003d \"mon_host \u003d %s\" % (\u0027,\u0027.join(monitors))"},{"line_number":70,"context_line":"            client_section \u003d \"[client.%s]\" % user"},{"line_number":71,"context_line":"            keyring \u003d (\"keyring \u003d /etc/ceph/%s.client.%s.keyring\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_de7a91bc","line":68,"in_reply_to":"9a629dbe_de70d10d","updated":"2016-11-10 21:18:42.000000000","message":"I tested it locally on v4 and v6 as well and all was okay, but please verify if you\u0027re inclined - i don\u0027t think the gate would catch this today.","commit_id":"851bb71265c8221b9e190d2b7908e117416eaa5f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d454d0adb7e984153b4642aef1b50e120020a819","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            fd, ceph_conf_path \u003d tempfile.mkstemp()"},{"line_number":67,"context_line":"            monitors \u003d [\"[%s]:%s\" % (ip, port) for ip, port"},{"line_number":68,"context_line":"                        in zip(monitor_ips, monitor_ports)]"},{"line_number":69,"context_line":"            mon_hosts \u003d \"mon_host \u003d %s\" % (\u0027,\u0027.join(monitors))"},{"line_number":70,"context_line":"            client_section \u003d \"[client.%s]\" % user"},{"line_number":71,"context_line":"            keyring \u003d (\"keyring \u003d /etc/ceph/%s.client.%s.keyring\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_7e88a571","line":68,"in_reply_to":"9a629dbe_fe6675eb","updated":"2016-11-10 20:59:01.000000000","message":"(or netutils.is_valid_ipv6() rather than the colon idea.)","commit_id":"851bb71265c8221b9e190d2b7908e117416eaa5f"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"6fb8cbe3138ffc7abb1c8677cf17c45d8d5bf390","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            fd, ceph_conf_path \u003d tempfile.mkstemp()"},{"line_number":67,"context_line":"            monitors \u003d [\"[%s]:%s\" % (ip, port) for ip, port"},{"line_number":68,"context_line":"                        in zip(monitor_ips, monitor_ports)]"},{"line_number":69,"context_line":"            mon_hosts \u003d \"mon_host \u003d %s\" % (\u0027,\u0027.join(monitors))"},{"line_number":70,"context_line":"            client_section \u003d \"[client.%s]\" % user"},{"line_number":71,"context_line":"            keyring \u003d (\"keyring \u003d /etc/ceph/%s.client.%s.keyring\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_de70d10d","line":68,"in_reply_to":"9a629dbe_fe6675eb","updated":"2016-11-10 21:14:55.000000000","message":"This syntax works for both so I thought it was the cleanest approach.","commit_id":"851bb71265c8221b9e190d2b7908e117416eaa5f"}],"os_brick/tests/initiator/connectors/test_rbd.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"a80419046b9b7b8460fcc1e70dca7a42c51fcedc","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        conn \u003d rbd.RBDConnector(None)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # common ipv4"},{"line_number":99,"context_line":"        hosts_in \u003d [\u0027192.168.1.1\u0027, \u0027192.168.1.2\u0027]"},{"line_number":100,"context_line":"        hosts_out \u003d [\u0027192.168.1.1\u0027, \u0027192.168.1.2\u0027]"},{"line_number":101,"context_line":"        self.assertEqual(hosts_out, conn._sanitize_mon_hosts(hosts_in))"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_7f8c03da","line":99,"updated":"2016-11-11 15:39:42.000000000","message":"Please, use ddt lib here to avoid code duplication","commit_id":"04331a36e930f3665ad3fc37a4a96faf7dd36153"}]}
