)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"b3d5472c8a8593811d673d2c536dd2b250500bbe","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Code cleanup in initiatorlinuxfc.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed two functionally superfluous lines of code in LinuxFibreChannel.get_fc_wwnns."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I404a3bda8bea42401b8f98d7685a176081267415"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_92b08945","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":85},"updated":"2016-12-02 11:15:13.000000000","message":"And please, divide it into two lines","commit_id":"f7958a83c8b8e56bb7ba358d3672ce2c91bbc220"}],"os_brick/initiator/linuxfc.py":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"26c01cd351043f721b6033f4621d18c89d2b9ee0","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # Note(walter-boring) modern Linux kernels contain the FC HBA\u0027s in /sys"},{"line_number":140,"context_line":"        # and are obtainable via the systool app"},{"line_number":141,"context_line":"        hbas \u003d self.get_fc_hbas()"},{"line_number":142,"context_line":"        if not hbas:"},{"line_number":143,"context_line":"            return []"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        hbas_info \u003d []"},{"line_number":146,"context_line":"        for hba in hbas:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_995a744f","side":"PARENT","line":143,"range":{"start_line":142,"start_character":0,"end_line":143,"end_character":21},"updated":"2016-12-02 10:39:26.000000000","message":"I think, we also can make the same change that you\u0027ve done here.","commit_id":"eca5a7f2e0d23da7367646817451c907866967c5"},{"author":{"_account_id":19991,"name":"Arne Recknagel","email":"arne.recknagel@hotmail.com","username":"arecknag"},"change_message_id":"e0ac1f5a25cc4c1429d1d1120e45e8a0f3b06611","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # Note(walter-boring) modern Linux kernels contain the FC HBA\u0027s in /sys"},{"line_number":140,"context_line":"        # and are obtainable via the systool app"},{"line_number":141,"context_line":"        hbas \u003d self.get_fc_hbas()"},{"line_number":142,"context_line":"        if not hbas:"},{"line_number":143,"context_line":"            return []"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        hbas_info \u003d []"},{"line_number":146,"context_line":"        for hba in hbas:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_5ddc3d12","side":"PARENT","line":143,"range":{"start_line":142,"start_character":0,"end_line":143,"end_character":21},"in_reply_to":"3a71b18c_995a744f","updated":"2016-12-02 14:02:49.000000000","message":"I agree on all your proposed changes. I noticed that the test for get_fc_hbas is a bit lacking, it should also be tested for the error paths. Especially if these changes go through, which rely on the return statement to always be iterable.","commit_id":"eca5a7f2e0d23da7367646817451c907866967c5"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"26c01cd351043f721b6033f4621d18c89d2b9ee0","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        hbas \u003d self.get_fc_hbas()"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        wwpns \u003d []"},{"line_number":165,"context_line":"        if hbas:"},{"line_number":166,"context_line":"            for hba in hbas:"},{"line_number":167,"context_line":"                if hba[\u0027port_state\u0027] \u003d\u003d \u0027Online\u0027:"},{"line_number":168,"context_line":"                    wwpn \u003d hba[\u0027port_name\u0027].replace(\u00270x\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_b907301b","side":"PARENT","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":16},"updated":"2016-12-02 10:39:26.000000000","message":"Same about this check","commit_id":"eca5a7f2e0d23da7367646817451c907866967c5"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"26c01cd351043f721b6033f4621d18c89d2b9ee0","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            return []"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        wwnns \u003d []"},{"line_number":183,"context_line":"        if hbas:"},{"line_number":184,"context_line":"            for hba in hbas:"},{"line_number":185,"context_line":"                if hba[\u0027port_state\u0027] \u003d\u003d \u0027Online\u0027:"},{"line_number":186,"context_line":"                    wwnn \u003d hba[\u0027node_name\u0027].replace(\u00270x\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_39b7a087","side":"PARENT","line":183,"range":{"start_line":183,"start_character":0,"end_line":183,"end_character":16},"updated":"2016-12-02 10:39:26.000000000","message":"I think, we don\u0027t need this check. We can left only a loop as at 201 line of this file (ps1).","commit_id":"eca5a7f2e0d23da7367646817451c907866967c5"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"26c01cd351043f721b6033f4621d18c89d2b9ee0","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        \"\"\"Get Fibre Channel WWNs and device paths from the system, if any.\"\"\""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        hbas \u003d self.get_fc_hbas()"},{"line_number":197,"context_line":"        if not hbas:"},{"line_number":198,"context_line":"            return []"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        hbas_info \u003d []"},{"line_number":201,"context_line":"        for hba in hbas:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_992194b7","side":"PARENT","line":198,"range":{"start_line":197,"start_character":0,"end_line":198,"end_character":21},"updated":"2016-12-02 10:39:26.000000000","message":"And here","commit_id":"eca5a7f2e0d23da7367646817451c907866967c5"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"e0dd05084073b0405c817d8a66079adb1680d15b","unresolved":false,"context_lines":[{"line_number":186,"context_line":"class LinuxFibreChannelS390X(LinuxFibreChannel):"},{"line_number":187,"context_line":"    def get_fc_hbas_info(self):"},{"line_number":188,"context_line":"        \"\"\"Get Fibre Channel WWNs and device paths from the system, if any.\"\"\""},{"line_number":189,"context_line":"        "},{"line_number":190,"context_line":"        hbas \u003d self.get_fc_hbas()"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        hbas_info \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_ae5196da","line":189,"range":{"start_line":189,"start_character":0,"end_line":189,"end_character":8},"updated":"2016-12-02 15:53:56.000000000","message":"Unexpectedly :)","commit_id":"5294c68fbfbd906d696a8a3838f255ecac578552"},{"author":{"_account_id":19991,"name":"Arne Recknagel","email":"arne.recknagel@hotmail.com","username":"arecknag"},"change_message_id":"e6993abbfd191380ec91e4ef9f9ead805bbb8226","unresolved":false,"context_lines":[{"line_number":186,"context_line":"class LinuxFibreChannelS390X(LinuxFibreChannel):"},{"line_number":187,"context_line":"    def get_fc_hbas_info(self):"},{"line_number":188,"context_line":"        \"\"\"Get Fibre Channel WWNs and device paths from the system, if any.\"\"\""},{"line_number":189,"context_line":"        "},{"line_number":190,"context_line":"        hbas \u003d self.get_fc_hbas()"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        hbas_info \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_4b6a86ef","line":189,"range":{"start_line":189,"start_character":0,"end_line":189,"end_character":8},"in_reply_to":"3a71b18c_ae5196da","updated":"2016-12-05 07:19:54.000000000","message":"Ah, my editor sometimes likes to start lines indented :p","commit_id":"5294c68fbfbd906d696a8a3838f255ecac578552"}]}