)]}'
{"os_brick/initiator/linuxscsi.py":[{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"8f29558c9e70d49b9786d24448f5e0ead40f0729","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            LOG.debug(\"multipath LUNs to remove %s\", devices)"},{"line_number":140,"context_line":"            for device in devices:"},{"line_number":141,"context_line":"                self.remove_scsi_device(device[\u0027device\u0027])"},{"line_number":142,"context_line":"                self.wait_for_volume_removal(device[\u0027device\u0027])"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def flush_device_io(self, device):"},{"line_number":145,"context_line":"        \"\"\"This is used to flush any remaining IO in the buffers.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_dd472fba","line":142,"updated":"2017-02-13 20:17:18.000000000","message":"Not sure the sort of expected error behavior here, but would it make more sense to loop through devices twice instead of waiting for each one as we remove them?\n\nMy thinking: if it takes a second for them to go away (slow system, whatever). If there are like 4 devices we wait 4 seconds, but if you loop through them all and delete them, then loop through and wait for delete it only waits for the first one, then checks the others and they should more than likely also be gone after waiting on the first one for the one second. Does that make sense?","commit_id":"d361a7e84ba1f384ccd7cb3d93a463cb345ec98d"}]}