)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"02cfa489e73742cdbbc8d56840f786aafbb09141","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cleanup orphaned iSCSi sessions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Its possible for an iSCSi connection to fail *after* login"},{"line_number":10,"context_line":"to the lun is successful. If multipath -r is run when the"},{"line_number":11,"context_line":"session is failed it will *not* be included in the multipath"},{"line_number":12,"context_line":"device. As a result the call to remove_multipath_device will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a30ddce_d5b036f7","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":3},"updated":"2017-03-07 18:55:38.000000000","message":"nit: It\u0027s","commit_id":"3df8b5a8597d1c4fdf160f0e160f3cafcc4db202"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"02cfa489e73742cdbbc8d56840f786aafbb09141","unresolved":false,"context_lines":[{"line_number":14,"context_line":"ensure that we have deleted *all* luns that we logged into"},{"line_number":15,"context_line":"*before* we call _disconnect_volume_multipath_iscsi."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I16a12a13780661ed16637d28a31cbf2ad8687318"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a30ddce_be99df70","line":17,"updated":"2017-03-07 18:55:38.000000000","message":"-1: Missing launchpad bug","commit_id":"3df8b5a8597d1c4fdf160f0e160f3cafcc4db202"}],"os_brick/initiator/connectors/iscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"02cfa489e73742cdbbc8d56840f786aafbb09141","unresolved":false,"context_lines":[{"line_number":493,"context_line":"            if multipath_device:"},{"line_number":494,"context_line":"                device_realpath \u003d os.path.realpath(host_device)"},{"line_number":495,"context_line":"                self._linuxscsi.remove_multipath_device(device_realpath)"},{"line_number":496,"context_line":"                # Its possible for an iSCSi connection to fail *after* login"},{"line_number":497,"context_line":"                # to the lun is successful. If multipath -r is run when the"},{"line_number":498,"context_line":"                # session is failed it will *not* be included in the multipath"},{"line_number":499,"context_line":"                # device. As a result the call to remove_multipath_device will"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_115e63e9","line":496,"range":{"start_line":496,"start_character":18,"end_line":496,"end_character":21},"updated":"2017-03-07 18:55:38.000000000","message":"nit: It\u0027s","commit_id":"3df8b5a8597d1c4fdf160f0e160f3cafcc4db202"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"02cfa489e73742cdbbc8d56840f786aafbb09141","unresolved":false,"context_lines":[{"line_number":500,"context_line":"                # not remove the underlying iSCSi device. As such we need to"},{"line_number":501,"context_line":"                # ensure that we have deleted *all* luns that we logged into"},{"line_number":502,"context_line":"                # *before* we call _disconnect_volume_multipath_iscsi."},{"line_number":503,"context_line":"                self._clean_orphaned_devices(connection_properties)"},{"line_number":504,"context_line":"                return self._disconnect_volume_multipath_iscsi("},{"line_number":505,"context_line":"                    connection_properties, multipath_device)"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_9b3c2d95","line":503,"updated":"2017-03-07 18:55:38.000000000","message":"-1: This doesn\u0027t look like the right approach to me, we should change the signature of remove_multipath_device to accept the chosen host_device and the list of host_devices, then remove L494 from here, and then in remove_multipath_device just do:\n\n device \u003d os.path.realpath(chosen_host_device)\n LOG.debug(\"remove multipath device %s\", device)      \n mpath_dev \u003d self.find_multipath_device(device)   \n devices \u003d {os.path.realpath(dev) for dev in host_devices}    \n if mpath_dev:                                        \n     self.flush_multipath_device(mpath_dev[\u0027id\u0027])     \n devices.update(mpath_dev[\u0027devices\u0027])\n LOG.debug(\"multipath LUNs to remove %s\", devices)\n for device in devices:                           \n     self.remove_scsi_device(device[\u0027device\u0027])","commit_id":"3df8b5a8597d1c4fdf160f0e160f3cafcc4db202"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"02cfa489e73742cdbbc8d56840f786aafbb09141","unresolved":false,"context_lines":[{"line_number":545,"context_line":"                                              dev.startswith("},{"line_number":546,"context_line":"                                                  \u0027/dev/disk/by-path/\u0027))"},{"line_number":547,"context_line":"                   and os.path.exists(dev)]"},{"line_number":548,"context_line":"        if not devices and logout:"},{"line_number":549,"context_line":"            self._disconnect_from_iscsi_portal(connection_properties)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def _munge_portal(self, target):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_b809f72e","line":548,"range":{"start_line":548,"start_character":27,"end_line":548,"end_character":33},"updated":"2017-03-07 18:55:38.000000000","message":"-1: If we go with this approach we should short-circuit this on L537 with:\n\n if not logout:\n    return","commit_id":"3df8b5a8597d1c4fdf160f0e160f3cafcc4db202"}]}