)]}'
{"os_brick/initiator/connectors/fibre_channel_s390x.py":[{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"6bb9a663fa3a88248fc4ccb61c3ba47e1ab92549","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                target_wwn,"},{"line_number":55,"context_line":"                lun)"},{"line_number":56,"context_line":"            self._linuxfc.configure_scsi_device(pci_num, target_wwn,"},{"line_number":57,"context_line":"                                                self._get_lun_string(lun))"},{"line_number":58,"context_line":"            host_devices.extend(host_device)"},{"line_number":59,"context_line":"        return host_devices"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_48ba1570","line":57,"range":{"start_line":57,"start_character":53,"end_line":57,"end_character":68},"updated":"2017-01-09 16:13:08.000000000","message":"so the rhel way is used here for ubuntu as well?","commit_id":"20a04c3829dc24bc28af7426718f5a5c9ba6af12"},{"author":{"_account_id":19991,"name":"Arne Recknagel","email":"arne.recknagel@hotmail.com","username":"arecknag"},"change_message_id":"960e66784a0b5f3f4bd4614fe2dba86d06117dee","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                target_wwn,"},{"line_number":55,"context_line":"                lun)"},{"line_number":56,"context_line":"            self._linuxfc.configure_scsi_device(pci_num, target_wwn,"},{"line_number":57,"context_line":"                                                self._get_lun_string(lun))"},{"line_number":58,"context_line":"            host_devices.extend(host_device)"},{"line_number":59,"context_line":"        return host_devices"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_fc60b9a6","line":57,"range":{"start_line":57,"start_character":53,"end_line":57,"end_character":68},"in_reply_to":"ba5201f7_48ba1570","updated":"2017-01-10 14:03:08.000000000","message":"I tested it and it worked fine, also the call path for the zfcp command does indeed use the same lun format in ubuntu, with the driver being at \n/sys/bus/ccw/drivers/zfcp/0.0.50d0/0x500507680b234ac0/0x0000000000000003/","commit_id":"20a04c3829dc24bc28af7426718f5a5c9ba6af12"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"6bb9a663fa3a88248fc4ccb61c3ba47e1ab92549","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def _get_device_file_path(self, pci_num, target_wwn, lun):"},{"line_number":70,"context_line":"        host_device \u003d ["},{"line_number":71,"context_line":"            \"/dev/disk/by-path/ccw-%s-zfcp-%s:%s\" % ("},{"line_number":72,"context_line":"                pci_num,"},{"line_number":73,"context_line":"                target_wwn,"},{"line_number":74,"context_line":"                self._get_lun_string(lun)),"},{"line_number":75,"context_line":"            \"/dev/disk/by-path/ccw-%s-fc-%s-lun-%s\" % ("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_685d1948","line":72,"range":{"start_line":72,"start_character":16,"end_line":72,"end_character":23},"updated":"2017-01-09 16:13:08.000000000","message":"you could make this a bit more readable when putting those arguments into a single line","commit_id":"20a04c3829dc24bc28af7426718f5a5c9ba6af12"},{"author":{"_account_id":19991,"name":"Arne Recknagel","email":"arne.recknagel@hotmail.com","username":"arecknag"},"change_message_id":"960e66784a0b5f3f4bd4614fe2dba86d06117dee","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def _get_device_file_path(self, pci_num, target_wwn, lun):"},{"line_number":70,"context_line":"        host_device \u003d ["},{"line_number":71,"context_line":"            \"/dev/disk/by-path/ccw-%s-zfcp-%s:%s\" % ("},{"line_number":72,"context_line":"                pci_num,"},{"line_number":73,"context_line":"                target_wwn,"},{"line_number":74,"context_line":"                self._get_lun_string(lun)),"},{"line_number":75,"context_line":"            \"/dev/disk/by-path/ccw-%s-fc-%s-lun-%s\" % ("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_3c296138","line":72,"range":{"start_line":72,"start_character":16,"end_line":72,"end_character":23},"in_reply_to":"ba5201f7_685d1948","updated":"2017-01-10 14:03:08.000000000","message":"I personally agree, just sticked to the former format. I changed it for the next patch.","commit_id":"20a04c3829dc24bc28af7426718f5a5c9ba6af12"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a9d1d0a20febfe69300730a3df88e0a265fc47d3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                pci_num,"},{"line_number":77,"context_line":"                target_wwn,"},{"line_number":78,"context_line":"                lun),"},{"line_number":79,"context_line":"        ]"},{"line_number":80,"context_line":"        return host_device"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _remove_devices(self, connection_properties, devices):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_82f5bccc","line":79,"updated":"2017-01-09 15:26:41.000000000","message":"FWIW, I\u0027d recommend to add a NOTE here which explains why we return 2 different paths here.","commit_id":"20a04c3829dc24bc28af7426718f5a5c9ba6af12"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"6bb9a663fa3a88248fc4ccb61c3ba47e1ab92549","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                pci_num,"},{"line_number":77,"context_line":"                target_wwn,"},{"line_number":78,"context_line":"                lun),"},{"line_number":79,"context_line":"        ]"},{"line_number":80,"context_line":"        return host_device"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _remove_devices(self, connection_properties, devices):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_e8774906","line":79,"in_reply_to":"ba5201f7_82f5bccc","updated":"2017-01-09 16:13:08.000000000","message":"+1","commit_id":"20a04c3829dc24bc28af7426718f5a5c9ba6af12"},{"author":{"_account_id":19991,"name":"Arne Recknagel","email":"arne.recknagel@hotmail.com","username":"arecknag"},"change_message_id":"960e66784a0b5f3f4bd4614fe2dba86d06117dee","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                pci_num,"},{"line_number":77,"context_line":"                target_wwn,"},{"line_number":78,"context_line":"                lun),"},{"line_number":79,"context_line":"        ]"},{"line_number":80,"context_line":"        return host_device"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _remove_devices(self, connection_properties, devices):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_bcfe31ac","line":79,"in_reply_to":"ba5201f7_e8774906","updated":"2017-01-10 14:03:08.000000000","message":"Done.","commit_id":"20a04c3829dc24bc28af7426718f5a5c9ba6af12"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"b8dcf806cd23cbd533556897168dd8db7c2e72f6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                target_wwn,"},{"line_number":55,"context_line":"                lun)"},{"line_number":56,"context_line":"            self._linuxfc.configure_scsi_device(pci_num, target_wwn,"},{"line_number":57,"context_line":"                                                self._get_lun_string(lun))"},{"line_number":58,"context_line":"            host_devices.extend(host_device)"},{"line_number":59,"context_line":"        return host_devices"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_f9d28033","line":57,"range":{"start_line":57,"start_character":53,"end_line":57,"end_character":68},"updated":"2017-01-10 16:50:14.000000000","message":"so the lun format here is common on all distros? If so, add a comment might be helpful!","commit_id":"dbe8d9b5891850ded809f58d91ef2df12984bf5b"},{"author":{"_account_id":19991,"name":"Arne Recknagel","email":"arne.recknagel@hotmail.com","username":"arecknag"},"change_message_id":"b6873805662b42e5c7c8d29cfab8dab74fbea836","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                target_wwn,"},{"line_number":55,"context_line":"                lun)"},{"line_number":56,"context_line":"            self._linuxfc.configure_scsi_device(pci_num, target_wwn,"},{"line_number":57,"context_line":"                                                self._get_lun_string(lun))"},{"line_number":58,"context_line":"            host_devices.extend(host_device)"},{"line_number":59,"context_line":"        return host_devices"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_2147554c","line":57,"range":{"start_line":57,"start_character":53,"end_line":57,"end_character":68},"in_reply_to":"ba5201f7_f9d28033","updated":"2017-01-11 07:42:10.000000000","message":"# NOTE(arne_r)\n# LUN driver path is the same on all distros, so no need to have\n# multiple calls here","commit_id":"dbe8d9b5891850ded809f58d91ef2df12984bf5b"}],"os_brick/tests/initiator/connectors/test_fibre_channel_s390x.py":[{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"6bb9a663fa3a88248fc4ccb61c3ba47e1ab92549","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                                      \"0x0002000000000000\")"},{"line_number":40,"context_line":"        self.assertEqual(2, len(devices))"},{"line_number":41,"context_line":"        device_path \u003d \"/dev/disk/by-path/ccw-3-zfcp-5:0x0002000000000000\""},{"line_number":42,"context_line":"        self.assertEqual(devices[0], device_path)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_get_lun_string(self):"},{"line_number":45,"context_line":"        lun \u003d 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_8b3dd7bd","line":42,"range":{"start_line":42,"start_character":27,"end_line":42,"end_character":28},"updated":"2017-01-09 16:13:08.000000000","message":"also assert for the other ubuntu device path here!","commit_id":"20a04c3829dc24bc28af7426718f5a5c9ba6af12"}]}