)]}'
{"os_brick/initiator/connectors/iscsi.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"af40fb9313f4aef8c45be00162d62bbaa590879e","unresolved":false,"context_lines":[{"line_number":855,"context_line":"    @utils.retry(exception.HostChannelsTargetsNotFound, backoff_rate\u003d1.5)"},{"line_number":856,"context_line":"    def _get_hosts_channels_targets_luns(self, ips_iqns_luns):"},{"line_number":857,"context_line":"        iqns \u003d {iqn: lun for ip, iqn, lun in ips_iqns_luns}"},{"line_number":858,"context_line":"        LOG.debug(\u0027Getting hosts, channels, and targets for iqns %s\u0027,"},{"line_number":859,"context_line":"                  iqns.keys())"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"        # Get all targets indexed by scsi host path"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_cc9fed63","line":858,"range":{"start_line":858,"start_character":60,"end_line":858,"end_character":64},"updated":"2017-02-16 15:30:15.000000000","message":"Suggest \u0027iqns:\u0027 for consistency with other messages.","commit_id":"669426e26e5b564a16175225071563145b64a493"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9328c29b126b9518a136e208664bbdfa685188ee","unresolved":false,"context_lines":[{"line_number":855,"context_line":"    @utils.retry(exception.HostChannelsTargetsNotFound, backoff_rate\u003d1.5)"},{"line_number":856,"context_line":"    def _get_hosts_channels_targets_luns(self, ips_iqns_luns):"},{"line_number":857,"context_line":"        iqns \u003d {iqn: lun for ip, iqn, lun in ips_iqns_luns}"},{"line_number":858,"context_line":"        LOG.debug(\u0027Getting hosts, channels, and targets for iqns %s\u0027,"},{"line_number":859,"context_line":"                  iqns.keys())"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"        # Get all targets indexed by scsi host path"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_481ae96f","line":858,"range":{"start_line":858,"start_character":60,"end_line":858,"end_character":64},"in_reply_to":"fa31d9ce_cc9fed63","updated":"2017-02-17 09:45:08.000000000","message":"Done","commit_id":"669426e26e5b564a16175225071563145b64a493"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"af40fb9313f4aef8c45be00162d62bbaa590879e","unresolved":false,"context_lines":[{"line_number":874,"context_line":"        result \u003d []"},{"line_number":875,"context_line":"        for session in sessions:"},{"line_number":876,"context_line":"            # Read iSCSI target name"},{"line_number":877,"context_line":"            with open(session, \u0027r\u0027) as f:"},{"line_number":878,"context_line":"                targetname \u003d f.read().strip(\u0027\\n\u0027)"},{"line_number":879,"context_line":"            # If we are interested in it we store its target information"},{"line_number":880,"context_line":"            if targetname in iqns:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_4c713d77","line":877,"range":{"start_line":877,"start_character":12,"end_line":877,"end_character":41},"updated":"2017-02-16 15:30:15.000000000","message":"Couldn\u0027t the open fail here?  Should we be prepared for that and catch any exceptions?","commit_id":"669426e26e5b564a16175225071563145b64a493"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9328c29b126b9518a136e208664bbdfa685188ee","unresolved":false,"context_lines":[{"line_number":874,"context_line":"        result \u003d []"},{"line_number":875,"context_line":"        for session in sessions:"},{"line_number":876,"context_line":"            # Read iSCSI target name"},{"line_number":877,"context_line":"            with open(session, \u0027r\u0027) as f:"},{"line_number":878,"context_line":"                targetname \u003d f.read().strip(\u0027\\n\u0027)"},{"line_number":879,"context_line":"            # If we are interested in it we store its target information"},{"line_number":880,"context_line":"            if targetname in iqns:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_e839ddd9","line":877,"range":{"start_line":877,"start_character":12,"end_line":877,"end_character":41},"in_reply_to":"fa31d9ce_4c713d77","updated":"2017-02-17 09:45:08.000000000","message":"Good catch, thanks!!  Both the open and the read could fail.","commit_id":"669426e26e5b564a16175225071563145b64a493"}]}
