)]}'
{"os_brick/initiator/connectors/rbd.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"978dff4296354615a8d7e01f8c77231a5e35ea5e","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        except Exception as e:"},{"line_number":197,"context_line":"            LOG.error(_LE(\"Failed to access RBD device handle: %(error)s\"),"},{"line_number":198,"context_line":"                      {\"error\": e})"},{"line_number":199,"context_line":"            if rbd_handle is not None:"},{"line_number":200,"context_line":"                rbd_handle.close()"},{"line_number":201,"context_line":"            return False"},{"line_number":202,"context_line":"        rbd_handle.seek(original_offset, 0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_9de2a29f","line":199,"range":{"start_line":199,"start_character":12,"end_line":199,"end_character":37},"updated":"2017-04-10 14:57:53.000000000","message":"If rbd_handle is None, this block wouldn\u0027t be reached, because rbd_handle.tell() above would have failed with an AttributeError.\n\nSo this check will never be satisfied.","commit_id":"fbb5ab7507fd594c8107e372529751c33d24f0c3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"488e66900a6d2fa0bd0e791ee150803c14b07c95","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        except Exception as e:"},{"line_number":197,"context_line":"            LOG.error(_LE(\"Failed to access RBD device handle: %(error)s\"),"},{"line_number":198,"context_line":"                      {\"error\": e})"},{"line_number":199,"context_line":"            if rbd_handle is not None:"},{"line_number":200,"context_line":"                rbd_handle.close()"},{"line_number":201,"context_line":"            return False"},{"line_number":202,"context_line":"        rbd_handle.seek(original_offset, 0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_dd8a6abd","line":199,"range":{"start_line":199,"start_character":12,"end_line":199,"end_character":37},"in_reply_to":"bff0334d_9de2a29f","updated":"2017-04-10 14:58:33.000000000","message":"Also there\u0027s a \"if rbd_handle is None\" check above that.","commit_id":"fbb5ab7507fd594c8107e372529751c33d24f0c3"},{"author":{"_account_id":21135,"name":"zhangdaolong","email":"daodragonzhang@gmail.com","username":"zhangdaolong"},"change_message_id":"8b98e29c2e966fe1d66a9d62f5bc61519bfa80b5","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        except Exception as e:"},{"line_number":197,"context_line":"            LOG.error(_LE(\"Failed to access RBD device handle: %(error)s\"),"},{"line_number":198,"context_line":"                      {\"error\": e})"},{"line_number":199,"context_line":"            if rbd_handle is not None:"},{"line_number":200,"context_line":"                rbd_handle.close()"},{"line_number":201,"context_line":"            return False"},{"line_number":202,"context_line":"        rbd_handle.seek(original_offset, 0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_7dbd8cd6","line":199,"range":{"start_line":199,"start_character":12,"end_line":199,"end_character":37},"in_reply_to":"bff0334d_9de2a29f","updated":"2017-04-11 00:53:50.000000000","message":"ok thank you","commit_id":"fbb5ab7507fd594c8107e372529751c33d24f0c3"},{"author":{"_account_id":21135,"name":"zhangdaolong","email":"daodragonzhang@gmail.com","username":"zhangdaolong"},"change_message_id":"8b98e29c2e966fe1d66a9d62f5bc61519bfa80b5","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        except Exception as e:"},{"line_number":197,"context_line":"            LOG.error(_LE(\"Failed to access RBD device handle: %(error)s\"),"},{"line_number":198,"context_line":"                      {\"error\": e})"},{"line_number":199,"context_line":"            if rbd_handle is not None:"},{"line_number":200,"context_line":"                rbd_handle.close()"},{"line_number":201,"context_line":"            return False"},{"line_number":202,"context_line":"        rbd_handle.seek(original_offset, 0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_3db3840c","line":199,"range":{"start_line":199,"start_character":12,"end_line":199,"end_character":37},"in_reply_to":"bff0334d_dd8a6abd","updated":"2017-04-11 00:53:50.000000000","message":"i see thank you","commit_id":"fbb5ab7507fd594c8107e372529751c33d24f0c3"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"eb10a120887eb15dce700d3cdd89a0f3b92370fe","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            LOG.error(\"Failed to access RBD device handle: %(error)s\","},{"line_number":205,"context_line":"                      {\"error\": e})"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"            rbd_handle.close()"},{"line_number":208,"context_line":"            return False"},{"line_number":209,"context_line":"        rbd_handle.seek(original_offset, 0)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_98dc0ae5","line":207,"updated":"2017-04-19 18:42:26.000000000","message":"this should be added in the finally clause.  And we shouldn\u0027t have removed it to ensure the seek is complete too.","commit_id":"c7133043255400f05297cb9cd36e78c8ae21cc17"},{"author":{"_account_id":21135,"name":"zhangdaolong","email":"daodragonzhang@gmail.com","username":"zhangdaolong"},"change_message_id":"0fdde676de30336ff3e0192bc4ca1c18c323a401","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            LOG.error(\"Failed to access RBD device handle: %(error)s\","},{"line_number":205,"context_line":"                      {\"error\": e})"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"            rbd_handle.close()"},{"line_number":208,"context_line":"            return False"},{"line_number":209,"context_line":"        rbd_handle.seek(original_offset, 0)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_ffdacd48","line":207,"in_reply_to":"7ffa3b31_98dc0ae5","updated":"2017-04-20 00:48:06.000000000","message":"thank you,i think When an exception occurs, A should be closed,After the exception occurs directly return False, there is no need to seek operation to complete.","commit_id":"c7133043255400f05297cb9cd36e78c8ae21cc17"}]}
