)]}'
{"os_brick/initiator/linuxscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e7ed0aa594183cd56b6965184bd2a671a2b61906","unresolved":false,"context_lines":[{"line_number":415,"context_line":"                msg \u003d (\"Multipathd failed to update the size mapping of \""},{"line_number":416,"context_line":"                       \"multipath device %(scsi_wwn)s volume %(volume)s\" %"},{"line_number":417,"context_line":"                       {\u0027scsi_wwn\u0027: scsi_wwn, \u0027volume\u0027: volume_paths})"},{"line_number":418,"context_line":"                LOG.error(msg)"},{"line_number":419,"context_line":"                return None"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"            new_size \u003d self.get_device_size(mpath_device)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_eb409c36","line":418,"range":{"start_line":418,"start_character":26,"end_line":418,"end_character":29},"updated":"2017-03-21 11:49:04.000000000","message":"If you need to do an update, please move the string directly into the LOG.error call and get rid of this temporary msg variable. Then the string formatting can also be delayed until needed by changing the \"%\" to \",\".","commit_id":"67b0cbcf4945c4c8fe4f295eae05de27215fbf14"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"ad1cdeea9ec0404edf98025e00d4bb85783a0b8a","unresolved":false,"context_lines":[{"line_number":415,"context_line":"                msg \u003d (\"Multipathd failed to update the size mapping of \""},{"line_number":416,"context_line":"                       \"multipath device %(scsi_wwn)s volume %(volume)s\" %"},{"line_number":417,"context_line":"                       {\u0027scsi_wwn\u0027: scsi_wwn, \u0027volume\u0027: volume_paths})"},{"line_number":418,"context_line":"                LOG.error(msg)"},{"line_number":419,"context_line":"                return None"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"            new_size \u003d self.get_device_size(mpath_device)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_c174a169","line":418,"range":{"start_line":418,"start_character":26,"end_line":418,"end_character":29},"in_reply_to":"1a1ced50_eb409c36","updated":"2017-03-21 12:37:23.000000000","message":"Done","commit_id":"67b0cbcf4945c4c8fe4f295eae05de27215fbf14"}],"os_brick/initiator/windows/base.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e7ed0aa594183cd56b6965184bd2a671a2b61906","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        mpio_enabled \u003d hostutils.check_server_feature("},{"line_number":46,"context_line":"            hostutils.FEATURE_MPIO)"},{"line_number":47,"context_line":"        if not mpio_enabled:"},{"line_number":48,"context_line":"            err_msg \u003d \"Using multipath connections for iSCSI and FC disks \" \\"},{"line_number":49,"context_line":"                      \"requires the Multipath IO Windows feature to be \" \\"},{"line_number":50,"context_line":"                      \"enabled. MPIO must be configured to claim such devices.\""},{"line_number":51,"context_line":"            LOG.error(err_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_eb67bce6","line":48,"range":{"start_line":48,"start_character":75,"end_line":48,"end_character":77},"updated":"2017-03-21 11:49:04.000000000","message":"Avoid using \\ for multiple lines. Just keep this all wrapped in () but get rid of the _LE part.","commit_id":"67b0cbcf4945c4c8fe4f295eae05de27215fbf14"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"ad1cdeea9ec0404edf98025e00d4bb85783a0b8a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        mpio_enabled \u003d hostutils.check_server_feature("},{"line_number":46,"context_line":"            hostutils.FEATURE_MPIO)"},{"line_number":47,"context_line":"        if not mpio_enabled:"},{"line_number":48,"context_line":"            err_msg \u003d \"Using multipath connections for iSCSI and FC disks \" \\"},{"line_number":49,"context_line":"                      \"requires the Multipath IO Windows feature to be \" \\"},{"line_number":50,"context_line":"                      \"enabled. MPIO must be configured to claim such devices.\""},{"line_number":51,"context_line":"            LOG.error(err_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_810d49ea","line":48,"range":{"start_line":48,"start_character":75,"end_line":48,"end_character":77},"in_reply_to":"1a1ced50_eb67bce6","updated":"2017-03-21 12:37:23.000000000","message":"Done","commit_id":"67b0cbcf4945c4c8fe4f295eae05de27215fbf14"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e7f0421d852ba26015c61f0937aac99fb9678337","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        mpio_enabled \u003d hostutils.check_server_feature("},{"line_number":46,"context_line":"            hostutils.FEATURE_MPIO)"},{"line_number":47,"context_line":"        if not mpio_enabled:"},{"line_number":48,"context_line":"            err_msg \u003d (\"Using multipath connections for iSCSI and FC disks \""},{"line_number":49,"context_line":"                       \"requires the Multipath IO Windows feature to be \""},{"line_number":50,"context_line":"                       \"enabled. MPIO must be configured to claim such \""},{"line_number":51,"context_line":"                       \"devices.\")"},{"line_number":52,"context_line":"            LOG.error(err_msg)"},{"line_number":53,"context_line":"            if enforce_multipath:"},{"line_number":54,"context_line":"                raise exception.BrickException(err_msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_fa94db43","line":51,"range":{"start_line":48,"start_character":0,"end_line":51,"end_character":34},"updated":"2017-03-21 15:10:29.000000000","message":"This should be _() as it could be a customer facing message.","commit_id":"5d949ca21f62bfcb67e5bcbb28479156a46caca4"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"252e307489cd1254baf6e497e1f986fd0b7c868c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        mpio_enabled \u003d hostutils.check_server_feature("},{"line_number":46,"context_line":"            hostutils.FEATURE_MPIO)"},{"line_number":47,"context_line":"        if not mpio_enabled:"},{"line_number":48,"context_line":"            err_msg \u003d (\"Using multipath connections for iSCSI and FC disks \""},{"line_number":49,"context_line":"                       \"requires the Multipath IO Windows feature to be \""},{"line_number":50,"context_line":"                       \"enabled. MPIO must be configured to claim such \""},{"line_number":51,"context_line":"                       \"devices.\")"},{"line_number":52,"context_line":"            LOG.error(err_msg)"},{"line_number":53,"context_line":"            if enforce_multipath:"},{"line_number":54,"context_line":"                raise exception.BrickException(err_msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_af61303b","line":51,"range":{"start_line":48,"start_character":0,"end_line":51,"end_character":34},"in_reply_to":"1a1ced50_fa94db43","updated":"2017-03-22 01:23:19.000000000","message":"Done, thanks","commit_id":"5d949ca21f62bfcb67e5bcbb28479156a46caca4"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"393458b8508d6c65c0df1c9544449935e7b5fd67","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        mpio_enabled \u003d hostutils.check_server_feature("},{"line_number":46,"context_line":"            hostutils.FEATURE_MPIO)"},{"line_number":47,"context_line":"        if not mpio_enabled:"},{"line_number":48,"context_line":"            err_msg \u003d (\"Using multipath connections for iSCSI and FC disks \""},{"line_number":49,"context_line":"                       \"requires the Multipath IO Windows feature to be \""},{"line_number":50,"context_line":"                       \"enabled. MPIO must be configured to claim such \""},{"line_number":51,"context_line":"                       \"devices.\")"},{"line_number":52,"context_line":"            LOG.error(err_msg)"},{"line_number":53,"context_line":"            if enforce_multipath:"},{"line_number":54,"context_line":"                raise exception.BrickException(err_msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_dd855407","line":51,"range":{"start_line":48,"start_character":0,"end_line":51,"end_character":34},"in_reply_to":"1a1ced50_fa94db43","updated":"2017-03-21 16:56:06.000000000","message":"Good catch. That was incorrect before, but we should fix it now.","commit_id":"5d949ca21f62bfcb67e5bcbb28479156a46caca4"}],"os_brick/initiator/windows/iscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e7ed0aa594183cd56b6965184bd2a671a2b61906","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            available_initiators \u003d self._iscsi_utils.get_iscsi_initiators()"},{"line_number":51,"context_line":"            for initiator in self.initiator_list:"},{"line_number":52,"context_line":"                if initiator not in available_initiators:"},{"line_number":53,"context_line":"                    msg \u003d \"The requested initiator %(req_initiator)s \" \\"},{"line_number":54,"context_line":"                          \"is not in the list of available initiators: \" \\"},{"line_number":55,"context_line":"                          \"%(avail_initiators)s.\""},{"line_number":56,"context_line":"                    LOG.warning(msg,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_8ba3a8ff","line":53,"range":{"start_line":53,"start_character":71,"end_line":53,"end_character":72},"updated":"2017-03-21 11:49:04.000000000","message":"Same as previous file. But would be better to get rid of the msg variable and just move this into the LOG.warning call.","commit_id":"67b0cbcf4945c4c8fe4f295eae05de27215fbf14"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"ad1cdeea9ec0404edf98025e00d4bb85783a0b8a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            available_initiators \u003d self._iscsi_utils.get_iscsi_initiators()"},{"line_number":51,"context_line":"            for initiator in self.initiator_list:"},{"line_number":52,"context_line":"                if initiator not in available_initiators:"},{"line_number":53,"context_line":"                    msg \u003d \"The requested initiator %(req_initiator)s \" \\"},{"line_number":54,"context_line":"                          \"is not in the list of available initiators: \" \\"},{"line_number":55,"context_line":"                          \"%(avail_initiators)s.\""},{"line_number":56,"context_line":"                    LOG.warning(msg,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_010239b4","line":53,"range":{"start_line":53,"start_character":71,"end_line":53,"end_character":72},"in_reply_to":"1a1ced50_8ba3a8ff","updated":"2017-03-21 12:37:23.000000000","message":"Done","commit_id":"67b0cbcf4945c4c8fe4f295eae05de27215fbf14"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e7f0421d852ba26015c61f0937aac99fb9678337","unresolved":false,"context_lines":[{"line_number":84,"context_line":"             target_iqn,"},{"line_number":85,"context_line":"             target_lun) in self._get_all_paths(connection_properties):"},{"line_number":86,"context_line":"            try:"},{"line_number":87,"context_line":"                msg \u003d \"Attempting to establish an iSCSI session to \" \\"},{"line_number":88,"context_line":"                      \"target %(target_iqn)s on portal %(target_portal)s \" \\"},{"line_number":89,"context_line":"                      \"accessing LUN %(target_lun)s using initiator \" \\"},{"line_number":90,"context_line":"                      \"%(initiator_name)s.\""},{"line_number":91,"context_line":"                LOG.info(msg, dict(target_portal\u003dtarget_portal,"},{"line_number":92,"context_line":"                                   target_iqn\u003dtarget_iqn,"},{"line_number":93,"context_line":"                                   target_lun\u003dtarget_lun,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_9a976739","line":90,"range":{"start_line":87,"start_character":22,"end_line":90,"end_character":43},"updated":"2017-03-21 15:10:29.000000000","message":"Should use ( ) here instead of \\","commit_id":"5d949ca21f62bfcb67e5bcbb28479156a46caca4"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"393458b8508d6c65c0df1c9544449935e7b5fd67","unresolved":false,"context_lines":[{"line_number":84,"context_line":"             target_iqn,"},{"line_number":85,"context_line":"             target_lun) in self._get_all_paths(connection_properties):"},{"line_number":86,"context_line":"            try:"},{"line_number":87,"context_line":"                msg \u003d \"Attempting to establish an iSCSI session to \" \\"},{"line_number":88,"context_line":"                      \"target %(target_iqn)s on portal %(target_portal)s \" \\"},{"line_number":89,"context_line":"                      \"accessing LUN %(target_lun)s using initiator \" \\"},{"line_number":90,"context_line":"                      \"%(initiator_name)s.\""},{"line_number":91,"context_line":"                LOG.info(msg, dict(target_portal\u003dtarget_portal,"},{"line_number":92,"context_line":"                                   target_iqn\u003dtarget_iqn,"},{"line_number":93,"context_line":"                                   target_lun\u003dtarget_lun,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_bd97b838","line":90,"range":{"start_line":87,"start_character":22,"end_line":90,"end_character":43},"in_reply_to":"1a1ced50_9a976739","updated":"2017-03-21 16:56:06.000000000","message":"+1","commit_id":"5d949ca21f62bfcb67e5bcbb28479156a46caca4"},{"author":{"_account_id":23081,"name":"Jeremy Zhang","email":"zhangjun_inspur@163.com","username":"jeremy.zhang"},"change_message_id":"252e307489cd1254baf6e497e1f986fd0b7c868c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"             target_iqn,"},{"line_number":85,"context_line":"             target_lun) in self._get_all_paths(connection_properties):"},{"line_number":86,"context_line":"            try:"},{"line_number":87,"context_line":"                msg \u003d \"Attempting to establish an iSCSI session to \" \\"},{"line_number":88,"context_line":"                      \"target %(target_iqn)s on portal %(target_portal)s \" \\"},{"line_number":89,"context_line":"                      \"accessing LUN %(target_lun)s using initiator \" \\"},{"line_number":90,"context_line":"                      \"%(initiator_name)s.\""},{"line_number":91,"context_line":"                LOG.info(msg, dict(target_portal\u003dtarget_portal,"},{"line_number":92,"context_line":"                                   target_iqn\u003dtarget_iqn,"},{"line_number":93,"context_line":"                                   target_lun\u003dtarget_lun,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_2fdd40e0","line":90,"range":{"start_line":87,"start_character":22,"end_line":90,"end_character":43},"in_reply_to":"1a1ced50_bd97b838","updated":"2017-03-22 01:23:19.000000000","message":"Done, thanks","commit_id":"5d949ca21f62bfcb67e5bcbb28479156a46caca4"}]}
