)]}'
{"os_brick/initiator/connectors/rbd.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4f31611d3b63a30950c2da30dc857ded4ba096c4","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            monitor_ips \u003d connection_properties[\u0027hosts\u0027]"},{"line_number":126,"context_line":"            monitor_ports \u003d connection_properties[\u0027ports\u0027]"},{"line_number":127,"context_line":"        except (IndexError, KeyError):"},{"line_number":128,"context_line":"            print(\"Caught indexerror\")"},{"line_number":129,"context_line":"            msg \u003d _(\"Connect volume failed, malformed connection properties\")"},{"line_number":130,"context_line":"            raise exception.BrickException(msg\u003dmsg)"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_295bf52e","line":128,"range":{"start_line":128,"start_character":12,"end_line":128,"end_character":37},"updated":"2017-04-05 13:57:35.000000000","message":"Please remove this debug.","commit_id":"5a664b9ca18ac4ad87d615134a6cb4b2adf3dabf"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"f4bd4c0bbcc3fe88bd33028e760c509916aa6632","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            monitor_ports \u003d connection_properties[\u0027ports\u0027]"},{"line_number":127,"context_line":"        except KeyError:"},{"line_number":128,"context_line":"            msg \u003d _(\"Connect volume failed, malformed connection properties\")"},{"line_number":129,"context_line":"            raise exception.BrickException(msg\u003dmsg)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        args \u003d [\u0027--id\u0027, user]"},{"line_number":132,"context_line":"        monitors \u003d [\"%s:%s\" % (ip, port) for ip, port in"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_f733e260","line":129,"updated":"2017-04-11 15:06:04.000000000","message":"this makes the connector fail the attach if these keys don\u0027t exist.   Are these keys always there?  What version of the cinder driver added this information?   I\u0027m concerned about someone with an older Cinder install upgrading os-brick and then attaches fail.","commit_id":"6e78ff8df9c09bdb48626751f00b140cd383d246"},{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"64f5a83b176bb5cd812c471cf8b41d77d65bf606","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            monitor_ports \u003d connection_properties[\u0027ports\u0027]"},{"line_number":127,"context_line":"        except KeyError:"},{"line_number":128,"context_line":"            msg \u003d _(\"Connect volume failed, malformed connection properties\")"},{"line_number":129,"context_line":"            raise exception.BrickException(msg\u003dmsg)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        args \u003d [\u0027--id\u0027, user]"},{"line_number":132,"context_line":"        monitors \u003d [\"%s:%s\" % (ip, port) for ip, port in"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_8201f6b1","line":129,"in_reply_to":"bff0334d_f733e260","updated":"2017-04-11 15:27:59.000000000","message":"Mirroring the key behaviour in _get_rbd_handle would seem appropriate - it looks like auth_username is always going to be provided, but the monitor ips and ports might not be.","commit_id":"6e78ff8df9c09bdb48626751f00b140cd383d246"},{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"64f5a83b176bb5cd812c471cf8b41d77d65bf606","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            raise exception.BrickException(msg\u003dmsg)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        args \u003d [\u0027--id\u0027, user]"},{"line_number":132,"context_line":"        monitors \u003d [\"%s:%s\" % (ip, port) for ip, port in"},{"line_number":133,"context_line":"                    zip(self._sanitize_mon_hosts(monitor_ips), monitor_ports)]"},{"line_number":134,"context_line":"        for monitor in monitors:"},{"line_number":135,"context_line":"            args +\u003d [\u0027--mon_host\u0027, monitor]"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_e229e236","line":132,"updated":"2017-04-11 15:27:59.000000000","message":"Addition of monitors would need to be conditional on cinder actually providing this information.","commit_id":"6e78ff8df9c09bdb48626751f00b140cd383d246"}]}