)]}'
{"os_brick/initiator/connector.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2fd6131c0f18e46bcfd2713f8c3dd9d8136a8d94","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            _mapping \u003d _connector_mapping_linux_s390x"},{"line_number":272,"context_line":"        elif arch in (initiator.PPC64, initiator.PPC64LE):"},{"line_number":273,"context_line":"            _mapping \u003d _connector_mapping_linux_ppc64"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        else:"},{"line_number":276,"context_line":"            _mapping \u003d _connector_mapping_linux"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5ff73747_01658eb5","line":274,"updated":"2017-04-24 14:25:49.000000000","message":"Remove extra line if you do an update.","commit_id":"548cb5cf9f11547502ab25d5e4e3efe03389d111"}],"os_brick/initiator/connectors/fibre_channel_ppc64.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2de6db8b49a2b2a9abba88f576c9d88f28ed363d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from os_brick import initiator"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from os_brick.initiator.connectors import fibre_channel"},{"line_number":20,"context_line":"from os_brick.initiator import linuxfc"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_8a6ac17d","line":18,"updated":"2017-04-17 13:42:12.000000000","message":"Extra blank line should be removed.","commit_id":"f2bf26f42d1da491f8ec9c11bab088826a142323"}],"os_brick/initiator/linuxfc.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2de6db8b49a2b2a9abba88f576c9d88f28ed363d","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        if host_device and len(host_device) \u003e 4:"},{"line_number":281,"context_line":"            host_device \u003d host_device[4:]"},{"line_number":282,"context_line":"        path \u003d \u0027/sys/class/fc_transport/target%s:\u0027 % host_device"},{"line_number":283,"context_line":"        cmd \u003d  \u0027grep %(wwnn)s %(path)s*/port_name\u0027 % {\u0027wwnn\u0027: str(hba[\u0027target_wwn\u0027]),"},{"line_number":284,"context_line":"                                                      \u0027path\u0027: path}"},{"line_number":285,"context_line":"        try:"},{"line_number":286,"context_line":"            out, _err \u003d self._execute(cmd)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_6a6095a6","line":283,"range":{"start_line":283,"start_character":62,"end_line":283,"end_character":65},"updated":"2017-04-17 13:42:12.000000000","message":"str() isn\u0027t needed here as you\u0027re formatting this into a string anyway.","commit_id":"f2bf26f42d1da491f8ec9c11bab088826a142323"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2de6db8b49a2b2a9abba88f576c9d88f28ed363d","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            return [line.split(\u0027/\u0027)[4].split(\u0027:\u0027)[1:]"},{"line_number":288,"context_line":"                    for line in out.split(\u0027\\n\u0027) if line.startswith(path)]"},{"line_number":289,"context_line":"        except Exception as exc:"},{"line_number":290,"context_line":"            LOG.error(_LE(\u0027Could not get HBA channel and SCSI target ID, \u0027"},{"line_number":291,"context_line":"                          \u0027reason: %s\u0027), exc)"},{"line_number":292,"context_line":"            return None"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_0a5fd1e2","line":290,"range":{"start_line":290,"start_character":22,"end_line":290,"end_character":25},"updated":"2017-04-17 13:42:12.000000000","message":"Log translations have been removed, so this should just be a plain string passed into the log call now.","commit_id":"f2bf26f42d1da491f8ec9c11bab088826a142323"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"b3098c78b339bbcd155f75a0df16169130c222bf","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    def _get_hba_channel_scsi_target(self, hba):"},{"line_number":273,"context_line":"        \"\"\"Try to get the HBA channel and SCSI target for an HBA."},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        This method only works for Fibre Channel targets that implement a"},{"line_number":276,"context_line":"        single WWNN for all ports, so caller should expect us to return either"},{"line_number":277,"context_line":"        None or an empty list."},{"line_number":278,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_796055a6","line":275,"updated":"2017-04-18 12:57:39.000000000","message":"This is not true for power. Each adapter has a unique wwnn. This is true for both physical adapters and NPIV adapters.","commit_id":"2a42f31c19bfff6588a5f9036a3b5dcf2c000a24"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"1d822ec15c8f05bcfb86be46f3b198c721df378b","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    def _get_hba_channel_scsi_target(self, hba):"},{"line_number":273,"context_line":"        \"\"\"Try to get the HBA channel and SCSI target for an HBA."},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        This method only works for Fibre Channel targets that implement a"},{"line_number":276,"context_line":"        single WWNN for all ports, so caller should expect us to return either"},{"line_number":277,"context_line":"        None or an empty list."},{"line_number":278,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_c38184fd","line":275,"in_reply_to":"7ffa3b31_796055a6","updated":"2017-04-19 17:36:16.000000000","message":"In the case of npiv adapter there can be cases where a single port is mapped to multiple target ports, which can be different as well.\nDo you mean initiator or target ports.","commit_id":"2a42f31c19bfff6588a5f9036a3b5dcf2c000a24"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"23ce0a79a48384a3105463165deafd7d4b80f255","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    def _get_hba_channel_scsi_target(self, hba):"},{"line_number":273,"context_line":"        \"\"\"Try to get the HBA channel and SCSI target for an HBA."},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        This method only works for Fibre Channel targets that implement a"},{"line_number":276,"context_line":"        single WWNN for all ports, so caller should expect us to return either"},{"line_number":277,"context_line":"        None or an empty list."},{"line_number":278,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_58f1e294","line":275,"in_reply_to":"7ffa3b31_c38184fd","updated":"2017-04-19 18:38:25.000000000","message":"My bad. Yes that is initiator.","commit_id":"2a42f31c19bfff6588a5f9036a3b5dcf2c000a24"}]}
