)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"662045e896ec3302993a9b64de9b357195cdc81a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"os_brick updates node.startup values from default value to"},{"line_number":10,"context_line":"\"automatic\" when it creates iscsi connection."},{"line_number":11,"context_line":"But existed target\u0027s node.startup values will be reverted from"},{"line_number":12,"context_line":"\"automatic\" to default value in creating iscsi connection process"},{"line_number":13,"context_line":"if multipath is used."},{"line_number":14,"context_line":"Because \"iscsiadm -m discovery -t sendtargets -p ...\" command will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f287b81_2b98c019","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":11},"updated":"2017-08-30 12:00:37.000000000","message":"nit: existing","commit_id":"effca382f89169b62d5db9035e48cbbda1409c56"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"662045e896ec3302993a9b64de9b357195cdc81a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"But existed target\u0027s node.startup values will be reverted from"},{"line_number":12,"context_line":"\"automatic\" to default value in creating iscsi connection process"},{"line_number":13,"context_line":"if multipath is used."},{"line_number":14,"context_line":"Because \"iscsiadm -m discovery -t sendtargets -p ...\" command will"},{"line_number":15,"context_line":"recreate all target information of specified node.[1] node.startup"},{"line_number":16,"context_line":"value will be reverted to default value by recreating."},{"line_number":17,"context_line":"\"iscsiadm -m discovery -t sendtargets -p ...\" command will be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f287b81_eb6bd8ed","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":7},"updated":"2017-08-30 12:00:37.000000000","message":"nit: When using multipath with a discovery type of backend, the","commit_id":"effca382f89169b62d5db9035e48cbbda1409c56"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"662045e896ec3302993a9b64de9b357195cdc81a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"if multipath is used."},{"line_number":14,"context_line":"Because \"iscsiadm -m discovery -t sendtargets -p ...\" command will"},{"line_number":15,"context_line":"recreate all target information of specified node.[1] node.startup"},{"line_number":16,"context_line":"value will be reverted to default value by recreating."},{"line_number":17,"context_line":"\"iscsiadm -m discovery -t sendtargets -p ...\" command will be"},{"line_number":18,"context_line":"executed in creating iscsi connections process if multipath is used."},{"line_number":19,"context_line":"As a result, \"automatic\" targets and default value targets will be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f287b81_4ba54c46","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":10},"updated":"2017-08-30 12:00:37.000000000","message":"nit: value of existing targets","commit_id":"effca382f89169b62d5db9035e48cbbda1409c56"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"662045e896ec3302993a9b64de9b357195cdc81a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Because \"iscsiadm -m discovery -t sendtargets -p ...\" command will"},{"line_number":15,"context_line":"recreate all target information of specified node.[1] node.startup"},{"line_number":16,"context_line":"value will be reverted to default value by recreating."},{"line_number":17,"context_line":"\"iscsiadm -m discovery -t sendtargets -p ...\" command will be"},{"line_number":18,"context_line":"executed in creating iscsi connections process if multipath is used."},{"line_number":19,"context_line":"As a result, \"automatic\" targets and default value targets will be"},{"line_number":20,"context_line":"mixed on the host."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f287b81_4b7aecb9","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":68},"updated":"2017-08-30 12:00:37.000000000","message":"If L14 suggestion is applied we don\u0027t need this paragraph.","commit_id":"effca382f89169b62d5db9035e48cbbda1409c56"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"662045e896ec3302993a9b64de9b357195cdc81a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"creating connection."},{"line_number":29,"context_line":"And, creating connection process is exclusived by"},{"line_number":30,"context_line":"\"os-brick-connect_volume\" semaphore in os-brick."},{"line_number":31,"context_line":"So this patch won\u0027t change node.startup value of connections"},{"line_number":32,"context_line":"being created."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[1]"},{"line_number":35,"context_line":"This behavior was explained in following page:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f287b81_6b2da8a6","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":14},"updated":"2017-08-30 12:00:37.000000000","message":"nit: This is not correct, you can say it will not change \"other\" connections being created.","commit_id":"effca382f89169b62d5db9035e48cbbda1409c56"}],"os_brick/initiator/connectors/iscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"08e56e6dae75f594c555c92f8d7bbdc9b1f97eb4","unresolved":false,"context_lines":[{"line_number":944,"context_line":"        delay_on_retry \u003d kwargs.pop(\u0027delay_on_retry\u0027, True)"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"        if update_all_targets:"},{"line_number":947,"context_line":"            (out, err) \u003d self._execute(\u0027iscsiadm\u0027, \u0027-m\u0027, \u0027node\u0027, \u0027-p\u0027,"},{"line_number":948,"context_line":"                                       connection_properties[\u0027target_portal\u0027],"},{"line_number":949,"context_line":"                                       *iscsi_command, run_as_root\u003dTrue,"},{"line_number":950,"context_line":"                                       root_helper\u003dself._root_helper,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_2b8db9d2","line":947,"updated":"2017-07-26 15:00:46.000000000","message":"-1: This could be setting to automatic one of the connections we are currently doing but that should still be in manual mode because the connection thread hasn\u0027t reached the success state (and may never reach it).   This would defeat the purpose of setting the attribute to manual in the first place.","commit_id":"a945973ba8d7a31320163a16982bae4c2b1145fa"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"662045e896ec3302993a9b64de9b357195cdc81a","unresolved":false,"context_lines":[{"line_number":939,"context_line":"    def _run_iscsiadm(self, connection_properties, iscsi_command, **kwargs):"},{"line_number":940,"context_line":"        check_exit_code \u003d kwargs.pop(\u0027check_exit_code\u0027, 0)"},{"line_number":941,"context_line":"        attempts \u003d kwargs.pop(\u0027attempts\u0027, 1)"},{"line_number":942,"context_line":"        update_all_targets \u003d kwargs.pop(\u0027update_all_targets\u0027, False)"},{"line_number":943,"context_line":"        delay_on_retry \u003d kwargs.pop(\u0027delay_on_retry\u0027, True)"},{"line_number":944,"context_line":""},{"line_number":945,"context_line":"        if update_all_targets:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_aba5d0a3","line":942,"updated":"2017-08-30 12:00:37.000000000","message":"nit: This name doesn\u0027t seem right, because this method isn\u0027t limited to update commands, removing the \"update_\" prefix would be more fitting.\n\nnit: I don\u0027t know why we keep adding these parameters here instead of just adding them to the method, which would make the code more readable:\n\n   def _run_iscsiadm(self, connection_properties, iscsi_command, all_targets\u003dFalse, \n                     **kwargs):","commit_id":"effca382f89169b62d5db9035e48cbbda1409c56"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"662045e896ec3302993a9b64de9b357195cdc81a","unresolved":false,"context_lines":[{"line_number":942,"context_line":"        update_all_targets \u003d kwargs.pop(\u0027update_all_targets\u0027, False)"},{"line_number":943,"context_line":"        delay_on_retry \u003d kwargs.pop(\u0027delay_on_retry\u0027, True)"},{"line_number":944,"context_line":""},{"line_number":945,"context_line":"        if update_all_targets:"},{"line_number":946,"context_line":"            (out, err) \u003d self._execute(\u0027iscsiadm\u0027, \u0027-m\u0027, \u0027node\u0027, \u0027-p\u0027,"},{"line_number":947,"context_line":"                                       connection_properties[\u0027target_portal\u0027],"},{"line_number":948,"context_line":"                                       *iscsi_command, run_as_root\u003dTrue,"},{"line_number":949,"context_line":"                                       root_helper\u003dself._root_helper,"},{"line_number":950,"context_line":"                                       check_exit_code\u003dcheck_exit_code,"},{"line_number":951,"context_line":"                                       attempts\u003dattempts,"},{"line_number":952,"context_line":"                                       delay_on_retry\u003ddelay_on_retry)"},{"line_number":953,"context_line":"        else:"},{"line_number":954,"context_line":"            (out, err) \u003d self._execute(\u0027iscsiadm\u0027, \u0027-m\u0027, \u0027node\u0027, \u0027-T\u0027,"},{"line_number":955,"context_line":"                                       connection_properties[\u0027target_iqn\u0027],"},{"line_number":956,"context_line":"                                       \u0027-p\u0027,"},{"line_number":957,"context_line":"                                       connection_properties[\u0027target_portal\u0027],"},{"line_number":958,"context_line":"                                       *iscsi_command, run_as_root\u003dTrue,"},{"line_number":959,"context_line":"                                       root_helper\u003dself._root_helper,"},{"line_number":960,"context_line":"                                       check_exit_code\u003dcheck_exit_code,"},{"line_number":961,"context_line":"                                       attempts\u003dattempts,"},{"line_number":962,"context_line":"                                       delay_on_retry\u003ddelay_on_retry)"},{"line_number":963,"context_line":"        msg \u003d (\"iscsiadm %(iscsi_command)s: stdout\u003d%(out)s stderr\u003d%(err)s\" %"},{"line_number":964,"context_line":"               {\u0027iscsi_command\u0027: iscsi_command, \u0027out\u0027: out, \u0027err\u0027: err})"},{"line_number":965,"context_line":"        # don\u0027t let passwords be shown in log output"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_4bde6cda","line":962,"range":{"start_line":945,"start_character":0,"end_line":962,"end_character":69},"updated":"2017-08-30 12:00:37.000000000","message":"-1: We are basically making the same call in both places, so we should be making just 1 call to make this clearer and easier to read.  Here are 2 suggestions:\n\n        import itertools\n\n        cmd \u003d (\u0027iscsiadm\u0027, \u0027-m\u0027, \u0027node\u0027,\n               \u0027-p\u0027, connection_properties[\u0027target_portal\u0027])\n        if all_targets:\n            cmd \u003d itertools.chain(cmd,\n                                  (\u0027-T\u0027, connection_properties[\u0027target_iqn\u0027]))\n        (out, err) \u003d self._execute(*itertools.chain(cmd, iscsi_command),\n                                   run_as_root\u003dTrue,\n                                   root_helper\u003dself._root_helper,\n                                   check_exit_code\u003dcheck_exit_code,\n                                   attempts\u003dattempts,\n                                   delay_on_retry\u003ddelay_on_retry)\n\n----\n\n\n        cmd \u003d [\u0027iscsiadm\u0027, \u0027-m\u0027, \u0027node\u0027, \u0027-p\u0027,\n               connection_properties[\u0027target_portal\u0027]]\n        if all_targets:\n            cmd.extend((\u0027-T\u0027, connection_properties[\u0027target_iqn\u0027]))\n        cmd.extend(iscsi_command)\n        (out, err) \u003d self._execute(*cmd, run_as_root\u003dTrue,\n                                   root_helper\u003dself._root_helper,\n                                   check_exit_code\u003dcheck_exit_code,\n                                   attempts\u003dattempts,\n                                   delay_on_retry\u003ddelay_on_retry)","commit_id":"effca382f89169b62d5db9035e48cbbda1409c56"},{"author":{"_account_id":8988,"name":"Rikimaru Honjo","email":"honjo.rikimaru@ntt-tx.co.jp","username":"rikimaru.honjo","inactive":true},"change_message_id":"9182b9cb55d279a6030daeb042972a9af0b86d26","unresolved":false,"context_lines":[{"line_number":1128,"context_line":"                pass"},{"line_number":1129,"context_line":""},{"line_number":1130,"context_line":"        LOG.debug(\u0027node.startup values are %(startup_values)s\u0027,"},{"line_number":1131,"context_line":"                  {\u0027startup_values\u0027: startup_values})"},{"line_number":1132,"context_line":"        return startup_values"},{"line_number":1133,"context_line":""},{"line_number":1134,"context_line":"    def _recover_node_startup_values(self, connection_properties,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_528167fa","line":1131,"updated":"2017-11-28 06:56:44.000000000","message":"Oops, sorry, I added this log for debug.\nI remove it.","commit_id":"8c8897fffb8616968382efd37c8c8b3abfcf69eb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d25e93d534e5874eb26f121f98217ce4ccae1a20","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"        return (out, err)"},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"    def _get_node_startup_values(self, connection_properties):"},{"line_number":1105,"context_line":"        out, _ \u003d\\"},{"line_number":1106,"context_line":"            self._run_iscsiadm_bare([\u0027-m\u0027, \u0027node\u0027, \u0027--op\u0027, \u0027show\u0027, \u0027-p\u0027,"},{"line_number":1107,"context_line":"                                    connection_properties[\u0027target_portal\u0027]]"},{"line_number":1108,"context_line":"                                    ) or \"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_486e6100","line":1105,"range":{"start_line":1105,"start_character":13,"end_line":1105,"end_character":14},"updated":"2017-11-29 22:08:07.000000000","message":"Great to denote this variable isn\u0027t used, but unfortunately this hides the _ imported for string translation, so it needs to be changed. Maybe __ instead.\n\nAlso, please do not use \\ to span multiple lines. Looks like you should be able to break on the opening (","commit_id":"602becda65be1255eef2e123ff63e208398c3281"},{"author":{"_account_id":8988,"name":"Rikimaru Honjo","email":"honjo.rikimaru@ntt-tx.co.jp","username":"rikimaru.honjo","inactive":true},"change_message_id":"23594fa17794108368ed1c5d0e412cc2a5bddcc9","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"        return (out, err)"},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"    def _get_node_startup_values(self, connection_properties):"},{"line_number":1105,"context_line":"        out, _ \u003d\\"},{"line_number":1106,"context_line":"            self._run_iscsiadm_bare([\u0027-m\u0027, \u0027node\u0027, \u0027--op\u0027, \u0027show\u0027, \u0027-p\u0027,"},{"line_number":1107,"context_line":"                                    connection_properties[\u0027target_portal\u0027]]"},{"line_number":1108,"context_line":"                                    ) or \"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_14dcdd72","line":1105,"range":{"start_line":1105,"start_character":13,"end_line":1105,"end_character":14},"in_reply_to":"ff82abbf_486e6100","updated":"2017-12-01 23:25:15.000000000","message":"Thank you for pointing out.\nI addressed it.","commit_id":"602becda65be1255eef2e123ff63e208398c3281"}]}
