)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"64388184c92f84718f01a94165b026a830145f22","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added os-brick changes to support NVMEoF for initiator CLI."},{"line_number":10,"context_line":"A New connector, NVMe connector, is added to handle initiator callsi for"},{"line_number":11,"context_line":"connecting and disconnecting volumes to instances using nvme-cli over"},{"line_number":12,"context_line":"RDMA."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I83697d6b46248edbe0a0ef3b76829b28ed5c048c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"df3967d1_10b6f0fb","line":12,"updated":"2017-07-31 20:21:34.000000000","message":"Since it\u0027s based on my PoC, I\u0027ll appreciate if you add me as co-author. Anyway, I won\u0027t -1 on it and be happy to +2 once all comments will be addressed","commit_id":"6ff092e15b4a246f99ce8508090a4ed7e8069491"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"9f3a1c1bfeb2659700e022235670315a14cf4f64","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added os-brick changes to support NVMEoF for initiator CLI."},{"line_number":10,"context_line":"A New connector, NVMe connector, is added to handle initiator callsi for"},{"line_number":11,"context_line":"connecting and disconnecting volumes to instances using nvme-cli over"},{"line_number":12,"context_line":"RDMA."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I83697d6b46248edbe0a0ef3b76829b28ed5c048c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"df3967d1_1996e1f1","line":12,"in_reply_to":"df3967d1_10b6f0fb","updated":"2017-08-02 12:36:30.000000000","message":"Yes sure I\u0027m adding you here and in nova commit as well.","commit_id":"6ff092e15b4a246f99ce8508090a4ed7e8069491"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"64388184c92f84718f01a94165b026a830145f22","unresolved":false,"context_lines":[{"line_number":10,"context_line":"A New connector, NVMe connector, is added to handle initiator callsi for"},{"line_number":11,"context_line":"connecting and disconnecting volumes to instances using nvme-cli over"},{"line_number":12,"context_line":"RDMA."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I83697d6b46248edbe0a0ef3b76829b28ed5c048c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"df3967d1_70741c36","line":13,"updated":"2017-07-31 20:21:34.000000000","message":"Please, add \"Related blueprint: nvme-target-cli\" note here","commit_id":"6ff092e15b4a246f99ce8508090a4ed7e8069491"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"9f3a1c1bfeb2659700e022235670315a14cf4f64","unresolved":false,"context_lines":[{"line_number":10,"context_line":"A New connector, NVMe connector, is added to handle initiator callsi for"},{"line_number":11,"context_line":"connecting and disconnecting volumes to instances using nvme-cli over"},{"line_number":12,"context_line":"RDMA."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I83697d6b46248edbe0a0ef3b76829b28ed5c048c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"df3967d1_d99f3901","line":13,"in_reply_to":"df3967d1_70741c36","updated":"2017-08-02 12:36:30.000000000","message":"Done","commit_id":"6ff092e15b4a246f99ce8508090a4ed7e8069491"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e62a371655f0a59d8eaeb512448c3f1f21ed82a","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint nvme-over-fabirc-nova"},{"line_number":15,"context_line":"Needed-By: I67a72c4226e54c18b3a6e4a13b5055fa6e85af09"},{"line_number":16,"context_line":"Needed-By: I168bcddde419aa9174822bb325e7a8608271aace"},{"line_number":17,"context_line":"Co-Authored-By: Ivan Kolodyazhny \u003ce0ne@e0ne.info\u003e"},{"line_number":18,"context_line":"Change-Id: I83697d6b46248edbe0a0ef3b76829b28ed5c048c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"1f485f77_c0b5c333","line":16,"updated":"2017-11-16 14:22:33.000000000","message":"This change is abandoned, so this link should probably be updated.","commit_id":"84c3854697ef6d3e9d6f9148d0f8c40f0cf532a7"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"39a3b8e0b50091ef7c5ffb98ac5dfc2444c48706","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint nvme-over-fabirc-nova"},{"line_number":15,"context_line":"Needed-By: I67a72c4226e54c18b3a6e4a13b5055fa6e85af09"},{"line_number":16,"context_line":"Needed-By: I168bcddde419aa9174822bb325e7a8608271aace"},{"line_number":17,"context_line":"Co-Authored-By: Ivan Kolodyazhny \u003ce0ne@e0ne.info\u003e"},{"line_number":18,"context_line":"Change-Id: I83697d6b46248edbe0a0ef3b76829b28ed5c048c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"1f485f77_e0af9f27","line":16,"in_reply_to":"1f485f77_00de3b6c","updated":"2017-11-16 14:43:03.000000000","message":"Done","commit_id":"84c3854697ef6d3e9d6f9148d0f8c40f0cf532a7"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"5037a3fb2bdc6efbadc3f72da753a31e735ec459","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint nvme-over-fabirc-nova"},{"line_number":15,"context_line":"Needed-By: I67a72c4226e54c18b3a6e4a13b5055fa6e85af09"},{"line_number":16,"context_line":"Needed-By: I168bcddde419aa9174822bb325e7a8608271aace"},{"line_number":17,"context_line":"Co-Authored-By: Ivan Kolodyazhny \u003ce0ne@e0ne.info\u003e"},{"line_number":18,"context_line":"Change-Id: I83697d6b46248edbe0a0ef3b76829b28ed5c048c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"1f485f77_00de3b6c","line":16,"in_reply_to":"1f485f77_c0b5c333","updated":"2017-11-16 14:23:59.000000000","message":"right, will update soon","commit_id":"84c3854697ef6d3e9d6f9148d0f8c40f0cf532a7"}],"os_brick/exception.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"64388184c92f84718f01a94165b026a830145f22","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"class NVMeParamException(BrickException):"},{"line_number":234,"context_line":"    message \u003d _(\"Param validation exception: %(validation_message)s.\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_70e3fc34","line":234,"updated":"2017-07-31 20:21:34.000000000","message":"There is nothin special for NVMe. Can we re-use InvalidParameterValue exception?","commit_id":"6ff092e15b4a246f99ce8508090a4ed7e8069491"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"9f3a1c1bfeb2659700e022235670315a14cf4f64","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"class NVMeParamException(BrickException):"},{"line_number":234,"context_line":"    message \u003d _(\"Param validation exception: %(validation_message)s.\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_d9b85977","line":234,"in_reply_to":"df3967d1_70e3fc34","updated":"2017-08-02 12:36:30.000000000","message":"Done","commit_id":"6ff092e15b4a246f99ce8508090a4ed7e8069491"}],"os_brick/initiator/connector.py":[{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"e88c6669c0e1ef672fe270f9c071e20b8cbd4ef9","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    \u0027os_brick.initiator.windows.fibre_channel.WindowsFCConnector\u0027,"},{"line_number":104,"context_line":"    \u0027os_brick.initiator.windows.smbfs.WindowsSMBFSConnector\u0027,"},{"line_number":105,"context_line":"    \u0027os_brick.initiator.connectors.vrtshyperscale.HyperScaleConnector\u0027,"},{"line_number":106,"context_line":"    \u0027os_brick.initiator.connectors.nvmetadm.NVMeConnector\u0027,"},{"line_number":107,"context_line":"]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# Mappings used to determine who to contruct in the factory"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_b87afaed","line":106,"range":{"start_line":106,"start_character":35,"end_line":106,"end_character":43},"updated":"2017-07-18 12:33:40.000000000","message":"nvmeadm","commit_id":"1d61e85df7f89ce2536b465a11b998fb28650f81"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"4a2741c6159cba7404c8f36a8ff4162a45622e5a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    \u0027os_brick.initiator.windows.fibre_channel.WindowsFCConnector\u0027,"},{"line_number":104,"context_line":"    \u0027os_brick.initiator.windows.smbfs.WindowsSMBFSConnector\u0027,"},{"line_number":105,"context_line":"    \u0027os_brick.initiator.connectors.vrtshyperscale.HyperScaleConnector\u0027,"},{"line_number":106,"context_line":"    \u0027os_brick.initiator.connectors.nvmetadm.NVMeConnector\u0027,"},{"line_number":107,"context_line":"]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# Mappings used to determine who to contruct in the factory"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_3897dc4a","line":106,"range":{"start_line":106,"start_character":35,"end_line":106,"end_character":43},"in_reply_to":"1f1a1f67_b87afaed","updated":"2017-07-19 13:20:45.000000000","message":"Done","commit_id":"1d61e85df7f89ce2536b465a11b998fb28650f81"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"e88c6669c0e1ef672fe270f9c071e20b8cbd4ef9","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        \u0027os_brick.initiator.connectors.gpfs.GPFSConnector\u0027,"},{"line_number":152,"context_line":"    initiator.VERITAS_HYPERSCALE:"},{"line_number":153,"context_line":"        \u0027os_brick.initiator.connectors.vrtshyperscale.HyperScaleConnector\u0027,"},{"line_number":154,"context_line":"    initiator.NVMETADM:"},{"line_number":155,"context_line":"        \u0027os_brick.initiator.connectors.nvmetadm.NVMeConnector\u0027,"},{"line_number":156,"context_line":"}"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_581086a8","line":154,"range":{"start_line":154,"start_character":14,"end_line":154,"end_character":22},"updated":"2017-07-18 12:33:40.000000000","message":"NVMEADM","commit_id":"1d61e85df7f89ce2536b465a11b998fb28650f81"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"4a2741c6159cba7404c8f36a8ff4162a45622e5a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        \u0027os_brick.initiator.connectors.gpfs.GPFSConnector\u0027,"},{"line_number":152,"context_line":"    initiator.VERITAS_HYPERSCALE:"},{"line_number":153,"context_line":"        \u0027os_brick.initiator.connectors.vrtshyperscale.HyperScaleConnector\u0027,"},{"line_number":154,"context_line":"    initiator.NVMETADM:"},{"line_number":155,"context_line":"        \u0027os_brick.initiator.connectors.nvmetadm.NVMeConnector\u0027,"},{"line_number":156,"context_line":"}"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_1892e057","line":154,"range":{"start_line":154,"start_character":14,"end_line":154,"end_character":22},"in_reply_to":"1f1a1f67_581086a8","updated":"2017-07-19 13:20:45.000000000","message":"Done","commit_id":"1d61e85df7f89ce2536b465a11b998fb28650f81"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"e88c6669c0e1ef672fe270f9c071e20b8cbd4ef9","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    initiator.VERITAS_HYPERSCALE:"},{"line_number":153,"context_line":"        \u0027os_brick.initiator.connectors.vrtshyperscale.HyperScaleConnector\u0027,"},{"line_number":154,"context_line":"    initiator.NVMETADM:"},{"line_number":155,"context_line":"        \u0027os_brick.initiator.connectors.nvmetadm.NVMeConnector\u0027,"},{"line_number":156,"context_line":"}"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"# Mapping for the S390X platform"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_780b427c","line":155,"range":{"start_line":155,"start_character":39,"end_line":155,"end_character":47},"updated":"2017-07-18 12:33:40.000000000","message":"nvmeadm","commit_id":"1d61e85df7f89ce2536b465a11b998fb28650f81"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"4a2741c6159cba7404c8f36a8ff4162a45622e5a","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    initiator.VERITAS_HYPERSCALE:"},{"line_number":153,"context_line":"        \u0027os_brick.initiator.connectors.vrtshyperscale.HyperScaleConnector\u0027,"},{"line_number":154,"context_line":"    initiator.NVMETADM:"},{"line_number":155,"context_line":"        \u0027os_brick.initiator.connectors.nvmetadm.NVMeConnector\u0027,"},{"line_number":156,"context_line":"}"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"# Mapping for the S390X platform"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_f89cc46a","line":155,"range":{"start_line":155,"start_character":39,"end_line":155,"end_character":47},"in_reply_to":"1f1a1f67_780b427c","updated":"2017-07-19 13:20:45.000000000","message":"Done","commit_id":"1d61e85df7f89ce2536b465a11b998fb28650f81"}],"os_brick/initiator/connectors/nvme.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"64388184c92f84718f01a94165b026a830145f22","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        return {}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def get_search_path(self):"},{"line_number":50,"context_line":"        return \u0027/dev  \u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def get_volume_paths(self, connection_properties):"},{"line_number":53,"context_line":"        path \u003d connection_properties[\u0027device_path\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_d04aa825","line":50,"updated":"2017-07-31 20:21:34.000000000","message":"do we need spaces here?","commit_id":"6ff092e15b4a246f99ce8508090a4ed7e8069491"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"9f3a1c1bfeb2659700e022235670315a14cf4f64","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        return {}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def get_search_path(self):"},{"line_number":50,"context_line":"        return \u0027/dev  \u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def get_volume_paths(self, connection_properties):"},{"line_number":53,"context_line":"        path \u003d connection_properties[\u0027device_path\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_5c3697e8","line":50,"in_reply_to":"df3967d1_d04aa825","updated":"2017-08-02 12:36:30.000000000","message":"no we don\u0027t :)","commit_id":"6ff092e15b4a246f99ce8508090a4ed7e8069491"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"64388184c92f84718f01a94165b026a830145f22","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        all_nvme_devices \u003d self._get_nvme_devices()"},{"line_number":134,"context_line":"        path \u003d set(all_nvme_devices) - set(current_nvme_devices)"},{"line_number":135,"context_line":"        path \u003d list(path)"},{"line_number":136,"context_line":"        LOG.debug(\u0027all_nvme_devices to be connected to are \\"},{"line_number":137,"context_line":"                  {0}\u0027.format(all_nvme_devices))"},{"line_number":138,"context_line":"        LOG.debug(\u0027NVMe device to be connected to is \\"},{"line_number":139,"context_line":"                  {0}\u0027.format(path[0]))"}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_10ddd041","line":136,"updated":"2017-07-31 20:21:34.000000000","message":"Please, change log calls here and below according our guidelines like [1]\n\n[1] https://github.com/openstack/os-brick/blob/4e6a4a3ce7b2d3203ac3de3a5457dad0ae7fc350/os_brick/encryptors/__init__.py#L80","commit_id":"6ff092e15b4a246f99ce8508090a4ed7e8069491"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"9f3a1c1bfeb2659700e022235670315a14cf4f64","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        all_nvme_devices \u003d self._get_nvme_devices()"},{"line_number":134,"context_line":"        path \u003d set(all_nvme_devices) - set(current_nvme_devices)"},{"line_number":135,"context_line":"        path \u003d list(path)"},{"line_number":136,"context_line":"        LOG.debug(\u0027all_nvme_devices to be connected to are \\"},{"line_number":137,"context_line":"                  {0}\u0027.format(all_nvme_devices))"},{"line_number":138,"context_line":"        LOG.debug(\u0027NVMe device to be connected to is \\"},{"line_number":139,"context_line":"                  {0}\u0027.format(path[0]))"}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_7c65dbe0","line":136,"in_reply_to":"df3967d1_10ddd041","updated":"2017-08-02 12:36:30.000000000","message":"Done","commit_id":"6ff092e15b4a246f99ce8508090a4ed7e8069491"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"523fe023b694916e024782b78a93918785403c12","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        port \u003d connection_properties[\u0027target_port\u0027]"},{"line_number":71,"context_line":"        nvme_transport_type \u003d connection_properties[\u0027nvme_transport_type\u0027]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        cmd \u003d [\u0027/usr/local/sbin/nvme\u0027, \u0027discover\u0027, \u0027-t\u0027, nvme_transport_type,"},{"line_number":74,"context_line":"               \u0027-a\u0027, target_portal, \u0027-s\u0027, port]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_beb31798","line":73,"range":{"start_line":73,"start_character":50,"end_line":73,"end_character":51},"updated":"2017-08-03 08:31:59.000000000","message":"split to new line","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"1b88c05cf4aac24e598ea08792fd7366bc710998","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        port \u003d connection_properties[\u0027target_port\u0027]"},{"line_number":71,"context_line":"        nvme_transport_type \u003d connection_properties[\u0027nvme_transport_type\u0027]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        cmd \u003d [\u0027/usr/local/sbin/nvme\u0027, \u0027discover\u0027, \u0027-t\u0027, nvme_transport_type,"},{"line_number":74,"context_line":"               \u0027-a\u0027, target_portal, \u0027-s\u0027, port]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_9c2a22e5","line":73,"range":{"start_line":73,"start_character":50,"end_line":73,"end_character":51},"in_reply_to":"df3967d1_beb31798","updated":"2017-08-06 13:26:12.000000000","message":"Done","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"523fe023b694916e024782b78a93918785403c12","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        nvme_transport_type \u003d connection_properties[\u0027nvme_transport_type\u0027]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        cmd \u003d [\u0027/usr/local/sbin/nvme\u0027, \u0027discover\u0027, \u0027-t\u0027, nvme_transport_type,"},{"line_number":74,"context_line":"               \u0027-a\u0027, target_portal, \u0027-s\u0027, port]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            (out, err) \u003d self._execute(*cmd, root_helper\u003dself._root_helper,"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_5ea66b55","line":74,"range":{"start_line":74,"start_character":35,"end_line":74,"end_character":36},"updated":"2017-08-03 08:31:59.000000000","message":"split to new line","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"1b88c05cf4aac24e598ea08792fd7366bc710998","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        nvme_transport_type \u003d connection_properties[\u0027nvme_transport_type\u0027]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        cmd \u003d [\u0027/usr/local/sbin/nvme\u0027, \u0027discover\u0027, \u0027-t\u0027, nvme_transport_type,"},{"line_number":74,"context_line":"               \u0027-a\u0027, target_portal, \u0027-s\u0027, port]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            (out, err) \u003d self._execute(*cmd, root_helper\u003dself._root_helper,"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_7c2f7ef6","line":74,"range":{"start_line":74,"start_character":35,"end_line":74,"end_character":36},"in_reply_to":"df3967d1_5ea66b55","updated":"2017-08-06 13:26:12.000000000","message":"Done","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"523fe023b694916e024782b78a93918785403c12","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            return self._get_nvme_portals_from_output(out)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        except putils.ProcessExecutionError:"},{"line_number":82,"context_line":"            LOG.error(\"Failed to discover NVMe subsystems on targer_portal: \\"},{"line_number":83,"context_line":"                       %(target_portal)s, target_port: %(port)s\","},{"line_number":84,"context_line":"                      {\u0027target_portal\u0027: target_portal, \u0027port\u0027: port})"},{"line_number":85,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_fe6abfea","line":82,"range":{"start_line":82,"start_character":76,"end_line":82,"end_character":77},"updated":"2017-08-03 08:31:59.000000000","message":"redundant","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"1b88c05cf4aac24e598ea08792fd7366bc710998","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            return self._get_nvme_portals_from_output(out)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        except putils.ProcessExecutionError:"},{"line_number":82,"context_line":"            LOG.error(\"Failed to discover NVMe subsystems on targer_portal: \\"},{"line_number":83,"context_line":"                       %(target_portal)s, target_port: %(port)s\","},{"line_number":84,"context_line":"                      {\u0027target_portal\u0027: target_portal, \u0027port\u0027: port})"},{"line_number":85,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_5c34ba4a","line":82,"range":{"start_line":82,"start_character":76,"end_line":82,"end_character":77},"in_reply_to":"df3967d1_fe6abfea","updated":"2017-08-06 13:26:12.000000000","message":"Done","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"523fe023b694916e024782b78a93918785403c12","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        target_portal \u003d connection_properties[\u0027target_portal\u0027]"},{"line_number":127,"context_line":"        port \u003d connection_properties[\u0027target_port\u0027]"},{"line_number":128,"context_line":"        nvme_transport_type \u003d connection_properties[\u0027nvme_transport_type\u0027]"},{"line_number":129,"context_line":"        cmd \u003d ["},{"line_number":130,"context_line":"            \u0027/usr/local/sbin/nvme\u0027, \u0027connect\u0027, \u0027-t\u0027, nvme_transport_type,"},{"line_number":131,"context_line":"            \u0027-n\u0027, conn_nqn, \u0027-a\u0027, target_portal, \u0027-s\u0027, port]"},{"line_number":132,"context_line":"        try:"},{"line_number":133,"context_line":"            self._execute(*cmd, root_helper\u003dself._root_helper,"},{"line_number":134,"context_line":"                          run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_de3dbbdd","line":131,"range":{"start_line":129,"start_character":15,"end_line":131,"end_character":59},"updated":"2017-08-03 08:31:59.000000000","message":"split this to some new lines, it will be easier to read","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"1b88c05cf4aac24e598ea08792fd7366bc710998","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        target_portal \u003d connection_properties[\u0027target_portal\u0027]"},{"line_number":127,"context_line":"        port \u003d connection_properties[\u0027target_port\u0027]"},{"line_number":128,"context_line":"        nvme_transport_type \u003d connection_properties[\u0027nvme_transport_type\u0027]"},{"line_number":129,"context_line":"        cmd \u003d ["},{"line_number":130,"context_line":"            \u0027/usr/local/sbin/nvme\u0027, \u0027connect\u0027, \u0027-t\u0027, nvme_transport_type,"},{"line_number":131,"context_line":"            \u0027-n\u0027, conn_nqn, \u0027-a\u0027, target_portal, \u0027-s\u0027, port]"},{"line_number":132,"context_line":"        try:"},{"line_number":133,"context_line":"            self._execute(*cmd, root_helper\u003dself._root_helper,"},{"line_number":134,"context_line":"                          run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_3c39f640","line":131,"range":{"start_line":129,"start_character":15,"end_line":131,"end_character":59},"in_reply_to":"df3967d1_de3dbbdd","updated":"2017-08-06 13:26:12.000000000","message":"Done","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"523fe023b694916e024782b78a93918785403c12","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                          run_as_root\u003dTrue)"},{"line_number":135,"context_line":"        except putils.ProcessExecutionError:"},{"line_number":136,"context_line":"            LOG.error("},{"line_number":137,"context_line":"                \"Failed to connect to NVMe nqn \\"},{"line_number":138,"context_line":"                %(conn_nqn)s\", {\u0027conn_nqn\u0027: conn_nqn})"},{"line_number":139,"context_line":"            raise"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_be2677cd","line":137,"range":{"start_line":137,"start_character":47,"end_line":137,"end_character":48},"updated":"2017-08-03 08:31:59.000000000","message":"redundant","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"1b88c05cf4aac24e598ea08792fd7366bc710998","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                          run_as_root\u003dTrue)"},{"line_number":135,"context_line":"        except putils.ProcessExecutionError:"},{"line_number":136,"context_line":"            LOG.error("},{"line_number":137,"context_line":"                \"Failed to connect to NVMe nqn \\"},{"line_number":138,"context_line":"                %(conn_nqn)s\", {\u0027conn_nqn\u0027: conn_nqn})"},{"line_number":139,"context_line":"            raise"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_fc3a4e32","line":137,"range":{"start_line":137,"start_character":47,"end_line":137,"end_character":48},"in_reply_to":"df3967d1_be2677cd","updated":"2017-08-06 13:26:12.000000000","message":"Done","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"523fe023b694916e024782b78a93918785403c12","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                      {\u0027path\u0027: path[0]})"},{"line_number":152,"context_line":"            return device_info"},{"line_number":153,"context_line":"        else:"},{"line_number":154,"context_line":"            LOG.error(\"Failed to retrieve available connected NVMe \\"},{"line_number":155,"context_line":"                      controllers when running nvme list\")"},{"line_number":156,"context_line":"            raise"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_9e23b3bd","line":154,"range":{"start_line":154,"start_character":67,"end_line":154,"end_character":68},"updated":"2017-08-03 08:31:59.000000000","message":"redundant","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"1b88c05cf4aac24e598ea08792fd7366bc710998","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                      {\u0027path\u0027: path[0]})"},{"line_number":152,"context_line":"            return device_info"},{"line_number":153,"context_line":"        else:"},{"line_number":154,"context_line":"            LOG.error(\"Failed to retrieve available connected NVMe \\"},{"line_number":155,"context_line":"                      controllers when running nvme list\")"},{"line_number":156,"context_line":"            raise"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_bc44c6b8","line":154,"range":{"start_line":154,"start_character":67,"end_line":154,"end_character":68},"in_reply_to":"df3967d1_9e23b3bd","updated":"2017-08-06 13:26:12.000000000","message":"Done","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"523fe023b694916e024782b78a93918785403c12","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        conn_nqn \u003d connection_properties[\u0027nqn\u0027]"},{"line_number":175,"context_line":"        device_path \u003d connection_properties[\u0027device_path\u0027]"},{"line_number":176,"context_line":"        LOG.debug("},{"line_number":177,"context_line":"            \"Trying to disconnect from NVMe nqn \\"},{"line_number":178,"context_line":"            %(conn_nqn)s with device_path %(device_path)s\","},{"line_number":179,"context_line":"            {\u0027conn_nqn\u0027: conn_nqn, \u0027device_path\u0027: device_path})"},{"line_number":180,"context_line":"        cmd \u003d ["}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_7e2c8fab","line":177,"range":{"start_line":177,"start_character":48,"end_line":177,"end_character":49},"updated":"2017-08-03 08:31:59.000000000","message":"ditto","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"1b88c05cf4aac24e598ea08792fd7366bc710998","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        conn_nqn \u003d connection_properties[\u0027nqn\u0027]"},{"line_number":175,"context_line":"        device_path \u003d connection_properties[\u0027device_path\u0027]"},{"line_number":176,"context_line":"        LOG.debug("},{"line_number":177,"context_line":"            \"Trying to disconnect from NVMe nqn \\"},{"line_number":178,"context_line":"            %(conn_nqn)s with device_path %(device_path)s\","},{"line_number":179,"context_line":"            {\u0027conn_nqn\u0027: conn_nqn, \u0027device_path\u0027: device_path})"},{"line_number":180,"context_line":"        cmd \u003d ["}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_7c189ed2","line":177,"range":{"start_line":177,"start_character":48,"end_line":177,"end_character":49},"in_reply_to":"df3967d1_7e2c8fab","updated":"2017-08-06 13:26:12.000000000","message":"Done","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"523fe023b694916e024782b78a93918785403c12","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        except putils.ProcessExecutionError:"},{"line_number":192,"context_line":"            LOG.error("},{"line_number":193,"context_line":"                \"Failed to disconnect from NVMe nqn \\"},{"line_number":194,"context_line":"                %(conn_nqn)s with device_path %(device_path)s\","},{"line_number":195,"context_line":"                {\u0027conn_nqn\u0027: conn_nqn, \u0027device_path\u0027: device_path})"},{"line_number":196,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_3e1cc776","line":193,"range":{"start_line":193,"start_character":52,"end_line":193,"end_character":53},"updated":"2017-08-03 08:31:59.000000000","message":"ditto","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"1b88c05cf4aac24e598ea08792fd7366bc710998","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        except putils.ProcessExecutionError:"},{"line_number":192,"context_line":"            LOG.error("},{"line_number":193,"context_line":"                \"Failed to disconnect from NVMe nqn \\"},{"line_number":194,"context_line":"                %(conn_nqn)s with device_path %(device_path)s\","},{"line_number":195,"context_line":"                {\u0027conn_nqn\u0027: conn_nqn, \u0027device_path\u0027: device_path})"},{"line_number":196,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_5c0dda8e","line":193,"range":{"start_line":193,"start_character":52,"end_line":193,"end_character":53},"in_reply_to":"df3967d1_3e1cc776","updated":"2017-08-06 13:26:12.000000000","message":"Done","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"78d76eaf90487bdac967ba5739111f45a0a23b9d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from os_brick.initiator.connectors import base"},{"line_number":18,"context_line":"from os_brick import utils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_concurrency import lockutils"},{"line_number":21,"context_line":"from oslo_concurrency import processutils as putils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"DEVICE_SCAN_ATTEMPTS_DEFAULT \u003d 3"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_6f92644e","line":23,"range":{"start_line":20,"start_character":0,"end_line":23,"end_character":35},"updated":"2017-08-15 18:31:58.000000000","message":"Should group the oslo imports before the os_brick imports.\n\nSee\n    https://docs.openstack.org/hacking/latest/user/hacking.html#imports","commit_id":"6eeefab50de768495085fde36c04c435a28d1af6"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"9b4d8e4022dcf4409247c0d7d20e025d576d1348","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from os_brick.initiator.connectors import base"},{"line_number":18,"context_line":"from os_brick import utils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_concurrency import lockutils"},{"line_number":21,"context_line":"from oslo_concurrency import processutils as putils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"DEVICE_SCAN_ATTEMPTS_DEFAULT \u003d 3"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_0f1165ad","line":23,"range":{"start_line":20,"start_character":0,"end_line":23,"end_character":35},"in_reply_to":"9f436f4f_6f92644e","updated":"2017-11-01 08:27:47.000000000","message":"Done","commit_id":"6eeefab50de768495085fde36c04c435a28d1af6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"78d76eaf90487bdac967ba5739111f45a0a23b9d","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"synchronized \u003d lockutils.synchronized_with_prefix(\u0027os-brick-\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class NVMeConnector(base.BaseLinuxConnector):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_2fb1fce1","line":29,"updated":"2017-08-15 18:31:58.000000000","message":"Does this need to be an external lock or is having it per-process sufficient?","commit_id":"6eeefab50de768495085fde36c04c435a28d1af6"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"9b4d8e4022dcf4409247c0d7d20e025d576d1348","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"synchronized \u003d lockutils.synchronized_with_prefix(\u0027os-brick-\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class NVMeConnector(base.BaseLinuxConnector):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_af9019ef","line":29,"in_reply_to":"9f436f4f_2fb1fce1","updated":"2017-11-01 08:27:47.000000000","message":"It has to be external, calls to nvme command should by synchronized","commit_id":"6eeefab50de768495085fde36c04c435a28d1af6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"78d76eaf90487bdac967ba5739111f45a0a23b9d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        port \u003d connection_properties[\u0027target_port\u0027]"},{"line_number":72,"context_line":"        nvme_transport_type \u003d connection_properties[\u0027nvme_transport_type\u0027]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        cmd \u003d [\u0027/usr/local/sbin/nvme\u0027, \u0027discover\u0027,"},{"line_number":75,"context_line":"               \u0027-t\u0027, nvme_transport_type,"},{"line_number":76,"context_line":"               \u0027-a\u0027, target_portal,"},{"line_number":77,"context_line":"               \u0027-s\u0027, port]"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_afd96c22","line":74,"range":{"start_line":74,"start_character":15,"end_line":74,"end_character":37},"updated":"2017-08-15 18:31:58.000000000","message":"I don\u0027t think you can assume that this command is in /usr/local/sbin/ instead of /usr/sbin/ or similar.\n\nThe connector should probably determine where this command is when initializing if it can\u0027t be called w/o a path specified.","commit_id":"6eeefab50de768495085fde36c04c435a28d1af6"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"9b4d8e4022dcf4409247c0d7d20e025d576d1348","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        port \u003d connection_properties[\u0027target_port\u0027]"},{"line_number":72,"context_line":"        nvme_transport_type \u003d connection_properties[\u0027nvme_transport_type\u0027]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        cmd \u003d [\u0027/usr/local/sbin/nvme\u0027, \u0027discover\u0027,"},{"line_number":75,"context_line":"               \u0027-t\u0027, nvme_transport_type,"},{"line_number":76,"context_line":"               \u0027-a\u0027, target_portal,"},{"line_number":77,"context_line":"               \u0027-s\u0027, port]"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_1549748a","line":74,"range":{"start_line":74,"start_character":15,"end_line":74,"end_character":37},"in_reply_to":"9f436f4f_afd96c22","updated":"2017-11-01 08:27:47.000000000","message":"we removed command full path, since command can be called my \u0027nvme\u0027","commit_id":"6eeefab50de768495085fde36c04c435a28d1af6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"78d76eaf90487bdac967ba5739111f45a0a23b9d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def _get_nvme_devices(self):"},{"line_number":91,"context_line":"        nvme_devices \u003d []"},{"line_number":92,"context_line":"        pattern \u003d r\u0027/dev/nvme[0-9]n[0-9]\u0027"},{"line_number":93,"context_line":"        cmd \u003d [\u0027/usr/local/sbin/nvme\u0027, \u0027list\u0027]"},{"line_number":94,"context_line":"        try:"},{"line_number":95,"context_line":"            (out, err) \u003d self._execute(*cmd, root_helper\u003dself._root_helper,"},{"line_number":96,"context_line":"                                       run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_6f094494","line":93,"range":{"start_line":93,"start_character":15,"end_line":93,"end_character":37},"updated":"2017-08-15 18:31:58.000000000","message":"Same as above.","commit_id":"6eeefab50de768495085fde36c04c435a28d1af6"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"9b4d8e4022dcf4409247c0d7d20e025d576d1348","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def _get_nvme_devices(self):"},{"line_number":91,"context_line":"        nvme_devices \u003d []"},{"line_number":92,"context_line":"        pattern \u003d r\u0027/dev/nvme[0-9]n[0-9]\u0027"},{"line_number":93,"context_line":"        cmd \u003d [\u0027/usr/local/sbin/nvme\u0027, \u0027list\u0027]"},{"line_number":94,"context_line":"        try:"},{"line_number":95,"context_line":"            (out, err) \u003d self._execute(*cmd, root_helper\u003dself._root_helper,"},{"line_number":96,"context_line":"                                       run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_551dbc71","line":93,"range":{"start_line":93,"start_character":15,"end_line":93,"end_character":37},"in_reply_to":"9f436f4f_6f094494","updated":"2017-11-01 08:27:47.000000000","message":"Done","commit_id":"6eeefab50de768495085fde36c04c435a28d1af6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"78d76eaf90487bdac967ba5739111f45a0a23b9d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        port \u003d connection_properties[\u0027target_port\u0027]"},{"line_number":131,"context_line":"        nvme_transport_type \u003d connection_properties[\u0027nvme_transport_type\u0027]"},{"line_number":132,"context_line":"        cmd \u003d ["},{"line_number":133,"context_line":"            \u0027/usr/local/sbin/nvme\u0027, \u0027connect\u0027,"},{"line_number":134,"context_line":"            \u0027-t\u0027, nvme_transport_type,"},{"line_number":135,"context_line":"            \u0027-n\u0027, conn_nqn,"},{"line_number":136,"context_line":"            \u0027-a\u0027, target_portal,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_4f0c40a4","line":133,"range":{"start_line":133,"start_character":12,"end_line":133,"end_character":34},"updated":"2017-08-15 18:31:58.000000000","message":"Same as above","commit_id":"6eeefab50de768495085fde36c04c435a28d1af6"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"9b4d8e4022dcf4409247c0d7d20e025d576d1348","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        port \u003d connection_properties[\u0027target_port\u0027]"},{"line_number":131,"context_line":"        nvme_transport_type \u003d connection_properties[\u0027nvme_transport_type\u0027]"},{"line_number":132,"context_line":"        cmd \u003d ["},{"line_number":133,"context_line":"            \u0027/usr/local/sbin/nvme\u0027, \u0027connect\u0027,"},{"line_number":134,"context_line":"            \u0027-t\u0027, nvme_transport_type,"},{"line_number":135,"context_line":"            \u0027-n\u0027, conn_nqn,"},{"line_number":136,"context_line":"            \u0027-a\u0027, target_portal,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_15173454","line":133,"range":{"start_line":133,"start_character":12,"end_line":133,"end_character":34},"in_reply_to":"9f436f4f_4f0c40a4","updated":"2017-11-01 08:27:47.000000000","message":"Done","commit_id":"6eeefab50de768495085fde36c04c435a28d1af6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"78d76eaf90487bdac967ba5739111f45a0a23b9d","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            \"%(conn_nqn)s with device_path %(device_path)s\","},{"line_number":185,"context_line":"            {\u0027conn_nqn\u0027: conn_nqn, \u0027device_path\u0027: device_path})"},{"line_number":186,"context_line":"        cmd \u003d ["},{"line_number":187,"context_line":"            \u0027/usr/local/sbin/nvme\u0027,"},{"line_number":188,"context_line":"            \u0027disconnect\u0027,"},{"line_number":189,"context_line":"            \u0027-d\u0027,"},{"line_number":190,"context_line":"            device_path]"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_2fffbc67","line":187,"range":{"start_line":187,"start_character":12,"end_line":187,"end_character":34},"updated":"2017-08-15 18:31:58.000000000","message":"Same as above.","commit_id":"6eeefab50de768495085fde36c04c435a28d1af6"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"9b4d8e4022dcf4409247c0d7d20e025d576d1348","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            \"%(conn_nqn)s with device_path %(device_path)s\","},{"line_number":185,"context_line":"            {\u0027conn_nqn\u0027: conn_nqn, \u0027device_path\u0027: device_path})"},{"line_number":186,"context_line":"        cmd \u003d ["},{"line_number":187,"context_line":"            \u0027/usr/local/sbin/nvme\u0027,"},{"line_number":188,"context_line":"            \u0027disconnect\u0027,"},{"line_number":189,"context_line":"            \u0027-d\u0027,"},{"line_number":190,"context_line":"            device_path]"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f436f4f_d5088c2e","line":187,"range":{"start_line":187,"start_character":12,"end_line":187,"end_character":34},"in_reply_to":"9f436f4f_2fffbc67","updated":"2017-11-01 08:27:47.000000000","message":"Done","commit_id":"6eeefab50de768495085fde36c04c435a28d1af6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d1f91ed862ad1dde7275177aae5123ab47d80b78","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            raise"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        import time"},{"line_number":148,"context_line":"        time.sleep(4)"},{"line_number":149,"context_line":"        all_nvme_devices \u003d self._get_nvme_devices()"},{"line_number":150,"context_line":"        path \u003d set(all_nvme_devices) - set(current_nvme_devices)"},{"line_number":151,"context_line":"        path \u003d list(path)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_7a03d310","line":148,"range":{"start_line":148,"start_character":13,"end_line":148,"end_character":18},"updated":"2017-10-30 18:08:08.000000000","message":"Instead of having a sleep it would be better to do a retry loop similar to how the iscsi connector works:\n\nhttps://github.com/openstack/os-brick/blob/master/os_brick/initiator/connectors/iscsi.py#L617\n\nThis could prevent unnecessary delays. Or on heavily loaded systems, it could give it more time to process device arrival events.","commit_id":"c07f3b126a71f465af897fe8f9b2d9f37266e799"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"380cd518708181fdca57a925a414db4fbeca4a1e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            raise"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        import time"},{"line_number":148,"context_line":"        time.sleep(4)"},{"line_number":149,"context_line":"        all_nvme_devices \u003d self._get_nvme_devices()"},{"line_number":150,"context_line":"        path \u003d set(all_nvme_devices) - set(current_nvme_devices)"},{"line_number":151,"context_line":"        path \u003d list(path)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_42fed338","line":148,"range":{"start_line":148,"start_character":13,"end_line":148,"end_character":18},"in_reply_to":"3f4b6375_7a03d310","updated":"2017-10-31 15:26:09.000000000","message":"Done","commit_id":"c07f3b126a71f465af897fe8f9b2d9f37266e799"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d1f91ed862ad1dde7275177aae5123ab47d80b78","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                      {\u0027path\u0027: path[0]})"},{"line_number":158,"context_line":"            return device_info"},{"line_number":159,"context_line":"        else:"},{"line_number":160,"context_line":"            LOG.error(\"Failed to retrieve available connected NVMe\""},{"line_number":161,"context_line":"                      \"controllers when running nvme list\")"},{"line_number":162,"context_line":"            raise"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_fa70e3de","line":160,"range":{"start_line":160,"start_character":66,"end_line":160,"end_character":67},"updated":"2017-10-30 18:08:08.000000000","message":"Missing trailing space.","commit_id":"c07f3b126a71f465af897fe8f9b2d9f37266e799"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"380cd518708181fdca57a925a414db4fbeca4a1e","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                      {\u0027path\u0027: path[0]})"},{"line_number":158,"context_line":"            return device_info"},{"line_number":159,"context_line":"        else:"},{"line_number":160,"context_line":"            LOG.error(\"Failed to retrieve available connected NVMe\""},{"line_number":161,"context_line":"                      \"controllers when running nvme list\")"},{"line_number":162,"context_line":"            raise"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_22fd173a","line":160,"range":{"start_line":160,"start_character":66,"end_line":160,"end_character":67},"in_reply_to":"3f4b6375_fa70e3de","updated":"2017-10-31 15:26:09.000000000","message":"Done","commit_id":"c07f3b126a71f465af897fe8f9b2d9f37266e799"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"c1f5813bd1f0c6f93db5631a5cc1a2c01643fa2c","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                \"%(conn_nqn)s\", {\u0027conn_nqn\u0027: conn_nqn})"},{"line_number":114,"context_line":"            raise"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        for retry in range(1, self.device_scan_attempts+1):"},{"line_number":117,"context_line":"            all_nvme_devices \u003d self._get_nvme_devices()"},{"line_number":118,"context_line":"            path \u003d set(all_nvme_devices) - set(current_nvme_devices)"},{"line_number":119,"context_line":"            if path:"}],"source_content_type":"text/x-python","patch_set":24,"id":"1f485f77_e961483b","line":116,"range":{"start_line":116,"start_character":30,"end_line":116,"end_character":57},"updated":"2017-11-12 16:35:35.000000000","message":"missing whitespace around arithmetic operator","commit_id":"992f65453697e07989d7d2dff3eb896b6b692f80"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"191de367ffd5f9c1cc608ded68f28750219e065e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                \"%(conn_nqn)s\", {\u0027conn_nqn\u0027: conn_nqn})"},{"line_number":114,"context_line":"            raise"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        for retry in range(1, self.device_scan_attempts+1):"},{"line_number":117,"context_line":"            all_nvme_devices \u003d self._get_nvme_devices()"},{"line_number":118,"context_line":"            path \u003d set(all_nvme_devices) - set(current_nvme_devices)"},{"line_number":119,"context_line":"            if path:"}],"source_content_type":"text/x-python","patch_set":24,"id":"1f485f77_3cb9aee8","line":116,"range":{"start_line":116,"start_character":30,"end_line":116,"end_character":57},"in_reply_to":"1f485f77_e961483b","updated":"2017-11-14 10:05:21.000000000","message":"Done","commit_id":"992f65453697e07989d7d2dff3eb896b6b692f80"}],"os_brick/initiator/connectors/nvmeadm.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"282ccfa387d5713634eed3d3c521a82a4eaf94ec","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from os_brick import utils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_concurrency import processutils as putils"},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import re"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_187da27e","line":19,"updated":"2017-07-26 18:36:45.000000000","message":"Imports here should be ordered per these guidelines:\n\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#imports","commit_id":"46e92d421ebed8ed6aaf76bebdc57e02811c8ecf"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"bcec066bbd44fb3eacb651c0f26be2503eeba9fd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from os_brick import utils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_concurrency import processutils as putils"},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import re"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df3967d1_b9a051a7","line":19,"in_reply_to":"ff346bd7_187da27e","updated":"2017-07-31 07:39:21.000000000","message":"Done","commit_id":"46e92d421ebed8ed6aaf76bebdc57e02811c8ecf"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e45345e6b5f4eb9867b611ba9dddcbb1921b2b1b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                \u0027Failed to list available NVMe connected controllers.\u0027)"},{"line_number":96,"context_line":"            raise"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    # TODO(e0ne): add lock"},{"line_number":99,"context_line":"    @utils.trace"},{"line_number":100,"context_line":"    def connect_volume(self, connection_properties):"},{"line_number":101,"context_line":"        \"\"\"Discover and attach the volume."}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_4cc0102b","line":98,"updated":"2017-07-26 17:07:34.000000000","message":"why is this a TODO?   why not just do it?","commit_id":"46e92d421ebed8ed6aaf76bebdc57e02811c8ecf"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"bcec066bbd44fb3eacb651c0f26be2503eeba9fd","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                \u0027Failed to list available NVMe connected controllers.\u0027)"},{"line_number":96,"context_line":"            raise"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    # TODO(e0ne): add lock"},{"line_number":99,"context_line":"    @utils.trace"},{"line_number":100,"context_line":"    def connect_volume(self, connection_properties):"},{"line_number":101,"context_line":"        \"\"\"Discover and attach the volume."}],"source_content_type":"text/x-python","patch_set":11,"id":"df3967d1_346c6835","line":98,"in_reply_to":"ff346bd7_4cc0102b","updated":"2017-07-31 07:39:21.000000000","message":"Done","commit_id":"46e92d421ebed8ed6aaf76bebdc57e02811c8ecf"}],"os_brick/tests/initiator/connectors/test_nvme.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"523fe023b694916e024782b78a93918785403c12","unresolved":false,"context_lines":[{"line_number":29,"context_line":"rdma_prtype: not specified"},{"line_number":30,"context_line":"rdma_qptype: connected"},{"line_number":31,"context_line":"rdma_cms:    rdma-cm"},{"line_number":32,"context_line":"rdma_pkey: 0x0000"},{"line_number":33,"context_line":"\"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"FAKE_NVME_LIST_OUTPUT \u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_3e9727ef","line":32,"range":{"start_line":32,"start_character":10,"end_line":32,"end_character":11},"updated":"2017-08-03 08:31:59.000000000","message":"add 4 spaces :D","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"1b88c05cf4aac24e598ea08792fd7366bc710998","unresolved":false,"context_lines":[{"line_number":29,"context_line":"rdma_prtype: not specified"},{"line_number":30,"context_line":"rdma_qptype: connected"},{"line_number":31,"context_line":"rdma_cms:    rdma-cm"},{"line_number":32,"context_line":"rdma_pkey: 0x0000"},{"line_number":33,"context_line":"\"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"FAKE_NVME_LIST_OUTPUT \u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_7c7d3ee6","line":32,"range":{"start_line":32,"start_character":10,"end_line":32,"end_character":11},"in_reply_to":"df3967d1_3e9727ef","updated":"2017-08-06 13:26:12.000000000","message":"I took the same real output when running nvme discover and it has only 1 space here :)","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"523fe023b694916e024782b78a93918785403c12","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"FAKE_NVME_LIST_OUTPUT \u003d \"\"\""},{"line_number":36,"context_line":"Node             SN                   Model                                  \\"},{"line_number":37,"context_line":"  Namespace Usage                      Format           FW Rev\\n"},{"line_number":38,"context_line":"---------------- -------------------- ---------------------------------------\\"},{"line_number":39,"context_line":"- --------- -------------------------- ---------------- --------\\n"},{"line_number":40,"context_line":"/dev/nvme0n1     67ff9467da6e5567     Linux                                  \\"}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_7ee24fa2","line":37,"range":{"start_line":37,"start_character":62,"end_line":37,"end_character":64},"updated":"2017-08-03 08:31:59.000000000","message":"maybe this is redundant","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"1b88c05cf4aac24e598ea08792fd7366bc710998","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"FAKE_NVME_LIST_OUTPUT \u003d \"\"\""},{"line_number":36,"context_line":"Node             SN                   Model                                  \\"},{"line_number":37,"context_line":"  Namespace Usage                      Format           FW Rev\\n"},{"line_number":38,"context_line":"---------------- -------------------- ---------------------------------------\\"},{"line_number":39,"context_line":"- --------- -------------------------- ---------------- --------\\n"},{"line_number":40,"context_line":"/dev/nvme0n1     67ff9467da6e5567     Linux                                  \\"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_1cdab2e8","line":37,"range":{"start_line":37,"start_character":62,"end_line":37,"end_character":64},"in_reply_to":"df3967d1_7ee24fa2","updated":"2017-08-06 13:26:12.000000000","message":"this is needed to reflect the real output shape  of the nvme list","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"523fe023b694916e024782b78a93918785403c12","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Node             SN                   Model                                  \\"},{"line_number":37,"context_line":"  Namespace Usage                      Format           FW Rev\\n"},{"line_number":38,"context_line":"---------------- -------------------- ---------------------------------------\\"},{"line_number":39,"context_line":"- --------- -------------------------- ---------------- --------\\n"},{"line_number":40,"context_line":"/dev/nvme0n1     67ff9467da6e5567     Linux                                  \\"},{"line_number":41,"context_line":"  10          1.07  GB /   1.07  GB    512   B +  0 B   4.8.0-58\\n"},{"line_number":42,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_1ef7c361","line":39,"range":{"start_line":39,"start_character":64,"end_line":39,"end_character":66},"updated":"2017-08-03 08:31:59.000000000","message":"maybe this is redundant","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"1b88c05cf4aac24e598ea08792fd7366bc710998","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Node             SN                   Model                                  \\"},{"line_number":37,"context_line":"  Namespace Usage                      Format           FW Rev\\n"},{"line_number":38,"context_line":"---------------- -------------------- ---------------------------------------\\"},{"line_number":39,"context_line":"- --------- -------------------------- ---------------- --------\\n"},{"line_number":40,"context_line":"/dev/nvme0n1     67ff9467da6e5567     Linux                                  \\"},{"line_number":41,"context_line":"  10          1.07  GB /   1.07  GB    512   B +  0 B   4.8.0-58\\n"},{"line_number":42,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_fcd6cec3","line":39,"range":{"start_line":39,"start_character":64,"end_line":39,"end_character":66},"in_reply_to":"df3967d1_1ef7c361","updated":"2017-08-06 13:26:12.000000000","message":"ditto","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"523fe023b694916e024782b78a93918785403c12","unresolved":false,"context_lines":[{"line_number":38,"context_line":"---------------- -------------------- ---------------------------------------\\"},{"line_number":39,"context_line":"- --------- -------------------------- ---------------- --------\\n"},{"line_number":40,"context_line":"/dev/nvme0n1     67ff9467da6e5567     Linux                                  \\"},{"line_number":41,"context_line":"  10          1.07  GB /   1.07  GB    512   B +  0 B   4.8.0-58\\n"},{"line_number":42,"context_line":"\"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"df3967d1_7efb6f46","line":41,"range":{"start_line":41,"start_character":64,"end_line":41,"end_character":66},"updated":"2017-08-03 08:31:59.000000000","message":"maybe this is redundant","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":18937,"name":"Rawan Herzallah","email":"rawan.a.herzallah@gmail.com","username":"RawanHerzallah"},"change_message_id":"1b88c05cf4aac24e598ea08792fd7366bc710998","unresolved":false,"context_lines":[{"line_number":38,"context_line":"---------------- -------------------- ---------------------------------------\\"},{"line_number":39,"context_line":"- --------- -------------------------- ---------------- --------\\n"},{"line_number":40,"context_line":"/dev/nvme0n1     67ff9467da6e5567     Linux                                  \\"},{"line_number":41,"context_line":"  10          1.07  GB /   1.07  GB    512   B +  0 B   4.8.0-58\\n"},{"line_number":42,"context_line":"\"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"bf3e73b7_dce30aa4","line":41,"range":{"start_line":41,"start_character":64,"end_line":41,"end_character":66},"in_reply_to":"df3967d1_7efb6f46","updated":"2017-08-06 13:26:12.000000000","message":"ditto","commit_id":"9a175086d8220ba40f7b586accfe4a2ecf1cd929"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d1f91ed862ad1dde7275177aae5123ab47d80b78","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def test_connect_volume("},{"line_number":72,"context_line":"        self,"},{"line_number":73,"context_line":"        mock_execute,"},{"line_number":74,"context_line":"            mock_devices):"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"            connection_properties \u003d {\u0027target_portal\u0027: \u0027portal\u0027,"},{"line_number":77,"context_line":"                                     \u0027target_port\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_dd3ac1cb","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":12},"updated":"2017-10-30 18:08:08.000000000","message":"Extra indentation here, but it looks like all arguments should fit on one line.","commit_id":"c07f3b126a71f465af897fe8f9b2d9f37266e799"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"380cd518708181fdca57a925a414db4fbeca4a1e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def test_connect_volume("},{"line_number":72,"context_line":"        self,"},{"line_number":73,"context_line":"        mock_execute,"},{"line_number":74,"context_line":"            mock_devices):"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"            connection_properties \u003d {\u0027target_portal\u0027: \u0027portal\u0027,"},{"line_number":77,"context_line":"                                     \u0027target_port\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f4b6375_826f2bfb","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":12},"in_reply_to":"3f4b6375_dd3ac1cb","updated":"2017-10-31 15:26:09.000000000","message":"Done","commit_id":"c07f3b126a71f465af897fe8f9b2d9f37266e799"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"92a22565525a590b01e324b3b43748f0484cfa1a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            run_as_root\u003dTrue)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @mock.patch.object(nvme.NVMeConnector, \u0027_get_nvme_devices\u0027)"},{"line_number":99,"context_line":"    @mock.patch.object(nvme.NVMeConnector, \u0027_execute\u0027)"},{"line_number":100,"context_line":"    def test_connect_volume_max_retry(self, mock_execute, mock_devices):"},{"line_number":101,"context_line":"        connection_properties \u003d {\u0027target_portal\u0027: \u0027portal\u0027,"},{"line_number":102,"context_line":"                                 \u0027target_port\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f4b6375_0ee4cc0d","line":99,"updated":"2017-11-08 16:33:40.000000000","message":"Please, mock time.sleep for \u0027conect_volume\u0027 tests","commit_id":"cbb1dbb4e5bf4da2425d17e66b01c2ec03b19c4b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6b6ad926cb7660d5cc77bfa8d780e6398fed3d49","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            run_as_root\u003dTrue)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @mock.patch.object(nvme.NVMeConnector, \u0027_get_nvme_devices\u0027)"},{"line_number":99,"context_line":"    @mock.patch.object(nvme.NVMeConnector, \u0027_execute\u0027)"},{"line_number":100,"context_line":"    def test_connect_volume_max_retry(self, mock_execute, mock_devices):"},{"line_number":101,"context_line":"        connection_properties \u003d {\u0027target_portal\u0027: \u0027portal\u0027,"},{"line_number":102,"context_line":"                                 \u0027target_port\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f4b6375_3a37be50","line":99,"in_reply_to":"3f4b6375_0ee4cc0d","updated":"2017-11-08 21:09:12.000000000","message":"I don\u0027t see this getting hit in the current unit tests. But you are right, this should be covered in case more unit tests are added that would cause that path to be hit.","commit_id":"cbb1dbb4e5bf4da2425d17e66b01c2ec03b19c4b"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"f6af75397321bb49f63ab318433b7ae48a5580e5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from os_brick.initiator import linuxscsi"},{"line_number":20,"context_line":"from os_brick.tests.initiator import test_connector"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"FAKE_NVME_DISCOVER_OUTPUT \u003d \"\"\""},{"line_number":23,"context_line":"Discovery Log Number of Records 1, Generation counter 75"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003dDiscovery Log Entry 0\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":"trtype:  rdma"},{"line_number":26,"context_line":"adrfam:  ipv4"},{"line_number":27,"context_line":"subtype: nvme subsystem"},{"line_number":28,"context_line":"treq:    not specified"},{"line_number":29,"context_line":"portid:  1"},{"line_number":30,"context_line":"trsvcid: 1023"},{"line_number":31,"context_line":"subnqn:  nvme-subsystem-name"},{"line_number":32,"context_line":"traddr:  1.1.1.1"},{"line_number":33,"context_line":"rdma_prtype: not specified"},{"line_number":34,"context_line":"rdma_qptype: connected"},{"line_number":35,"context_line":"rdma_cms:    rdma-cm"},{"line_number":36,"context_line":"rdma_pkey: 0x0000"},{"line_number":37,"context_line":"\"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"FAKE_NVME_LIST_OUTPUT \u003d \"\"\""},{"line_number":40,"context_line":"Node             SN                   Model                                  \\"}],"source_content_type":"text/x-python","patch_set":22,"id":"1f485f77_829acfc2","line":37,"range":{"start_line":22,"start_character":0,"end_line":37,"end_character":3},"updated":"2017-11-09 16:05:07.000000000","message":"remove this. It is not in use","commit_id":"044fdf3df22d4b5d58e21eb91879976812c95eac"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"d30f74e2936ff572388a028d4da798d6e5110c00","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from os_brick.initiator import linuxscsi"},{"line_number":20,"context_line":"from os_brick.tests.initiator import test_connector"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"FAKE_NVME_DISCOVER_OUTPUT \u003d \"\"\""},{"line_number":23,"context_line":"Discovery Log Number of Records 1, Generation counter 75"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003dDiscovery Log Entry 0\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":"trtype:  rdma"},{"line_number":26,"context_line":"adrfam:  ipv4"},{"line_number":27,"context_line":"subtype: nvme subsystem"},{"line_number":28,"context_line":"treq:    not specified"},{"line_number":29,"context_line":"portid:  1"},{"line_number":30,"context_line":"trsvcid: 1023"},{"line_number":31,"context_line":"subnqn:  nvme-subsystem-name"},{"line_number":32,"context_line":"traddr:  1.1.1.1"},{"line_number":33,"context_line":"rdma_prtype: not specified"},{"line_number":34,"context_line":"rdma_qptype: connected"},{"line_number":35,"context_line":"rdma_cms:    rdma-cm"},{"line_number":36,"context_line":"rdma_pkey: 0x0000"},{"line_number":37,"context_line":"\"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"FAKE_NVME_LIST_OUTPUT \u003d \"\"\""},{"line_number":40,"context_line":"Node             SN                   Model                                  \\"}],"source_content_type":"text/x-python","patch_set":22,"id":"1f485f77_138e1378","line":37,"range":{"start_line":22,"start_character":0,"end_line":37,"end_character":3},"in_reply_to":"1f485f77_829acfc2","updated":"2017-11-12 08:06:38.000000000","message":"Done","commit_id":"044fdf3df22d4b5d58e21eb91879976812c95eac"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"5d5b890ef1bbc32e203165c4589c70e3f4510ab4","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @mock.patch.object(nvme.NVMeConnector, \u0027_get_nvme_devices\u0027)"},{"line_number":98,"context_line":"    @mock.patch.object(nvme.NVMeConnector, \u0027_execute\u0027)"},{"line_number":99,"context_line":"    @mock.patch(\u0027time.sleep\u0027, return_value\u003dNone)"},{"line_number":100,"context_line":"    def test_connect_volume_max_retry("},{"line_number":101,"context_line":"            self, mock_sleep, mock_execute, mock_devices):"},{"line_number":102,"context_line":"        connection_properties \u003d {\u0027target_portal\u0027: \u0027portal\u0027,"}],"source_content_type":"text/x-python","patch_set":25,"id":"1f485f77_ab02f209","line":99,"updated":"2017-11-14 14:27:40.000000000","message":"don\u0027t need return_value for time.sleep mocks","commit_id":"b3a59119d08d253982135e00698cc1668f7b17ba"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"85e4d715ff8cedbe93f116a63bab8bc6764d4eec","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @mock.patch.object(nvme.NVMeConnector, \u0027_get_nvme_devices\u0027)"},{"line_number":98,"context_line":"    @mock.patch.object(nvme.NVMeConnector, \u0027_execute\u0027)"},{"line_number":99,"context_line":"    @mock.patch(\u0027time.sleep\u0027, return_value\u003dNone)"},{"line_number":100,"context_line":"    def test_connect_volume_max_retry("},{"line_number":101,"context_line":"            self, mock_sleep, mock_execute, mock_devices):"},{"line_number":102,"context_line":"        connection_properties \u003d {\u0027target_portal\u0027: \u0027portal\u0027,"}],"source_content_type":"text/x-python","patch_set":25,"id":"1f485f77_cfdd3971","line":99,"in_reply_to":"1f485f77_ab02f209","updated":"2017-11-14 14:36:12.000000000","message":"Done","commit_id":"b3a59119d08d253982135e00698cc1668f7b17ba"}]}
