)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fae0c98f2cc626ae79aca47b6642271f4738baf7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix iSCSI volume attachment over RDMA transport"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Recent changes assumed \u0027tcp:\u0027 prefix to iscsi sessions,"},{"line_number":10,"context_line":"and that broke the session status discovery for RDMA"},{"line_number":11,"context_line":"connections. in this change we add the \u0027iser:\u0027 transport"},{"line_number":12,"context_line":"prefix to the os-brick functions, to fix volumes attach"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f287b81_fd3a53cb","line":9,"updated":"2017-08-22 11:13:38.000000000","message":"This does not come from recent changes, it\u0027s been like that for a while [1], the problem is that now we rely more heavily on the session information for a successful connection/disconnection.\n\n\n[1] https://github.com/openstack/os-brick/blob/7fc3bf912af87622aa68e2d63530fd5d2a930a00/os_brick/initiator/connectors/iscsi.py#L735","commit_id":"62eb7f68ff6fe39404f25bb876ae2f5a344b6f7c"}],"os_brick/initiator/connectors/iscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1f858453253040cd2e79586b5648e3b38832fb73","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"            sessions \u003d self._get_iscsi_sessions_full()"},{"line_number":1022,"context_line":"            for s in sessions:"},{"line_number":1023,"context_line":"                # Found our session, return session_id"},{"line_number":1024,"context_line":"                if (\u0027tcp:\u0027 \u003d\u003d s[0] or \u0027iser:\u0027 \u003d\u003d s[0]) and \\"},{"line_number":1025,"context_line":"                        portal \u003d\u003d s[2] and s[4] \u003d\u003d target_iqn:"},{"line_number":1026,"context_line":"                    return s[1], manual_scan"},{"line_number":1027,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_90a14efb","line":1024,"range":{"start_line":1024,"start_character":59,"end_line":1024,"end_character":60},"updated":"2017-08-14 14:53:07.000000000","message":"Please avoid using \\ for multiple lines. Wrap in () would be better.","commit_id":"9971ee7311baa13db35d58fd542593a0ed58146a"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"f2f04922797d1b0a6a18a1d3f856224d00160b6c","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"            sessions \u003d self._get_iscsi_sessions_full()"},{"line_number":1022,"context_line":"            for s in sessions:"},{"line_number":1023,"context_line":"                # Found our session, return session_id"},{"line_number":1024,"context_line":"                if (\u0027tcp:\u0027 \u003d\u003d s[0] or \u0027iser:\u0027 \u003d\u003d s[0]) and \\"},{"line_number":1025,"context_line":"                        portal \u003d\u003d s[2] and s[4] \u003d\u003d target_iqn:"},{"line_number":1026,"context_line":"                    return s[1], manual_scan"},{"line_number":1027,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_900caea5","line":1024,"range":{"start_line":1024,"start_character":59,"end_line":1024,"end_character":60},"in_reply_to":"9f436f4f_90a14efb","updated":"2017-08-14 15:07:55.000000000","message":"Done","commit_id":"9971ee7311baa13db35d58fd542593a0ed58146a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fae0c98f2cc626ae79aca47b6642271f4738baf7","unresolved":false,"context_lines":[{"line_number":782,"context_line":"        nodes \u003d self._get_iscsi_nodes()"},{"line_number":783,"context_line":"        sessions \u003d self._get_iscsi_sessions_full()"},{"line_number":784,"context_line":"        # Use (portal, iqn) to map the session value"},{"line_number":785,"context_line":"        sessions_map \u003d {(s[2], s[4]): s[1] for s in sessions if"},{"line_number":786,"context_line":"                        (s[0] \u003d\u003d \u0027tcp:\u0027 or s[0] \u003d\u003d \u0027iser:\u0027)}"},{"line_number":787,"context_line":"        # device_map will keep a tuple with devices from the connection and"},{"line_number":788,"context_line":"        # others that don\u0027t belong to this connection\" (belong, others)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_e2c74e45","line":785,"range":{"start_line":785,"start_character":61,"end_line":785,"end_character":63},"updated":"2017-08-22 11:13:38.000000000","message":"nit: move the if to the next line","commit_id":"62eb7f68ff6fe39404f25bb876ae2f5a344b6f7c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fae0c98f2cc626ae79aca47b6642271f4738baf7","unresolved":false,"context_lines":[{"line_number":783,"context_line":"        sessions \u003d self._get_iscsi_sessions_full()"},{"line_number":784,"context_line":"        # Use (portal, iqn) to map the session value"},{"line_number":785,"context_line":"        sessions_map \u003d {(s[2], s[4]): s[1] for s in sessions if"},{"line_number":786,"context_line":"                        (s[0] \u003d\u003d \u0027tcp:\u0027 or s[0] \u003d\u003d \u0027iser:\u0027)}"},{"line_number":787,"context_line":"        # device_map will keep a tuple with devices from the connection and"},{"line_number":788,"context_line":"        # others that don\u0027t belong to this connection\" (belong, others)"},{"line_number":789,"context_line":"        device_map \u003d collections.defaultdict(lambda: (set(), set()))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_c247b2bc","line":786,"range":{"start_line":786,"start_character":24,"end_line":786,"end_character":59},"updated":"2017-08-22 11:13:38.000000000","message":"-0.5: We should try to consolidate this and the change in L1024 with a common solution, with either:\n\nA class attribute:\n\n    VALID_SESSIONS \u003d (\u0027tcp:\u0027, \u0027iser:\u0027)\n\n    [ ... ]\n\n        sessions_map \u003d {(s[2], s[4]): s[1] for s in sessions\n                        if s[0] in self.VALID_SESSIONS}\n\nOr a method:\n\n    @staticmethod\n    def is_valid_session(session_type):\n        return session_type in (\u0027tcp:\u0027, \u0027iser:\u0027)\n\n    [ ... ]\n\n        sessions_map \u003d {(s[2], s[4]): s[1] for s in sessions\n                        if self.is_vali-session(s[0])}","commit_id":"62eb7f68ff6fe39404f25bb876ae2f5a344b6f7c"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"67e77011bd17a6e5b6be3944660fddbbc1b3d67d","unresolved":false,"context_lines":[{"line_number":783,"context_line":"        sessions \u003d self._get_iscsi_sessions_full()"},{"line_number":784,"context_line":"        # Use (portal, iqn) to map the session value"},{"line_number":785,"context_line":"        sessions_map \u003d {(s[2], s[4]): s[1] for s in sessions if"},{"line_number":786,"context_line":"                        (s[0] \u003d\u003d \u0027tcp:\u0027 or s[0] \u003d\u003d \u0027iser:\u0027)}"},{"line_number":787,"context_line":"        # device_map will keep a tuple with devices from the connection and"},{"line_number":788,"context_line":"        # others that don\u0027t belong to this connection\" (belong, others)"},{"line_number":789,"context_line":"        device_map \u003d collections.defaultdict(lambda: (set(), set()))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_723b1438","line":786,"range":{"start_line":786,"start_character":24,"end_line":786,"end_character":59},"in_reply_to":"7f287b81_c247b2bc","updated":"2017-08-23 08:06:53.000000000","message":"Done","commit_id":"62eb7f68ff6fe39404f25bb876ae2f5a344b6f7c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fae0c98f2cc626ae79aca47b6642271f4738baf7","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"            sessions \u003d self._get_iscsi_sessions_full()"},{"line_number":1022,"context_line":"            for s in sessions:"},{"line_number":1023,"context_line":"                # Found our session, return session_id"},{"line_number":1024,"context_line":"                if ((\u0027tcp:\u0027 \u003d\u003d s[0] or \u0027iser:\u0027 \u003d\u003d s[0]) and"},{"line_number":1025,"context_line":"                        portal \u003d\u003d s[2] and s[4] \u003d\u003d target_iqn):"},{"line_number":1026,"context_line":"                    return s[1], manual_scan"},{"line_number":1027,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_2212f6b2","line":1024,"updated":"2017-08-22 11:13:38.000000000","message":"ditto","commit_id":"62eb7f68ff6fe39404f25bb876ae2f5a344b6f7c"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"67e77011bd17a6e5b6be3944660fddbbc1b3d67d","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"            sessions \u003d self._get_iscsi_sessions_full()"},{"line_number":1022,"context_line":"            for s in sessions:"},{"line_number":1023,"context_line":"                # Found our session, return session_id"},{"line_number":1024,"context_line":"                if ((\u0027tcp:\u0027 \u003d\u003d s[0] or \u0027iser:\u0027 \u003d\u003d s[0]) and"},{"line_number":1025,"context_line":"                        portal \u003d\u003d s[2] and s[4] \u003d\u003d target_iqn):"},{"line_number":1026,"context_line":"                    return s[1], manual_scan"},{"line_number":1027,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_9227a013","line":1024,"in_reply_to":"7f287b81_2212f6b2","updated":"2017-08-23 08:06:53.000000000","message":"Done","commit_id":"62eb7f68ff6fe39404f25bb876ae2f5a344b6f7c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4a1c17219703424a747030aa7beace524531a44a","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    supported_transports \u003d [\u0027be2iscsi\u0027, \u0027bnx2i\u0027, \u0027cxgb3i\u0027, \u0027default\u0027,"},{"line_number":45,"context_line":"                            \u0027cxgb4i\u0027, \u0027qla4xxx\u0027, \u0027ocs\u0027, \u0027iser\u0027]"},{"line_number":46,"context_line":"    VALID_SESSIONS_PREFIX \u003d (\u0027tcp:\u0027, \u0027iser:\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def __init__(self, root_helper, driver\u003dNone,"},{"line_number":49,"context_line":"                 execute\u003dNone, use_multipath\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_75c2de87","line":46,"range":{"start_line":46,"start_character":19,"end_line":46,"end_character":25},"updated":"2017-08-23 08:20:37.000000000","message":"Not really a prefix, but the protocol","commit_id":"af2f60f9bab271ba26d4d1e8f15e0d1ce7f1ccec"}],"os_brick/tests/initiator/connectors/test_iser.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fae0c98f2cc626ae79aca47b6642271f4738baf7","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @mock.patch.object(iscsi.ISCSIConnector, \u0027_get_iscsi_sessions_full\u0027)"},{"line_number":62,"context_line":"    @mock.patch.object(iscsi.ISCSIConnector, \u0027_execute\u0027)"},{"line_number":63,"context_line":"    def test_connect_to_iscsi_portal_(self, exec_mock, get_sessions_mock):"},{"line_number":64,"context_line":"        \"\"\"connect to portal while session already established\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # connected sessions"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_426ce207","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":37},"updated":"2017-08-22 11:13:38.000000000","message":"-1: Remove ending underscore","commit_id":"62eb7f68ff6fe39404f25bb876ae2f5a344b6f7c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fae0c98f2cc626ae79aca47b6642271f4738baf7","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @mock.patch.object(iscsi.ISCSIConnector, \u0027_get_iscsi_sessions_full\u0027)"},{"line_number":62,"context_line":"    @mock.patch.object(iscsi.ISCSIConnector, \u0027_execute\u0027)"},{"line_number":63,"context_line":"    def test_connect_to_iscsi_portal_(self, exec_mock, get_sessions_mock):"},{"line_number":64,"context_line":"        \"\"\"connect to portal while session already established\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # connected sessions"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_62991e1e","line":63,"range":{"start_line":63,"start_character":55,"end_line":63,"end_character":72},"updated":"2017-08-22 11:13:38.000000000","message":"?: Why does it have a different name here than on L40?","commit_id":"62eb7f68ff6fe39404f25bb876ae2f5a344b6f7c"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"67e77011bd17a6e5b6be3944660fddbbc1b3d67d","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @mock.patch.object(iscsi.ISCSIConnector, \u0027_get_iscsi_sessions_full\u0027)"},{"line_number":62,"context_line":"    @mock.patch.object(iscsi.ISCSIConnector, \u0027_execute\u0027)"},{"line_number":63,"context_line":"    def test_connect_to_iscsi_portal_(self, exec_mock, get_sessions_mock):"},{"line_number":64,"context_line":"        \"\"\"connect to portal while session already established\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # connected sessions"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_b2605c34","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":37},"in_reply_to":"7f287b81_426ce207","updated":"2017-08-23 08:06:53.000000000","message":"Done","commit_id":"62eb7f68ff6fe39404f25bb876ae2f5a344b6f7c"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"67e77011bd17a6e5b6be3944660fddbbc1b3d67d","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @mock.patch.object(iscsi.ISCSIConnector, \u0027_get_iscsi_sessions_full\u0027)"},{"line_number":62,"context_line":"    @mock.patch.object(iscsi.ISCSIConnector, \u0027_execute\u0027)"},{"line_number":63,"context_line":"    def test_connect_to_iscsi_portal_(self, exec_mock, get_sessions_mock):"},{"line_number":64,"context_line":"        \"\"\"connect to portal while session already established\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # connected sessions"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_7252f469","line":63,"range":{"start_line":63,"start_character":55,"end_line":63,"end_character":72},"in_reply_to":"7f287b81_62991e1e","updated":"2017-08-23 08:06:53.000000000","message":"Done","commit_id":"62eb7f68ff6fe39404f25bb876ae2f5a344b6f7c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fae0c98f2cc626ae79aca47b6642271f4738baf7","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    @mock.patch.object(iscsi.ISCSIConnector, \u0027_get_iscsi_sessions_full\u0027)"},{"line_number":62,"context_line":"    @mock.patch.object(iscsi.ISCSIConnector, \u0027_execute\u0027)"},{"line_number":63,"context_line":"    def test_connect_to_iscsi_portal_(self, exec_mock, get_sessions_mock):"},{"line_number":64,"context_line":"        \"\"\"connect to portal while session already established\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # connected sessions"},{"line_number":67,"context_line":"        get_sessions_mock.side_effect \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_c2fc5240","line":64,"range":{"start_line":64,"start_character":11,"end_line":64,"end_character":12},"updated":"2017-08-22 11:13:38.000000000","message":"nit: Connect","commit_id":"62eb7f68ff6fe39404f25bb876ae2f5a344b6f7c"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"67e77011bd17a6e5b6be3944660fddbbc1b3d67d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    @mock.patch.object(iscsi.ISCSIConnector, \u0027_get_iscsi_sessions_full\u0027)"},{"line_number":62,"context_line":"    @mock.patch.object(iscsi.ISCSIConnector, \u0027_execute\u0027)"},{"line_number":63,"context_line":"    def test_connect_to_iscsi_portal_(self, exec_mock, get_sessions_mock):"},{"line_number":64,"context_line":"        \"\"\"connect to portal while session already established\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # connected sessions"},{"line_number":67,"context_line":"        get_sessions_mock.side_effect \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_12c73015","line":64,"range":{"start_line":64,"start_character":11,"end_line":64,"end_character":12},"in_reply_to":"7f287b81_c2fc5240","updated":"2017-08-23 08:06:53.000000000","message":"Done","commit_id":"62eb7f68ff6fe39404f25bb876ae2f5a344b6f7c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fae0c98f2cc626ae79aca47b6642271f4738baf7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            [(\u0027iser:\u0027, \u0027session_iser\u0027, \u0027ip:port\u0027, \u00271\u0027, \u0027target_1\u0027)]"},{"line_number":69,"context_line":"        ]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # with mock.patch.object(self.connector, \u0027_execute\u0027) as exec_mock:"},{"line_number":72,"context_line":"        exec_mock.side_effect \u003d [(\u0027\u0027, None), (\u0027\u0027, None), (\u0027\u0027, None)]"},{"line_number":73,"context_line":"        res \u003d self.connector._connect_to_iscsi_portal(self.connection_data)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_c291f2f3","line":71,"updated":"2017-08-22 11:13:38.000000000","message":"-1: You forgot to remove this comment","commit_id":"62eb7f68ff6fe39404f25bb876ae2f5a344b6f7c"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"67e77011bd17a6e5b6be3944660fddbbc1b3d67d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            [(\u0027iser:\u0027, \u0027session_iser\u0027, \u0027ip:port\u0027, \u00271\u0027, \u0027target_1\u0027)]"},{"line_number":69,"context_line":"        ]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # with mock.patch.object(self.connector, \u0027_execute\u0027) as exec_mock:"},{"line_number":72,"context_line":"        exec_mock.side_effect \u003d [(\u0027\u0027, None), (\u0027\u0027, None), (\u0027\u0027, None)]"},{"line_number":73,"context_line":"        res \u003d self.connector._connect_to_iscsi_portal(self.connection_data)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_b2d5fcbb","line":71,"in_reply_to":"7f287b81_c291f2f3","updated":"2017-08-23 08:06:53.000000000","message":"Done","commit_id":"62eb7f68ff6fe39404f25bb876ae2f5a344b6f7c"}]}
