)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"5bd90f2a69f465ad8d1d5839fc37433b1a74fb06","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"FC PPC64 device discovery issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We found the following issues during FC pp64 device discovery"},{"line_number":10,"context_line":"1. When multipath is enabled get_host_devices returns duplicate"},{"line_number":11,"context_line":"path entries due to which remove fails."},{"line_number":12,"context_line":"2. WWPN grep should be case insensitive"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_643bf1d0","line":9,"updated":"2017-09-06 16:24:12.000000000","message":"Can we rephrase this to something like:\n\nChange ppc64 device discovery to remove duplicate devices in _get_host_devices().\n\nChange _get_hba_channel_scsi_target() to find devices regardless of the case of WWPNs","commit_id":"ee039a9349553fb7c5df49ea54d371b678b042f4"}],"os_brick/initiator/connectors/fibre_channel_ppc64.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"17f4836bb92952e4042b4f731756c5f8e336ed29","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                target_wwn,"},{"line_number":52,"context_line":"                self._linuxscsi.process_lun_id(lun))"},{"line_number":53,"context_line":"            host_devices.append(host_device)"},{"line_number":54,"context_line":"        return set(host_devices)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _get_possible_volume_paths(self, connection_properties, hbas):"},{"line_number":57,"context_line":"        ports \u003d connection_properties[\u0027target_wwn\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_53e1e1fb","line":54,"updated":"2017-09-06 15:00:05.000000000","message":"The FibreChannelConnector _get_host_devices() returns a list and not a set, this should too.","commit_id":"ee039a9349553fb7c5df49ea54d371b678b042f4"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"5d8b847cc32f4eea7a66fecdb14ed52515149515","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                target_wwn,"},{"line_number":52,"context_line":"                self._linuxscsi.process_lun_id(lun))"},{"line_number":53,"context_line":"            host_devices.add(host_device)"},{"line_number":54,"context_line":"        return list(host_devices)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _get_possible_volume_paths(self, connection_properties, hbas):"},{"line_number":57,"context_line":"        ports \u003d connection_properties[\u0027target_wwn\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_0432ea10","line":54,"updated":"2017-09-06 18:28:23.000000000","message":"If you remove the set then you will return duplicates\nI think you want:\n\nreturn list(set(host_devices))","commit_id":"df5c746239034634845deb55dc4a2a54ae26c76a"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"86f77f8a7ef6deae562824a7fa3f4d8639dad899","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                target_wwn,"},{"line_number":52,"context_line":"                self._linuxscsi.process_lun_id(lun))"},{"line_number":53,"context_line":"            host_devices.add(host_device)"},{"line_number":54,"context_line":"        return list(host_devices)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _get_possible_volume_paths(self, connection_properties, hbas):"},{"line_number":57,"context_line":"        ports \u003d connection_properties[\u0027target_wwn\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_87981cc0","line":54,"in_reply_to":"7f287b81_0432ea10","updated":"2017-09-06 18:34:12.000000000","message":"host_devices is initialized as a set() at line 48\nso there will be no duplicates.\nI added the UT for this as well waiting for the jenkins result","commit_id":"df5c746239034634845deb55dc4a2a54ae26c76a"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"26340f9557ebc565c23ca1dbbdec8e2189541e4d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                target_wwn,"},{"line_number":52,"context_line":"                self._linuxscsi.process_lun_id(lun))"},{"line_number":53,"context_line":"            host_devices.add(host_device)"},{"line_number":54,"context_line":"        return list(host_devices)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _get_possible_volume_paths(self, connection_properties, hbas):"},{"line_number":57,"context_line":"        ports \u003d connection_properties[\u0027target_wwn\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_e70a40d0","line":54,"in_reply_to":"7f287b81_87981cc0","updated":"2017-09-06 18:40:18.000000000","message":"Your right I missed it","commit_id":"df5c746239034634845deb55dc4a2a54ae26c76a"}],"os_brick/tests/initiator/connectors/test_fibre_channel_ppc64.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c306532df3bc49e5d96c00aa40c7d0ba2bd9f00e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        device_path \u003d \"/dev/disk/by-path/fc-0x5005076802332ade-lun-2\""},{"line_number":41,"context_line":"        self.assertEqual(devices[0], device_path)"},{"line_number":42,"context_line":"        device_path \u003d \"/dev/disk/by-path/fc-0x5005076802232ade-lun-2\""},{"line_number":43,"context_line":"        self.assertEqual(devices[1], device_path)"},{"line_number":44,"context_line":"        # test duplicates"},{"line_number":45,"context_line":"        possible_devs \u003d [(3, \"0x5005076802232ade\"),"},{"line_number":46,"context_line":"                         (3, \"0x5005076802232ade\"), ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_67253009","line":43,"updated":"2017-09-06 18:50:50.000000000","message":"This test is no good because it assumes that a set will be converted to a list in a particular order, which is not true.\n\nIt fails py35 tests on my system.\n\nYou need to assert that both paths are in devices[], but you don\u0027t know which one is at [0] and which is at [1].  Or you can sort the paths in _get_host_devices.","commit_id":"e055591d5831f4b13a5fe3deba1564fe6cbd5577"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"828592d7e4ba50a34410578e26ea03e23befe949","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        device_path \u003d \"/dev/disk/by-path/fc-0x5005076802332ade-lun-2\""},{"line_number":41,"context_line":"        self.assertEqual(devices[0], device_path)"},{"line_number":42,"context_line":"        device_path \u003d \"/dev/disk/by-path/fc-0x5005076802232ade-lun-2\""},{"line_number":43,"context_line":"        self.assertEqual(devices[1], device_path)"},{"line_number":44,"context_line":"        # test duplicates"},{"line_number":45,"context_line":"        possible_devs \u003d [(3, \"0x5005076802232ade\"),"},{"line_number":46,"context_line":"                         (3, \"0x5005076802232ade\"), ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_7bc25d36","line":43,"in_reply_to":"7f287b81_67253009","updated":"2017-09-07 07:59:31.000000000","message":"Thanks for the comment, I am looking into the py35 error.\n\nIdea here is not to get the sorted list, but just to find if the device exist in the list, I agree comparing with the exact index is not proper, I will modify to use ANY to make sure device exist.","commit_id":"e055591d5831f4b13a5fe3deba1564fe6cbd5577"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ef4aee2df444624398aac5aab2a84c2f16bf293c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        devices \u003d self.connector._get_host_devices(possible_devs, lun)"},{"line_number":39,"context_line":"        self.assertEqual(2, len(devices))"},{"line_number":40,"context_line":"        device_path \u003d \"/dev/disk/by-path/fc-0x5005076802332ade-lun-2\""},{"line_number":41,"context_line":"        self.assertTrue(any(x \u003d\u003d device_path for x in devices))"},{"line_number":42,"context_line":"        device_path \u003d \"/dev/disk/by-path/fc-0x5005076802232ade-lun-2\""},{"line_number":43,"context_line":"        self.assertTrue(any(x \u003d\u003d device_path for x in devices))"},{"line_number":44,"context_line":"        # test duplicates"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_7605c40f","line":41,"updated":"2017-09-07 16:16:10.000000000","message":"This can just be assertIn(device_path, devices)","commit_id":"e52e84e86869400d5607b7df9b3d1e567d40e86a"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"8c2e8a1fbccd1925896e8461c8cc38d53f120621","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        devices \u003d self.connector._get_host_devices(possible_devs, lun)"},{"line_number":39,"context_line":"        self.assertEqual(2, len(devices))"},{"line_number":40,"context_line":"        device_path \u003d \"/dev/disk/by-path/fc-0x5005076802332ade-lun-2\""},{"line_number":41,"context_line":"        self.assertTrue(any(x \u003d\u003d device_path for x in devices))"},{"line_number":42,"context_line":"        device_path \u003d \"/dev/disk/by-path/fc-0x5005076802232ade-lun-2\""},{"line_number":43,"context_line":"        self.assertTrue(any(x \u003d\u003d device_path for x in devices))"},{"line_number":44,"context_line":"        # test duplicates"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_bcb448d2","line":41,"in_reply_to":"7f287b81_7605c40f","updated":"2017-09-14 17:58:25.000000000","message":"Done","commit_id":"e52e84e86869400d5607b7df9b3d1e567d40e86a"}]}
