)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"02bc6f3a554c4fa99e9deea64c477313616c2fc1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"transimitted via storage NIC. This need to define an iface and set the"},{"line_number":12,"context_line":"iface.net_ifacename value to the storage interface name."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Unfortunately, the current iscsi connector does not support to use a"},{"line_number":15,"context_line":"custom iface. The _validate_iface_transport will change it to default."},{"line_number":16,"context_line":"After add tcp to the supported_transports, it is possible to use a"},{"line_number":17,"context_line":"custom iface."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_9da6d0c0","line":14,"updated":"2017-10-26 21:19:02.000000000","message":"Can you explain a little how adding tcp as a transport allows you to control which interface is used?","commit_id":"b1c2c2cc10b4d35aa7bf8c8770bf8a7fe139fa41"},{"author":{"_account_id":21334,"name":"Jack Lu","email":"renxlu@cisco.com","username":"renxlu"},"change_message_id":"f133c4983a9873ad9824d5e58060e22a9db76a50","unresolved":false,"context_lines":[{"line_number":11,"context_line":"transimitted via storage NIC. This need to define an iface and set the"},{"line_number":12,"context_line":"iface.net_ifacename value to the storage interface name."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Unfortunately, the current iscsi connector does not support to use a"},{"line_number":15,"context_line":"custom iface. The _validate_iface_transport will change it to default."},{"line_number":16,"context_line":"After add tcp to the supported_transports, it is possible to use a"},{"line_number":17,"context_line":"custom iface."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_67b6d68c","line":14,"in_reply_to":"3f4b6375_9da6d0c0","updated":"2017-10-27 09:05:22.000000000","message":"Has updated, thanks for your time.","commit_id":"b1c2c2cc10b4d35aa7bf8c8770bf8a7fe139fa41"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"28488d35191afa9756500bd2da7317116fbf7735","unresolved":false,"context_lines":[{"line_number":39,"context_line":"transport."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Change-Id: I85a62cb6e7f8d8982e97e792d647d38ce5641060"},{"line_number":42,"context_line":"Closes-Bug:#1722432"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff82abbf_cdd1fc59","line":42,"updated":"2017-11-20 21:56:18.000000000","message":"Should probably have a \"fixes\" release note with this change to mention that you can now use \"tcp\" with the [libvirt]/iscsi_iface option in nova - and a corresponding release note in nova when nova requires a minimum version of os-brick with this change.","commit_id":"0e7d8efede2829da520a630f7bb3c0395ae8aad7"},{"author":{"_account_id":21334,"name":"Jack Lu","email":"renxlu@cisco.com","username":"renxlu"},"change_message_id":"9a9dcb746a27822d0cd339764f16fd82b70a904b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"transport."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Change-Id: I85a62cb6e7f8d8982e97e792d647d38ce5641060"},{"line_number":42,"context_line":"Closes-Bug:#1722432"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff82abbf_0d34c4dd","line":42,"in_reply_to":"ff82abbf_cdd1fc59","updated":"2017-12-01 02:34:02.000000000","message":"Thanks for your review, Matt! I have updated the nova docs, here is the change https://review.openstack.org/#/c/524443/","commit_id":"0e7d8efede2829da520a630f7bb3c0395ae8aad7"}],"os_brick/initiator/connectors/iscsi.py":[{"author":{"_account_id":21330,"name":"Qunyi Qian","email":"quqian@cisco.com","username":"quqian"},"change_message_id":"c9704abed32c389a874eb30ec4182d20cbe630c2","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        \"\"\"Check that given iscsi_iface uses only supported transports"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        Accepted transport names for provided iface param are"},{"line_number":270,"context_line":"        be2iscsi, bnx2i, cxgb3i, cxgb4i, default, qla4xxx, ocs or iser."},{"line_number":271,"context_line":"        Note the difference between transport and iface;"},{"line_number":272,"context_line":"        unlike default(iscsi_tcp)/iser, this is not one and the same for"},{"line_number":273,"context_line":"        offloaded transports, where the default format is"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_ed04391a","line":270,"updated":"2017-10-16 01:49:58.000000000","message":"Comment not match","commit_id":"b1c2c2cc10b4d35aa7bf8c8770bf8a7fe139fa41"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"28488d35191afa9756500bd2da7317116fbf7735","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \"\"\"Connector class to attach/detach iSCSI volumes.\"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    supported_transports \u003d [\u0027be2iscsi\u0027, \u0027bnx2i\u0027, \u0027cxgb3i\u0027, \u0027default\u0027,"},{"line_number":45,"context_line":"                            \u0027cxgb4i\u0027, \u0027qla4xxx\u0027, \u0027ocs\u0027, \u0027iser\u0027, \u0027tcp\u0027]"},{"line_number":46,"context_line":"    VALID_SESSIONS_PREFIX \u003d (\u0027tcp:\u0027, \u0027iser:\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def __init__(self, root_helper, driver\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_4ddc0c74","line":45,"range":{"start_line":45,"start_character":65,"end_line":45,"end_character":68},"updated":"2017-11-20 21:56:18.000000000","message":"Looks like you should have a corresponding change to the nova docs for both the iscsi_iface option:\n\nhttps://github.com/openstack/nova/blob/master/nova/conf/libvirt.py#L809\n\nand docs here:\n\nhttps://docs.openstack.org/nova/pike/admin/configuration/iscsi-offload.html","commit_id":"0e7d8efede2829da520a630f7bb3c0395ae8aad7"}],"releasenotes/notes/bug-1722432-2408dab55c903c5b.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7d23b337532466c34b30c5b4d78b3f878dd8cc2c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1722432 \u003chttps://bugs.launchpad.net/os-brick/+bug/1722432\u003e`_]"},{"line_number":5,"context_line":"    Changes the supported_transports to support tcp transport. With this"},{"line_number":6,"context_line":"    change, we can define an custom iface with tcp transport to limit the"},{"line_number":7,"context_line":"    storage traffic only be transimitted via storage NIC we specified."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_065ae981","line":6,"range":{"start_line":6,"start_character":26,"end_line":6,"end_character":28},"updated":"2018-01-16 16:07:43.000000000","message":"s/an/a/","commit_id":"cfe5b19fad14857773b27359eec9a8d62cf1ee7d"}]}
