)]}'
{"os_brick/encryptors/cryptsetup.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"afbd73ea9b22937c104e1ba8947c043eff1b3ec2","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    def _close_volume(self, **kwargs):"},{"line_number":170,"context_line":"        \"\"\"Closes the device (effectively removes the dm-crypt mapping).\"\"\""},{"line_number":171,"context_line":"        LOG.debug(\"closing encrypted volume %s\", self.dev_path)"},{"line_number":172,"context_line":"        # NOTE(mdbooth): remove will return 4 (wrong device specified) if"},{"line_number":173,"context_line":"        # the device doesn\u0027t exist. We assume here that the caller hasn\u0027t"},{"line_number":174,"context_line":"        # specified the wrong device, and that it doesn\u0027t exist because it"},{"line_number":175,"context_line":"        # isn\u0027t open. We don\u0027t fail in this case in order to make this"},{"line_number":176,"context_line":"        # operation idempotent."},{"line_number":177,"context_line":"        self._execute(\u0027cryptsetup\u0027, \u0027remove\u0027, self.dev_name,"},{"line_number":178,"context_line":"                      run_as_root\u003dTrue, check_exit_code\u003d[0, 4],"},{"line_number":179,"context_line":"                      root_helper\u003dself._root_helper)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_37e580dc","line":176,"range":{"start_line":172,"start_character":8,"end_line":176,"end_character":31},"updated":"2017-11-29 19:38:45.000000000","message":"wonder if there\u0027s a way to verify that assumption?","commit_id":"cedf281c7349daeec3ad85f12c75a47b1caf55ad"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"4096bf76043071b311625de529ce901b0ae3d8e4","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    def _close_volume(self, **kwargs):"},{"line_number":170,"context_line":"        \"\"\"Closes the device (effectively removes the dm-crypt mapping).\"\"\""},{"line_number":171,"context_line":"        LOG.debug(\"closing encrypted volume %s\", self.dev_path)"},{"line_number":172,"context_line":"        # NOTE(mdbooth): remove will return 4 (wrong device specified) if"},{"line_number":173,"context_line":"        # the device doesn\u0027t exist. We assume here that the caller hasn\u0027t"},{"line_number":174,"context_line":"        # specified the wrong device, and that it doesn\u0027t exist because it"},{"line_number":175,"context_line":"        # isn\u0027t open. We don\u0027t fail in this case in order to make this"},{"line_number":176,"context_line":"        # operation idempotent."},{"line_number":177,"context_line":"        self._execute(\u0027cryptsetup\u0027, \u0027remove\u0027, self.dev_name,"},{"line_number":178,"context_line":"                      run_as_root\u003dTrue, check_exit_code\u003d[0, 4],"},{"line_number":179,"context_line":"                      root_helper\u003dself._root_helper)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_777b08f4","line":176,"range":{"start_line":172,"start_character":8,"end_line":176,"end_character":31},"in_reply_to":"ff82abbf_37e580dc","updated":"2017-11-29 19:44:36.000000000","message":"What I was saying here (and on IRC) is that this is an improvement and I think it\u0027s fine.  One nit or suggestion for a follow up however is to check and verify if it\u0027s \"not open\" or if it doesn\u0027t exist and respond appropriately.  Rather than just assuming here and hiding the details it might be worth looking at possibly only ignoring if in fact the device exists and is not open after a verification check.","commit_id":"cedf281c7349daeec3ad85f12c75a47b1caf55ad"}]}