)]}'
{"os_brick/initiator/connector.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"99df26254468afaf82626ac2b61088c8a0d3b987","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    return props"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"def get_connector_mapping(arch\u003dNone):"},{"line_number":234,"context_line":"    # We do this instead of assigning it in the definition"},{"line_number":235,"context_line":"    # to help mocking for unit tests"},{"line_number":236,"context_line":"    if arch is None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_46651345","line":233,"updated":"2018-04-02 19:17:53.000000000","message":"This should be _get_connector_mapping() to indicate that it\u0027s not part of the library API.","commit_id":"c299899dee49dcca22c116fae9914d6bf46dbdfd"},{"author":{"_account_id":21279,"name":"Patricia Domingues","email":"patricia.domingues@canonical.com","username":"patriciasd"},"change_message_id":"6551eae89f453eba9a6cc4f193c382e594f35bc8","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    return props"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"def get_connector_mapping(arch\u003dNone):"},{"line_number":234,"context_line":"    # We do this instead of assigning it in the definition"},{"line_number":235,"context_line":"    # to help mocking for unit tests"},{"line_number":236,"context_line":"    if arch is None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_61e361da","line":233,"in_reply_to":"bf659307_46651345","updated":"2018-04-02 20:13:55.000000000","message":"But the intention of adding this function was to access it from nova. Should it still be marked private?","commit_id":"c299899dee49dcca22c116fae9914d6bf46dbdfd"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3a58ad2a7dbea3ddfda8ef728236e823729fad1b","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    return props"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"def get_connector_mapping(arch\u003dNone):"},{"line_number":234,"context_line":"    # We do this instead of assigning it in the definition"},{"line_number":235,"context_line":"    # to help mocking for unit tests"},{"line_number":236,"context_line":"    if arch is None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_ac64ff4a","line":233,"in_reply_to":"bf659307_610cc1a4","updated":"2018-04-03 14:11:56.000000000","message":"Ok, sounds good.\n\nCould we add a \"\"\" comment describing its purpose?","commit_id":"c299899dee49dcca22c116fae9914d6bf46dbdfd"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f87b1e8faedde83bab263e8b935f5731ac5d1bbd","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    return props"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"def get_connector_mapping(arch\u003dNone):"},{"line_number":234,"context_line":"    # We do this instead of assigning it in the definition"},{"line_number":235,"context_line":"    # to help mocking for unit tests"},{"line_number":236,"context_line":"    if arch is None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_610cc1a4","line":233,"in_reply_to":"bf659307_61e361da","updated":"2018-04-02 20:17:10.000000000","message":"Oh right, not I remember. You are correct Patricia. This does need to be public for it to be usable by Nova.","commit_id":"c299899dee49dcca22c116fae9914d6bf46dbdfd"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6df52bef182dc7f2acf439f3949f3d34227cac73","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    return props"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"# (patriciadomin):this function should be marked private,"},{"line_number":234,"context_line":"# but we need it public to access it from Nova."},{"line_number":235,"context_line":"def get_connector_mapping(arch\u003dNone):"},{"line_number":236,"context_line":"    # We do this instead of assigning it in the definition"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_0fb4e0f0","line":233,"range":{"start_line":233,"start_character":18,"end_line":233,"end_character":57},"updated":"2018-04-04 13:52:39.000000000","message":"It shouldn\u0027t, I just missed the purpose here when commenting previously.","commit_id":"df9f0579a459e7403b67ec528bc1acc868c3e252"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f432581c87c2aa2ad0c77ec14aaefa4759f9f7f2","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    return props"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"# (patriciadomin):we need this to access it from Nova."},{"line_number":234,"context_line":"def get_connector_mapping(arch\u003dNone):"},{"line_number":235,"context_line":"    # We do this instead of assigning it in the definition"},{"line_number":236,"context_line":"    # to help mocking for unit tests"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf659307_2fc4abf4","line":233,"updated":"2018-04-11 15:21:57.000000000","message":"Please add information in a docstring like Eric requested in patchset 5. So something like:\n\ndef get_connector_mapping(arch\u003dNone):\n    \"\"\"Get connector mappings based on platform.\n\n    This is used by Nova to get the right connector information.\n\n    :param arch: The architecture being requested.\n    \"\"\"","commit_id":"ab7bf3061dfc90a39bde9466015df3fdde6e01da"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"69b3955466aff4eaea4511ac297fb1236206f71f","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"def get_connector_mapping(arch\u003dNone):"},{"line_number":234,"context_line":"    \"\"\"Get connector mapping based on platform."},{"line_number":235,"context_line":"    This is used by Nova to get the right connector information."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    :param arch: The architecture being requested."}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_cb395cd7","line":234,"updated":"2018-04-11 18:53:48.000000000","message":"Need a blank line after docstring summary line.","commit_id":"1ccb77e0b02023cdc5703112a4519768de0bd091"}],"os_brick/tests/initiator/test_connector.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"75e95f33ba69d3f759f4debdcffd00131b51a27e","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        mapping_x86 \u003d connector.get_connector_mapping()"},{"line_number":192,"context_line":"        mock_platform_machine.return_value \u003d \u0027ppc64le\u0027"},{"line_number":193,"context_line":"        mapping_ppc \u003d connector.get_connector_mapping()"},{"line_number":194,"context_line":"        self.assertNotEqual(mapping_x86,mapping_ppc)"},{"line_number":195,"context_line":"        mock_platform_machine.return_value \u003d \u0027s390x\u0027"},{"line_number":196,"context_line":"        mapping_s390 \u003d connector.get_connector_mapping()"},{"line_number":197,"context_line":"        self.assertNotEqual(mapping_x86,mapping_s390)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_8a8589d1","line":194,"range":{"start_line":194,"start_character":39,"end_line":194,"end_character":40},"updated":"2018-03-30 20:16:54.000000000","message":"This will probably complain - needs a space after the comma.","commit_id":"065414f6a5e23e837325b2b8bc613ba93aa5ec02"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"75e95f33ba69d3f759f4debdcffd00131b51a27e","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        self.assertNotEqual(mapping_x86,mapping_ppc)"},{"line_number":195,"context_line":"        mock_platform_machine.return_value \u003d \u0027s390x\u0027"},{"line_number":196,"context_line":"        mapping_s390 \u003d connector.get_connector_mapping()"},{"line_number":197,"context_line":"        self.assertNotEqual(mapping_x86,mapping_s390)"},{"line_number":198,"context_line":"        self.assertNotEqual(mapping_ppc,mapping_s390)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def test_factory(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_2a6ebd2e","line":197,"range":{"start_line":197,"start_character":39,"end_line":197,"end_character":40},"updated":"2018-03-30 20:16:54.000000000","message":"These too.","commit_id":"065414f6a5e23e837325b2b8bc613ba93aa5ec02"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"644697c649d397c8970197b0b87f2e8c4232640e","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    @mock.patch(\u0027sys.platform\u0027, \u0027win32\u0027)"},{"line_number":182,"context_line":"    def test_get_connector_mapping_win32(self):"},{"line_number":183,"context_line":"        mapping_win32 \u003d connector.get_connector_mapping()"},{"line_number":184,"context_line":"        self.assertTrue(mapping_win32.has_key(\u0027ISCSI\u0027))"},{"line_number":185,"context_line":"        self.assertFalse(mapping_win32.has_key(\u0027STORPOOL\u0027))"},{"line_number":186,"context_line":"        self.assertFalse(mapping_win32.has_key(\u0027RBD\u0027))"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_e518f61e","line":184,"range":{"start_line":184,"start_character":38,"end_line":184,"end_character":45},"updated":"2018-03-30 21:28:29.000000000","message":"Missed this in the error output. has_key is deprecated and shouldn\u0027t be used. Just make these:\n\n    self.assertTrue(\u0027ISCSI\u0027 in mapping_win32)","commit_id":"64dc3b4840257d30b16ca143b5cb013b622b1460"}]}
