)]}'
{"os_brick/initiator/linuxfc.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9f6e3011a4858c411d33de4d67992e872d142fe6","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            # We need to run command in shell to expand the * glob"},{"line_number":71,"context_line":"            out, _err \u003d self._execute(cmd, shell\u003dTrue)"},{"line_number":72,"context_line":"            return [line.split(\u0027/\u0027)[4].split(\u0027:\u0027)[1:]"},{"line_number":73,"context_line":"                    for line in out.split(\u0027\\n\u0027) if line.startswith(path)]"},{"line_number":74,"context_line":"        except Exception as exc:"},{"line_number":75,"context_line":"            LOG.debug(\u0027Could not get HBA channel and SCSI target ID, path: \u0027"},{"line_number":76,"context_line":"                      \u0027%(path)s*, reason: %(reason)s\u0027, {\u0027path\u0027: path,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9c8fad2d","line":73,"range":{"start_line":72,"start_character":12,"end_line":73,"end_character":73},"updated":"2018-06-05 08:33:10.000000000","message":"nit: I know that this should never return an empty list, but your previous solution was more robust, as it would work if we returned None or an empty list here.","commit_id":"50ef90251c474b69665fd49444db6ae06711f408"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4645558e376fd746e37200ed16e65fc964081711","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            # We need to run command in shell to expand the * glob"},{"line_number":71,"context_line":"            out, _err \u003d self._execute(cmd, shell\u003dTrue)"},{"line_number":72,"context_line":"            return [line.split(\u0027/\u0027)[4].split(\u0027:\u0027)[1:]"},{"line_number":73,"context_line":"                    for line in out.split(\u0027\\n\u0027) if line.startswith(path)]"},{"line_number":74,"context_line":"        except Exception as exc:"},{"line_number":75,"context_line":"            LOG.debug(\u0027Could not get HBA channel and SCSI target ID, path: \u0027"},{"line_number":76,"context_line":"                      \u0027%(path)s*, reason: %(reason)s\u0027, {\u0027path\u0027: path,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0c5d8714","line":73,"range":{"start_line":72,"start_character":12,"end_line":73,"end_character":73},"in_reply_to":"5f7c97a3_6771cd77","updated":"2018-06-06 12:49:19.000000000","message":"Thanks for the explanation.\n\nWhile this, and code in L104-108, makes sense for your follow up patch, they don\u0027t make sense on this one.\n\nIn my opinion, bug fixing patches should make sense on their own. Multi-patch features are different.\n\nWe won\u0027t be backporting the new follow up feature to older releases, but we\u0027ll be backporting this patch.\n\nSo the result is that we\u0027ll have code that doesn\u0027t look so good in those branches.  This code will also be suboptimal, as we are running a loop on L105 where a single check is enough.\n\nAt least now I understand why you did it. ;-)","commit_id":"50ef90251c474b69665fd49444db6ae06711f408"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"1969a2e6f820ff3b98ff6f5f829e894d11991bfa","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            # We need to run command in shell to expand the * glob"},{"line_number":71,"context_line":"            out, _err \u003d self._execute(cmd, shell\u003dTrue)"},{"line_number":72,"context_line":"            return [line.split(\u0027/\u0027)[4].split(\u0027:\u0027)[1:]"},{"line_number":73,"context_line":"                    for line in out.split(\u0027\\n\u0027) if line.startswith(path)]"},{"line_number":74,"context_line":"        except Exception as exc:"},{"line_number":75,"context_line":"            LOG.debug(\u0027Could not get HBA channel and SCSI target ID, path: \u0027"},{"line_number":76,"context_line":"                      \u0027%(path)s*, reason: %(reason)s\u0027, {\u0027path\u0027: path,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6771cd77","line":73,"range":{"start_line":72,"start_character":12,"end_line":73,"end_character":73},"in_reply_to":"5f7c97a3_9c8fad2d","updated":"2018-06-05 17:25:41.000000000","message":"This change from the previous solution is due to the support for multiple luns, and why I cobbled them together into a single review last time ;)\n\nCheck out the changes in https://review.openstack.org/#/c/571332/3 for this method and it should make more sense why I went this route.","commit_id":"50ef90251c474b69665fd49444db6ae06711f408"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9f6e3011a4858c411d33de4d67992e872d142fe6","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            for hba in hbas:"},{"line_number":103,"context_line":"                cts \u003d get_cts(hba, connection_properties)"},{"line_number":104,"context_line":"                found_info \u003d True"},{"line_number":105,"context_line":"                for hba_channel, target_id in cts:"},{"line_number":106,"context_line":"                    if hba_channel \u003d\u003d \u0027-\u0027 or target_id \u003d\u003d \u0027-\u0027:"},{"line_number":107,"context_line":"                        found_info \u003d False"},{"line_number":108,"context_line":"                target_list \u003d with_info if found_info else no_info"},{"line_number":109,"context_line":"                target_list.append((hba, cts))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"            process \u003d with_info or no_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dc11a506","line":108,"range":{"start_line":104,"start_character":0,"end_line":108,"end_character":66},"updated":"2018-06-05 08:33:10.000000000","message":"-1: Too complicated, we can replace original L103 and L104 with:\n\n if cts and cts[0][0] !\u003d \u0027-\u0027:\n    with_info.append((hba, cts))\n else:\n    no_info.append((hba, cts))\n\nOr we can change the name of target_list and do a oneliner:\n\n tgt_list \u003d with_info if cts and cts[0][0] !\u003d \u0027-\u0027 else no_info","commit_id":"50ef90251c474b69665fd49444db6ae06711f408"}]}
