)]}'
{"os_brick/initiator/connectors/rbd.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ce1832d142764b150e8a0c61cf77f46a81e10119","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        # the size of the extended volume."},{"line_number":254,"context_line":"        device_info \u003d self.connect_volume(connection_properties)"},{"line_number":255,"context_line":"        new_size \u003d device_info.get(\u0027path\u0027).rbd_image.size()"},{"line_number":256,"context_line":"        self.disconnect_volume(connection_properties, device_info)"},{"line_number":257,"context_line":"        return new_size"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3d7e0fe3","line":256,"updated":"2018-09-05 11:58:01.000000000","message":"why are you disconnecting the volume here?  This is not how extend is supposed to work.  You need to leave the volume attached.\n\nYou also have to make sure the local system sees the new size, as the same way that FC and iSCSI devices do.","commit_id":"cb346610294a327577b11f81818a78e695f0ac0d"},{"author":{"_account_id":5575,"name":"Jose Castro Leon","email":"jose.castro.leon@cern.ch","username":"jose-castro-leon"},"change_message_id":"14a02a4f32a776b5c93a4d396836eb3e3e2470fe","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        # the size of the extended volume."},{"line_number":254,"context_line":"        device_info \u003d self.connect_volume(connection_properties)"},{"line_number":255,"context_line":"        new_size \u003d device_info.get(\u0027path\u0027).rbd_image.size()"},{"line_number":256,"context_line":"        self.disconnect_volume(connection_properties, device_info)"},{"line_number":257,"context_line":"        return new_size"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8f17ea46","line":256,"in_reply_to":"3f79a3b5_3d7e0fe3","updated":"2018-09-05 12:12:13.000000000","message":"In iSCSI and FC the servers is directly attached to the volume and it exposes it to the VMs connected. On RBD the VM has direct connection to it and we only need to retrieve the extended size to inform it.\n\nThere is nothing to inform the local filesystem of the server as this is never exposed to it","commit_id":"cb346610294a327577b11f81818a78e695f0ac0d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c3441983bf8706c82ccafbf513bfa8bd05173867","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        # the size of the extended volume."},{"line_number":254,"context_line":"        device_info \u003d self.connect_volume(connection_properties)"},{"line_number":255,"context_line":"        new_size \u003d device_info.get(\u0027path\u0027).rbd_image.size()"},{"line_number":256,"context_line":"        self.disconnect_volume(connection_properties, device_info)"},{"line_number":257,"context_line":"        return new_size"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a3df5dd5","line":256,"in_reply_to":"3f79a3b5_8f17ea46","updated":"2018-09-05 15:25:51.000000000","message":"That still isn\u0027t clear. Can you explain why disconnect_volume needs to be called?","commit_id":"cb346610294a327577b11f81818a78e695f0ac0d"},{"author":{"_account_id":5575,"name":"Jose Castro Leon","email":"jose.castro.leon@cern.ch","username":"jose-castro-leon"},"change_message_id":"c54877bb8d05d2c5368ffa86ec61b449efb4b90d","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        # the size of the extended volume."},{"line_number":254,"context_line":"        device_info \u003d self.connect_volume(connection_properties)"},{"line_number":255,"context_line":"        new_size \u003d device_info.get(\u0027path\u0027).rbd_image.size()"},{"line_number":256,"context_line":"        self.disconnect_volume(connection_properties, device_info)"},{"line_number":257,"context_line":"        return new_size"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_020da834","line":256,"in_reply_to":"3f79a3b5_99ff3002","updated":"2018-11-28 10:45:24.000000000","message":"Could you please have a look on the last comment? In the line 254 it\u0027s connecting to the volume, on 255 retrieving the new size and then in 256 disconnecting this temporary connection. This should be ok, shouldn\u0027t it?","commit_id":"cb346610294a327577b11f81818a78e695f0ac0d"},{"author":{"_account_id":5575,"name":"Jose Castro Leon","email":"jose.castro.leon@cern.ch","username":"jose-castro-leon"},"change_message_id":"4fd57a4ee21ba7865f528a8b18bf54e392391228","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        # the size of the extended volume."},{"line_number":254,"context_line":"        device_info \u003d self.connect_volume(connection_properties)"},{"line_number":255,"context_line":"        new_size \u003d device_info.get(\u0027path\u0027).rbd_image.size()"},{"line_number":256,"context_line":"        self.disconnect_volume(connection_properties, device_info)"},{"line_number":257,"context_line":"        return new_size"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_99ff3002","line":256,"in_reply_to":"3f79a3b5_a3df5dd5","updated":"2018-10-15 06:16:20.000000000","message":"To avoid leaving orphaned connections, I only need to connect retrieve the data I\u0027m interested in and then disconnect. The VM connection has already a well established connection and will be unaffected by this method.","commit_id":"cb346610294a327577b11f81818a78e695f0ac0d"}],"os_brick/tests/initiator/connectors/test_rbd.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"70a8ab5d3bd673cc5565ae474d0c10d176427653","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    def test_extend_volume(self, mock_rbd, mock_rados):"},{"line_number":268,"context_line":"        new_size \u003d 1024"},{"line_number":269,"context_line":"        self.mock_ioctx \u003d mock.Mock()"},{"line_number":270,"context_line":"        self.mock_image \u003d \\"},{"line_number":271,"context_line":"            linuxrbd.rbd.Image(self.mock_ioctx, \u0027test\u0027)"},{"line_number":272,"context_line":"        self.mock_image.size.return_value \u003d new_size"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ceb26e94","line":270,"range":{"start_line":270,"start_character":26,"end_line":270,"end_character":27},"updated":"2018-08-28 12:52:03.000000000","message":"Nit: this new line is no longer recommended, try:\nself.mock_image \u003d linuxrbd.rbd.Image(\n    self.mock_ioctx, \u0027test\u0027)","commit_id":"cb42863d565b8f3607164627be4216cede7c8ab0"}]}
