)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"0aa53478c6ca234f0126a6cdb80bcc4631c4a38c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hamdy Khader \u003chamdyk@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-13 13:10:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ignore volume disconnect if it is not connected"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0f5533c0f00707380aa2e8039bcb99f9fba6687a"},{"line_number":10,"context_line":"Closes-Bug: #1792315"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_6465fae0","line":7,"updated":"2018-09-16 08:41:05.000000000","message":"please explain the problem this commit is addressing and suggested solution","commit_id":"aaa16ddd090a18ab1bf1601c3bc060088b0b22ec"}],"os_brick/initiator/connectors/nvme.py":[{"author":{"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},"change_message_id":"a817a39ee627f669e54742b3164116dff405c178","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        conn_nqn \u003d connection_properties[\u0027nqn\u0027]"},{"line_number":152,"context_line":"        device_path \u003d connection_properties[\u0027device_path\u0027]"},{"line_number":153,"context_line":"        current_nvme_devices \u003d self._get_nvme_devices()"},{"line_number":154,"context_line":"        if device_path not in current_nvme_devices:"},{"line_number":155,"context_line":"            LOG.warning(\u0027trying to disconnect device %s that is not connected\u0027,"},{"line_number":156,"context_line":"                        device_path)"},{"line_number":157,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_045e8612","line":154,"updated":"2018-09-16 08:33:33.000000000","message":"please use log with dictionaries, see example in line 159","commit_id":"aaa16ddd090a18ab1bf1601c3bc060088b0b22ec"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"e6b6fc3b0535b419c97043dc02dbf55215521382","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        conn_nqn \u003d connection_properties[\u0027nqn\u0027]"},{"line_number":152,"context_line":"        device_path \u003d connection_properties[\u0027device_path\u0027]"},{"line_number":153,"context_line":"        current_nvme_devices \u003d self._get_nvme_devices()"},{"line_number":154,"context_line":"        if device_path not in current_nvme_devices:"},{"line_number":155,"context_line":"            LOG.warning(\u0027trying to disconnect device %s that is not connected\u0027,"},{"line_number":156,"context_line":"                        device_path)"},{"line_number":157,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ca2f37a5","line":154,"in_reply_to":"3f79a3b5_045e8612","updated":"2018-09-16 18:16:37.000000000","message":"Done","commit_id":"aaa16ddd090a18ab1bf1601c3bc060088b0b22ec"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"0aa53478c6ca234f0126a6cdb80bcc4631c4a38c","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        current_nvme_devices \u003d self._get_nvme_devices()"},{"line_number":154,"context_line":"        if device_path not in current_nvme_devices:"},{"line_number":155,"context_line":"            LOG.warning(\u0027trying to disconnect device %s that is not connected\u0027,"},{"line_number":156,"context_line":"                        device_path)"},{"line_number":157,"context_line":"            return"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        LOG.debug("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_64aadad2","line":156,"updated":"2018-09-16 08:41:05.000000000","message":"i am not familiar with the module but the method disconnects a connected NVMe device.\n\nif a given device_path is not connect, it may indicate misuse or some sort of corruption.\n\nIMO the caller should enforce this, instead of suppressing.","commit_id":"aaa16ddd090a18ab1bf1601c3bc060088b0b22ec"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"e6b6fc3b0535b419c97043dc02dbf55215521382","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        current_nvme_devices \u003d self._get_nvme_devices()"},{"line_number":154,"context_line":"        if device_path not in current_nvme_devices:"},{"line_number":155,"context_line":"            LOG.warning(\u0027trying to disconnect device %s that is not connected\u0027,"},{"line_number":156,"context_line":"                        device_path)"},{"line_number":157,"context_line":"            return"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        LOG.debug("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4a2327bf","line":156,"in_reply_to":"3f79a3b5_64aadad2","updated":"2018-09-16 18:16:37.000000000","message":"Normally disconnect_volume is called and device_path is connected but when compute node restarts, nova calls disconnect_volume before starting the VM, at that point no NVME connections would be found.","commit_id":"aaa16ddd090a18ab1bf1601c3bc060088b0b22ec"}]}
