)]}'
{"os_brick/initiator/connectors/iscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"139e7eef2ca3a34587eb26c0449fc93a754c5d09","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        for ip, iqn, lun in ips_iqns_luns:"},{"line_number":708,"context_line":"            props \u003d connection_properties.copy()"},{"line_number":709,"context_line":"            props.update(target_portal\u003dip, target_iqn\u003diqn, target_lun\u003dlun)"},{"line_number":710,"context_line":"            for key in (\u0027target_portals\u0027, \u0027target_iqns\u0027, \u0027target_luns\u0027):"},{"line_number":711,"context_line":"                props.pop(key, None)"},{"line_number":712,"context_line":"            threads.append(executor.Thread(target\u003dself._connect_vol,"},{"line_number":713,"context_line":"                                           args\u003d(retries, props, data)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_548cfd2c","line":710,"updated":"2018-10-01 15:44:07.000000000","message":"If you do an update, it might be good to add a comment here to explain why these values are not needed in what is getting passed in to the thread so it\u0027s more obvious.","commit_id":"24fe4dce93760f7ac2d3c914fbf1e868056ca2cb"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"377a4df82a7a89451d445bcefd2ded8f949a1cf3","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        for ip, iqn, lun in ips_iqns_luns:"},{"line_number":708,"context_line":"            props \u003d connection_properties.copy()"},{"line_number":709,"context_line":"            props.update(target_portal\u003dip, target_iqn\u003diqn, target_lun\u003dlun)"},{"line_number":710,"context_line":"            for key in (\u0027target_portals\u0027, \u0027target_iqns\u0027, \u0027target_luns\u0027):"},{"line_number":711,"context_line":"                props.pop(key, None)"},{"line_number":712,"context_line":"            threads.append(executor.Thread(target\u003dself._connect_vol,"},{"line_number":713,"context_line":"                                           args\u003d(retries, props, data)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_adb02742","line":710,"in_reply_to":"3f79a3b5_548cfd2c","updated":"2018-10-08 03:30:52.000000000","message":"Done","commit_id":"24fe4dce93760f7ac2d3c914fbf1e868056ca2cb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a14da2e9f17b61432fef00541aa6e3652803738c","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        for ip, iqn, lun in ips_iqns_luns:"},{"line_number":708,"context_line":"            props \u003d connection_properties.copy()"},{"line_number":709,"context_line":"            props.update(target_portal\u003dip, target_iqn\u003diqn, target_lun\u003dlun)"},{"line_number":710,"context_line":"            # NOTE(yenai): Remove unused connection properties:"},{"line_number":711,"context_line":"            # \u0027target_portals\u0027, \u0027target_iqns\u0027, \u0027target_luns\u0027; in addition,"},{"line_number":712,"context_line":"            # make the debug message in _connect_vol more cleaner."},{"line_number":713,"context_line":"            for key in (\u0027target_portals\u0027, \u0027target_iqns\u0027, \u0027target_luns\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_db78ae7f","line":710,"updated":"2018-10-08 15:30:50.000000000","message":"Well, that says what the code does, which is obvious, but doesn\u0027t provide any information as to why they are being removed which was my point in the last revision.","commit_id":"2bac55c7871ea118cfd85e585aad014da65ebc02"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"40b2f0dfa3dc11f743db891e7ce51da90bb4697b","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        for ip, iqn, lun in ips_iqns_luns:"},{"line_number":708,"context_line":"            props \u003d connection_properties.copy()"},{"line_number":709,"context_line":"            props.update(target_portal\u003dip, target_iqn\u003diqn, target_lun\u003dlun)"},{"line_number":710,"context_line":"            # NOTE(yenai): Remove unused connection properties:"},{"line_number":711,"context_line":"            # \u0027target_portals\u0027, \u0027target_iqns\u0027, \u0027target_luns\u0027; in addition,"},{"line_number":712,"context_line":"            # make the debug message in _connect_vol more cleaner."},{"line_number":713,"context_line":"            for key in (\u0027target_portals\u0027, \u0027target_iqns\u0027, \u0027target_luns\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_92e529a7","line":710,"in_reply_to":"3f79a3b5_97419b66","updated":"2018-10-09 06:49:04.000000000","message":"The new solution was introduced in this patch: https://review.openstack.org/#/c/455393/.\nNow the _connect_vol is used as [parallelize logins], we will never use these args.\n\nThe [LOG.debug(\u0027Connected to %s using %s\u0027, device, strutils.mask_password(props))] in _connect_vol will print these unused infos which makes a mess.","commit_id":"2bac55c7871ea118cfd85e585aad014da65ebc02"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0ddadc2c49d40d8006356d7dd38170c23d11e12b","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        for ip, iqn, lun in ips_iqns_luns:"},{"line_number":708,"context_line":"            props \u003d connection_properties.copy()"},{"line_number":709,"context_line":"            props.update(target_portal\u003dip, target_iqn\u003diqn, target_lun\u003dlun)"},{"line_number":710,"context_line":"            # NOTE(yenai): Remove unused connection properties:"},{"line_number":711,"context_line":"            # \u0027target_portals\u0027, \u0027target_iqns\u0027, \u0027target_luns\u0027; in addition,"},{"line_number":712,"context_line":"            # make the debug message in _connect_vol more cleaner."},{"line_number":713,"context_line":"            for key in (\u0027target_portals\u0027, \u0027target_iqns\u0027, \u0027target_luns\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_97419b66","line":710,"in_reply_to":"3f79a3b5_db78ae7f","updated":"2018-10-09 05:54:51.000000000","message":"I think Sean\u0027s point here is for you to describe :\n1) why the values came into existence and to serve which purpose?\n2) why are they not needed anymore? how is the situation handled  which required these values before?\nCorrect me if i\u0027m wrong.","commit_id":"2bac55c7871ea118cfd85e585aad014da65ebc02"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"40b2f0dfa3dc11f743db891e7ce51da90bb4697b","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        for ip, iqn, lun in ips_iqns_luns:"},{"line_number":708,"context_line":"            props \u003d connection_properties.copy()"},{"line_number":709,"context_line":"            props.update(target_portal\u003dip, target_iqn\u003diqn, target_lun\u003dlun)"},{"line_number":710,"context_line":"            # NOTE(yenai): Remove unused connection properties:"},{"line_number":711,"context_line":"            # \u0027target_portals\u0027, \u0027target_iqns\u0027, \u0027target_luns\u0027; in addition,"},{"line_number":712,"context_line":"            # make the debug message in _connect_vol more cleaner."},{"line_number":713,"context_line":"            for key in (\u0027target_portals\u0027, \u0027target_iqns\u0027, \u0027target_luns\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b2e8657b","line":710,"in_reply_to":"3f79a3b5_db78ae7f","updated":"2018-10-09 06:49:04.000000000","message":"Just see the new note.","commit_id":"2bac55c7871ea118cfd85e585aad014da65ebc02"}]}