)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"21a1d84caec47640de65d78502a673396e023319","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yenai \u003cyenai@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-26 17:50:31 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove meanless debug log"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. self._execute is a function object."},{"line_number":10,"context_line":"2. @utils.trace has already do the debug job."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_636be985","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":15},"updated":"2018-09-26 10:47:23.000000000","message":"you mean meaningless or useless?","commit_id":"ce8a3400958e631e35095ca55149ec0ff45dc473"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"16b1e5e312dd0b4c5ed96d8e67d740b99c9f230a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yenai \u003cyenai@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-26 17:50:31 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove meanless debug log"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. self._execute is a function object."},{"line_number":10,"context_line":"2. @utils.trace has already do the debug job."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_985c60f1","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":15},"in_reply_to":"3f79a3b5_636be985","updated":"2018-09-27 02:02:19.000000000","message":"meanless","commit_id":"ce8a3400958e631e35095ca55149ec0ff45dc473"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"21a1d84caec47640de65d78502a673396e023319","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove meanless debug log"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. self._execute is a function object."},{"line_number":10,"context_line":"2. @utils.trace has already do the debug job."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2041339bb713c6e94481e3991385d4a9e433433e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_e304d9c7","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":30},"updated":"2018-09-26 10:47:23.000000000","message":"already does","commit_id":"ce8a3400958e631e35095ca55149ec0ff45dc473"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"16b1e5e312dd0b4c5ed96d8e67d740b99c9f230a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove meanless debug log"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. self._execute is a function object."},{"line_number":10,"context_line":"2. @utils.trace has already do the debug job."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2041339bb713c6e94481e3991385d4a9e433433e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_d85098d8","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":30},"in_reply_to":"3f79a3b5_e304d9c7","updated":"2018-09-27 02:02:19.000000000","message":"Done","commit_id":"ce8a3400958e631e35095ca55149ec0ff45dc473"}],"os_brick/initiator/connectors/fibre_channel.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"18535836011a60a394f4f7b23405eac001aadc18","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        target_wwn - World Wide Name"},{"line_number":186,"context_line":"        target_lun - LUN id of the volume"},{"line_number":187,"context_line":"        \"\"\""},{"line_number":188,"context_line":"        LOG.debug(\"execute \u003d %s\", self._execute)"},{"line_number":189,"context_line":"        device_info \u003d {\u0027type\u0027: \u0027block\u0027}"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        connection_properties \u003d self._add_targets_to_connection_properties("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_34466c7d","side":"PARENT","line":188,"range":{"start_line":188,"start_character":8,"end_line":188,"end_character":48},"updated":"2018-09-27 11:42:59.000000000","message":"A better improvement other than just removing this would be to print the connection_properties.","commit_id":"10ea64db9cd49ff1ad8c49c21f40785951921511"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"35e7561294a3ab3a568d799ffdc793ded9398f89","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        target_wwn - World Wide Name"},{"line_number":186,"context_line":"        target_lun - LUN id of the volume"},{"line_number":187,"context_line":"        \"\"\""},{"line_number":188,"context_line":"        LOG.debug(\"execute \u003d %s\", self._execute)"},{"line_number":189,"context_line":"        device_info \u003d {\u0027type\u0027: \u0027block\u0027}"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        connection_properties \u003d self._add_targets_to_connection_properties("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8c47291f","side":"PARENT","line":188,"range":{"start_line":188,"start_character":8,"end_line":188,"end_character":48},"in_reply_to":"3f79a3b5_34466c7d","updated":"2018-09-28 01:11:23.000000000","message":"You can just see @utils.trace.","commit_id":"10ea64db9cd49ff1ad8c49c21f40785951921511"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"18535836011a60a394f4f7b23405eac001aadc18","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            device_path \u003d self.host_device"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        device_info[\u0027path\u0027] \u003d device_path"},{"line_number":257,"context_line":"        LOG.debug(\"connect_volume returning %s\", device_info)"},{"line_number":258,"context_line":"        return device_info"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def _get_host_devices(self, possible_devs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b4511c33","side":"PARENT","line":257,"updated":"2018-09-27 11:42:59.000000000","message":"-1: This one should not be removed as the value returned by the function might be very useful.","commit_id":"10ea64db9cd49ff1ad8c49c21f40785951921511"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"9a1697e96bc6c818d0b758132c8f0d3e669406fe","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            device_path \u003d self.host_device"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        device_info[\u0027path\u0027] \u003d device_path"},{"line_number":257,"context_line":"        LOG.debug(\"connect_volume returning %s\", device_info)"},{"line_number":258,"context_line":"        return device_info"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def _get_host_devices(self, possible_devs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a420f29b","side":"PARENT","line":257,"in_reply_to":"3f79a3b5_4c5111d9","updated":"2018-09-28 11:55:28.000000000","message":"Hmm, got it.","commit_id":"10ea64db9cd49ff1ad8c49c21f40785951921511"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"35e7561294a3ab3a568d799ffdc793ded9398f89","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            device_path \u003d self.host_device"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        device_info[\u0027path\u0027] \u003d device_path"},{"line_number":257,"context_line":"        LOG.debug(\"connect_volume returning %s\", device_info)"},{"line_number":258,"context_line":"        return device_info"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def _get_host_devices(self, possible_devs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4c5111d9","side":"PARENT","line":257,"in_reply_to":"3f79a3b5_b4511c33","updated":"2018-09-28 01:11:23.000000000","message":"@utils.trace just do the job.","commit_id":"10ea64db9cd49ff1ad8c49c21f40785951921511"}]}
