)]}'
{"os_brick/initiator/linuxscsi.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ee4bdb8e71f173dfca23514bc953a4cab9482fd2","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        \"\"\"Verify that all specified devices have the expected WWN.\"\"\""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        for device_name in device_names:"},{"line_number":161,"context_line":"            found_wwn \u003d self.get_sysfs_wwn([device_name])"},{"line_number":162,"context_line":"            if found_wwn !\u003d expected_wwn:"},{"line_number":163,"context_line":"                raise exception.VolumeDeviceValidationFailed("},{"line_number":164,"context_line":"                    device\u003ddevice_name, expected\u003dexpected_wwn,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_41d21002","line":161,"range":{"start_line":161,"start_character":24,"end_line":161,"end_character":57},"updated":"2019-01-30 05:40:33.000000000","message":"could you explain why we send devices as separate individual device list when the expected wwn is same?","commit_id":"fe711fa271eeb950cd13b3a7e4201a61a33f45ab"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"6ddb54c467af72aa693c7afe5388008d1f56e8e6","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        \"\"\"Verify that all specified devices have the expected WWN.\"\"\""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        for device_name in device_names:"},{"line_number":161,"context_line":"            found_wwn \u003d self.get_sysfs_wwn([device_name])"},{"line_number":162,"context_line":"            if found_wwn !\u003d expected_wwn:"},{"line_number":163,"context_line":"                raise exception.VolumeDeviceValidationFailed("},{"line_number":164,"context_line":"                    device\u003ddevice_name, expected\u003dexpected_wwn,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_615e3445","line":161,"range":{"start_line":161,"start_character":24,"end_line":161,"end_character":57},"in_reply_to":"9fdfeff1_41d21002","updated":"2019-01-30 09:38:26.000000000","message":"We expect all devices to have the same WWN, but one or more of the devices may in fact be from a previous connection that wasn\u0027t cleaned up.  Therefore we need to check all devices.  get_sysfs_wwn only accepts a list, but returns the WWN from the first device that it can read.  Therefore, I call it for each device to ensure that all WWNs match the expected one.","commit_id":"fe711fa271eeb950cd13b3a7e4201a61a33f45ab"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"35ba6833a94a4ee7e1a0c7b218c7da95bc4dd499","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        \"\"\"Verify that all specified devices have the expected WWN.\"\"\""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        for device_name in device_names:"},{"line_number":161,"context_line":"            found_wwn \u003d self.get_sysfs_wwn([device_name])"},{"line_number":162,"context_line":"            if found_wwn !\u003d expected_wwn:"},{"line_number":163,"context_line":"                raise exception.VolumeDeviceValidationFailed("},{"line_number":164,"context_line":"                    device\u003ddevice_name, expected\u003dexpected_wwn,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_76a273fe","line":161,"range":{"start_line":161,"start_character":24,"end_line":161,"end_character":57},"in_reply_to":"9fdfeff1_615e3445","updated":"2019-01-30 10:53:18.000000000","message":"So the behavior of get_sysfs_wwn isn\u0027t compatible with this new verification function so a little tweak to reuse the code.Thanks for the explanation.","commit_id":"fe711fa271eeb950cd13b3a7e4201a61a33f45ab"}]}
