)]}'
{"os_brick/initiator/connectors/iscsi.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6864a674f128f4c2b1006822086e6508b9980837","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        except exception.TargetPortalsNotFound:"},{"line_number":196,"context_line":"            raise"},{"line_number":197,"context_line":"        except Exception:"},{"line_number":198,"context_line":"            LOG.exception(\u0027Exception encountered during portal discovery\u0027)"},{"line_number":199,"context_line":"            if \u0027target_portals\u0027 in connection_properties:"},{"line_number":200,"context_line":"                raise exception.TargetPortalsNotFound("},{"line_number":201,"context_line":"                    target_portals\u003dconnection_properties[\u0027target_portals\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_d5c98c5a","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":74},"updated":"2019-02-04 14:29:25.000000000","message":"The exception for targetportals is raised at L#196. don\u0027t we need to log in that case?\nAlso can we add the targetportal/s in the log like done at L#657.","commit_id":"f3ad8c08fe52f8bd042f91a209151a0ff7ff606f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9f89140936634bb545bf961207f2c48ea8056868","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        except exception.TargetPortalsNotFound:"},{"line_number":196,"context_line":"            raise"},{"line_number":197,"context_line":"        except Exception:"},{"line_number":198,"context_line":"            LOG.exception(\u0027Exception encountered during portal discovery\u0027)"},{"line_number":199,"context_line":"            if \u0027target_portals\u0027 in connection_properties:"},{"line_number":200,"context_line":"                raise exception.TargetPortalsNotFound("},{"line_number":201,"context_line":"                    target_portals\u003dconnection_properties[\u0027target_portals\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_643906f1","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":74},"in_reply_to":"9fdfeff1_ce29f69b","updated":"2019-02-05 05:31:57.000000000","message":"Not all the connection_properties just the target_portal(s) (connection_properties[\u0027target_portal(s)\u0027])\nAnyways it\u0027s just a suggestion.","commit_id":"f3ad8c08fe52f8bd042f91a209151a0ff7ff606f"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"6b6e36a58753f043800ba0ef092960b6f4017225","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        except exception.TargetPortalsNotFound:"},{"line_number":196,"context_line":"            raise"},{"line_number":197,"context_line":"        except Exception:"},{"line_number":198,"context_line":"            LOG.exception(\u0027Exception encountered during portal discovery\u0027)"},{"line_number":199,"context_line":"            if \u0027target_portals\u0027 in connection_properties:"},{"line_number":200,"context_line":"                raise exception.TargetPortalsNotFound("},{"line_number":201,"context_line":"                    target_portals\u003dconnection_properties[\u0027target_portals\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_ce29f69b","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":74},"in_reply_to":"9fdfeff1_d5c98c5a","updated":"2019-02-04 20:24:37.000000000","message":"L#196 isn\u0027t a problem because we\u0027re just re-raising the exception - it can be caught by a caller and logged.  Here, where I added the log, we catch an exception and raise a different exception, and we lose the original. I\u0027m not sure what else I can add to the message short of printing all of connection_properties, which is overkill in my opinion.","commit_id":"f3ad8c08fe52f8bd042f91a209151a0ff7ff606f"}]}
