)]}'
{"os_brick/initiator/connectors/vxflexos.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"e87725bef02b9b75d2a7eadd468585b55af2caa1","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        self.local_sdc_ip \u003d connection_properties[\u0027hostIP\u0027]"},{"line_number":269,"context_line":"        # handle deprecated parameters for backward compatibility"},{"line_number":270,"context_line":"        d_option_used \u003d False"},{"line_number":271,"context_line":"        try:"},{"line_number":272,"context_line":"            self.volume_name \u003d connection_properties[\u0027vxflexos_volname\u0027]"},{"line_number":273,"context_line":"        except KeyError:"},{"line_number":274,"context_line":"            self.volume_name \u003d connection_properties[\u0027scaleIO_volname\u0027]"},{"line_number":275,"context_line":"            d_option_used \u003d True"},{"line_number":276,"context_line":"        try:"},{"line_number":277,"context_line":"            self.volume_id \u003d connection_properties[\u0027vxflexos_volume_id\u0027]"},{"line_number":278,"context_line":"        except KeyError:"},{"line_number":279,"context_line":"            self.volume_id \u003d connection_properties.get(\u0027scaleIO_volume_id\u0027)"},{"line_number":280,"context_line":"            d_option_used \u003d True"},{"line_number":281,"context_line":"        if d_option_used:"},{"line_number":282,"context_line":"            LOG.warning(\"Deprecated: scaleIO_volname and scaleIO_volume_id \""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_8def81e8","line":279,"range":{"start_line":271,"start_character":8,"end_line":279,"end_character":75},"updated":"2019-03-05 17:30:03.000000000","message":"Looks right. But why the same should not be done for the other connection_properties?","commit_id":"6b60614afaf88819ce92a2d0ed269035a3c8b261"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"18573d3dfb7c9ec759d425765e3a141207638b7d","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        self.local_sdc_ip \u003d connection_properties[\u0027hostIP\u0027]"},{"line_number":269,"context_line":"        # handle deprecated parameters for backward compatibility"},{"line_number":270,"context_line":"        d_option_used \u003d False"},{"line_number":271,"context_line":"        try:"},{"line_number":272,"context_line":"            self.volume_name \u003d connection_properties[\u0027vxflexos_volname\u0027]"},{"line_number":273,"context_line":"        except KeyError:"},{"line_number":274,"context_line":"            self.volume_name \u003d connection_properties[\u0027scaleIO_volname\u0027]"},{"line_number":275,"context_line":"            d_option_used \u003d True"},{"line_number":276,"context_line":"        try:"},{"line_number":277,"context_line":"            self.volume_id \u003d connection_properties[\u0027vxflexos_volume_id\u0027]"},{"line_number":278,"context_line":"        except KeyError:"},{"line_number":279,"context_line":"            self.volume_id \u003d connection_properties.get(\u0027scaleIO_volume_id\u0027)"},{"line_number":280,"context_line":"            d_option_used \u003d True"},{"line_number":281,"context_line":"        if d_option_used:"},{"line_number":282,"context_line":"            LOG.warning(\"Deprecated: scaleIO_volname and scaleIO_volume_id \""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_78599afc","line":279,"range":{"start_line":271,"start_character":8,"end_line":279,"end_character":75},"in_reply_to":"5fc1f717_106cf434","updated":"2019-03-06 16:56:08.000000000","message":"Not sure what you are talking about here as this will never raise a KeyError.","commit_id":"6b60614afaf88819ce92a2d0ed269035a3c8b261"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"a3034b8a11c6e116f5b3cc1537dc44883c932497","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        self.local_sdc_ip \u003d connection_properties[\u0027hostIP\u0027]"},{"line_number":269,"context_line":"        # handle deprecated parameters for backward compatibility"},{"line_number":270,"context_line":"        d_option_used \u003d False"},{"line_number":271,"context_line":"        try:"},{"line_number":272,"context_line":"            self.volume_name \u003d connection_properties[\u0027vxflexos_volname\u0027]"},{"line_number":273,"context_line":"        except KeyError:"},{"line_number":274,"context_line":"            self.volume_name \u003d connection_properties[\u0027scaleIO_volname\u0027]"},{"line_number":275,"context_line":"            d_option_used \u003d True"},{"line_number":276,"context_line":"        try:"},{"line_number":277,"context_line":"            self.volume_id \u003d connection_properties[\u0027vxflexos_volume_id\u0027]"},{"line_number":278,"context_line":"        except KeyError:"},{"line_number":279,"context_line":"            self.volume_id \u003d connection_properties.get(\u0027scaleIO_volume_id\u0027)"},{"line_number":280,"context_line":"            d_option_used \u003d True"},{"line_number":281,"context_line":"        if d_option_used:"},{"line_number":282,"context_line":"            LOG.warning(\"Deprecated: scaleIO_volname and scaleIO_volume_id \""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_b3a085a7","line":279,"range":{"start_line":271,"start_character":8,"end_line":279,"end_character":75},"in_reply_to":"5fc1f717_18e1769b","updated":"2019-03-06 17:34:33.000000000","message":"I see - while I do agree with you. This is a very specific patch and I would prefer to do actual cleanup up outside of this patch. Keeping the changes small will help make the back porting etc easier.","commit_id":"6b60614afaf88819ce92a2d0ed269035a3c8b261"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d56032722b3cbd76bdff28879f85ebf2603389e8","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        self.local_sdc_ip \u003d connection_properties[\u0027hostIP\u0027]"},{"line_number":269,"context_line":"        # handle deprecated parameters for backward compatibility"},{"line_number":270,"context_line":"        d_option_used \u003d False"},{"line_number":271,"context_line":"        try:"},{"line_number":272,"context_line":"            self.volume_name \u003d connection_properties[\u0027vxflexos_volname\u0027]"},{"line_number":273,"context_line":"        except KeyError:"},{"line_number":274,"context_line":"            self.volume_name \u003d connection_properties[\u0027scaleIO_volname\u0027]"},{"line_number":275,"context_line":"            d_option_used \u003d True"},{"line_number":276,"context_line":"        try:"},{"line_number":277,"context_line":"            self.volume_id \u003d connection_properties[\u0027vxflexos_volume_id\u0027]"},{"line_number":278,"context_line":"        except KeyError:"},{"line_number":279,"context_line":"            self.volume_id \u003d connection_properties.get(\u0027scaleIO_volume_id\u0027)"},{"line_number":280,"context_line":"            d_option_used \u003d True"},{"line_number":281,"context_line":"        if d_option_used:"},{"line_number":282,"context_line":"            LOG.warning(\"Deprecated: scaleIO_volname and scaleIO_volume_id \""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_18e1769b","line":279,"range":{"start_line":271,"start_character":8,"end_line":279,"end_character":75},"in_reply_to":"5fc1f717_78599afc","updated":"2019-03-06 17:12:29.000000000","message":"I\u0027m talking about line 274.","commit_id":"6b60614afaf88819ce92a2d0ed269035a3c8b261"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"40749e550e61ec255cc1c7de82a8f9c7b48c896f","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        self.local_sdc_ip \u003d connection_properties[\u0027hostIP\u0027]"},{"line_number":269,"context_line":"        # handle deprecated parameters for backward compatibility"},{"line_number":270,"context_line":"        d_option_used \u003d False"},{"line_number":271,"context_line":"        try:"},{"line_number":272,"context_line":"            self.volume_name \u003d connection_properties[\u0027vxflexos_volname\u0027]"},{"line_number":273,"context_line":"        except KeyError:"},{"line_number":274,"context_line":"            self.volume_name \u003d connection_properties[\u0027scaleIO_volname\u0027]"},{"line_number":275,"context_line":"            d_option_used \u003d True"},{"line_number":276,"context_line":"        try:"},{"line_number":277,"context_line":"            self.volume_id \u003d connection_properties[\u0027vxflexos_volume_id\u0027]"},{"line_number":278,"context_line":"        except KeyError:"},{"line_number":279,"context_line":"            self.volume_id \u003d connection_properties.get(\u0027scaleIO_volume_id\u0027)"},{"line_number":280,"context_line":"            d_option_used \u003d True"},{"line_number":281,"context_line":"        if d_option_used:"},{"line_number":282,"context_line":"            LOG.warning(\"Deprecated: scaleIO_volname and scaleIO_volume_id \""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_ada83d77","line":279,"range":{"start_line":271,"start_character":8,"end_line":279,"end_character":75},"in_reply_to":"5fc1f717_8def81e8","updated":"2019-03-05 17:35:17.000000000","message":"It probably should, but this is a very specific fix and I don’t know if other code paths can handle null values properly. Ideally someone would follow up on this patch to make this code path more robust.","commit_id":"6b60614afaf88819ce92a2d0ed269035a3c8b261"},{"author":{"_account_id":29675,"name":"Yury Kulazhenkov","email":"kulazhenkov@gmail.com","username":"yury-kulaz"},"change_message_id":"9914860b1c56ba2690e15b1ba7361e4d79f868b7","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        self.local_sdc_ip \u003d connection_properties[\u0027hostIP\u0027]"},{"line_number":269,"context_line":"        # handle deprecated parameters for backward compatibility"},{"line_number":270,"context_line":"        d_option_used \u003d False"},{"line_number":271,"context_line":"        try:"},{"line_number":272,"context_line":"            self.volume_name \u003d connection_properties[\u0027vxflexos_volname\u0027]"},{"line_number":273,"context_line":"        except KeyError:"},{"line_number":274,"context_line":"            self.volume_name \u003d connection_properties[\u0027scaleIO_volname\u0027]"},{"line_number":275,"context_line":"            d_option_used \u003d True"},{"line_number":276,"context_line":"        try:"},{"line_number":277,"context_line":"            self.volume_id \u003d connection_properties[\u0027vxflexos_volume_id\u0027]"},{"line_number":278,"context_line":"        except KeyError:"},{"line_number":279,"context_line":"            self.volume_id \u003d connection_properties.get(\u0027scaleIO_volume_id\u0027)"},{"line_number":280,"context_line":"            d_option_used \u003d True"},{"line_number":281,"context_line":"        if d_option_used:"},{"line_number":282,"context_line":"            LOG.warning(\"Deprecated: scaleIO_volname and scaleIO_volume_id \""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_d60c3a44","line":279,"range":{"start_line":271,"start_character":8,"end_line":279,"end_character":75},"in_reply_to":"5fc1f717_ada83d77","updated":"2019-03-05 20:16:24.000000000","message":"The VxFlex OS connector can handle None value only for volume_id option.  There is no need to change other options because they are strictly required, so it will be better to fail right here with KeyError rather than continue with None values.","commit_id":"6b60614afaf88819ce92a2d0ed269035a3c8b261"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3a1bb7bbd26fa1217da25e715b12e1a050d0a2e4","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        self.local_sdc_ip \u003d connection_properties[\u0027hostIP\u0027]"},{"line_number":269,"context_line":"        # handle deprecated parameters for backward compatibility"},{"line_number":270,"context_line":"        d_option_used \u003d False"},{"line_number":271,"context_line":"        try:"},{"line_number":272,"context_line":"            self.volume_name \u003d connection_properties[\u0027vxflexos_volname\u0027]"},{"line_number":273,"context_line":"        except KeyError:"},{"line_number":274,"context_line":"            self.volume_name \u003d connection_properties[\u0027scaleIO_volname\u0027]"},{"line_number":275,"context_line":"            d_option_used \u003d True"},{"line_number":276,"context_line":"        try:"},{"line_number":277,"context_line":"            self.volume_id \u003d connection_properties[\u0027vxflexos_volume_id\u0027]"},{"line_number":278,"context_line":"        except KeyError:"},{"line_number":279,"context_line":"            self.volume_id \u003d connection_properties.get(\u0027scaleIO_volume_id\u0027)"},{"line_number":280,"context_line":"            d_option_used \u003d True"},{"line_number":281,"context_line":"        if d_option_used:"},{"line_number":282,"context_line":"            LOG.warning(\"Deprecated: scaleIO_volname and scaleIO_volume_id \""}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_106cf434","line":279,"range":{"start_line":271,"start_character":8,"end_line":279,"end_character":75},"in_reply_to":"5fc1f717_d60c3a44","updated":"2019-03-06 14:17:35.000000000","message":"We should not fail with a KeyError, that should be correctly handled by raising a correct OSBrickException.","commit_id":"6b60614afaf88819ce92a2d0ed269035a3c8b261"}]}
