)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"691e8f55ce449b17c4508f1fb6666eb5081ba4eb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"works as expected when OS-Brick is the only managing the iSCSI"},{"line_number":11,"context_line":"sessions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"On drivers that share the targets we will have problems if we manually"},{"line_number":14,"context_line":"set the target/portal before Cinder/Nova have attached a volume and we"},{"line_number":15,"context_line":"use the FQDN for the portal instead of an static IP."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The problem is that the iSCSI initiator will reuse the session it"},{"line_number":18,"context_line":"already has but OS-Brick will not be able to find the session, because"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_23005eab","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":52},"updated":"2019-03-12 09:56:32.000000000","message":"Can you give bit of detail, which driver? what is the usecase? do we really support that?","commit_id":"6cb3bd9699b257447fd53ea0ca3bb3c30beebb86"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"9377f0e153863b755d6b9fc710042e22188f394c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d0cd7df5_3e59a51c","updated":"2022-08-18 00:53:20.000000000","message":"I agree that the explanation of the situation is a little lacking. It is copied from the bug, which is similarly concise.\nhttps://bugs.launchpad.net/os-brick/+bug/1819472","commit_id":"1f06fbca4d3096888a4548521d6a84df82bdaef5"}],"os_brick/initiator/connectors/iscsi.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"691e8f55ce449b17c4508f1fb6666eb5081ba4eb","unresolved":false,"context_lines":[{"line_number":1028,"context_line":"                return s[1]"},{"line_number":1029,"context_line":""},{"line_number":1030,"context_line":"        if exhaustive:"},{"line_number":1031,"context_line":"            addr, port \u003d portal.split(\u0027:\u0027)"},{"line_number":1032,"context_line":"            try:"},{"line_number":1033,"context_line":"                socket.inet_aton(addr)"},{"line_number":1034,"context_line":"                # Portal may be added out of OS-Brick using the FQDN and driver"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_40f80048","line":1031,"range":{"start_line":1031,"start_character":12,"end_line":1031,"end_character":42},"updated":"2019-03-12 09:56:32.000000000","message":"This is probably not going to work for ipv6","commit_id":"6cb3bd9699b257447fd53ea0ca3bb3c30beebb86"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"691e8f55ce449b17c4508f1fb6666eb5081ba4eb","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"                                  \"node.session.auth.password\","},{"line_number":1099,"context_line":"                                  connection_properties[\u0027auth_password\u0027])"},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"        # Duplicate logins crash iscsiadm after load, so we scan active"},{"line_number":1102,"context_line":"        # sessions to see if the node is logged in."},{"line_number":1103,"context_line":"        session \u003d self._get_session(portal, target_iqn)"},{"line_number":1104,"context_line":"        err_code \u003d \u0027\u0027"},{"line_number":1105,"context_line":"        if session is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_83c4b292","line":1102,"range":{"start_line":1101,"start_character":8,"end_line":1102,"end_character":51},"updated":"2019-03-12 09:56:32.000000000","message":"So you removed the loop but it seems that has been added for some reason. Basically if you want to change the logic I would recommend to do that in a specific commit. So we can discuss of it.","commit_id":"6cb3bd9699b257447fd53ea0ca3bb3c30beebb86"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"691e8f55ce449b17c4508f1fb6666eb5081ba4eb","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"                         \u0027err\u0027: err_code})"},{"line_number":1123,"context_line":"            return None, None"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"        # We want the session to always be automatic, even if someone outside"},{"line_number":1126,"context_line":"        # of OS-Brick created it and didn\u0027t set it to automatic."},{"line_number":1127,"context_line":"        self._iscsiadm_update(connection_properties,"},{"line_number":1128,"context_line":"                              \"node.startup\","},{"line_number":1129,"context_line":"                              \"automatic\")"},{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"        return session, manual_scan"},{"line_number":1132,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_a30c4eec","line":1129,"range":{"start_line":1125,"start_character":0,"end_line":1129,"end_character":42},"updated":"2019-03-12 09:56:32.000000000","message":"This should be proposed in a separate commit. So you can provide details of why now we want automatic discovery at startup.","commit_id":"6cb3bd9699b257447fd53ea0ca3bb3c30beebb86"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"9377f0e153863b755d6b9fc710042e22188f394c","unresolved":true,"context_lines":[{"line_number":1028,"context_line":"                return s[1]"},{"line_number":1029,"context_line":""},{"line_number":1030,"context_line":"        if exhaustive:"},{"line_number":1031,"context_line":"            addr, port \u003d portal.split(\u0027:\u0027)"},{"line_number":1032,"context_line":"            try:"},{"line_number":1033,"context_line":"                socket.inet_aton(addr)"},{"line_number":1034,"context_line":"                # Portal may be added out of OS-Brick using the FQDN and driver"}],"source_content_type":"text/x-python","patch_set":2,"id":"b71ec0ce_884bd840","line":1031,"updated":"2022-08-18 00:53:20.000000000","message":"This does not work with IPv6, apparently. They use [a:b::c]:port for addresses.","commit_id":"1f06fbca4d3096888a4548521d6a84df82bdaef5"}]}