)]}'
{"os_brick/initiator/linuxscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8a6f0cabdb3b2bd8e050380f318b51ff9fd72010","unresolved":false,"context_lines":[{"line_number":445,"context_line":"            lines \u003d out.strip()"},{"line_number":446,"context_line":"            lines \u003d lines.split(\"\\n\")"},{"line_number":447,"context_line":"            lines \u003d [line for line in lines"},{"line_number":448,"context_line":"                     if not re.match(MULTIPATH_ERROR_REGEX, line)"},{"line_number":449,"context_line":"                     and len(line)]"},{"line_number":450,"context_line":"            if lines:"},{"line_number":451,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_c1e0adcf","line":448,"updated":"2019-04-15 16:24:15.000000000","message":"Keeping \"and\" at the end of the line is still more readable and it\u0027s immediately obvious there is more. I\u0027d rather keep trailing conditions like this.","commit_id":"babc544a460fb5b5040581502f248a8666819385"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"60e5584c5e4b20faf119825e624b37f745c274af","unresolved":false,"context_lines":[{"line_number":445,"context_line":"            lines \u003d out.strip()"},{"line_number":446,"context_line":"            lines \u003d lines.split(\"\\n\")"},{"line_number":447,"context_line":"            lines \u003d [line for line in lines"},{"line_number":448,"context_line":"                     if not re.match(MULTIPATH_ERROR_REGEX, line)"},{"line_number":449,"context_line":"                     and len(line)]"},{"line_number":450,"context_line":"            if lines:"},{"line_number":451,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_9d2b0593","line":448,"in_reply_to":"3fce034c_a1c7a112","updated":"2019-04-23 15:11:22.000000000","message":"I\u0027m just reverting it back to how it was, I\u0027ll worry about forming an opinion on all this later. :)","commit_id":"babc544a460fb5b5040581502f248a8666819385"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"595ccba0d01765d5697c94a5b01b0a3ba7589e7f","unresolved":false,"context_lines":[{"line_number":445,"context_line":"            lines \u003d out.strip()"},{"line_number":446,"context_line":"            lines \u003d lines.split(\"\\n\")"},{"line_number":447,"context_line":"            lines \u003d [line for line in lines"},{"line_number":448,"context_line":"                     if not re.match(MULTIPATH_ERROR_REGEX, line)"},{"line_number":449,"context_line":"                     and len(line)]"},{"line_number":450,"context_line":"            if lines:"},{"line_number":451,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_a1c7a112","line":448,"in_reply_to":"3fce034c_c1e0adcf","updated":"2019-04-15 16:31:12.000000000","message":"This is going to be the source of much controversy!","commit_id":"babc544a460fb5b5040581502f248a8666819385"}],"tox.ini":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"595ccba0d01765d5697c94a5b01b0a3ba7589e7f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"# reason: pep8 itself is not sure about this one and"},{"line_number":89,"context_line":"#  reversed this rule in 2016"},{"line_number":90,"context_line":"show-source \u003d True"},{"line_number":91,"context_line":"ignore \u003d E251,W503"},{"line_number":92,"context_line":"enable-extensions\u003dH106,H203,H204,H205"},{"line_number":93,"context_line":"builtins \u003d _"},{"line_number":94,"context_line":"exclude\u003d.venv,.git,.tox,dist,*lib/python*,*egg,build"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fce034c_a179e1fc","line":91,"updated":"2019-04-15 16:31:12.000000000","message":"I thought both W503 and W504 were off by default in recent flake8?  I guess W503 wasn\u0027t disabled in the version you were working with or you wouldn\u0027t have included the ignore here.  I wonder if we should explicitly disable them both so we don\u0027t get random failures based on what flake8 happens to be installed at the time.\n\n(For the record, I am pro-W504 and am very happy to see W503 go.)","commit_id":"babc544a460fb5b5040581502f248a8666819385"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6af886fd41c8a0da6f1c6b65ffdbcd13bcfe5409","unresolved":false,"context_lines":[{"line_number":88,"context_line":"# reason: pep8 itself is not sure about this one and"},{"line_number":89,"context_line":"#  reversed this rule in 2016"},{"line_number":90,"context_line":"show-source \u003d True"},{"line_number":91,"context_line":"ignore \u003d E251,W503"},{"line_number":92,"context_line":"enable-extensions\u003dH106,H203,H204,H205"},{"line_number":93,"context_line":"builtins \u003d _"},{"line_number":94,"context_line":"exclude\u003d.venv,.git,.tox,dist,*lib/python*,*egg,build"}],"source_content_type":"text/x-properties","patch_set":1,"id":"ffb9cba7_48a069f5","line":91,"in_reply_to":"3fce034c_a179e1fc","updated":"2019-04-23 15:15:26.000000000","message":"They\u0027re both off by default in flake8 3.7.6+.\n\nWe seem to still run 2.6.2.","commit_id":"babc544a460fb5b5040581502f248a8666819385"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a1de3d07fbe05d579e44da11920bff13cfbc252b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"# reason: pep8 itself is not sure about this one and"},{"line_number":89,"context_line":"#  reversed this rule in 2016"},{"line_number":90,"context_line":"show-source \u003d True"},{"line_number":91,"context_line":"ignore \u003d E251,W503"},{"line_number":92,"context_line":"enable-extensions\u003dH106,H203,H204,H205"},{"line_number":93,"context_line":"builtins \u003d _"},{"line_number":94,"context_line":"exclude\u003d.venv,.git,.tox,dist,*lib/python*,*egg,build"}],"source_content_type":"text/x-properties","patch_set":1,"id":"ffb9cba7_559f6f5e","line":91,"in_reply_to":"ffb9cba7_48a069f5","updated":"2019-04-25 17:48:03.000000000","message":"I think we should also disable W504 for now.  The docs say that both 503 and 504 are off by default in 2.6.0 -- but someone must have made a change to turn 503 on in 2.6.2.  It would be good to not have to worry about whether someone\u0027s made a similar change in 2.6.3 ... 3.7.5 with 504.  I think a lot of our code would suddenly fail.","commit_id":"babc544a460fb5b5040581502f248a8666819385"}]}