)]}'
{"os_brick/initiator/linuxfc.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ca18f5fbaf9492a77a609364ce51d5626b803b0f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        granted permission to connect."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        For drivers that don\u0027t return an initiator to target map we try to find"},{"line_number":45,"context_line":"        the info for all the target ports."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        For drivers that return an initiator_target_map we use the"},{"line_number":48,"context_line":"        initiator_target_lun_map entry that was generated by the FC connector"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_285187da","line":45,"updated":"2019-11-07 15:52:15.000000000","message":"Cinder has drivers that don\u0027t return the initiator_target_map?\nThat\u0027s not good as they will never work with the Fiber Channel Zone manager to auto zone connections.","commit_id":"500907e130ddf4f558d865f4e890b555fa0b380e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0bfc1f765f9544fe84c724d919a48c0e4664457e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        granted permission to connect."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        For drivers that don\u0027t return an initiator to target map we try to find"},{"line_number":45,"context_line":"        the info for all the target ports."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        For drivers that return an initiator_target_map we use the"},{"line_number":48,"context_line":"        initiator_target_lun_map entry that was generated by the FC connector"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_55bc7d05","line":45,"in_reply_to":"3fa7e38b_285187da","updated":"2019-11-11 14:48:43.000000000","message":"We have at least some that return None: https://bugs.launchpad.net/os-brick/+bug/1746218","commit_id":"500907e130ddf4f558d865f4e890b555fa0b380e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"308673a7412257c7b6e410515d51c40f7fa11992","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        based on the contents of the connection information data to know which"},{"line_number":50,"context_line":"        target ports to look for."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        :returns: 2-Tuple with the first entry being a lists of [c, t, l]"},{"line_number":53,"context_line":"        entries where the target port was found, and the second entry of the"},{"line_number":54,"context_line":"        tuple being a set of luns for ports that were not found."},{"line_number":55,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_09727bae","line":52,"range":{"start_line":52,"start_character":59,"end_line":52,"end_character":60},"updated":"2019-11-11 04:31:37.000000000","message":"I think this should be \"list\".","commit_id":"500907e130ddf4f558d865f4e890b555fa0b380e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0bfc1f765f9544fe84c724d919a48c0e4664457e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        based on the contents of the connection information data to know which"},{"line_number":50,"context_line":"        target ports to look for."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        :returns: 2-Tuple with the first entry being a lists of [c, t, l]"},{"line_number":53,"context_line":"        entries where the target port was found, and the second entry of the"},{"line_number":54,"context_line":"        tuple being a set of luns for ports that were not found."},{"line_number":55,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b544d11a","line":52,"range":{"start_line":52,"start_character":59,"end_line":52,"end_character":60},"in_reply_to":"3fa7e38b_09727bae","updated":"2019-11-11 14:48:43.000000000","message":"Done","commit_id":"500907e130ddf4f558d865f4e890b555fa0b380e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"308673a7412257c7b6e410515d51c40f7fa11992","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        # present for this hba or default to targets if not present."},{"line_number":58,"context_line":"        targets \u003d conn_props[\u0027targets\u0027]"},{"line_number":59,"context_line":"        if conn_props.get(\u0027initiator_target_map\u0027) is not None:"},{"line_number":60,"context_line":"            # This map we try to use was generaged by the FC connector"},{"line_number":61,"context_line":"            targets \u003d conn_props[\u0027initiator_target_lun_map\u0027].get("},{"line_number":62,"context_line":"                hba[\u0027port_name\u0027], targets)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a966c7ed","line":60,"range":{"start_line":60,"start_character":47,"end_line":60,"end_character":48},"updated":"2019-11-11 04:31:37.000000000","message":"should be \u0027t\u0027.","commit_id":"500907e130ddf4f558d865f4e890b555fa0b380e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0bfc1f765f9544fe84c724d919a48c0e4664457e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        # present for this hba or default to targets if not present."},{"line_number":58,"context_line":"        targets \u003d conn_props[\u0027targets\u0027]"},{"line_number":59,"context_line":"        if conn_props.get(\u0027initiator_target_map\u0027) is not None:"},{"line_number":60,"context_line":"            # This map we try to use was generaged by the FC connector"},{"line_number":61,"context_line":"            targets \u003d conn_props[\u0027initiator_target_lun_map\u0027].get("},{"line_number":62,"context_line":"                hba[\u0027port_name\u0027], targets)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_5551ddd8","line":60,"range":{"start_line":60,"start_character":47,"end_line":60,"end_character":48},"in_reply_to":"3fa7e38b_a966c7ed","updated":"2019-11-11 14:48:43.000000000","message":"Done","commit_id":"500907e130ddf4f558d865f4e890b555fa0b380e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"308673a7412257c7b6e410515d51c40f7fa11992","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                LOG.debug(\u0027Could not get HBA channel and SCSI target ID, path:\u0027"},{"line_number":82,"context_line":"                          \u0027 %(path)s*, reason: %(reason)s\u0027, {\u0027path\u0027: path,"},{"line_number":83,"context_line":"                                                             \u0027reason\u0027: exc})"},{"line_number":84,"context_line":"                # If we didn\u0027t find any paths just give back wildcards for"},{"line_number":85,"context_line":"                # the channel and target ids as part of the not found list."},{"line_number":86,"context_line":"                luns_not_found.add(lun)"},{"line_number":87,"context_line":"        return ctls, luns_not_found"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6f452fb4","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":75},"updated":"2019-11-11 04:31:37.000000000","message":"This comment doesn\u0027t seem accurate any more since you aren\u0027t actually creating the wildcard ctls until line 134 in rescan_hosts().","commit_id":"500907e130ddf4f558d865f4e890b555fa0b380e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0bfc1f765f9544fe84c724d919a48c0e4664457e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                LOG.debug(\u0027Could not get HBA channel and SCSI target ID, path:\u0027"},{"line_number":82,"context_line":"                          \u0027 %(path)s*, reason: %(reason)s\u0027, {\u0027path\u0027: path,"},{"line_number":83,"context_line":"                                                             \u0027reason\u0027: exc})"},{"line_number":84,"context_line":"                # If we didn\u0027t find any paths just give back wildcards for"},{"line_number":85,"context_line":"                # the channel and target ids as part of the not found list."},{"line_number":86,"context_line":"                luns_not_found.add(lun)"},{"line_number":87,"context_line":"        return ctls, luns_not_found"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9570b575","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":75},"in_reply_to":"3fa7e38b_6f452fb4","updated":"2019-11-11 14:48:43.000000000","message":"Done","commit_id":"500907e130ddf4f558d865f4e890b555fa0b380e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"308673a7412257c7b6e410515d51c40f7fa11992","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        get_ctls \u003d self._get_hba_channel_scsi_target_lun"},{"line_number":118,"context_line":"        for hba in hbas:"},{"line_number":119,"context_line":"            ctls, luns_wildcards \u003d get_ctls(hba, connection_properties)"},{"line_number":120,"context_line":"            # If we found the target ports, ignore HBAs that din\u0027t found them"},{"line_number":121,"context_line":"            if ctls:"},{"line_number":122,"context_line":"                process.append((hba, ctls))"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6f1e8fbc","line":120,"range":{"start_line":120,"start_character":61,"end_line":120,"end_character":72},"updated":"2019-11-11 04:31:37.000000000","message":"didn\u0027t find","commit_id":"500907e130ddf4f558d865f4e890b555fa0b380e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0bfc1f765f9544fe84c724d919a48c0e4664457e","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        get_ctls \u003d self._get_hba_channel_scsi_target_lun"},{"line_number":118,"context_line":"        for hba in hbas:"},{"line_number":119,"context_line":"            ctls, luns_wildcards \u003d get_ctls(hba, connection_properties)"},{"line_number":120,"context_line":"            # If we found the target ports, ignore HBAs that din\u0027t found them"},{"line_number":121,"context_line":"            if ctls:"},{"line_number":122,"context_line":"                process.append((hba, ctls))"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b56db19a","line":120,"range":{"start_line":120,"start_character":61,"end_line":120,"end_character":72},"in_reply_to":"3fa7e38b_6f1e8fbc","updated":"2019-11-11 14:48:43.000000000","message":"Done","commit_id":"500907e130ddf4f558d865f4e890b555fa0b380e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6b0f88b2ff8f73e1af36858774cfc5bff02553af","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        get_ctls \u003d self._get_hba_channel_scsi_target_lun"},{"line_number":117,"context_line":"        for hba in hbas:"},{"line_number":118,"context_line":"            ctls, luns_wildcards \u003d get_ctls(hba, connection_properties)"},{"line_number":119,"context_line":"            # If we found the target ports, ignore HBAs that din\u0027t find them"},{"line_number":120,"context_line":"            if ctls:"},{"line_number":121,"context_line":"                process.append((hba, ctls))"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_2f963040","line":119,"range":{"start_line":119,"start_character":61,"end_line":119,"end_character":64},"updated":"2019-11-13 17:32:10.000000000","message":"didn\u0027t","commit_id":"708733e49598145eb8e898d486723dc3df00a52f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bb821ee30f07ff63199706cdb5feedb3675f072b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        get_ctls \u003d self._get_hba_channel_scsi_target_lun"},{"line_number":117,"context_line":"        for hba in hbas:"},{"line_number":118,"context_line":"            ctls, luns_wildcards \u003d get_ctls(hba, connection_properties)"},{"line_number":119,"context_line":"            # If we found the target ports, ignore HBAs that din\u0027t find them"},{"line_number":120,"context_line":"            if ctls:"},{"line_number":121,"context_line":"                process.append((hba, ctls))"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_b6c3548a","line":119,"range":{"start_line":119,"start_character":61,"end_line":119,"end_character":64},"in_reply_to":"3fa7e38b_2f963040","updated":"2019-11-13 21:34:47.000000000","message":"Thanks, I\u0027ll fix it if I upload another patch.","commit_id":"708733e49598145eb8e898d486723dc3df00a52f"}],"os_brick/tests/initiator/test_linuxfc.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"308673a7412257c7b6e410515d51c40f7fa11992","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        get_chan_results \u003d [([], {1}), ([], {1})]"},{"line_number":377,"context_line":"        hbas, con_props \u003d self.__get_rescan_info(zone_manager\u003dTrue)"},{"line_number":378,"context_line":"        # Remove the initiator map"},{"line_number":379,"context_line":"        con_props.pop(\u0027initiator_target_map\u0027)"},{"line_number":380,"context_line":"        con_props.pop(\u0027initiator_target_lun_map\u0027)"},{"line_number":381,"context_line":"        con_props[\u0027enable_wildcard_scan\u0027] \u003d False"},{"line_number":382,"context_line":"        with mock.patch.object(self.lfc, \u0027_get_hba_channel_scsi_target_lun\u0027,"},{"line_number":383,"context_line":"                               side_effect\u003dget_chan_results), \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_4f1633aa","line":380,"range":{"start_line":379,"start_character":0,"end_line":380,"end_character":49},"updated":"2019-11-11 04:31:37.000000000","message":"Is there a reason why you\u0027re not simply setting zone_manager\u003dFalse at line 377?  (This is also done in the previous test.)","commit_id":"500907e130ddf4f558d865f4e890b555fa0b380e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0bfc1f765f9544fe84c724d919a48c0e4664457e","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        get_chan_results \u003d [([], {1}), ([], {1})]"},{"line_number":377,"context_line":"        hbas, con_props \u003d self.__get_rescan_info(zone_manager\u003dTrue)"},{"line_number":378,"context_line":"        # Remove the initiator map"},{"line_number":379,"context_line":"        con_props.pop(\u0027initiator_target_map\u0027)"},{"line_number":380,"context_line":"        con_props.pop(\u0027initiator_target_lun_map\u0027)"},{"line_number":381,"context_line":"        con_props[\u0027enable_wildcard_scan\u0027] \u003d False"},{"line_number":382,"context_line":"        with mock.patch.object(self.lfc, \u0027_get_hba_channel_scsi_target_lun\u0027,"},{"line_number":383,"context_line":"                               side_effect\u003dget_chan_results), \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_fa3c78e2","line":380,"range":{"start_line":379,"start_character":0,"end_line":380,"end_character":49},"in_reply_to":"3fa7e38b_4f1633aa","updated":"2019-11-11 14:48:43.000000000","message":"True, I don\u0027t think it\u0027s necessary for this test.","commit_id":"500907e130ddf4f558d865f4e890b555fa0b380e"}]}