)]}'
{"os_brick/tests/initiator/connectors/test_iscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"915ef013461f5feb70b32710e558e244fbeb798d","unresolved":false,"context_lines":[{"line_number":1591,"context_line":"        self.assertRaises(exception.VolumeDeviceNotFound,"},{"line_number":1592,"context_line":"                          self.connector._get_device_link,"},{"line_number":1593,"context_line":"                          \u0027wwn\u0027, \u0027/dev/sda\u0027, None)"},{"line_number":1594,"context_line":"        listdir_mock.assert_has_calls(["},{"line_number":1595,"context_line":"            mock.call(\u0027/dev/disk/by-id/\u0027),"},{"line_number":1596,"context_line":"            mock.call(\u0027/dev/disk/by-id/\u0027),"},{"line_number":1597,"context_line":"            mock.call(\u0027/dev/disk/by-id/\u0027)])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_699a0f70","line":1594,"updated":"2019-11-29 11:53:47.000000000","message":"-1: We need to check the number of calls, because afaik assert_has_calls would be OK if there were even 4 calls.","commit_id":"b28b7303b7969e265f692610587c414459112c11"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"915ef013461f5feb70b32710e558e244fbeb798d","unresolved":false,"context_lines":[{"line_number":1592,"context_line":"                          self.connector._get_device_link,"},{"line_number":1593,"context_line":"                          \u0027wwn\u0027, \u0027/dev/sda\u0027, None)"},{"line_number":1594,"context_line":"        listdir_mock.assert_has_calls(["},{"line_number":1595,"context_line":"            mock.call(\u0027/dev/disk/by-id/\u0027),"},{"line_number":1596,"context_line":"            mock.call(\u0027/dev/disk/by-id/\u0027),"},{"line_number":1597,"context_line":"            mock.call(\u0027/dev/disk/by-id/\u0027)])"},{"line_number":1598,"context_line":"        realpath_mock.assert_has_calls(["},{"line_number":1599,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-wwn\u0027),"},{"line_number":1600,"context_line":"            mock.call(\u0027/dev/disk/by-id/dm-...\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c9c8e376","line":1597,"range":{"start_line":1595,"start_character":0,"end_line":1597,"end_character":43},"updated":"2019-11-29 11:53:47.000000000","message":"nit: Clearer:\n\n  listdir_mock.assert_has_calls(3 * [mock.call(\u0027/dev/disk/by-id/\u0027)])","commit_id":"b28b7303b7969e265f692610587c414459112c11"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"915ef013461f5feb70b32710e558e244fbeb798d","unresolved":false,"context_lines":[{"line_number":1595,"context_line":"            mock.call(\u0027/dev/disk/by-id/\u0027),"},{"line_number":1596,"context_line":"            mock.call(\u0027/dev/disk/by-id/\u0027),"},{"line_number":1597,"context_line":"            mock.call(\u0027/dev/disk/by-id/\u0027)])"},{"line_number":1598,"context_line":"        realpath_mock.assert_has_calls(["},{"line_number":1599,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-wwn\u0027),"},{"line_number":1600,"context_line":"            mock.call(\u0027/dev/disk/by-id/dm-...\u0027),"},{"line_number":1601,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-...\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_e97fdf14","line":1598,"updated":"2019-11-29 11:53:47.000000000","message":"nit: Count number of calls","commit_id":"b28b7303b7969e265f692610587c414459112c11"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"915ef013461f5feb70b32710e558e244fbeb798d","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"            mock.call(\u0027/dev/disk/by-id/\u0027),"},{"line_number":1597,"context_line":"            mock.call(\u0027/dev/disk/by-id/\u0027)])"},{"line_number":1598,"context_line":"        realpath_mock.assert_has_calls(["},{"line_number":1599,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-wwn\u0027),"},{"line_number":1600,"context_line":"            mock.call(\u0027/dev/disk/by-id/dm-...\u0027),"},{"line_number":1601,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-...\u0027),"},{"line_number":1602,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-wwn\u0027),"},{"line_number":1603,"context_line":"            mock.call(\u0027/dev/disk/by-id/dm-...\u0027),"},{"line_number":1604,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-...\u0027),"},{"line_number":1605,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-wwn\u0027),"},{"line_number":1606,"context_line":"            mock.call(\u0027/dev/disk/by-id/dm-...\u0027),"},{"line_number":1607,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-...\u0027)])"},{"line_number":1608,"context_line":""},{"line_number":1609,"context_line":"    @mock.patch(\u0027time.sleep\u0027)"},{"line_number":1610,"context_line":"    @mock.patch(\u0027os.path.realpath\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c976a340","line":1607,"range":{"start_line":1599,"start_character":0,"end_line":1607,"end_character":51},"updated":"2019-11-29 11:53:47.000000000","message":"nit: Cleaner\n\n        realpath_mock.assert_has_calls(3 * [\n            mock.call(\u0027/dev/disk/by-id/scsi-wwn\u0027),\n            mock.call(\u0027/dev/disk/by-id/dm-...\u0027),\n            mock.call(\u0027/dev/disk/by-id/scsi-...\u0027)])","commit_id":"b28b7303b7969e265f692610587c414459112c11"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"915ef013461f5feb70b32710e558e244fbeb798d","unresolved":false,"context_lines":[{"line_number":1620,"context_line":"        self.connector._get_device_link(\u0027wwn\u0027, \u0027/dev/sda\u0027, None)"},{"line_number":1621,"context_line":""},{"line_number":1622,"context_line":"        # Assert that listdir and realpath have been called correctly"},{"line_number":1623,"context_line":"        mock_listdir.assert_has_calls(["},{"line_number":1624,"context_line":"            mock.call(\u0027/dev/disk/by-id/\u0027),"},{"line_number":1625,"context_line":"            mock.call(\u0027/dev/disk/by-id/\u0027)])"},{"line_number":1626,"context_line":"        mock_realpath.assert_has_calls(["},{"line_number":1627,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-wwn\u0027),"},{"line_number":1628,"context_line":"            mock.call(\u0027/dev/disk/by-id/dm-...\u0027),"},{"line_number":1629,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-...\u0027),"},{"line_number":1630,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-wwn\u0027),"},{"line_number":1631,"context_line":"            mock.call(\u0027/dev/disk/by-id/dm-...\u0027),"},{"line_number":1632,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-...\u0027),"},{"line_number":1633,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-wwn\u0027)])"},{"line_number":1634,"context_line":""},{"line_number":1635,"context_line":"    @mock.patch(\u0027time.sleep\u0027)"},{"line_number":1636,"context_line":"    @mock.patch(\u0027os.path.realpath\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_298bb717","line":1633,"range":{"start_line":1623,"start_character":0,"end_line":1633,"end_character":51},"updated":"2019-11-29 11:53:47.000000000","message":"-1: Same as above, count calls.\nnit: Use * as mentioned above","commit_id":"b28b7303b7969e265f692610587c414459112c11"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"915ef013461f5feb70b32710e558e244fbeb798d","unresolved":false,"context_lines":[{"line_number":1635,"context_line":"    @mock.patch(\u0027time.sleep\u0027)"},{"line_number":1636,"context_line":"    @mock.patch(\u0027os.path.realpath\u0027)"},{"line_number":1637,"context_line":"    @mock.patch(\u0027os.listdir\u0027, return_value\u003d[\u0027dm-...\u0027, \u0027scsi-...\u0027])"},{"line_number":1638,"context_line":"    def test__get_device_link_symlink_found_after_retry_by_listdir("},{"line_number":1639,"context_line":"            self, mock_listdir, mock_realpath, mock_time):"},{"line_number":1640,"context_line":""},{"line_number":1641,"context_line":"        # Return the expected realpath on the second retry while looping over"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_69c1af2f","line":1638,"updated":"2019-11-29 11:53:47.000000000","message":"I don\u0027t really think we need both the previous test and this one, having just one should be enough...  But I\u0027m OK leaving both.","commit_id":"b28b7303b7969e265f692610587c414459112c11"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"915ef013461f5feb70b32710e558e244fbeb798d","unresolved":false,"context_lines":[{"line_number":1647,"context_line":"        self.connector._get_device_link(\u0027wwn\u0027, \u0027/dev/sda\u0027, None)"},{"line_number":1648,"context_line":""},{"line_number":1649,"context_line":"        # Assert that listdir and realpath have been called correctly"},{"line_number":1650,"context_line":"        mock_listdir.assert_has_calls(["},{"line_number":1651,"context_line":"            mock.call(\u0027/dev/disk/by-id/\u0027),"},{"line_number":1652,"context_line":"            mock.call(\u0027/dev/disk/by-id/\u0027)])"},{"line_number":1653,"context_line":"        mock_realpath.assert_has_calls(["},{"line_number":1654,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-wwn\u0027),"},{"line_number":1655,"context_line":"            mock.call(\u0027/dev/disk/by-id/dm-...\u0027),"},{"line_number":1656,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-...\u0027),"},{"line_number":1657,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-wwn\u0027),"},{"line_number":1658,"context_line":"            mock.call(\u0027/dev/disk/by-id/dm-...\u0027),"},{"line_number":1659,"context_line":"            mock.call(\u0027/dev/disk/by-id/scsi-...\u0027)])"},{"line_number":1660,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a9c7a746","line":1657,"range":{"start_line":1650,"start_character":0,"end_line":1657,"end_character":50},"updated":"2019-11-29 11:53:47.000000000","message":"-1: Same as above, count calls.\nnit: Use * as mentioned above","commit_id":"b28b7303b7969e265f692610587c414459112c11"}]}