)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"8ebdfe96fa70db6e15b81584163a96ab11f3c081","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Found whilst testing cinder-backup with ceph on Ubuntu focal and"},{"line_number":10,"context_line":"OpenStack Ussuri.  Focal installs Ceph Octopus, and, as the linked bug"},{"line_number":11,"context_line":"shows, Octopus has slightly changed its requirements to need a"},{"line_number":12,"context_line":"[general] ini heading at the beginning of the config file that is"},{"line_number":13,"context_line":"generated within the RBDConnector() class."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Includes code to resolve which version of ceph is installed as a client"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f560f44_efcc1c8c","line":12,"range":{"start_line":12,"start_character":1,"end_line":12,"end_character":8},"updated":"2020-08-28 14:41:13.000000000","message":"According to docs [1], it should be \u0027global\u0027, not \u0027general\u0027\n\n[1] https://docs.ceph.com/docs/octopus/rados/configuration/common/#example-ceph-conf","commit_id":"105119ee4284876b7704656b010880200223eb6f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6297762a40586379e05221176184c120c5962be7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Found whilst testing cinder-backup with ceph on Ubuntu focal and"},{"line_number":10,"context_line":"OpenStack Ussuri.  Focal installs Ceph Octopus, and, as the linked bug"},{"line_number":11,"context_line":"shows, Octopus has slightly changed its requirements to need a"},{"line_number":12,"context_line":"[general] ini heading at the beginning of the config file that is"},{"line_number":13,"context_line":"generated within the RBDConnector() class."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Includes code to resolve which version of ceph is installed as a client"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f560f44_4f1f03b7","line":12,"range":{"start_line":12,"start_character":1,"end_line":12,"end_character":8},"in_reply_to":"9f560f44_efcc1c8c","updated":"2020-08-28 19:04:02.000000000","message":"Thanks, Ivan.  The bug report says \u0027[global]\u0027 also:\nhttps://bugs.launchpad.net/tripleo/+bug/1865754/comments/2","commit_id":"105119ee4284876b7704656b010880200223eb6f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"8ebdfe96fa70db6e15b81584163a96ab11f3c081","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Includes code to resolve which version of ceph is installed as a client"},{"line_number":16,"context_line":"to only change octopus and later"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Includes release note for the change."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ie8011fc83bc41edd2768ade6d42d737b4598ca2d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f560f44_2fc73467","line":17,"updated":"2020-08-28 14:41:13.000000000","message":"Please, add a link do the docs [1] into the commit message too\n\n[1] https://docs.ceph.com/docs/octopus/rados/configuration/common/#example-ceph-conf","commit_id":"105119ee4284876b7704656b010880200223eb6f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6297762a40586379e05221176184c120c5962be7","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Includes code to resolve which version of ceph is installed as a client"},{"line_number":16,"context_line":"to only change octopus and later"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Includes release note for the change."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ie8011fc83bc41edd2768ade6d42d737b4598ca2d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f560f44_4fa9c322","line":17,"in_reply_to":"9f560f44_2fc73467","updated":"2020-08-28 19:04:02.000000000","message":"Interestingly, the [global] section goes back to at least mimic:\nhttps://docs.ceph.com/docs/mimic/rados/configuration/common/#example-ceph-conf\n\nHave we verified that no one has seen this problem with nautilus?","commit_id":"105119ee4284876b7704656b010880200223eb6f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"16b3870964103157370a7e0568629eb4ec7cc7aa","unresolved":false,"context_lines":[{"line_number":13,"context_line":"generated within the RBDConnector() class."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Includes code to resolve which version of ceph is installed as a client"},{"line_number":16,"context_line":"to only change octopus and later. It also cinder Ceph backup driver."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Includes release note for the change."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9f560f44_cb600c11","line":16,"range":{"start_line":16,"start_character":34,"end_line":16,"end_character":68},"updated":"2020-08-31 19:18:44.000000000","message":"There\u0027s something wrong with this sentence.","commit_id":"00d40ea8033093922d2bfe1d16d58babc7743ae6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"56022a04f70ed59d60288fce65f665b4a7925126","unresolved":false,"context_lines":[{"line_number":13,"context_line":"generated within the RBDConnector() class."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Includes code to resolve which version of ceph is installed as a client"},{"line_number":16,"context_line":"to only change octopus and later. It also cinder Ceph backup driver."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Includes release note for the change."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9f560f44_0b1ddf72","line":16,"range":{"start_line":16,"start_character":34,"end_line":16,"end_character":68},"in_reply_to":"9f560f44_cb600c11","updated":"2020-09-01 06:21:57.000000000","message":"Done","commit_id":"00d40ea8033093922d2bfe1d16d58babc7743ae6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c6cac724d71dbcee80be80336fcb4146b725a0b3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ivan Kolodyazhny \u003ce0ne@e0ne.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-01 09:21:28 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for rbd connector to work with ceph octupus"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Found whilst testing cinder-backup with ceph on Ubuntu focal and"},{"line_number":10,"context_line":"OpenStack Ussuri.  Focal installs Ceph Octopus, and, as the linked bug"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9f560f44_187366b3","line":7,"range":{"start_line":7,"start_character":40,"end_line":7,"end_character":47},"updated":"2020-09-01 16:11:54.000000000","message":"octopus","commit_id":"61efa613409a49a03ffa9fcbf7b540ff49d71f22"}],"os_brick/initiator/connectors/rbd.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"43c8d111d2889fb5db986f437d0766cd22865a64","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    # output of \u0027ceph --version\u0027 on different versions of ceph"},{"line_number":115,"context_line":"    # ceph version 0.80.11 (8424145d49264624a3b0a204aedb127835161070)"},{"line_number":116,"context_line":"    # ceph version 10.2.11 (e4b061b47f07f583c92a050d9e84b1813a35671e)"},{"line_number":117,"context_line":"    # ceph version 12.2.13 (584a20eb0237c657dc0567da126be145106aa47e) luminous (stable)"},{"line_number":118,"context_line":"    # ceph version 14.2.9 (581f22da52345dba46ee232b73b990f06029a2a0) nautilus (stable)"},{"line_number":119,"context_line":"    # ceph version 15.2.3 (d289bbdec69ed7c1f516e0a093594580a76b78d0) octopus (stable)"},{"line_number":120,"context_line":"    def _determine_ceph_client_version(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_404e7b38","line":117,"updated":"2020-07-22 12:19:54.000000000","message":"pep8: E501 line too long (87 \u003e 79 characters)","commit_id":"d4d47989707df7126d7c98e1cb9485288ea407c4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"43c8d111d2889fb5db986f437d0766cd22865a64","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    # ceph version 0.80.11 (8424145d49264624a3b0a204aedb127835161070)"},{"line_number":116,"context_line":"    # ceph version 10.2.11 (e4b061b47f07f583c92a050d9e84b1813a35671e)"},{"line_number":117,"context_line":"    # ceph version 12.2.13 (584a20eb0237c657dc0567da126be145106aa47e) luminous (stable)"},{"line_number":118,"context_line":"    # ceph version 14.2.9 (581f22da52345dba46ee232b73b990f06029a2a0) nautilus (stable)"},{"line_number":119,"context_line":"    # ceph version 15.2.3 (d289bbdec69ed7c1f516e0a093594580a76b78d0) octopus (stable)"},{"line_number":120,"context_line":"    def _determine_ceph_client_version(self):"},{"line_number":121,"context_line":"        cmd \u003d [\u0027ceph\u0027, \u0027--version\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_a05e77e6","line":118,"updated":"2020-07-22 12:19:54.000000000","message":"pep8: E501 line too long (86 \u003e 79 characters)","commit_id":"d4d47989707df7126d7c98e1cb9485288ea407c4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"43c8d111d2889fb5db986f437d0766cd22865a64","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    # ceph version 10.2.11 (e4b061b47f07f583c92a050d9e84b1813a35671e)"},{"line_number":117,"context_line":"    # ceph version 12.2.13 (584a20eb0237c657dc0567da126be145106aa47e) luminous (stable)"},{"line_number":118,"context_line":"    # ceph version 14.2.9 (581f22da52345dba46ee232b73b990f06029a2a0) nautilus (stable)"},{"line_number":119,"context_line":"    # ceph version 15.2.3 (d289bbdec69ed7c1f516e0a093594580a76b78d0) octopus (stable)"},{"line_number":120,"context_line":"    def _determine_ceph_client_version(self):"},{"line_number":121,"context_line":"        cmd \u003d [\u0027ceph\u0027, \u0027--version\u0027]"},{"line_number":122,"context_line":"        (out, _) \u003d self._execute(*cmd)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_8061b3ab","line":119,"updated":"2020-07-22 12:19:54.000000000","message":"pep8: E501 line too long (85 \u003e 79 characters)","commit_id":"d4d47989707df7126d7c98e1cb9485288ea407c4"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4c59d02561dfce1796c01505bd7ac149db5d3eb9","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def _determine_ceph_client_version(self):"},{"line_number":121,"context_line":"        cmd \u003d [\u0027ceph\u0027, \u0027--version\u0027]"},{"line_number":122,"context_line":"        (out, _) \u003d self._execute(*cmd)"},{"line_number":123,"context_line":"        print(\"out is \u0027{}\u0027\".format(out))"},{"line_number":124,"context_line":"        return out.split(\" \")[2]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _get_rbd_handle(self, connection_properties):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_efe4d010","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":13},"updated":"2020-07-22 19:41:34.000000000","message":"Please remove, maybe this was left from debugging?","commit_id":"7ae57586f9fbd93828a884c36aacc19f2d7c96d5"},{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"8e1d9771384c9e1c2ba8ed737cfd18603f2bdcd3","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def _determine_ceph_client_version(self):"},{"line_number":121,"context_line":"        cmd \u003d [\u0027ceph\u0027, \u0027--version\u0027]"},{"line_number":122,"context_line":"        (out, _) \u003d self._execute(*cmd)"},{"line_number":123,"context_line":"        print(\"out is \u0027{}\u0027\".format(out))"},{"line_number":124,"context_line":"        return out.split(\" \")[2]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _get_rbd_handle(self, connection_properties):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_dfe5333a","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":13},"in_reply_to":"bf51134e_efe4d010","updated":"2020-07-23 05:53:37.000000000","message":"Yes, thanks for the catch!  Will remove.","commit_id":"7ae57586f9fbd93828a884c36aacc19f2d7c96d5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b3dc26059605af908bc4a591e202d629f34f4210","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            with os.fdopen(fd, \u0027w\u0027) as conf_file:"},{"line_number":100,"context_line":"                # BUG#1865754 - ceph octopus requires \"[general]\" as part of"},{"line_number":101,"context_line":"                # the ini conf file that is generated."},{"line_number":102,"context_line":"                if ceph_version \u003e\u003d \"15.2.3\":"},{"line_number":103,"context_line":"                    config \u003d [\"[general]\", \"\\n\","},{"line_number":104,"context_line":"                              mon_hosts, \"\\n\", keyring, \"\\n\"]"},{"line_number":105,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_a5dce474","line":102,"range":{"start_line":102,"start_character":36,"end_line":102,"end_character":42},"updated":"2020-07-28 14:55:29.000000000","message":"Wouldn\u0027t this be 15.2.0?","commit_id":"bb89677b3490b046a80844386ad4ca3f0ec3eabc"},{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"b7bc29beab21c114443328806ff65c8941cb46ea","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            with os.fdopen(fd, \u0027w\u0027) as conf_file:"},{"line_number":100,"context_line":"                # BUG#1865754 - ceph octopus requires \"[general]\" as part of"},{"line_number":101,"context_line":"                # the ini conf file that is generated."},{"line_number":102,"context_line":"                if ceph_version \u003e\u003d \"15.2.3\":"},{"line_number":103,"context_line":"                    config \u003d [\"[general]\", \"\\n\","},{"line_number":104,"context_line":"                              mon_hosts, \"\\n\", keyring, \"\\n\"]"},{"line_number":105,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_21db8ded","line":102,"range":{"start_line":102,"start_character":36,"end_line":102,"end_character":42},"in_reply_to":"9f560f44_a5dce474","updated":"2020-07-29 19:26:05.000000000","message":"yes, it should be; I was doing testing on Ubuntu and that\u0027s the vesion that ships.  I will adjust it.  Thanks.","commit_id":"bb89677b3490b046a80844386ad4ca3f0ec3eabc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d0ba1f1f7e25567ffb8ca686312f3ef27491b9d5","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            with os.fdopen(fd, \u0027w\u0027) as conf_file:"},{"line_number":100,"context_line":"                # BUG#1865754 - ceph octopus requires \"[general]\" as part of"},{"line_number":101,"context_line":"                # the ini conf file that is generated."},{"line_number":102,"context_line":"                if ceph_version \u003e\u003d \"15.2.0\":"},{"line_number":103,"context_line":"                    config \u003d [\"[general]\", \"\\n\","},{"line_number":104,"context_line":"                              mon_hosts, \"\\n\", keyring, \"\\n\"]"},{"line_number":105,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_d0a5b004","line":102,"range":{"start_line":102,"start_character":19,"end_line":102,"end_character":43},"updated":"2020-08-25 22:43:56.000000000","message":"I don\u0027t know that we want to rely on string comparisons here.  What I\u0027m worried about is:\n\n  \u003e\u003e\u003e \"15.11.1\" \u003e\u003d \"15.2.0\"\n  False\n\nThe packaging module is in global-requirements, so you could add it to requirements.txt and use it here, something like this:\n\n  \u003e\u003e\u003e from packaging.version import parse as ver_parse\n  \u003e\u003e\u003e fifteen2 \u003d ver_parse(\"15.2.0\")\n  \u003e\u003e\u003e fifteen11 \u003d ver_parse(\"15.11.1\")\n  \u003e\u003e\u003e fifteen11 \u003e\u003d fifteen2\n  True","commit_id":"848f170b8894852a5d889a68187766ad3fb23448"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8725f5d6b6300bcf997194a6242e86339fe1b1ad","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            with os.fdopen(fd, \u0027w\u0027) as conf_file:"},{"line_number":100,"context_line":"                # BUG#1865754 - ceph octopus requires \"[general]\" as part of"},{"line_number":101,"context_line":"                # the ini conf file that is generated."},{"line_number":102,"context_line":"                if ceph_version \u003e\u003d \"15.2.0\":"},{"line_number":103,"context_line":"                    config \u003d [\"[general]\", \"\\n\","},{"line_number":104,"context_line":"                              mon_hosts, \"\\n\", keyring, \"\\n\"]"},{"line_number":105,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_14054e46","line":102,"range":{"start_line":102,"start_character":19,"end_line":102,"end_character":43},"in_reply_to":"9f560f44_d0a5b004","updated":"2020-08-26 14:16:45.000000000","message":"You can do this w/ oslo_utils.versionutils is_compatible().","commit_id":"848f170b8894852a5d889a68187766ad3fb23448"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3f7171b63b3593380607eedf4d54774420fdae3a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            with os.fdopen(fd, \u0027w\u0027) as conf_file:"},{"line_number":107,"context_line":"                # BUG#1865754 - ceph octopus requires \"[general]\" as part of"},{"line_number":108,"context_line":"                # the ini conf file that is generated."},{"line_number":109,"context_line":"                if ver_parse(ceph_version) \u003e\u003d ver_parse(\"15.2.0\"):"},{"line_number":110,"context_line":"                    config \u003d [\"[general]\", \"\\n\","},{"line_number":111,"context_line":"                              mon_hosts, \"\\n\", keyring, \"\\n\"]"},{"line_number":112,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_f26ff85c","line":109,"updated":"2020-08-27 13:08:20.000000000","message":"Sorry that I forgot about oslo versionutils.  I agree with Eric that it\u0027s better to use those (because they\u0027ll make sure if the underlying library changes, the oslo utils will remain stable).  Also, it has a \"same_major\" parameter that will make it easy to fix the case where ceph P goes back to the old-style config.  \n\n  \u003e\u003e\u003e from oslo_utils import versionutils\n  \u003e\u003e\u003e OCTOPUS_BASE_VERSION\u003d\"15.2.0\"\n  \u003e\u003e\u003e versionutils.is_compatible(OCTOPUS_BASE_VERSION, \"15.11.1\")\n  True\n  \u003e\u003e\u003e versionutils.is_compatible(OCTOPUS_BASE_VERSION, \"14.11.1\")\n  False\n  \u003e\u003e\u003e versionutils.is_compatible(OCTOPUS_BASE_VERSION, \"16.11.1\")\n  False\n  \u003e\u003e\u003e versionutils.is_compatible(OCTOPUS_BASE_VERSION, \"16.11.1\", same_major\u003dFalse)\n  True\n\nSo yeah, that\u0027s a not so subtle nudge to define the base version at the top of the file.  And also, I apologize for including the python output above, but the order of parameters in oslo versionutils was the opposite of what I was expecting, so I thought it might be helpful to point that out.","commit_id":"5c5c51c2f120cea832771b074f88e8a9a2a899a2"},{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"b963187d78a309ad2dd7185b22d07429233a1ff6","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            with os.fdopen(fd, \u0027w\u0027) as conf_file:"},{"line_number":107,"context_line":"                # BUG#1865754 - ceph octopus requires \"[general]\" as part of"},{"line_number":108,"context_line":"                # the ini conf file that is generated."},{"line_number":109,"context_line":"                if ver_parse(ceph_version) \u003e\u003d ver_parse(\"15.2.0\"):"},{"line_number":110,"context_line":"                    config \u003d [\"[general]\", \"\\n\","},{"line_number":111,"context_line":"                              mon_hosts, \"\\n\", keyring, \"\\n\"]"},{"line_number":112,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_f26ed829","line":109,"in_reply_to":"9f560f44_f26ff85c","updated":"2020-08-27 13:19:32.000000000","message":"No worries :)  If it makes the code better, I\u0027m all for it.  I\u0027ll update the patch with the suggestion above.  thanks!","commit_id":"5c5c51c2f120cea832771b074f88e8a9a2a899a2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"46f07a9bfcfd0d84c5807b253a1877c59e454b33","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            with os.fdopen(fd, \u0027w\u0027) as conf_file:"},{"line_number":110,"context_line":"                # BUG#1865754 - ceph octopus requires \"[general]\" as part of"},{"line_number":111,"context_line":"                # the ini conf file that is generated."},{"line_number":112,"context_line":"                if versionutils.is_compatible(OCTOPUS_BASE_VERSION,"},{"line_number":113,"context_line":"                                              ceph_version):"},{"line_number":114,"context_line":"                    config \u003d [\"[general]\", \"\\n\","},{"line_number":115,"context_line":"                              mon_hosts, \"\\n\", keyring, \"\\n\"]"},{"line_number":116,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_eb56de29","line":113,"range":{"start_line":112,"start_character":18,"end_line":113,"end_character":59},"updated":"2020-08-27 20:22:14.000000000","message":"The default for \u0027same_major\u0027 is True, so this call will return False when we hit ceph 16.x.0.  So I guess the question is, do we think it likely that ceph P will go back to the config without \u0027[general]\u0027, or will \u0027[general]\u0027 be required from O onwards?","commit_id":"119fd745c26beb154b93cabbab9e838000ec382b"},{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"06c158da674921f067845f935c24bd0226832817","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            with os.fdopen(fd, \u0027w\u0027) as conf_file:"},{"line_number":110,"context_line":"                # BUG#1865754 - ceph octopus requires \"[general]\" as part of"},{"line_number":111,"context_line":"                # the ini conf file that is generated."},{"line_number":112,"context_line":"                if versionutils.is_compatible(OCTOPUS_BASE_VERSION,"},{"line_number":113,"context_line":"                                              ceph_version):"},{"line_number":114,"context_line":"                    config \u003d [\"[general]\", \"\\n\","},{"line_number":115,"context_line":"                              mon_hosts, \"\\n\", keyring, \"\\n\"]"},{"line_number":116,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_f1fc08b7","line":113,"range":{"start_line":112,"start_character":18,"end_line":113,"end_character":59},"in_reply_to":"9f560f44_eb56de29","updated":"2020-08-28 08:52:32.000000000","message":"That\u0027s an intriguing default.  I guess it\u0027s meant to be \"only compatible with this version by default\", which is fair enough.  I think this is a breaking change going forwards, so I\u0027ll change the \u0027same_major\u0027 to False.  I\u0027ll be testing with the next version of Ceph anyway, so I\u0027ll hopefully pickup any further changes as they come in.","commit_id":"119fd745c26beb154b93cabbab9e838000ec382b"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"8ebdfe96fa70db6e15b81584163a96ab11f3c081","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                if versionutils.is_compatible(OCTOPUS_BASE_VERSION,"},{"line_number":113,"context_line":"                                              ceph_version,"},{"line_number":114,"context_line":"                                              same_major\u003dFalse):"},{"line_number":115,"context_line":"                    config \u003d [\"[general]\", \"\\n\","},{"line_number":116,"context_line":"                              mon_hosts, \"\\n\", keyring, \"\\n\"]"},{"line_number":117,"context_line":"                else:"},{"line_number":118,"context_line":"                    config \u003d [mon_hosts, \"\\n\", keyring, \"\\n\"]"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_6f9e4c6a","line":115,"range":{"start_line":115,"start_character":32,"end_line":115,"end_character":39},"updated":"2020-08-28 14:41:13.000000000","message":"global","commit_id":"105119ee4284876b7704656b010880200223eb6f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c6cac724d71dbcee80be80336fcb4146b725a0b3","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        try:"},{"line_number":108,"context_line":"            fd, ceph_conf_path \u003d tempfile.mkstemp(prefix\u003d\"brickrbd_\")"},{"line_number":109,"context_line":"            with os.fdopen(fd, \u0027w\u0027) as conf_file:"},{"line_number":110,"context_line":"                # BUG#1865754 - ceph octopus requires \"[general]\" as part of"},{"line_number":111,"context_line":"                # the ini conf file that is generated."},{"line_number":112,"context_line":"                if versionutils.is_compatible(OCTOPUS_BASE_VERSION,"},{"line_number":113,"context_line":"                                              ceph_version,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_7d0b742a","line":110,"range":{"start_line":110,"start_character":56,"end_line":110,"end_character":63},"updated":"2020-09-01 16:11:54.000000000","message":"global!!!","commit_id":"61efa613409a49a03ffa9fcbf7b540ff49d71f22"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c6cac724d71dbcee80be80336fcb4146b725a0b3","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            fd, ceph_conf_path \u003d tempfile.mkstemp(prefix\u003d\"brickrbd_\")"},{"line_number":109,"context_line":"            with os.fdopen(fd, \u0027w\u0027) as conf_file:"},{"line_number":110,"context_line":"                # BUG#1865754 - ceph octopus requires \"[general]\" as part of"},{"line_number":111,"context_line":"                # the ini conf file that is generated."},{"line_number":112,"context_line":"                if versionutils.is_compatible(OCTOPUS_BASE_VERSION,"},{"line_number":113,"context_line":"                                              ceph_version,"},{"line_number":114,"context_line":"                                              same_major\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_583b1ec7","line":111,"updated":"2020-09-01 16:11:54.000000000","message":"Since this comment needs to be fixed anyway, I think it would be a good idea to add:  By setting same_major\u003dFalse below, we are betting that this change will also be required for releases after octopus.","commit_id":"61efa613409a49a03ffa9fcbf7b540ff49d71f22"}],"os_brick/tests/initiator/connectors/test_rbd.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d0ba1f1f7e25567ffb8ca686312f3ef27491b9d5","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        \"ceph version 14.2.9 (581f...) nautilus (stable)\","},{"line_number":163,"context_line":"        None))"},{"line_number":164,"context_line":"    @mock.patch(\u0027os_brick.initiator.connectors.rbd.tempfile.mkstemp\u0027)"},{"line_number":165,"context_line":"    def test_create_ceph_conf(self, mock_mkstemp, mock_execute):"},{"line_number":166,"context_line":"        mockopen \u003d mock.mock_open()"},{"line_number":167,"context_line":"        fd \u003d mock.sentinel.fd"},{"line_number":168,"context_line":"        tmpfile \u003d mock.sentinel.tmpfile"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_30deac6c","line":165,"updated":"2020-08-25 22:43:56.000000000","message":"I think you can enhance this test (and maybe add another one) to verify that the config is being created correctly.  See http://paste.openstack.org/show/797151/ for a suggestion.","commit_id":"848f170b8894852a5d889a68187766ad3fb23448"},{"author":{"_account_id":20870,"name":"Alex Kavanagh","email":"alex@ajkavanagh.co.uk","username":"ajkavanagh"},"change_message_id":"115edd0efa12fa715e9b7abf0b27d9594dc5c17c","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        \"ceph version 14.2.9 (581f...) nautilus (stable)\","},{"line_number":163,"context_line":"        None))"},{"line_number":164,"context_line":"    @mock.patch(\u0027os_brick.initiator.connectors.rbd.tempfile.mkstemp\u0027)"},{"line_number":165,"context_line":"    def test_create_ceph_conf(self, mock_mkstemp, mock_execute):"},{"line_number":166,"context_line":"        mockopen \u003d mock.mock_open()"},{"line_number":167,"context_line":"        fd \u003d mock.sentinel.fd"},{"line_number":168,"context_line":"        tmpfile \u003d mock.sentinel.tmpfile"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_5785f658","line":165,"in_reply_to":"9f560f44_30deac6c","updated":"2020-08-27 11:42:33.000000000","message":"Done.\n\nThanks for the additional test; very useful!","commit_id":"848f170b8894852a5d889a68187766ad3fb23448"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"16b3870964103157370a7e0568629eb4ec7cc7aa","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        _, args, _ \u003d mockopen().writelines.mock_calls[0]"},{"line_number":181,"context_line":"        self.assertNotIn(\u0027[global]\u0027, args[0])"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    @mock.patch.object(priv_rootwrap, \u0027execute\u0027, return_value\u003d("},{"line_number":184,"context_line":"        \"ceph version 15.2.3 (d289...) octopus (stable)\","},{"line_number":185,"context_line":"        None))"},{"line_number":186,"context_line":"    @mock.patch(\u0027os_brick.initiator.connectors.rbd.tempfile.mkstemp\u0027)"},{"line_number":187,"context_line":"    def test_create_ceph_conf_octopus(self, mock_mkstemp, mock_execute):"},{"line_number":188,"context_line":"        mockopen \u003d mock.mock_open()"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_2bac2834","line":185,"range":{"start_line":183,"start_character":0,"end_line":185,"end_character":14},"updated":"2020-08-31 19:18:44.000000000","message":"Could you make the same change to use ddt as you did for the previous test?  The ones to add would be:\n\n\"ceph version 15.2.11-99-gaf0268dc91 (af0268dc9) octopus (stable)\"\n\"ceph version 16.2.0 (d4118d68c) permoteuthis (stable)\"\n\n(The first one to catch a positive development version, the second to make sure same_major\u003dFalse is being passed to oslo versionutils.)","commit_id":"00d40ea8033093922d2bfe1d16d58babc7743ae6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"56022a04f70ed59d60288fce65f665b4a7925126","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        _, args, _ \u003d mockopen().writelines.mock_calls[0]"},{"line_number":181,"context_line":"        self.assertNotIn(\u0027[global]\u0027, args[0])"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    @mock.patch.object(priv_rootwrap, \u0027execute\u0027, return_value\u003d("},{"line_number":184,"context_line":"        \"ceph version 15.2.3 (d289...) octopus (stable)\","},{"line_number":185,"context_line":"        None))"},{"line_number":186,"context_line":"    @mock.patch(\u0027os_brick.initiator.connectors.rbd.tempfile.mkstemp\u0027)"},{"line_number":187,"context_line":"    def test_create_ceph_conf_octopus(self, mock_mkstemp, mock_execute):"},{"line_number":188,"context_line":"        mockopen \u003d mock.mock_open()"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_cb8da7d4","line":185,"range":{"start_line":183,"start_character":0,"end_line":185,"end_character":14},"in_reply_to":"9f560f44_2bac2834","updated":"2020-09-01 06:21:57.000000000","message":"Done","commit_id":"00d40ea8033093922d2bfe1d16d58babc7743ae6"}],"releasenotes/notes/bug-1865754-ceph-octopus-compatibility-a56a05b7395efa7f.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2c34843b60dad856d253e5dae351f83a2a88812b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"fixes:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    `Bug #1865754 \u003chttps://bugs.launchpad.net/cinder/+bug/1865754\u003e`_:"},{"line_number":6,"context_line":"    Fix to the rbd connecttor to work with Ceph Octopus (Version 15.2.0 and"},{"line_number":7,"context_line":"    later). Octopus has slightly changed its requirements such that it now"},{"line_number":8,"context_line":"    needs a ``[general]`` heading at the beginning of the ``ini`` config file"},{"line_number":9,"context_line":"    that is generated within the ``RBDConnector()`` class.  This release"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_9c0e8e2f","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":29},"updated":"2020-08-27 14:56:07.000000000","message":"connector","commit_id":"29ff285ff76d452e7b9510196d2c8056215f3386"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2c34843b60dad856d253e5dae351f83a2a88812b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    Fix to the rbd connecttor to work with Ceph Octopus (Version 15.2.0 and"},{"line_number":7,"context_line":"    later). Octopus has slightly changed its requirements such that it now"},{"line_number":8,"context_line":"    needs a ``[general]`` heading at the beginning of the ``ini`` config file"},{"line_number":9,"context_line":"    that is generated within the ``RBDConnector()`` class.  This release"},{"line_number":10,"context_line":"    detects the Ceph version and supplied the appropriate config file."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_dc2da68f","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":49},"updated":"2020-08-27 14:56:07.000000000","message":"The parentheses are part of the class name.","commit_id":"29ff285ff76d452e7b9510196d2c8056215f3386"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2c34843b60dad856d253e5dae351f83a2a88812b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    later). Octopus has slightly changed its requirements such that it now"},{"line_number":8,"context_line":"    needs a ``[general]`` heading at the beginning of the ``ini`` config file"},{"line_number":9,"context_line":"    that is generated within the ``RBDConnector()`` class.  This release"},{"line_number":10,"context_line":"    detects the Ceph version and supplied the appropriate config file."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_fc198a79","line":10,"range":{"start_line":10,"start_character":33,"end_line":10,"end_character":41},"updated":"2020-08-27 14:56:07.000000000","message":"supplies","commit_id":"29ff285ff76d452e7b9510196d2c8056215f3386"}]}