)]}'
{"os_brick/tests/initiator/connectors/test_scaleio.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3db89a449bffc478766f51990cc9ef69d148e7f2","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        self.connector.connect_volume(self.fake_connection_properties)"},{"line_number":173,"context_line":"        self.get_guid_mock.assert_called_once_with("},{"line_number":174,"context_line":"            self.connector.GET_GUID_OP_CODE)"},{"line_number":175,"context_line":"        self.get_password_mock.assert_called_once()"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def test_connect_volume_without_volume_id(self):"},{"line_number":178,"context_line":"        \"\"\"Successful connect to volume without a Volume Id\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_523d3cb9","line":175,"range":{"start_line":175,"start_character":8,"end_line":175,"end_character":51},"updated":"2020-06-03 12:10:20.000000000","message":"This just checks if the get_password method is called.\nit would be better for a followup to include a test which actually calls get_connector_password and we can mock the mkdir, configparser etc and check if they are actually called.","commit_id":"5414305a2b2c776be62b695c4144dd4ace7f5b30"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8feae9d83116cc69bb603d8fd6cd09f28320e38e","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        self.connector.connect_volume(self.fake_connection_properties)"},{"line_number":173,"context_line":"        self.get_guid_mock.assert_called_once_with("},{"line_number":174,"context_line":"            self.connector.GET_GUID_OP_CODE)"},{"line_number":175,"context_line":"        self.get_password_mock.assert_called_once()"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def test_connect_volume_without_volume_id(self):"},{"line_number":178,"context_line":"        \"\"\"Successful connect to volume without a Volume Id\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_92dfd464","line":175,"range":{"start_line":175,"start_character":8,"end_line":175,"end_character":51},"in_reply_to":"ff570b3c_523d3cb9","updated":"2020-06-03 12:15:59.000000000","message":"ignore mkdir, i meant any other function like os.path.isfile but the general idea is to actually call the method.","commit_id":"5414305a2b2c776be62b695c4144dd4ace7f5b30"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"fc19fc2b81252bc63434fad534d07d0fedcf1ba0","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        self.connector.connect_volume(self.fake_connection_properties)"},{"line_number":173,"context_line":"        self.get_guid_mock.assert_called_once_with("},{"line_number":174,"context_line":"            self.connector.GET_GUID_OP_CODE)"},{"line_number":175,"context_line":"        self.get_password_mock.assert_called_once()"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def test_connect_volume_without_volume_id(self):"},{"line_number":178,"context_line":"        \"\"\"Successful connect to volume without a Volume Id\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_1210e4ff","line":175,"range":{"start_line":175,"start_character":8,"end_line":175,"end_character":51},"in_reply_to":"ff570b3c_92dfd464","updated":"2020-06-03 12:20:13.000000000","message":"Agree, will do it in another patch.","commit_id":"5414305a2b2c776be62b695c4144dd4ace7f5b30"}]}