)]}'
{"os_brick/initiator/connectors/rbd.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"1ae6b37aaaf784b7626e2934d9329a3a526e348d","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            if conf:"},{"line_number":412,"context_line":"                try:"},{"line_number":413,"context_line":"                    rbd_privsep.delete_if_exists(conf)"},{"line_number":414,"context_line":"                except Exception:"},{"line_number":415,"context_line":"                    LOG.warning(\u0027Could not remove config file %s\u0027, conf)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        if not device_path:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_be2a018d","line":414,"range":{"start_line":414,"start_character":23,"end_line":414,"end_character":32},"updated":"2020-07-30 20:17:14.000000000","message":"Can we handle less general exception here? Also, it would be useful for troubleshooting to have exception details in the debug logs","commit_id":"a2679fd28ab584b612ca0481313f755ec0a7a5fd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a2246c7b75b507215bb48dfd472838825027d7d3","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            if conf:"},{"line_number":412,"context_line":"                try:"},{"line_number":413,"context_line":"                    rbd_privsep.delete_if_exists(conf)"},{"line_number":414,"context_line":"                except Exception:"},{"line_number":415,"context_line":"                    LOG.warning(\u0027Could not remove config file %s\u0027, conf)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        if not device_path:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_27d541ba","line":414,"range":{"start_line":414,"start_character":23,"end_line":414,"end_character":32},"in_reply_to":"9f560f44_be2a018d","updated":"2020-07-31 09:07:39.000000000","message":"Yeah, this issue is so unlikely to happen that we really need to give a bit more info when it happens.  I\u0027ll add its string representation.\n\nOn using a narrower exception, that would mean that in some cases we could fail the extend because we couldn\u0027t delete the config file, which I don\u0027t think we should do.","commit_id":"a2679fd28ab584b612ca0481313f755ec0a7a5fd"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4f36971ab9dcb476473e97a716ee68488daff9ba","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            try:"},{"line_number":396,"context_line":"                # Handles should return absolute position on seek, but the RBD"},{"line_number":397,"context_line":"                # wrapper doesn\u0027t, so we need to call tell afterwards"},{"line_number":398,"context_line":"                handle.seek(0, 2)"},{"line_number":399,"context_line":"                return handle.tell()"},{"line_number":400,"context_line":"            finally:"},{"line_number":401,"context_line":"                fileutils.delete_if_exists(handle.rbd_conf)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_2c866267","line":398,"range":{"start_line":398,"start_character":31,"end_line":398,"end_character":32},"updated":"2020-08-25 14:36:16.000000000","message":"probably use os.SEEK_END here for more clarity?","commit_id":"29752fb54bbc3ae8d6abd7d857633635311c19d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"77412e133f800327480ffbb01f1a4e280c99673b","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            try:"},{"line_number":396,"context_line":"                # Handles should return absolute position on seek, but the RBD"},{"line_number":397,"context_line":"                # wrapper doesn\u0027t, so we need to call tell afterwards"},{"line_number":398,"context_line":"                handle.seek(0, 2)"},{"line_number":399,"context_line":"                return handle.tell()"},{"line_number":400,"context_line":"            finally:"},{"line_number":401,"context_line":"                fileutils.delete_if_exists(handle.rbd_conf)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_c1384ca1","line":398,"range":{"start_line":398,"start_character":31,"end_line":398,"end_character":32},"in_reply_to":"9f560f44_2c866267","updated":"2020-08-25 17:37:04.000000000","message":"Since we use the integers in the function being called, https://review.opendev.org/#/c/737312/5/os_brick/initiator/linuxrbd.py@201 , I\u0027m inclined not to hold up this patch for this change.  But it could be worth a follow up patch to change the integers to symbolic constants throughout.","commit_id":"29752fb54bbc3ae8d6abd7d857633635311c19d4"}],"os_brick/tests/initiator/connectors/test_rbd.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e7160e46adce73f5069f3ad36f05f5ce14223e4d","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        self.assertRaises(exception.BrickException,"},{"line_number":257,"context_line":"                          rbd_connector.connect_volume,"},{"line_number":258,"context_line":"                          conn)"},{"line_number":259,"context_line":"    @mock.patch(\u0027os_brick.initiator.connectors.rbd.\u0027"},{"line_number":260,"context_line":"                \u0027RBDConnector._local_attach_volume\u0027)"},{"line_number":261,"context_line":"    def test_connect_volume_local(self, mock_local_attach):"},{"line_number":262,"context_line":"        connector \u003d rbd.RBDConnector(None, do_local_attach\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_49ce5f82","line":259,"updated":"2020-06-22 17:59:40.000000000","message":"pep8: E301 expected 1 blank line, found 0","commit_id":"198051deb8c2ecf275e5a05273453d79ee46f345"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4f36971ab9dcb476473e97a716ee68488daff9ba","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        res \u003d connector.extend_volume(self.connection_properties)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        mock_handle.assert_called_once_with(self.connection_properties)"},{"line_number":429,"context_line":"        mock_handle.return_value.seek.assert_called_once_with(0, 2)"},{"line_number":430,"context_line":"        mock_handle.return_value.tell.assert_called_once_with()"},{"line_number":431,"context_line":"        self.assertIs(mock_handle().tell(), res)"},{"line_number":432,"context_line":"        mock_delete.assert_called_once_with(mock_handle().rbd_conf)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_4cd2b6d2","line":429,"range":{"start_line":429,"start_character":65,"end_line":429,"end_character":66},"updated":"2020-08-25 14:36:16.000000000","message":"same","commit_id":"29752fb54bbc3ae8d6abd7d857633635311c19d4"}]}