)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4ef79983998b1116013bef375638afb7c96ec237","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Also modified the _get_host_devices() method to:"},{"line_number":18,"context_line":"    - add the lun argument"},{"line_number":19,"context_line":"    - a check for whether the host is a standalone host using PCI or an NPIV guest using FC path"},{"line_number":20,"context_line":"    - returning the host devices accordingly"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Tested cinder backup-create with this change - successful."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_8b09cb2d","line":19,"updated":"2020-07-30 11:43:58.000000000","message":"Sorry, I\u0027m not sure I understand what \"NPIV guest\" means. Could you elavorate a bit, please?\n\nPlease don\u0027t go over 72 characters per line if possible as per our guidelines: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"2cddc19c4224342ba145b0eb284b624f8873e5fa"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"920dc2cf126f5c94c2bad685a8a06feef8d16dce","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    positional argument:\u0027lun\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Modified the _get_host_devices() method to"},{"line_number":17,"context_line":"add the lun argument."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Tested cinder backup-create."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"827e6dde_5bf7a3cb","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":3},"updated":"2021-01-13 17:59:07.000000000","message":"-1: remove","commit_id":"0805cf4ea4dc73bcd697cc14b3ff3464f6331121"}],"doc/requirements.txt":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"920dc2cf126f5c94c2bad685a8a06feef8d16dce","unresolved":true,"context_lines":[{"line_number":4,"context_line":"openstackdocstheme\u003e\u003d2.2.1 # Apache-2.0"},{"line_number":5,"context_line":"reno\u003e\u003d3.1.0 # Apache-2.0"},{"line_number":6,"context_line":"sphinx\u003e\u003d2.0.0,!\u003d2.1.0 # BSD"},{"line_number":7,"context_line":"os-api-ref\u003e\u003d1.5.0 # Apache-2.0"},{"line_number":8,"context_line":"sphinxcontrib-apidoc\u003e\u003d0.2.0  # BSD"},{"line_number":9,"context_line":"sphinx-feature-classification\u003e\u003d1.1.0 # Apache 2.0"}],"source_content_type":"text/plain","patch_set":20,"id":"d2904dfe_6d36e461","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":49},"updated":"2021-01-13 17:59:07.000000000","message":"-1: Unrelated changes","commit_id":"0805cf4ea4dc73bcd697cc14b3ff3464f6331121"}],"lower-constraints.txt":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"920dc2cf126f5c94c2bad685a8a06feef8d16dce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"appdirs\u003d\u003d1.3.0"},{"line_number":2,"context_line":"asn1crypto\u003d\u003d0.23.0"},{"line_number":3,"context_line":"Babel\u003d\u003d2.8.0"},{"line_number":4,"context_line":"castellan\u003d\u003d3.6.0"},{"line_number":5,"context_line":"cffi\u003d\u003d1.14.2"},{"line_number":6,"context_line":"cliff\u003d\u003d3.4.0"},{"line_number":7,"context_line":"cmd2\u003d\u003d1.3.8"},{"line_number":8,"context_line":"coverage\u003d\u003d5.2.1"},{"line_number":9,"context_line":"cryptography\u003d\u003d3.1"},{"line_number":10,"context_line":"ddt\u003d\u003d1.4.1"},{"line_number":11,"context_line":"debtcollector\u003d\u003d2.2.0"},{"line_number":12,"context_line":"dnspython\u003d\u003d1.16.0"},{"line_number":13,"context_line":"doc8\u003d\u003d0.8.1"},{"line_number":14,"context_line":"entrypoints\u003d\u003d0.3"},{"line_number":15,"context_line":"eventlet\u003d\u003d0.26.1"},{"line_number":16,"context_line":"extras\u003d\u003d1.0.0"},{"line_number":17,"context_line":"fasteners\u003d\u003d0.14.1"},{"line_number":18,"context_line":"fixtures\u003d\u003d3.0.0"},{"line_number":19,"context_line":"future\u003d\u003d0.18.2"},{"line_number":20,"context_line":"greenlet\u003d\u003d0.4.16"},{"line_number":21,"context_line":"idna\u003d\u003d2.10"},{"line_number":22,"context_line":"iso8601\u003d\u003d0.1.12"},{"line_number":23,"context_line":"keystoneauth1\u003d\u003d4.2.1"},{"line_number":24,"context_line":"linecache2\u003d\u003d1.0.0"},{"line_number":25,"context_line":"lxml\u003d\u003d4.5.2"},{"line_number":26,"context_line":"msgpack\u003d\u003d1.0.0"},{"line_number":27,"context_line":"netaddr\u003d\u003d0.8.0"},{"line_number":28,"context_line":"netifaces\u003d\u003d0.10.9"},{"line_number":29,"context_line":"os-client-config\u003d\u003d1.28.0"},{"line_number":30,"context_line":"os-service-types\u003d\u003d1.7.0"},{"line_number":31,"context_line":"os-win\u003d\u003d5.1.0"},{"line_number":32,"context_line":"oslo.concurrency\u003d\u003d4.3.0"},{"line_number":33,"context_line":"oslo.config\u003d\u003d8.3.2"},{"line_number":34,"context_line":"oslo.context\u003d\u003d3.1.1"},{"line_number":35,"context_line":"oslo.i18n\u003d\u003d5.0.1"},{"line_number":36,"context_line":"oslo.log\u003d\u003d4.4.0"},{"line_number":37,"context_line":"oslo.privsep\u003d\u003d2.4.0"},{"line_number":38,"context_line":"oslo.serialization\u003d\u003d4.0.1"},{"line_number":39,"context_line":"oslo.service\u003d\u003d2.4.0"},{"line_number":40,"context_line":"oslo.utils\u003d\u003d4.7.0"},{"line_number":41,"context_line":"oslo.vmware\u003d\u003d3.7.0"},{"line_number":42,"context_line":"oslotest\u003d\u003d4.4.1"},{"line_number":43,"context_line":"Paste\u003d\u003d3.4.3"},{"line_number":44,"context_line":"PasteDeploy\u003d\u003d2.1.0"},{"line_number":45,"context_line":"pbr\u003d\u003d5.5.0"},{"line_number":46,"context_line":"prettytable\u003d\u003d0.7.2"},{"line_number":47,"context_line":"pycparser\u003d\u003d2.20"},{"line_number":48,"context_line":"pyinotify\u003d\u003d0.9.6"},{"line_number":49,"context_line":"pyparsing\u003d\u003d2.4.7"},{"line_number":50,"context_line":"pyperclip\u003d\u003d1.8.0"},{"line_number":51,"context_line":"python-barbicanclient\u003d\u003d5.0.1"},{"line_number":52,"context_line":"python-dateutil\u003d\u003d2.8.1"},{"line_number":53,"context_line":"python-mimeparse\u003d\u003d1.6.0"},{"line_number":54,"context_line":"python-subunit\u003d\u003d1.4.0"},{"line_number":55,"context_line":"pytz\u003d\u003d2020.1"},{"line_number":56,"context_line":"PyYAML\u003d\u003d5.3.1"},{"line_number":57,"context_line":"repoze.lru\u003d\u003d0.7"},{"line_number":58,"context_line":"requests\u003d\u003d2.23.0"},{"line_number":59,"context_line":"requestsexceptions\u003d\u003d1.2.0"},{"line_number":60,"context_line":"rfc3986\u003d\u003d1.4.0"},{"line_number":61,"context_line":"Routes\u003d\u003d2.4.1"},{"line_number":62,"context_line":"six\u003d\u003d1.15.0"},{"line_number":63,"context_line":"stestr\u003d\u003d3.0.1"},{"line_number":64,"context_line":"stevedore\u003d\u003d3.2.2"},{"line_number":65,"context_line":"suds-jurko\u003d\u003d0.6"},{"line_number":66,"context_line":"tenacity\u003d\u003d6.2.0"},{"line_number":67,"context_line":"testrepository\u003d\u003d0.0.20"},{"line_number":68,"context_line":"testscenarios\u003d\u003d0.5.0"},{"line_number":69,"context_line":"testtools\u003d\u003d2.4.0"},{"line_number":70,"context_line":"traceback2\u003d\u003d1.4.0"},{"line_number":71,"context_line":"unittest2\u003d\u003d1.1.0"},{"line_number":72,"context_line":"urllib3\u003d\u003d1.25.10"},{"line_number":73,"context_line":"WebOb\u003d\u003d1.8.6"},{"line_number":74,"context_line":"wrapt\u003d\u003d1.12.1"}],"source_content_type":"text/plain","patch_set":20,"id":"7aa9c2df_c9ffe3e6","line":74,"range":{"start_line":4,"start_character":0,"end_line":74,"end_character":13},"updated":"2021-01-13 17:59:07.000000000","message":"-1: Unrelated changes","commit_id":"0805cf4ea4dc73bcd697cc14b3ff3464f6331121"}],"os_brick/initiator/connectors/fibre_channel_ppc64.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c38a99359897a6562926c2f6ce5ba8be569c2563","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self._linuxfc.set_execute(execute)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _get_possible_paths_by_wwn(self, connection_properties):"},{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        New full method with logic to look up devices by wwn ID, rather than"},{"line_number":48,"context_line":"        ITL/symlinks. Method requires that \u0027device_info\u0027 be set in"},{"line_number":49,"context_line":"        connection_properties, and that \u0027scsi_wwn\u0027 be present in device_info."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_0630c99e","line":46,"updated":"2020-06-23 08:54:36.000000000","message":"pep8: H404: multi line docstring should start without a leading new line","commit_id":"f2cbade3918636a43f91755f5ff7a1878e75b9e6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c38a99359897a6562926c2f6ce5ba8be569c2563","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self._linuxfc.set_execute(execute)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _get_possible_paths_by_wwn(self, connection_properties):"},{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        New full method with logic to look up devices by wwn ID, rather than"},{"line_number":48,"context_line":"        ITL/symlinks. Method requires that \u0027device_info\u0027 be set in"},{"line_number":49,"context_line":"        connection_properties, and that \u0027scsi_wwn\u0027 be present in device_info."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e634b595","line":46,"updated":"2020-06-23 08:54:36.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"f2cbade3918636a43f91755f5ff7a1878e75b9e6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c38a99359897a6562926c2f6ce5ba8be569c2563","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _get_possible_paths_by_wwn(self, connection_properties):"},{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        New full method with logic to look up devices by wwn ID, rather than"},{"line_number":48,"context_line":"        ITL/symlinks. Method requires that \u0027device_info\u0027 be set in"},{"line_number":49,"context_line":"        connection_properties, and that \u0027scsi_wwn\u0027 be present in device_info."},{"line_number":50,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_4626416a","line":47,"updated":"2020-06-23 08:54:36.000000000","message":"pep8: H404: multi line docstring should start without a leading new line","commit_id":"f2cbade3918636a43f91755f5ff7a1878e75b9e6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c38a99359897a6562926c2f6ce5ba8be569c2563","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _get_possible_paths_by_wwn(self, connection_properties):"},{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        New full method with logic to look up devices by wwn ID, rather than"},{"line_number":48,"context_line":"        ITL/symlinks. Method requires that \u0027device_info\u0027 be set in"},{"line_number":49,"context_line":"        connection_properties, and that \u0027scsi_wwn\u0027 be present in device_info."},{"line_number":50,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_262b4d30","line":47,"updated":"2020-06-23 08:54:36.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"f2cbade3918636a43f91755f5ff7a1878e75b9e6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c38a99359897a6562926c2f6ce5ba8be569c2563","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def _get_possible_paths_by_wwn(self, connection_properties):"},{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        New full method with logic to look up devices by wwn ID, rather than"},{"line_number":48,"context_line":"        ITL/symlinks. Method requires that \u0027device_info\u0027 be set in"},{"line_number":49,"context_line":"        connection_properties, and that \u0027scsi_wwn\u0027 be present in device_info."},{"line_number":50,"context_line":"        \"\"\""},{"line_number":51,"context_line":"        from oslo_concurrency import processutils as putils"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_86233956","line":48,"updated":"2020-06-23 08:54:36.000000000","message":"pep8: H404: multi line docstring should start without a leading new line","commit_id":"f2cbade3918636a43f91755f5ff7a1878e75b9e6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c38a99359897a6562926c2f6ce5ba8be569c2563","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def _get_possible_paths_by_wwn(self, connection_properties):"},{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        New full method with logic to look up devices by wwn ID, rather than"},{"line_number":48,"context_line":"        ITL/symlinks. Method requires that \u0027device_info\u0027 be set in"},{"line_number":49,"context_line":"        connection_properties, and that \u0027scsi_wwn\u0027 be present in device_info."},{"line_number":50,"context_line":"        \"\"\""},{"line_number":51,"context_line":"        from oslo_concurrency import processutils as putils"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_6620a549","line":48,"updated":"2020-06-23 08:54:36.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"f2cbade3918636a43f91755f5ff7a1878e75b9e6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c38a99359897a6562926c2f6ce5ba8be569c2563","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        New full method with logic to look up devices by wwn ID, rather than"},{"line_number":48,"context_line":"        ITL/symlinks. Method requires that \u0027device_info\u0027 be set in"},{"line_number":49,"context_line":"        connection_properties, and that \u0027scsi_wwn\u0027 be present in device_info."},{"line_number":50,"context_line":"        \"\"\""},{"line_number":51,"context_line":"        from oslo_concurrency import processutils as putils"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_c619b122","line":49,"updated":"2020-06-23 08:54:36.000000000","message":"pep8: H404: multi line docstring should start without a leading new line","commit_id":"f2cbade3918636a43f91755f5ff7a1878e75b9e6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c38a99359897a6562926c2f6ce5ba8be569c2563","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        New full method with logic to look up devices by wwn ID, rather than"},{"line_number":48,"context_line":"        ITL/symlinks. Method requires that \u0027device_info\u0027 be set in"},{"line_number":49,"context_line":"        connection_properties, and that \u0027scsi_wwn\u0027 be present in device_info."},{"line_number":50,"context_line":"        \"\"\""},{"line_number":51,"context_line":"        from oslo_concurrency import processutils as putils"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a6163df0","line":49,"updated":"2020-06-23 08:54:36.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"f2cbade3918636a43f91755f5ff7a1878e75b9e6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c38a99359897a6562926c2f6ce5ba8be569c2563","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        New full method with logic to look up devices by wwn ID, rather than"},{"line_number":48,"context_line":"        ITL/symlinks. Method requires that \u0027device_info\u0027 be set in"},{"line_number":49,"context_line":"        connection_properties, and that \u0027scsi_wwn\u0027 be present in device_info."},{"line_number":50,"context_line":"        \"\"\""},{"line_number":51,"context_line":"        from oslo_concurrency import processutils as putils"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        v_wwn \u003d connection_properties[\u0027device_info\u0027][\u0027scsi_wwn\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_06d5691c","line":50,"updated":"2020-06-23 08:54:36.000000000","message":"pep8: H404: multi line docstring should start without a leading new line","commit_id":"f2cbade3918636a43f91755f5ff7a1878e75b9e6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c38a99359897a6562926c2f6ce5ba8be569c2563","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        New full method with logic to look up devices by wwn ID, rather than"},{"line_number":48,"context_line":"        ITL/symlinks. Method requires that \u0027device_info\u0027 be set in"},{"line_number":49,"context_line":"        connection_properties, and that \u0027scsi_wwn\u0027 be present in device_info."},{"line_number":50,"context_line":"        \"\"\""},{"line_number":51,"context_line":"        from oslo_concurrency import processutils as putils"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        v_wwn \u003d connection_properties[\u0027device_info\u0027][\u0027scsi_wwn\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e6d95557","line":50,"updated":"2020-06-23 08:54:36.000000000","message":"pep8: H405: multi line docstring summary not separated with an empty line","commit_id":"f2cbade3918636a43f91755f5ff7a1878e75b9e6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c38a99359897a6562926c2f6ce5ba8be569c2563","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            return []"},{"line_number":56,"context_line":"        LOG.info(\"Find paths by page83 (volume wwn) ID: %s\" % v_wwn)"},{"line_number":57,"context_line":"        dev_paths \u003d list()"},{"line_number":58,"context_line":"        for devname in [d for d in os.listdir(\u0027/sys/block\u0027)"},{"line_number":59,"context_line":"                        if d.startswith(\u0027sd\u0027)]:"},{"line_number":60,"context_line":"            realdev \u003d \u0027/dev/\u0027 + devname"},{"line_number":61,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_46dbe14d","line":58,"updated":"2020-06-23 08:54:36.000000000","message":"pep8: F821 undefined name \u0027os\u0027","commit_id":"f2cbade3918636a43f91755f5ff7a1878e75b9e6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c38a99359897a6562926c2f6ce5ba8be569c2563","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            if hba[\u0027node_name\u0027].lower() in c_map.keys():"},{"line_number":104,"context_line":"                hba[\u0027target_wwn\u0027] \u003d c_map.get(hba[\u0027node_name\u0027].lower())"},{"line_number":105,"context_line":"        possible_devs \u003d self._get_possible_devices(hbas, ports)"},{"line_number":106,"context_line":"        lun \u003d connection_properties.get(\u0027target_lun\u0027, 0)"},{"line_number":107,"context_line":"        host_paths \u003d self._get_host_devices(possible_devs)"},{"line_number":108,"context_line":"        LOG.info(\"host_paths \u003d %s\" % host_paths)"},{"line_number":109,"context_line":"        return host_paths"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_26e06dfa","line":106,"updated":"2020-06-23 08:54:36.000000000","message":"pep8: F841 local variable \u0027lun\u0027 is assigned to but never used","commit_id":"f2cbade3918636a43f91755f5ff7a1878e75b9e6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"79d905f8e99c9ced852ad2b84413a81c74e86e46","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            if hba[\u0027node_name\u0027].lower() in c_map.keys():"},{"line_number":103,"context_line":"                hba[\u0027target_wwn\u0027] \u003d c_map.get(hba[\u0027node_name\u0027].lower())"},{"line_number":104,"context_line":"        possible_devs \u003d self._get_possible_devices(hbas, ports)"},{"line_number":105,"context_line":"        lun \u003d connection_properties.get(\u0027target_lun\u0027, 0)"},{"line_number":106,"context_line":"        host_paths \u003d self._get_host_devices(possible_devs)"},{"line_number":107,"context_line":"        LOG.info(\"host_paths \u003d %s\" % host_paths)"},{"line_number":108,"context_line":"        return host_paths"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_389b6518","line":105,"updated":"2020-06-23 13:03:25.000000000","message":"pep8: F841 local variable \u0027lun\u0027 is assigned to but never used","commit_id":"2cddc19c4224342ba145b0eb284b624f8873e5fa"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"f79f8d1d183e80fe60f06d448ec3cf0192d9718e","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            if hba[\u0027node_name\u0027].lower() in c_map.keys():"},{"line_number":103,"context_line":"                hba[\u0027target_wwn\u0027] \u003d c_map.get(hba[\u0027node_name\u0027].lower())"},{"line_number":104,"context_line":"        possible_devs \u003d self._get_possible_devices(hbas, ports)"},{"line_number":105,"context_line":"        lun \u003d connection_properties.get(\u0027target_lun\u0027, 0)"},{"line_number":106,"context_line":"        host_paths \u003d self._get_host_devices(possible_devs)"},{"line_number":107,"context_line":"        LOG.info(\"host_paths \u003d %s\" % host_paths)"},{"line_number":108,"context_line":"        return host_paths"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_c0868a66","line":105,"in_reply_to":"bf51134e_389b6518","updated":"2020-12-09 07:04:52.000000000","message":"Done","commit_id":"2cddc19c4224342ba145b0eb284b624f8873e5fa"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"59b4f294201f18436f6fa0a5b7923d641c027fa4","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        host_devices \u003d set()"},{"line_number":47,"context_line":"        for pci_num, target_wwn, lun in possible_devs:"},{"line_number":48,"context_line":"            if \u0027:\u0027 in pci_num:"},{"line_number":49,"context_line":"                host_device \u003d \"/dev/disk/by-path/pci-%s-fc-%s-lun-%s\" % ("},{"line_number":50,"context_line":"                    pci_num,"},{"line_number":51,"context_line":"                    target_wwn,"},{"line_number":52,"context_line":"                    self._linuxscsi.process_lun_id(lun))"}],"source_content_type":"text/x-python","patch_set":5,"id":"99ed318b_0ff0b5cd","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":27},"updated":"2020-12-07 13:22:47.000000000","message":"This \"host_device\" is not added to \"host_devices\". Might be statement at line number \u002757\u0027 should be outside of else block.","commit_id":"ca4acfed08c5d7370b35c466a207025a5b76441c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"920dc2cf126f5c94c2bad685a8a06feef8d16dce","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    def _get_host_devices(self, possible_devs):"},{"line_number":45,"context_line":"        host_devices \u003d set()"},{"line_number":46,"context_line":"        for pci_num, target_wwn, lun in possible_devs:"},{"line_number":47,"context_line":"            pci_str \u003d isinstance(pci_num, str)"},{"line_number":48,"context_line":"            if pci_str and \u0027:\u0027 in pci_num:"},{"line_number":49,"context_line":"                host_device \u003d \"/dev/disk/by-path/pci-%s-fc-%s-lun-%s\" % ("},{"line_number":50,"context_line":"                    pci_num,"},{"line_number":51,"context_line":"                    target_wwn,"},{"line_number":52,"context_line":"                    self._linuxscsi.process_lun_id(lun))"},{"line_number":53,"context_line":"            else:"},{"line_number":54,"context_line":"                host_device \u003d \"/dev/disk/by-path/fc-%s-lun-%s\" % ("},{"line_number":55,"context_line":"                    target_wwn,"},{"line_number":56,"context_line":"                    self._linuxscsi.process_lun_id(lun))"},{"line_number":57,"context_line":"            host_devices.add(host_device)"},{"line_number":58,"context_line":"        return list(host_devices)"}],"source_content_type":"text/x-python","patch_set":20,"id":"6c54e6a7_2aaf6af1","line":56,"range":{"start_line":47,"start_character":11,"end_line":56,"end_character":56},"updated":"2021-01-13 17:59:07.000000000","message":"-1: If this patch is focusing on just fixing the lun parameter, then changes on L44 and L46 are enough, right?","commit_id":"0805cf4ea4dc73bcd697cc14b3ff3464f6331121"}],"os_brick/tests/initiator/connectors/test_fibre_channel_ppc64.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"920dc2cf126f5c94c2bad685a8a06feef8d16dce","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @mock.patch.object(linuxscsi.LinuxSCSI, \u0027process_lun_id\u0027, return_value\u003d\u00272\u0027)"},{"line_number":34,"context_line":"    def test_get_host_devices(self, mock_process_lun_id):"},{"line_number":35,"context_line":"        possible_devs \u003d [(3, \"0x5005076802232ade\", 2),"},{"line_number":36,"context_line":"                         (3, \"0x5005076802332ade\", 2), ]"},{"line_number":37,"context_line":"        devices \u003d self.connector._get_host_devices(possible_devs)"},{"line_number":38,"context_line":"        self.assertEqual(2, len(devices))"}],"source_content_type":"text/x-python","patch_set":20,"id":"eb15cb9e_2146891c","line":35,"range":{"start_line":35,"start_character":51,"end_line":35,"end_character":52},"updated":"2021-01-13 17:59:07.000000000","message":"nit: I would prefer to leave it using the `lun` variable, as it makes it clear what it is that we are checking there.","commit_id":"0805cf4ea4dc73bcd697cc14b3ff3464f6331121"}],"requirements.txt":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"920dc2cf126f5c94c2bad685a8a06feef8d16dce","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"a3c858ed_d5750743","line":19,"range":{"start_line":4,"start_character":0,"end_line":19,"end_character":0},"updated":"2021-01-13 17:59:07.000000000","message":"-1: Unrelated changes","commit_id":"0805cf4ea4dc73bcd697cc14b3ff3464f6331121"}],"test-requirements.txt":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"920dc2cf126f5c94c2bad685a8a06feef8d16dce","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"hacking\u003e\u003d3.1.0,\u003c3.2.0 # Apache-2.0"},{"line_number":6,"context_line":"coverage\u003e\u003d5.2.1 # Apache-2.0"},{"line_number":7,"context_line":"ddt\u003e\u003d1.4.1 # MIT"},{"line_number":8,"context_line":"oslotest\u003e\u003d4.4.1 # Apache-2.0"},{"line_number":9,"context_line":"testscenarios\u003e\u003d0.5.0 # Apache-2.0/BSD"},{"line_number":10,"context_line":"testtools\u003e\u003d2.4.0 # MIT"},{"line_number":11,"context_line":"stestr\u003e\u003d3.0.1 # Apache-2.0"},{"line_number":12,"context_line":"oslo.vmware\u003e\u003d3.7.0 # Apache-2.0"},{"line_number":13,"context_line":"castellan\u003e\u003d3.6.0 # Apache-2.0"},{"line_number":14,"context_line":"pycodestyle\u003d\u003d2.6.0 # MIT"},{"line_number":15,"context_line":"doc8\u003e\u003d0.8.1 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":20,"id":"bd3207bf_957d0c72","line":15,"range":{"start_line":5,"start_character":0,"end_line":15,"end_character":24},"updated":"2021-01-13 17:59:07.000000000","message":"-1: Unrelated changes","commit_id":"0805cf4ea4dc73bcd697cc14b3ff3464f6331121"}]}