)]}'
{"id":"openstack%2Fos-brick~742383","triplet_id":"openstack%2Fos-brick~master~Ib9914405474aa4006f689ad8fba90761b2f73e39","project":"openstack/os-brick","branch":"master","topic":"bug/1884114","hashtags":[],"change_id":"Ib9914405474aa4006f689ad8fba90761b2f73e39","subject":"rbd: Warn if ceph udev rules are not configured","status":"ABANDONED","created":"2020-07-22 10:15:44.000000000","updated":"2020-07-22 10:19:01.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ed93688fcb4d0b185fee6ab707b1fbc48b284fe5","_number":742383,"virtual_id_number":742383,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"b3f6746480795ab48c5997406b1d23a4aed55826","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-07-22 10:15:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"044eb94c15d87b5c4b1104899a1558fb70a8231f","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-07-22 10:19:01.000000000","message":"Abandoned\n\nWhoops, this should be a new PS for https://review.opendev.org/#/c/736758/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"60acce5feca194ae4619245fedec12987b147dca","revisions":{"60acce5feca194ae4619245fedec12987b147dca":{"kind":"REWORK","_number":1,"created":"2020-07-22 10:15:44.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/83/742383/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/os-brick","ref":"refs/changes/83/742383/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/os-brick refs/changes/83/742383/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/os-brick refs/changes/83/742383/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/os-brick refs/changes/83/742383/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/os-brick refs/changes/83/742383/1"}}},"commit":{"parents":[{"commit":"26299257ceb092ab82fab17b707bc48963abecaf","subject":"Merge \"Switch from unittest2 compat methods to Python 3.x methods\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-brick/commit/26299257ceb092ab82fab17b707bc48963abecaf"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2020-07-22 10:07:19.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2020-07-22 10:15:14.000000000","tz":60},"subject":"rbd: Warn if ceph udev rules are not configured","message":"rbd: Warn if ceph udev rules are not configured\n\nThe LUKS encryptor feature expects devices to have a symbolic link that\nit can overwrite in order to enable transparent encryption/decryption\nfor instances [1]. This is generally the case for RBD volumes, as Ceph\nuses udev rules [2] to create a \u0027/dev/rbd/{pool}/{device}\u0027 -\u003e\n\u0027/dev/rbdN\u0027 symlink. However, in an environment where udev daemon is not\npresent or configured correctly, this symlink will never be configured.\nThis causes things to crash and burn in a rather non-obvious manner when\nlocally attaching an encrypted RBD volume:\n\n  oslo_concurrency.processutils.ProcessExecutionError: Unexpected error while running command.\n  Command: cryptsetup luksOpen --key-file\u003d- /dev/rbd/volumes/volume-foo crypt-volume-foo\n  Exit code: 4\n  Stdout: \u0027\u0027\n  Stderr: \"Device /dev/rbd/volumes/foo doesn\u0027t exist or access denied.\\n\"\n\n(\u0027foo\u0027 being a stand-in for a very long \u0027device-$UUID\u0027 name)\n\nThe long term fix here is to probably stop relying on the side effects\nof these udev rules, i.e. the symlinks, but that is a far more involved\nfix that would not be backportable. Instead, for now we simply leave a\nbreadcrumb for the user, informing them as to what\u0027s gone wrong and\nencouraging them to look at the bug report for more information.\n\n[1] https://github.com/openstack/os-brick/blob/3.1.0/os_brick/encryptors/luks.py#L191-L195\n[2] https://github.com/ceph/ceph/blob/v14.0.0/udev/50-rbd.rules\n\nChange-Id: Ib9914405474aa4006f689ad8fba90761b2f73e39\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\nRelated-Bug: #1884114\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-brick/commit/60acce5feca194ae4619245fedec12987b147dca"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-brick/commit/60acce5feca194ae4619245fedec12987b147dca"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}