)]}'
{"bindep.txt":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7f01582a8ccbf8e918267fb61cb182cde72169eb","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# WARNING: please make sure any additional os-brick-specific dependency"},{"line_number":6,"context_line":"# not already covered by other packages is also installed through devstack."},{"line_number":7,"context_line":"# os-brick installed through pip does not include this file, so"},{"line_number":8,"context_line":"# the dependencies must be installed in another way."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"curl"},{"line_number":11,"context_line":"device-mapper-multipath [platform:rpm]"}],"source_content_type":"text/plain","patch_set":1,"id":"9f560f44_cf3953f3","line":8,"updated":"2020-08-12 14:10:44.000000000","message":"Should we point out specifically where? Or link to an example patch showing what to do?","commit_id":"c1df38e95c65df974d5b34e649aeb358acb6115f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7a6446a2e682f8cb93fc30bcf94c67cee1b8b945","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# WARNING: please make sure any additional os-brick-specific dependency"},{"line_number":6,"context_line":"# not already covered by other packages is also installed through devstack."},{"line_number":7,"context_line":"# os-brick installed through pip does not include this file, so"},{"line_number":8,"context_line":"# the dependencies must be installed in another way."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"curl"},{"line_number":11,"context_line":"device-mapper-multipath [platform:rpm]"}],"source_content_type":"text/plain","patch_set":1,"id":"9f560f44_f617c250","line":8,"in_reply_to":"9f560f44_cf3953f3","updated":"2020-08-13 12:07:33.000000000","message":"I agree with Sean here, because it took us a week to find those weird files.  I think a link to https://review.opendev.org/#/c/745838/ would be good.","commit_id":"c1df38e95c65df974d5b34e649aeb358acb6115f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ea072661044fdfcbbdad28cee202c8117a8c5621","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# not already covered by other packages is also installed through devstack."},{"line_number":7,"context_line":"# os-brick installed through pip does not include this file, so"},{"line_number":8,"context_line":"# the dependencies must be installed explicitly in devstack"},{"line_number":9,"context_line":"# by changing the list of packages under files/*/os-brick."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"curl"},{"line_number":12,"context_line":"device-mapper-multipath [platform:rpm]"}],"source_content_type":"text/plain","patch_set":2,"id":"9f560f44_fce041fd","line":9,"updated":"2020-08-13 12:44:44.000000000","message":"Let\u0027s explicitly state this is in devstack. I could see someone looking at this, looking at that os-brick tree structure, and being confused what this is talking about..\n\nA link to the review as an example would be even better.","commit_id":"e16d8e05955f5ecf4d608eaa1e947ab4e49a8efd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8dd6fa2aa34d58150d75ef5daa2cb7edbd3f5558","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# not already covered by other packages is also installed through devstack."},{"line_number":7,"context_line":"# os-brick installed through pip does not include this file, so"},{"line_number":8,"context_line":"# the dependencies must be installed explicitly in devstack"},{"line_number":9,"context_line":"# by changing the list of packages under files/*/os-brick."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"curl"},{"line_number":12,"context_line":"device-mapper-multipath [platform:rpm]"}],"source_content_type":"text/plain","patch_set":2,"id":"9f560f44_3cc47492","line":9,"range":{"start_line":9,"start_character":57,"end_line":9,"end_character":58},"updated":"2020-08-13 17:01:22.000000000","message":"please add \"in the devstack code repository\".  (It\u0027s slightly repetitive, but leaves no doubt as to where the files you mention are located.)","commit_id":"e16d8e05955f5ecf4d608eaa1e947ab4e49a8efd"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"99df1bb9c98dd4ab1111494652c01597bdcf0547","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# not already covered by other packages is also installed through devstack."},{"line_number":7,"context_line":"# os-brick installed through pip does not include this file, so"},{"line_number":8,"context_line":"# the dependencies must be installed explicitly in devstack"},{"line_number":9,"context_line":"# by changing the list of packages under files/*/os-brick."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"curl"},{"line_number":12,"context_line":"device-mapper-multipath [platform:rpm]"}],"source_content_type":"text/plain","patch_set":2,"id":"9f560f44_7c8ef1d0","line":9,"in_reply_to":"9f560f44_3cc75948","updated":"2020-08-13 13:09:55.000000000","message":"I was thinking that linking that review may be confusing, as it does much more than just adding lsscsi","commit_id":"e16d8e05955f5ecf4d608eaa1e947ab4e49a8efd"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"32ff76b2a5698fc49d91034a02810630719095d6","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# not already covered by other packages is also installed through devstack."},{"line_number":7,"context_line":"# os-brick installed through pip does not include this file, so"},{"line_number":8,"context_line":"# the dependencies must be installed explicitly in devstack"},{"line_number":9,"context_line":"# by changing the list of packages under files/*/os-brick."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"curl"},{"line_number":12,"context_line":"device-mapper-multipath [platform:rpm]"}],"source_content_type":"text/plain","patch_set":2,"id":"9f560f44_7c7c31b5","line":9,"in_reply_to":"9f560f44_7c8ef1d0","updated":"2020-08-13 13:11:35.000000000","message":"Yeah, fair enough. This is at least a much better breadcrumb to help find our way than we had before.","commit_id":"e16d8e05955f5ecf4d608eaa1e947ab4e49a8efd"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"5c6f1e61476e044258fc39629d5071e4c96d7e4e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# not already covered by other packages is also installed through devstack."},{"line_number":7,"context_line":"# os-brick installed through pip does not include this file, so"},{"line_number":8,"context_line":"# the dependencies must be installed explicitly in devstack"},{"line_number":9,"context_line":"# by changing the list of packages under files/*/os-brick."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"curl"},{"line_number":12,"context_line":"device-mapper-multipath [platform:rpm]"}],"source_content_type":"text/plain","patch_set":2,"id":"9f560f44_3cc75948","line":9,"in_reply_to":"9f560f44_fce041fd","updated":"2020-08-13 12:55:13.000000000","message":"Or just move the \"in devstack\" from the line below at the end of this line? I though it was clear this last sentence was to be read under that condition (but again not a native speaker).","commit_id":"e16d8e05955f5ecf4d608eaa1e947ab4e49a8efd"}]}