)]}'
{"os_brick/tests/initiator/connectors/test_scaleio.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"9f78ce9a6dde430f0bde9e0f292b4c72a44528f7","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        connection_properties \u003d {"},{"line_number":180,"context_line":"            \u0027hostIP\u0027: test_connector.MY_IP,"},{"line_number":181,"context_line":"            \u0027serverIP\u0027: test_connector.MY_IP,"},{"line_number":182,"context_line":"            \u0027scaleIO_volname\u0027: self.vol[\u0027name\u0027],"},{"line_number":183,"context_line":"            \u0027scaleIO_volume_id\u0027: self.vol[\u0027provider_id\u0027],"},{"line_number":184,"context_line":"            \u0027serverPort\u0027: 443,"},{"line_number":185,"context_line":"            \u0027serverUsername\u0027: \u0027test\u0027,"},{"line_number":186,"context_line":"            \u0027serverPassword\u0027: \u0027fake\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_724735be","line":183,"range":{"start_line":182,"start_character":0,"end_line":183,"end_character":57},"updated":"2020-08-13 20:01:56.000000000","message":"would we need to have two versions of this operation?\nOne that goes back to scaleIO brand and all driver releases based on it? And another for vxflexOS brand and all drivers based on it?\nOr for os_brick we left scaleIO for all release?","commit_id":"54504830828757e9d72e9440dde9cff33684a74d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f8d02f22802edc32d3ae08eabd11784dc7ce47b4","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        connection_properties \u003d {"},{"line_number":180,"context_line":"            \u0027hostIP\u0027: test_connector.MY_IP,"},{"line_number":181,"context_line":"            \u0027serverIP\u0027: test_connector.MY_IP,"},{"line_number":182,"context_line":"            \u0027scaleIO_volname\u0027: self.vol[\u0027name\u0027],"},{"line_number":183,"context_line":"            \u0027scaleIO_volume_id\u0027: self.vol[\u0027provider_id\u0027],"},{"line_number":184,"context_line":"            \u0027serverPort\u0027: 443,"},{"line_number":185,"context_line":"            \u0027serverUsername\u0027: \u0027test\u0027,"},{"line_number":186,"context_line":"            \u0027serverPassword\u0027: \u0027fake\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_74aa78d2","line":183,"range":{"start_line":182,"start_character":0,"end_line":183,"end_character":57},"in_reply_to":"9f560f44_39459918","updated":"2020-08-14 14:46:27.000000000","message":"The brick connector is an extremely low level implementation detail, so product brand names (ScaleIO vs. VxFlex OS vs. PowerFlex) should be transparent to the end user.","commit_id":"54504830828757e9d72e9440dde9cff33684a74d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5172fc76354a9a13f24793b4f966bcfa3bfdc6c5","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        connection_properties \u003d {"},{"line_number":180,"context_line":"            \u0027hostIP\u0027: test_connector.MY_IP,"},{"line_number":181,"context_line":"            \u0027serverIP\u0027: test_connector.MY_IP,"},{"line_number":182,"context_line":"            \u0027scaleIO_volname\u0027: self.vol[\u0027name\u0027],"},{"line_number":183,"context_line":"            \u0027scaleIO_volume_id\u0027: self.vol[\u0027provider_id\u0027],"},{"line_number":184,"context_line":"            \u0027serverPort\u0027: 443,"},{"line_number":185,"context_line":"            \u0027serverUsername\u0027: \u0027test\u0027,"},{"line_number":186,"context_line":"            \u0027serverPassword\u0027: \u0027fake\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_39459918","line":183,"range":{"start_line":182,"start_character":0,"end_line":183,"end_character":57},"in_reply_to":"9f560f44_724735be","updated":"2020-08-14 13:12:06.000000000","message":"Currently even vxflexos driver returns driver_volume_type:scaleio and scaleIO_* parameters, so we need only scaleIO_* parameters now.\n\nIn the future, you might want to add vxflexos connector with switching to driver_volume_type:vxflexos and some vxflexos_* parameters, but IMO that is a different topic.","commit_id":"54504830828757e9d72e9440dde9cff33684a74d"}]}