)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ad6b3b140fd9a4354c55e92ac6f1359b7bc59e09","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Current get_device_info uses space as delimiter to get the 1st colume of"},{"line_number":10,"context_line":"lsscsi output as \u0027H:C:T:L\u0027 info. But if the hlu# \u003e\u003d 10000, the 1st and"},{"line_number":11,"context_line":"2nd columns are concated and then 1st column becomes \u0027[H:C:T:L]disk\u0027."},{"line_number":12,"context_line":"When this happens, wrong hlu# is returned in dev_info."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I35c54556ea58768d078ac732c9361e32d141a5dd"},{"line_number":15,"context_line":"Closes-bug: #1892500"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_9ea6c60e","line":12,"updated":"2020-08-24 13:08:38.000000000","message":"This description is only correct for lsscsi 0.28 -- it looks like in 0.29, a space is added after the closing bracket even when the H:C:T:L field is longer, and the previous code would work as expected.\n\n    https://github.com/hreinecke/lsscsi/commit/45b4bb13519a782df4d0a4dca471e0d576a6b87d\n\nIt may be worth pointing out here that this only applies to certain versions of lsscsi.","commit_id":"08f73c78012edf775b3c8d5d4f1dc42834c325b0"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"aa38ad29d0b069714727f390ce5e148b35b42c3b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Current get_device_info uses space as delimiter to get the 1st colume of"},{"line_number":10,"context_line":"lsscsi output as \u0027H:C:T:L\u0027 info. But if the hlu# \u003e\u003d 10000, the 1st and"},{"line_number":11,"context_line":"2nd columns are concated and then 1st column becomes \u0027[H:C:T:L]disk\u0027."},{"line_number":12,"context_line":"When this happens, wrong hlu# is returned in dev_info."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I35c54556ea58768d078ac732c9361e32d141a5dd"},{"line_number":15,"context_line":"Closes-bug: #1892500"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_743793b1","line":12,"in_reply_to":"9f560f44_9ea6c60e","updated":"2020-08-24 14:44:20.000000000","message":"Hi Eric,\nThere\u0027s no need to point out.\nThe latest patchset works for both cases (both versions)\nIf you take a look at the new ut test, you should see that by using \u0027]\u0027 as the delimiter, it does not matter whether there\u0027s a space or not after \u0027]\u0027 (because we don\u0027t care anything after \u0027]\u0027.\nthanks and regards\nSam","commit_id":"08f73c78012edf775b3c8d5d4f1dc42834c325b0"}],"os_brick/tests/initiator/test_linuxscsi.py":[{"author":{"_account_id":18742,"name":"Ryan Liang","email":"ryan.liang@emc.com","username":"RyanLiang"},"change_message_id":"494cfd35fe0f445c445121801833ca3798de5e46","unresolved":false,"context_lines":[{"line_number":848,"context_line":"            \u0027multipathd\u0027, \u0027show\u0027, \u0027status\u0027, run_as_root\u003dTrue, root_helper\u003dNone)"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    def test_get_device_info(self):"},{"line_number":851,"context_line":"        ret \u003d \"[1:1:0:10000]disk Vendor Array 0100 /dev/adevice\\n\""},{"line_number":852,"context_line":"        with mock.patch.object(self.linuxscsi, \u0027_execute\u0027) as exec_mock:"},{"line_number":853,"context_line":"            exec_mock.return_value \u003d (ret, \"\")"},{"line_number":854,"context_line":"            info \u003d self.linuxscsi.get_device_info(\u0027/dev/adevice\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_5eb55331","line":851,"range":{"start_line":851,"start_character":21,"end_line":851,"end_character":28},"updated":"2020-08-24 08:14:14.000000000","message":"Please keep the old case, and add a new case for `[1:1:0:10000]disk...`.","commit_id":"7aa53d19b6972794daddfaa67c491af17ef950e0"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"91d96f40d8ebc634a5cb1f545f7e8869181725a5","unresolved":false,"context_lines":[{"line_number":848,"context_line":"            \u0027multipathd\u0027, \u0027show\u0027, \u0027status\u0027, run_as_root\u003dTrue, root_helper\u003dNone)"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    def test_get_device_info(self):"},{"line_number":851,"context_line":"        ret \u003d \"[1:1:0:10000]disk Vendor Array 0100 /dev/adevice\\n\""},{"line_number":852,"context_line":"        with mock.patch.object(self.linuxscsi, \u0027_execute\u0027) as exec_mock:"},{"line_number":853,"context_line":"            exec_mock.return_value \u003d (ret, \"\")"},{"line_number":854,"context_line":"            info \u003d self.linuxscsi.get_device_info(\u0027/dev/adevice\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_0456ee5c","line":851,"range":{"start_line":851,"start_character":21,"end_line":851,"end_character":28},"in_reply_to":"9f560f44_5eb55331","updated":"2020-08-24 10:42:43.000000000","message":"Hi Ryan,\nthanks for suggestion.\nadded cases for both scenarios.\nregards\nSam","commit_id":"7aa53d19b6972794daddfaa67c491af17ef950e0"}]}