)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"6ac398b0dbe57b2c7706da58382105f0c2c8351f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-09-22 14:51:03 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"encryptors: Remove \u0027CryptsetupEncryptor\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This has been deprecated since the 2.10.0 release way back in Train. We"},{"line_number":10,"context_line":"can safely remove it now."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"4bce1573_8fc27d9f","line":7,"updated":"2026-09-24 13:43:52.000000000","message":"Please note the tempest dependency here and that this conflicts with 791274 (which rewrites cryptsetup.py rather than deleting it); whichever lands second needs a rebase.","commit_id":"18e7d2c8a9bbb2cd1290a35de3d460babdfab33c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0911265483ed0bda5b46d2bd9d27e75db59e9539","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3401e8d4_a5024fbf","updated":"2022-02-14 10:12:06.000000000","message":"There\u0027s work to be done elsewhere before we can merge this","commit_id":"e3575725b32a2adbdb42c2a0befdb79575e01245"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"6ac398b0dbe57b2c7706da58382105f0c2c8351f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"58005ead_0e4b28b0","updated":"2026-09-24 13:43:52.000000000","message":"The os-brick side of this is fine and overdue. The problem is outside the repo: tempest master still runs the plain-cryptsetup scenario, so this cannot pass its own gate. Lee\u0027s PS3 -1 from 2021 is still exactly right and the two release-note threads are still open.\n\n-1 until a tempest change exists to gate or remove ``test_encrypted_cinder_volumes_cryptsetup``, with a Depends-On here. A recheck will fail the same way (I posted one yesterday before looking).","commit_id":"18e7d2c8a9bbb2cd1290a35de3d460babdfab33c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"a4912b3081075217d795b39657281345980744d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"23a1c488_379692e8","updated":"2026-09-23 15:30:28.000000000","message":"recheck","commit_id":"18e7d2c8a9bbb2cd1290a35de3d460babdfab33c"}],"os_brick/encryptors/__init__.py":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"6ac398b0dbe57b2c7706da58382105f0c2c8351f","unresolved":true,"context_lines":[{"line_number":27,"context_line":"LUKS \u003d \"luks\""},{"line_number":28,"context_line":"LUKS2 \u003d \"luks2\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"FORMAT_TO_FRONTEND_ENCRYPTOR_MAP \u003d {"},{"line_number":31,"context_line":"    LUKS: \u0027os_brick.encryptors.luks.LuksEncryptor\u0027,"},{"line_number":32,"context_line":"    LUKS2: \u0027os_brick.encryptors.luks.Luks2Encryptor\u0027,"},{"line_number":33,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"f06e511d_ff1fa6ff","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":36},"updated":"2026-09-24 13:43:52.000000000","message":"The lvm-lio-barbican failure is exactly this removal: tempest master still creates a volume type with provider ``plain`` in ``TestEncryptedCinderVolumes.test_encrypted_cinder_volumes_cryptsetup`` (test_encrypted_cinder_volumes.py:95), gated only on ``compute_feature_enabled.attach_encrypted_volume``. Tempest needs a new feature flag for the plain format (defaulting off on master, on for stable), or the test dropped, and this change needs a Depends-On to that. Nothing of the kind is open in tempest today.","commit_id":"18e7d2c8a9bbb2cd1290a35de3d460babdfab33c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"6ac398b0dbe57b2c7706da58382105f0c2c8351f","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    LUKS2: \u0027os_brick.encryptors.luks.Luks2Encryptor\u0027,"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LEGACY_PROVIDER_CLASS_TO_FORMAT_MAP \u003d {"},{"line_number":36,"context_line":"    \"nova.volume.encryptors.luks.LuksEncryptor\": LUKS,"},{"line_number":37,"context_line":"    \"nova.volume.encryptors.nop.NoopEncryptor\": None,"},{"line_number":38,"context_line":"    \"os_brick.encryptors.luks.LuksEncryptor\": LUKS,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fc6f8623_ff4a8006","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":39},"updated":"2026-09-24 13:43:52.000000000","message":"Related: the cinder API schema for encryption types validates ``provider`` as any string, so operators can still create ``plain`` types after this merges and will only find out at attach time with an import error from the out-of-tree path. Either a cinder change that rejects unsupported providers should land alongside, or the release note needs to say clearly that ``plain`` types must be retyped before upgrading os-brick.\n\nFor the record I checked cinder and nova master: neither references ``encryptors.PLAIN``, so removing the constant itself is safe.","commit_id":"18e7d2c8a9bbb2cd1290a35de3d460babdfab33c"}],"releasenotes/notes/remove-CryptsetupEncryptor-encryptor-d440183f587c4e7a.yaml":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"7d100468744613b7a66c3e21ecb4cedd45a76f29","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    the ``LuksEncryptor`` or ``Luks2Encryptor`` encryptors. For example:"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"      $ openstack volume type create \\"},{"line_number":11,"context_line":"          --encryption-provider luks2 \\"},{"line_number":12,"context_line":"          --encryption-control-location front-end \\"},{"line_number":13,"context_line":"          MyLuks2Encryptor"},{"line_number":14,"context_line":"      $ cinder retype --migration-policy on-demand \\"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fd5a985d_051f5c63","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":37},"updated":"2021-06-07 18:31:33.000000000","message":"Any reason for this instead of luks?","commit_id":"b6d7a4257f5dcd04a0601810770fc28a688372bd"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"7d100468744613b7a66c3e21ecb4cedd45a76f29","unresolved":true,"context_lines":[{"line_number":11,"context_line":"          --encryption-provider luks2 \\"},{"line_number":12,"context_line":"          --encryption-control-location front-end \\"},{"line_number":13,"context_line":"          MyLuks2Encryptor"},{"line_number":14,"context_line":"      $ cinder retype --migration-policy on-demand \\"},{"line_number":15,"context_line":"          $VOLUME MyLuks2Encryptor"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"764764ea_861f4a25","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":34},"updated":"2021-06-07 18:31:33.000000000","message":"This should work but there\u0027s zero coverage of this at the moment so we might want to get that covered first before we push ahead with this.","commit_id":"b6d7a4257f5dcd04a0601810770fc28a688372bd"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"6ac398b0dbe57b2c7706da58382105f0c2c8351f","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    2.10.0 release, has been removed. This encryptor and the underlying plain"},{"line_number":6,"context_line":"    cryptsetup encryption format it used were not widely used and were"},{"line_number":7,"context_line":"    inflexible (no key rotation). Users should retype existing volumes to use"},{"line_number":8,"context_line":"    the ``LuksEncryptor`` or ``Luks2Encryptor`` encryptors. For example:"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"      $ openstack volume type create \\"},{"line_number":11,"context_line":"          --encryption-provider luks2 \\"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"32baacea_9318f8c5","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":72},"updated":"2026-09-24 13:43:52.000000000","message":"Lee\u0027s question on this line is still open. luks2 as the example is the right call (key rotation, header redundancy), but a one-line reply on his thread would let it be resolved.","commit_id":"18e7d2c8a9bbb2cd1290a35de3d460babdfab33c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"6ac398b0dbe57b2c7706da58382105f0c2c8351f","unresolved":true,"context_lines":[{"line_number":11,"context_line":"          --encryption-provider luks2 \\"},{"line_number":12,"context_line":"          --encryption-control-location front-end \\"},{"line_number":13,"context_line":"          MyLuks2Encryptor"},{"line_number":14,"context_line":"      $ openstack volume set \\"},{"line_number":15,"context_line":"          --retype-policy on-demand \\"},{"line_number":16,"context_line":"          --type MyLuks2Encryptor \\"},{"line_number":17,"context_line":"          $VOLUME"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"aa483723_82a77a52","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":30},"updated":"2026-09-24 13:43:52.000000000","message":"Lee\u0027s second open thread: the retype path this recommends (plain to luks2 via on-demand migration) has no CI coverage anywhere. Since the release note is effectively telling operators \"do this or lose access to your data\", it would be good to either state it was verified manually, or add a note that the volume must be ``available`` (retype with an encryption change is refused for in-use volumes).","commit_id":"18e7d2c8a9bbb2cd1290a35de3d460babdfab33c"}]}