)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"38ca3ba40196db8e9594525afe7dda2e482d9b70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"26d85ec8_bd159f52","updated":"2021-10-15 18:48:16.000000000","message":"lgtm. I don\u0027t see any reason to fiddle with unit tests because it would only be testing oslo_concurrency\u0027s behavior.","commit_id":"b321b592a649d26e7d4ec933f87ec5ec8b928f2c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"f8f85fefc98c6a9379e8f8e3625494f3d5961c65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"287af0cb_f271bbb1","updated":"2021-10-15 16:30:42.000000000","message":"looks good to me. \ngiven the issues we have previously I agree that this is the best approach","commit_id":"b321b592a649d26e7d4ec933f87ec5ec8b928f2c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d603f3143d403124d32a650abf92262cd1e8c9e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"136e5ce1_3662b73e","updated":"2021-11-04 14:59:20.000000000","message":"Code change looks good.  I agree with your decision to make the change consistently across connectors.\n\nQuestion inline about the release note.","commit_id":"e46cad6e536036c71bcd3d1900df0d6fdeaa92c0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e3800480c9b73e3060ea73f8b1041fedd51670a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"882e8e35_d423bbe2","updated":"2021-10-28 08:22:13.000000000","message":"Forgot to add the external to the guard_connection context manager.  In most cases modern systems with a not too old Open iSCSI version this last external lock will not be used, but we should consider it while we are at it.","commit_id":"e46cad6e536036c71bcd3d1900df0d6fdeaa92c0"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e9eea3970775810469a011ac14dbbce39b4430e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d7cc7a6f_9caf5f37","updated":"2021-10-28 13:09:09.000000000","message":"Looks good to me","commit_id":"e46cad6e536036c71bcd3d1900df0d6fdeaa92c0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ad523f6f3331b7bc439a5d079c135723c163b0bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"28eeed3f_85571924","updated":"2021-11-11 18:04:06.000000000","message":"LGTM.","commit_id":"6a43669edc583f8fbcfb4c0f1c7bf6cebad9abd7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b507127e0fa7f7ce217b3fce20841fb1cee83b25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"aba8ba37_9b2b1bd0","updated":"2021-11-11 14:57:03.000000000","message":"Looks good!","commit_id":"6a43669edc583f8fbcfb4c0f1c7bf6cebad9abd7"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"7fd8776c90a414d38a6c7660000116d4ef968306","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3fe2a6d8_4dabf2a5","updated":"2021-11-12 01:48:00.000000000","message":"recheck","commit_id":"6a43669edc583f8fbcfb4c0f1c7bf6cebad9abd7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"13953b958aea547f25cb717788be1f36936eb783","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"735e1792_a42bc14c","updated":"2021-11-11 20:29:34.000000000","message":"recheck py36 tests couldn\u0027t install dependencies from pypi","commit_id":"6a43669edc583f8fbcfb4c0f1c7bf6cebad9abd7"}],"releasenotes/notes/external-locks-9f015988ebdc37d6.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d603f3143d403124d32a650abf92262cd1e8c9e0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d8ea8402_a172fbba","line":7,"updated":"2021-11-04 14:59:20.000000000","message":"Do we need to add an \u0027upgrade\u0027 section mentioning that [oslo_concurrency]/lock_path must now be set in the services using os-brick?  The default (in cinder at least) is None.  If it\u0027s not set, oslo.concurrency will raise a RequiredOptError, though I\u0027m not sure exactly when that would happen.","commit_id":"e46cad6e536036c71bcd3d1900df0d6fdeaa92c0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"27fa09b9f9654c9ffe7bc72c15123029dc5967d7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"eced237d_589266d4","line":7,"in_reply_to":"d8ea8402_a172fbba","updated":"2021-11-11 05:10:36.000000000","message":"I agree with Brian, we need to mention it since the consumer of os-brick (nova, cinder or glance) needs to configure the lock_path in their respective conf files to prevent RequiredOptError[1].\n\n[1] https://github.com/openstack/oslo.concurrency/blob/master/oslo_concurrency/lockutils.py#L180-L183","commit_id":"e46cad6e536036c71bcd3d1900df0d6fdeaa92c0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"37f2eac327b6ce94a26ad18c0bdd48124b8c5803","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"08dccfea_f81b6b0c","line":7,"in_reply_to":"eced237d_589266d4","updated":"2021-11-11 14:53:11.000000000","message":"Done","commit_id":"e46cad6e536036c71bcd3d1900df0d6fdeaa92c0"}]}