)]}'
{"id":"openstack%2Fos-brick~817708","triplet_id":"openstack%2Fos-brick~stable%2Fwallaby~I6f7f7d19540361204d4ae3ead2bd6dcddb8fcd68","project":"openstack/os-brick","branch":"stable/wallaby","topic":"bug/1947370","attention_set":{},"removed_from_attention_set":{"27615":{"account":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"last_update":"2021-11-12 17:16:27.000000000","reason":"Change was submitted"},"9535":{"account":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"last_update":"2021-11-12 09:39:35.000000000","reason":"Gorka Eguileor replied on the change"}},"hashtags":[],"change_id":"I6f7f7d19540361204d4ae3ead2bd6dcddb8fcd68","subject":"Use file locks in connectors","status":"MERGED","created":"2021-11-12 07:16:22.000000000","updated":"2022-04-21 15:15:16.000000000","submitted":"2021-11-12 17:16:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"817708-bug/1947370","meta_rev_id":"990152aaf68c97b5206390aced06bf2c5d68d3cc","_number":817708,"virtual_id_number":817708,"owner":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-11-12 17:16:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"recommended":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"all":[{"value":1,"date":"2021-11-12 15:16:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},{"value":2,"date":"2021-11-12 15:17:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-11-12 09:39:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},{"value":1,"date":"2021-11-12 15:17:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},{"_account_id":26077,"name":"NetApp SolidFire CI","email":"ng-openstack-solidfire-ci@netapp.com","username":"netapp-solidfire-ci"},{"_account_id":27710,"name":"Cloudbase OSBrick Windows CI","email":"windows_osbrick_ci@cloudbasesolutions.com","username":"windows-osbrick-ci"}],"REVIEWER":[{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-12 07:16:22.000000000","updated_by":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"reviewer":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"state":"REVIEWER"},{"updated":"2021-11-12 10:28:21.000000000","updated_by":{"_account_id":27710,"name":"Cloudbase OSBrick Windows CI","email":"windows_osbrick_ci@cloudbasesolutions.com","username":"windows-osbrick-ci"},"reviewer":{"_account_id":27710,"name":"Cloudbase OSBrick Windows CI","email":"windows_osbrick_ci@cloudbasesolutions.com","username":"windows-osbrick-ci"},"state":"CC"},{"updated":"2021-11-12 10:53:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-12 13:56:02.000000000","updated_by":{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},"reviewer":{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-11-12 14:36:57.000000000","updated_by":{"_account_id":26077,"name":"NetApp SolidFire CI","email":"ng-openstack-solidfire-ci@netapp.com","username":"netapp-solidfire-ci"},"reviewer":{"_account_id":26077,"name":"NetApp SolidFire CI","email":"ng-openstack-solidfire-ci@netapp.com","username":"netapp-solidfire-ci"},"state":"CC"},{"updated":"2021-11-12 15:16:15.000000000","updated_by":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"reviewer":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"state":"REVIEWER"},{"updated":"2021-11-12 15:17:04.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2022-04-21 13:55:55.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"CC"}],"messages":[{"id":"408b307554975657bc3a53ffcea23d0ab590aa62","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2021-11-12 07:16:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"87614911dcfb33fbd95cf78952c5495335e36fa7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2021-11-12 07:20:50.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"de41579947717d01c3eada2e3cc18383d1115734","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2021-11-12 07:32:50.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"7626fd04ad9381fc092d5020a8f40858840e7ed8","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2021-11-12 08:53:54.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"ea42c7329460727f38c93e907275093fdda6e76b","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2021-11-12 08:57:10.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"4af4e869362b6333392ce9cfc9ecc3fd5168a0ec","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2021-11-12 09:04:53.000000000","message":"Patch Set 4: Published edit on patch set 3.","accounts_in_message":[],"_revision_number":4},{"id":"ed0ba5e29e13ef3b227c7bb074546d66bb3ab2e0","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2021-11-12 09:05:11.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"17de71a1f0d4bd0cd38aee2feba0040fbab4ded3","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2021-11-12 09:39:35.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"1c152db47d7cf4a41876d906af003c0b8537f20b","tag":"autogenerated:cloudbase-ci","author":{"_account_id":27710,"name":"Cloudbase OSBrick Windows CI","email":"windows_osbrick_ci@cloudbasesolutions.com","username":"windows-osbrick-ci"},"date":"2021-11-12 10:28:21.000000000","message":"Patch Set 4:\n\nFor rechecking only on the Cloudbase OSBrick Windows CI, add a review comment with run-Cloudbase OSBrick Windows CI\n\n- os-brick-iscsi http://cloudbase-ci.com/os-brick/817708/4/iscsi/ : FAILURE in 54m 19s\n- os-brick-smb http://cloudbase-ci.com/os-brick/817708/4/smb/ : SUCCESS in 1h 02m 58s\n- os-brick-ceph http://cloudbase-ci.com/os-brick/817708/4/ceph/ : FAILURE in 1h 23m 05s","accounts_in_message":[],"_revision_number":4},{"id":"2eab617c8f6e17a4fcb2b717d36250a1fd5f0e5c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-12 10:53:30.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/934a686fd9df474ebe6c20e936b8c676 : SUCCESS in 1h 40m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d4da2de8006448479173ac50c2eed2b7 : SUCCESS in 5m 14s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/aeae4d131a324e84b180758e1817d900 : SUCCESS in 7m 24s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1f6a438d5b21473fb645416a46ddf4af : SUCCESS in 6m 08s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/1b02c5240f2841f795b057f26ed84dbf : SUCCESS in 5m 44s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a13b512a679b4bbfb2cd282471ab44a9 : SUCCESS in 8m 16s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1b57fd38b3fa438e95011e21f43a8597 : SUCCESS in 5m 58s\n- os-brick-code-coverage https://zuul.opendev.org/t/openstack/build/c50dfcb40ef24e138ef4a30279bf134f : SUCCESS in 6m 29s (non-voting)\n- os-brick-src-devstack-plugin-ceph https://zuul.opendev.org/t/openstack/build/bbea24b63d754229ac3416b99c631b32 : SUCCESS in 1h 15m 25s (non-voting)\n- os-brick-src-tempest-lvm-lio-barbican https://zuul.opendev.org/t/openstack/build/3c4302eb2e314b25845ba47ae52bb05e : SUCCESS in 1h 40m 21s\n- os-brick-src-tempest-nfs https://zuul.opendev.org/t/openstack/build/4b5912605b134892b1873fe1883535c5 : SUCCESS in 1h 41m 30s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"34d807be79e8bc704119a279ff1f4396b8f321b8","author":{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},"date":"2021-11-12 13:56:02.000000000","message":"Patch Set 4:\n\nBuild failed.\n\n- cinder-cDOT-iSCSI https://logs.openstack.netapp.com/logs/08/817708/4/upstream-check/cinder-cDOT-iSCSI/912f33a/ : FAILURE in 2h 59m 58s\n- cinder-cDOT-NFS https://logs.openstack.netapp.com/logs/08/817708/4/upstream-check/cinder-cDOT-NFS/3ca5f84/ : FAILURE in 2h 44m 52s\n- cinder-cDOT-FCP https://logs.openstack.netapp.com/logs/08/817708/4/upstream-check/cinder-cDOT-FCP/b12f388/ : NOT_REGISTERED\n\nComment \u0027run-NetApp CI\u0027 to rerun these tests. https://wiki.openstack.org/wiki/ThirdPartySystems/NetApp_CI","accounts_in_message":[],"_revision_number":4},{"id":"e1fef8ba6be326b0a3bebc29294642e6b4cd9fa3","author":{"_account_id":26077,"name":"NetApp SolidFire CI","email":"ng-openstack-solidfire-ci@netapp.com","username":"netapp-solidfire-ci"},"date":"2021-11-12 14:36:57.000000000","message":"Patch Set 4:\n\nBuild failed.\n\n- cinder-solidfire-iSCSI https://logs.openstack.netapp.com/logs/08/817708/4/upstream-solidfire-check/cinder-solidfire-iSCSI/534673d/ : FAILURE in 3h 43m 04s\n\nComment \u0027run-NetApp Solidfire CI\u0027 to rerun these tests. https://wiki.openstack.org/wiki/ThirdPartySystems/NetApp_SolidFire_CI","accounts_in_message":[],"_revision_number":4},{"id":"ba3bc5bf0ea5c7aaf84d9054b867a9e0922c5dfb","author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"date":"2021-11-12 15:16:15.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"e1b45e8477fa21bdae3b314e0f1cf97dae99c77d","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2021-11-12 15:17:04.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"60e2af9a4d92cc954c2e11efc05b0922aa097b4f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-12 15:18:11.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"b5dfad78441bb495172fd4f7dce4822c63ae3728","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-12 17:16:27.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/bc35af1505d241099ee2b67fc8aaa74b : SUCCESS in 1h 37m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4243c96fb8ce4df2aa552be3de0e2a67 : SUCCESS in 5m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8dbd2e520685457eae71270970bc97c8 : SUCCESS in 6m 53s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1541f86d60c041729b982af018d3ea1e : SUCCESS in 5m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/68eb958f47d046a292969ffdaf03c6c9 : SUCCESS in 7m 43s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9daa2db6c8a64344a9e0d71dea19c417 : SUCCESS in 6m 06s\n- os-brick-src-tempest-lvm-lio-barbican https://zuul.opendev.org/t/openstack/build/415c57f0cad94bf1ab1a8fa9065ae661 : SUCCESS in 1h 56m 47s","accounts_in_message":[],"_revision_number":4},{"id":"b3842f76e19e097229f5bcf609df93bcf3b76c94","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-12 17:16:27.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":4},{"id":"b13f3beeddee83fdc9a4de70a5413fec4b1b678c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-12 17:18:49.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/030ef4694d2d4806a969174f37c8058c : SUCCESS in 59s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/744b09c2b4064df2bf669cec6ec33b2f : SUCCESS in 1m 10s","accounts_in_message":[],"_revision_number":4},{"id":"84f8e839003d44177761f59864ebe93cceb52227","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-04-21 13:55:55.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"55105ec9b26471d4b4eba6190321dba21372a47c","tag":"autogenerated:gerrit:revert","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-04-21 13:57:49.000000000","message":"Created a revert of this change as Ic37872bc1053e61262187219736c339ea78a07be","accounts_in_message":[],"_revision_number":4},{"id":"85c7fd471d193ef5207ede45cce7c4a269ed0a11","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-04-21 14:17:35.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"990152aaf68c97b5206390aced06bf2c5d68d3cc","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2022-04-21 15:15:16.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"ecaf7f8962e12b43f9759ddc1b608f30eb9f5ebb","revisions":{"2a0d42dbe99b5d174af8844a9505413fd1ff2723":{"kind":"REWORK","_number":1,"created":"2021-11-12 07:16:22.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/08/817708/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/os-brick","ref":"refs/changes/08/817708/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/os-brick refs/changes/08/817708/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/os-brick refs/changes/08/817708/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/os-brick refs/changes/08/817708/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/os-brick refs/changes/08/817708/1"}}},"commit":{"parents":[{"commit":"779d1e48c79a7e47dd49ef8acaeeb61e99c253f0","subject":"multipath/iscsi: iSCSI connections are not reinitiated after reboot","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-brick/commit/779d1e48c79a7e47dd49ef8acaeeb61e99c253f0"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2021-10-15 12:33:57.000000000","tz":120},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2021-11-12 07:16:18.000000000","tz":-300},"subject":"Use file locks in connectors","message":"Use file locks in connectors\n\nCurrently os-brick is using in-process locks that will only prevent concurrent\naccess to critical sections to threads within a single process.\n\nBut based on the comment from iSCSI it seems like the code assumed that\nthese were file based locks that prevented concurrent access from\nmultiple processes.\n\nMentioned iSCSI comment is being removed because it\u0027s not correct that\nour current retry mechanism will work with connect and disconnect\nconcurrency issues.\n\nThe reason why we haven\u0027t seen errors in Nova is because it runs a\nsingle process and locks will be effective.\n\nThis is probably also not an issue in some transport protocols, such as\nFC and RBD, and it wouldn\u0027t be an issue in iSCSI connections that don\u0027t\nshare targets.\n\nBut for others, such as  iSCSI with shared targets and NVMe-OF, not\nusing file locks will create race conditions in the following cases:\n\n- More than 1 cinder backend: Because we can have one backend doing a\n  detach in a create volume from image and the other an attach for an\n  offline migration.\n\n- Backup/Restore if backup and volume services are running on the same\n  host.\n\n- HCI scenarios where cinder volume and nova compute are running on the\n  same host, even if the same lock path if configured.\n\n- Glance using Cinder as backend and is running on the same node as\n  cinder-volume or cinder-backup.\n\nThe problematic race conditions happen because the disconnect will do a\nlogout of the iSCSI target once the connect call has already confirmed\nthat the session to the target exists.\n\nWe could just add the file locks to iSCSI and NVMe, but I think it\u0027s\nsafer to add it to all the connectors and then, after proper testing, we\ncan can change back the locks that can be changed, and remove or reduce\nthe critical section in others.\n\nCloses-Bug: #1947370\nChange-Id: I6f7f7d19540361204d4ae3ead2bd6dcddb8fcd68\n(cherry picked from commit 6a43669edc583f8fbcfb4c0f1c7bf6cebad9abd7)\n(cherry picked from commit 19a4820f5c4ccca10d50d08198873b1515ee257b)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-brick/commit/2a0d42dbe99b5d174af8844a9505413fd1ff2723"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-brick/commit/2a0d42dbe99b5d174af8844a9505413fd1ff2723"}]},"branch":"refs/heads/stable/wallaby"},"f72e814f154bdb6e481fe074bcc3f546a5bea06f":{"kind":"REWORK","_number":2,"created":"2021-11-12 07:20:50.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/08/817708/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/os-brick","ref":"refs/changes/08/817708/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/os-brick refs/changes/08/817708/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/os-brick refs/changes/08/817708/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/os-brick refs/changes/08/817708/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/os-brick refs/changes/08/817708/2"}}},"commit":{"parents":[{"commit":"779d1e48c79a7e47dd49ef8acaeeb61e99c253f0","subject":"multipath/iscsi: iSCSI connections are not reinitiated after reboot","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-brick/commit/779d1e48c79a7e47dd49ef8acaeeb61e99c253f0"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2021-10-15 12:33:57.000000000","tz":120},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2021-11-12 07:20:22.000000000","tz":-300},"subject":"Use file locks in connectors","message":"Use file locks in connectors\n\nCurrently os-brick is using in-process locks that will only prevent concurrent\naccess to critical sections to threads within a single process.\n\nBut based on the comment from iSCSI it seems like the code assumed that\nthese were file based locks that prevented concurrent access from\nmultiple processes.\n\nMentioned iSCSI comment is being removed because it\u0027s not correct that\nour current retry mechanism will work with connect and disconnect\nconcurrency issues.\n\nThe reason why we haven\u0027t seen errors in Nova is because it runs a\nsingle process and locks will be effective.\n\nThis is probably also not an issue in some transport protocols, such as\nFC and RBD, and it wouldn\u0027t be an issue in iSCSI connections that don\u0027t\nshare targets.\n\nBut for others, such as  iSCSI with shared targets and NVMe-OF, not\nusing file locks will create race conditions in the following cases:\n\n- More than 1 cinder backend: Because we can have one backend doing a\n  detach in a create volume from image and the other an attach for an\n  offline migration.\n\n- Backup/Restore if backup and volume services are running on the same\n  host.\n\n- HCI scenarios where cinder volume and nova compute are running on the\n  same host, even if the same lock path if configured.\n\n- Glance using Cinder as backend and is running on the same node as\n  cinder-volume or cinder-backup.\n\nThe problematic race conditions happen because the disconnect will do a\nlogout of the iSCSI target once the connect call has already confirmed\nthat the session to the target exists.\n\nWe could just add the file locks to iSCSI and NVMe, but I think it\u0027s\nsafer to add it to all the connectors and then, after proper testing, we\ncan can change back the locks that can be changed, and remove or reduce\nthe critical section in others.\n\nCloses-Bug: #1947370\nChange-Id: I6f7f7d19540361204d4ae3ead2bd6dcddb8fcd68\n(cherry picked from commit 6a43669edc583f8fbcfb4c0f1c7bf6cebad9abd7)\n(cherry picked from commit 19a4820f5c4ccca10d50d08198873b1515ee257b)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-brick/commit/f72e814f154bdb6e481fe074bcc3f546a5bea06f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-brick/commit/f72e814f154bdb6e481fe074bcc3f546a5bea06f"}]},"branch":"refs/heads/stable/wallaby"},"08ddf69d648c5622a5a300a8636bda727b5b2722":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2021-11-12 07:32:50.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/08/817708/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/os-brick","ref":"refs/changes/08/817708/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/os-brick refs/changes/08/817708/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/os-brick refs/changes/08/817708/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/os-brick refs/changes/08/817708/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/os-brick refs/changes/08/817708/3"}}},"commit":{"parents":[{"commit":"779d1e48c79a7e47dd49ef8acaeeb61e99c253f0","subject":"multipath/iscsi: iSCSI connections are not reinitiated after reboot","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-brick/commit/779d1e48c79a7e47dd49ef8acaeeb61e99c253f0"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2021-10-15 12:33:57.000000000","tz":120},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2021-11-12 07:27:07.000000000","tz":-300},"subject":"Use file locks in connectors","message":"Use file locks in connectors\n\nCurrently os-brick is using in-process locks that will only prevent concurrent\naccess to critical sections to threads within a single process.\n\nBut based on the comment from iSCSI it seems like the code assumed that\nthese were file based locks that prevented concurrent access from\nmultiple processes.\n\nMentioned iSCSI comment is being removed because it\u0027s not correct that\nour current retry mechanism will work with connect and disconnect\nconcurrency issues.\n\nThe reason why we haven\u0027t seen errors in Nova is because it runs a\nsingle process and locks will be effective.\n\nThis is probably also not an issue in some transport protocols, such as\nFC and RBD, and it wouldn\u0027t be an issue in iSCSI connections that don\u0027t\nshare targets.\n\nBut for others, such as  iSCSI with shared targets and NVMe-OF, not\nusing file locks will create race conditions in the following cases:\n\n- More than 1 cinder backend: Because we can have one backend doing a\n  detach in a create volume from image and the other an attach for an\n  offline migration.\n\n- Backup/Restore if backup and volume services are running on the same\n  host.\n\n- HCI scenarios where cinder volume and nova compute are running on the\n  same host, even if the same lock path if configured.\n\n- Glance using Cinder as backend and is running on the same node as\n  cinder-volume or cinder-backup.\n\nThe problematic race conditions happen because the disconnect will do a\nlogout of the iSCSI target once the connect call has already confirmed\nthat the session to the target exists.\n\nWe could just add the file locks to iSCSI and NVMe, but I think it\u0027s\nsafer to add it to all the connectors and then, after proper testing, we\ncan can change back the locks that can be changed, and remove or reduce\nthe critical section in others.\n\nCloses-Bug: #1947370\nChange-Id: I6f7f7d19540361204d4ae3ead2bd6dcddb8fcd68\n(cherry picked from commit 6a43669edc583f8fbcfb4c0f1c7bf6cebad9abd7)\n(cherry picked from commit 19a4820f5c4ccca10d50d08198873b1515ee257b)\nConflicts: os_brick/initiator/connectors/iscsi.py\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-brick/commit/08ddf69d648c5622a5a300a8636bda727b5b2722"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-brick/commit/08ddf69d648c5622a5a300a8636bda727b5b2722"}]},"branch":"refs/heads/stable/wallaby"},"ecaf7f8962e12b43f9759ddc1b608f30eb9f5ebb":{"kind":"REWORK","_number":4,"created":"2021-11-12 09:04:53.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/08/817708/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/os-brick","ref":"refs/changes/08/817708/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/os-brick refs/changes/08/817708/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/os-brick refs/changes/08/817708/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/os-brick refs/changes/08/817708/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/os-brick refs/changes/08/817708/4"}}},"commit":{"parents":[{"commit":"779d1e48c79a7e47dd49ef8acaeeb61e99c253f0","subject":"multipath/iscsi: iSCSI connections are not reinitiated after reboot","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-brick/commit/779d1e48c79a7e47dd49ef8acaeeb61e99c253f0"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2021-10-15 12:33:57.000000000","tz":120},"committer":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2021-11-12 09:04:29.000000000","tz":0},"subject":"Use file locks in connectors","message":"Use file locks in connectors\n\nCurrently os-brick is using in-process locks that will only prevent concurrent\naccess to critical sections to threads within a single process.\n\nBut based on the comment from iSCSI it seems like the code assumed that\nthese were file based locks that prevented concurrent access from\nmultiple processes.\n\nMentioned iSCSI comment is being removed because it\u0027s not correct that\nour current retry mechanism will work with connect and disconnect\nconcurrency issues.\n\nThe reason why we haven\u0027t seen errors in Nova is because it runs a\nsingle process and locks will be effective.\n\nThis is probably also not an issue in some transport protocols, such as\nFC and RBD, and it wouldn\u0027t be an issue in iSCSI connections that don\u0027t\nshare targets.\n\nBut for others, such as  iSCSI with shared targets and NVMe-OF, not\nusing file locks will create race conditions in the following cases:\n\n- More than 1 cinder backend: Because we can have one backend doing a\n  detach in a create volume from image and the other an attach for an\n  offline migration.\n\n- Backup/Restore if backup and volume services are running on the same\n  host.\n\n- HCI scenarios where cinder volume and nova compute are running on the\n  same host, even if the same lock path if configured.\n\n- Glance using Cinder as backend and is running on the same node as\n  cinder-volume or cinder-backup.\n\nThe problematic race conditions happen because the disconnect will do a\nlogout of the iSCSI target once the connect call has already confirmed\nthat the session to the target exists.\n\nWe could just add the file locks to iSCSI and NVMe, but I think it\u0027s\nsafer to add it to all the connectors and then, after proper testing, we\ncan can change back the locks that can be changed, and remove or reduce\nthe critical section in others.\n\nCloses-Bug: #1947370\nChange-Id: I6f7f7d19540361204d4ae3ead2bd6dcddb8fcd68\n(cherry picked from commit 6a43669edc583f8fbcfb4c0f1c7bf6cebad9abd7)\n(cherry picked from commit 19a4820f5c4ccca10d50d08198873b1515ee257b)\nConflicts: os_brick/initiator/connectors/iscsi.py\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-brick/commit/ecaf7f8962e12b43f9759ddc1b608f30eb9f5ebb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-brick/commit/ecaf7f8962e12b43f9759ddc1b608f30eb9f5ebb"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}