)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"82cb078c4b27bb042ee228a01dd613ea46c1b776","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Execute multipath -l with device WWN"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"``multipath -l`` expects multipath device WWN as it\u0027s argument and"},{"line_number":10,"context_line":"we currently provide it with the path of the underlying device."},{"line_number":11,"context_line":"This runs into the issue of ``multipath -l`` command failing"},{"line_number":12,"context_line":"thereby failing the volume attachment operation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4e245e79_5fb3db0e","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":62},"updated":"2022-01-10 12:39:48.000000000","message":"-1: AFAIK that is false.  It can work with WWID, device path, or device ID, as explained by the man page.\n\nSYNOPSYS\n        multipath [-v level] [-l|-ll] [device]\n\n\nARGUMENTS\n       The device argument restricts multipath\u0027s operation to devices matching the given expres‐\n       sion.  The  argument  may refer either to a multipath map or to its components (\"paths\").\n       The expression may be in one of the following formats:\n\n       device node   file name of a device node, e.g. /dev/dm-10 or /dev/sda. If the node refers\n                     to  an existing device mapper device representing a multipath map, this se‐\n                     lects the map or its paths, depending on the operation mode. Otherwise,  it\n                     selects a path device.\n\n       device ID     kernel  device  number  specified  by major:minor numbers, e.g. 65:16. This\n                     format can only be used for path devices.\n\n       WWID          a World Wide Identifier matching a multipath map  or  its  paths.  To  list\n                     WWIDs  of devices present in the system, use e.g. the command \"multipath -d\n                     -v3 2\u003e/dev/null\".","commit_id":"b1685c07ff37d52e858d5cb63e312a87feb0f411"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"fb26c58f2eaede17b479d2391bccda791a4ea7f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f520e786_92ea1408","updated":"2021-12-27 06:27:14.000000000","message":"LGTM","commit_id":"b1685c07ff37d52e858d5cb63e312a87feb0f411"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c305f9a771c58a67105dc982c442b98aa24f3c32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1be7e896_d28fab1b","updated":"2021-12-26 15:52:32.000000000","message":"Looks good to me","commit_id":"b1685c07ff37d52e858d5cb63e312a87feb0f411"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"37ad7b4863d5edb4baedba6009b5f607eb276ae6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c608796f_0aecfddb","updated":"2021-12-27 15:22:03.000000000","message":"The code looks good, thanks for the bugfix Rajat. \nAs far as I know we don\u0027t have a CI job for multipath to check this.","commit_id":"b1685c07ff37d52e858d5cb63e312a87feb0f411"}],"os_brick/initiator/connectors/base.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"82cb078c4b27bb042ee228a01dd613ea46c1b776","unresolved":true,"context_lines":[{"line_number":101,"context_line":"        multipath_id \u003d None"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        if path is None:"},{"line_number":104,"context_line":"            # we should pass the multipath device WWN instead of the underlying"},{"line_number":105,"context_line":"            # device path to find_multipath_device"},{"line_number":106,"context_line":"            mpath_info \u003d self._linuxscsi.find_multipath_device("},{"line_number":107,"context_line":"                device_wwn)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ce93c28_0a58a613","line":104,"range":{"start_line":104,"start_character":14,"end_line":104,"end_character":54},"updated":"2022-01-10 12:39:48.000000000","message":"Please add the reason why we should","commit_id":"b1685c07ff37d52e858d5cb63e312a87feb0f411"}]}