)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"78ddf3d305c679584ad5361dc861db4f317e7c5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"22aebc43_9fe4b4c8","updated":"2022-02-09 22:40:30.000000000","message":"See inline comments.","commit_id":"c981b7ea7a68957e578f5918bbd494261d2e2f1b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4005dbe6be7ebd052bbf48e955fc5660979f5478","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c8ec3be0_4abdfd6f","updated":"2022-02-10 14:18:58.000000000","message":"Please fix the commit message.  Standard format is:\n\nsubject line: 50 chars max\n(blank line)\nbody of commit message, wrapped at 70 chars\n\nthanks!","commit_id":"124b9db43cf540c06bf7df2a95a311509c17a65d"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"9fe9ce76e1a89ee1bdae553ce9fff9b4229130e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6aabcb5b_201bfa54","in_reply_to":"c8ec3be0_4abdfd6f","updated":"2022-02-10 16:13:57.000000000","message":"Done","commit_id":"124b9db43cf540c06bf7df2a95a311509c17a65d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b210df840a4aed072106a9b5d50d2f1adbbf7bcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2943a712_80a204f5","updated":"2022-02-12 19:26:05.000000000","message":"Change looks OK, zuul and third-party CI are green.","commit_id":"ef884020b3d435b9971d3ce298ddd1f9b50ab81a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1f41104522d604c800b8dd9a4392b7a95fb5bcba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7772c6a5_8fd8a784","updated":"2022-02-14 15:32:22.000000000","message":"Looks good to me!  Thanks!","commit_id":"ef884020b3d435b9971d3ce298ddd1f9b50ab81a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"22894d188529ca2b0ff2653ae70eaa44ddca7aa5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c6a9ae18_2fbea83e","updated":"2022-02-14 19:02:07.000000000","message":"recheck tempest-full-py3 : tempest.api.volume.test_volumes_snapshots_negative.VolumesSnapshotNegativeTestJSON.test_volume_from_snapshot_decreasing_size - could not ssh into instance","commit_id":"ef884020b3d435b9971d3ce298ddd1f9b50ab81a"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"ee2ba515b86666098a7b3b8a57eb12414e77fbe4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5a7c2a88_94f16718","in_reply_to":"c6a9ae18_2fbea83e","updated":"2022-02-14 20:37:27.000000000","message":"Could be a temporary network issue?\nAll volume tempest tests in our CI env pass thru:\n{0} tempest.api.volume.test_volumes_snapshots_negative.VolumesSnapshotNegativeTestJSON.test_volume_from_snapshot_decreasing_size [2.578207s] ... ok","commit_id":"ef884020b3d435b9971d3ce298ddd1f9b50ab81a"}],"os_brick/initiator/connectors/nvmeof.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"78ddf3d305c679584ad5361dc861db4f317e7c5b","unresolved":true,"context_lines":[{"line_number":788,"context_line":"                if is_exist:"},{"line_number":789,"context_line":"                    return"},{"line_number":790,"context_line":"                time.sleep(1)"},{"line_number":791,"context_line":"            except Exception:"},{"line_number":792,"context_line":"                LOG.debug(\u0027[!] Exception_wait_raid!\u0027)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"cfcb46dc_06065cc8","line":791,"range":{"start_line":791,"start_character":12,"end_line":791,"end_character":28},"updated":"2022-02-09 22:40:30.000000000","message":"You\u0027re swallowing the exception here ... are you sure you don\u0027t want to re-raise?","commit_id":"c981b7ea7a68957e578f5918bbd494261d2e2f1b"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"5e7e49a4724315b136bcccab03d602a66ab44e5f","unresolved":false,"context_lines":[{"line_number":788,"context_line":"                if is_exist:"},{"line_number":789,"context_line":"                    return"},{"line_number":790,"context_line":"                time.sleep(1)"},{"line_number":791,"context_line":"            except Exception:"},{"line_number":792,"context_line":"                LOG.debug(\u0027[!] Exception_wait_raid!\u0027)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"0560cc16_be858f12","line":791,"range":{"start_line":791,"start_character":12,"end_line":791,"end_character":28},"in_reply_to":"78f10687_37b2264b","updated":"2022-02-10 13:58:40.000000000","message":"Ack","commit_id":"c981b7ea7a68957e578f5918bbd494261d2e2f1b"},{"author":{"_account_id":34550,"name":"Gili Buzaglo","email":"gili.buzaglo@kioxia.com","username":"gilib"},"change_message_id":"a03fb0fe8a51f40fe6eb2bfb03c8b400ffc8c876","unresolved":true,"context_lines":[{"line_number":788,"context_line":"                if is_exist:"},{"line_number":789,"context_line":"                    return"},{"line_number":790,"context_line":"                time.sleep(1)"},{"line_number":791,"context_line":"            except Exception:"},{"line_number":792,"context_line":"                LOG.debug(\u0027[!] Exception_wait_raid!\u0027)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"78f10687_37b2264b","line":791,"range":{"start_line":791,"start_character":12,"end_line":791,"end_character":28},"in_reply_to":"cfcb46dc_06065cc8","updated":"2022-02-10 10:28:11.000000000","message":"We don\u0027t want to stop waiting due to some exception ,this way it\u0027s more robust","commit_id":"c981b7ea7a68957e578f5918bbd494261d2e2f1b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"78ddf3d305c679584ad5361dc861db4f317e7c5b","unresolved":true,"context_lines":[{"line_number":790,"context_line":"                time.sleep(1)"},{"line_number":791,"context_line":"            except Exception:"},{"line_number":792,"context_line":"                LOG.debug(\u0027[!] Exception_wait_raid!\u0027)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    @staticmethod"},{"line_number":795,"context_line":"    def end_raid(executor, device_path):"},{"line_number":796,"context_line":"        raid_exists \u003d NVMeOFConnector.is_raid_exists(executor, device_path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f441f05_66792c82","line":793,"updated":"2022-02-09 22:40:30.000000000","message":"If you reach line 793, it means that you did the full wait and the md still wasn\u0027t created.  I\u0027d think you\u0027d want to at least log that, and possibly raise an exception?","commit_id":"c981b7ea7a68957e578f5918bbd494261d2e2f1b"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"5e7e49a4724315b136bcccab03d602a66ab44e5f","unresolved":false,"context_lines":[{"line_number":790,"context_line":"                time.sleep(1)"},{"line_number":791,"context_line":"            except Exception:"},{"line_number":792,"context_line":"                LOG.debug(\u0027[!] Exception_wait_raid!\u0027)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    @staticmethod"},{"line_number":795,"context_line":"    def end_raid(executor, device_path):"},{"line_number":796,"context_line":"        raid_exists \u003d NVMeOFConnector.is_raid_exists(executor, device_path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d4cfcb5b_c594e7b7","line":793,"in_reply_to":"082607ac_f1a947d3","updated":"2022-02-10 13:58:40.000000000","message":"Done","commit_id":"c981b7ea7a68957e578f5918bbd494261d2e2f1b"},{"author":{"_account_id":34550,"name":"Gili Buzaglo","email":"gili.buzaglo@kioxia.com","username":"gilib"},"change_message_id":"a03fb0fe8a51f40fe6eb2bfb03c8b400ffc8c876","unresolved":true,"context_lines":[{"line_number":790,"context_line":"                time.sleep(1)"},{"line_number":791,"context_line":"            except Exception:"},{"line_number":792,"context_line":"                LOG.debug(\u0027[!] Exception_wait_raid!\u0027)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    @staticmethod"},{"line_number":795,"context_line":"    def end_raid(executor, device_path):"},{"line_number":796,"context_line":"        raid_exists \u003d NVMeOFConnector.is_raid_exists(executor, device_path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"082607ac_f1a947d3","line":793,"in_reply_to":"3f441f05_66792c82","updated":"2022-02-10 10:28:11.000000000","message":"Agree, we should log and raise an exception if wait didn\u0027t help (although it\u0027s probability is ~0)","commit_id":"c981b7ea7a68957e578f5918bbd494261d2e2f1b"}]}
