)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6ff23b9960b7a6aa121a2f9701724db568fb6994","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e79b509_a787fb5b","updated":"2022-07-15 12:15:02.000000000","message":"LGTM.","commit_id":"e17bdf969b55aa8d51d7335274b19b3d58c2ed3c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7eb12291d5d660f29cc17f305945ef214d5ac514","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e07048b_bd3662af","updated":"2022-07-15 12:21:32.000000000","message":"Since it\u0027s already approved, just leaving my vote. LGTM.","commit_id":"e17bdf969b55aa8d51d7335274b19b3d58c2ed3c"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"aa05afccb15b4219bcbf1264e4b914f7f26aad9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2d2310ed_86e3aef7","updated":"2022-07-13 14:27:19.000000000","message":"This fix looks good to me.","commit_id":"e17bdf969b55aa8d51d7335274b19b3d58c2ed3c"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"9cef1c77389358da38e67ee68d799397802c7c82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e88bbfcc_d93b4923","updated":"2022-07-13 14:04:56.000000000","message":"run Pure Storage CI","commit_id":"e17bdf969b55aa8d51d7335274b19b3d58c2ed3c"}],"os_brick/initiator/connectors/nvmeof.py":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"9cef1c77389358da38e67ee68d799397802c7c82","unresolved":false,"context_lines":[{"line_number":851,"context_line":"        LOG.debug(\"[!] cmd \u003d \" + str(cmd))"},{"line_number":852,"context_line":"        fs_type \u003d None"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"        # We don\u0027t care about errors, on error lines will be \u0027\u0027 so it\u0027s ok"},{"line_number":855,"context_line":"        lines, err \u003d self._execute("},{"line_number":856,"context_line":"            *cmd, run_as_root\u003dTrue, root_helper\u003dself._root_helper,"},{"line_number":857,"context_line":"            check_exit_code\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a1a90cdd_a5aac095","line":854,"updated":"2022-07-13 14:04:56.000000000","message":"Thanks for this comment.","commit_id":"e17bdf969b55aa8d51d7335274b19b3d58c2ed3c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7eb12291d5d660f29cc17f305945ef214d5ac514","unresolved":true,"context_lines":[{"line_number":851,"context_line":"        LOG.debug(\"[!] cmd \u003d \" + str(cmd))"},{"line_number":852,"context_line":"        fs_type \u003d None"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"        # We don\u0027t care about errors, on error lines will be \u0027\u0027 so it\u0027s ok"},{"line_number":855,"context_line":"        lines, err \u003d self._execute("},{"line_number":856,"context_line":"            *cmd, run_as_root\u003dTrue, root_helper\u003dself._root_helper,"},{"line_number":857,"context_line":"            check_exit_code\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c8be7a95_f56b1eaa","line":854,"range":{"start_line":854,"start_character":46,"end_line":854,"end_character":47},"updated":"2022-07-15 12:21:32.000000000","message":"nit: comma here","commit_id":"e17bdf969b55aa8d51d7335274b19b3d58c2ed3c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7eb12291d5d660f29cc17f305945ef214d5ac514","unresolved":true,"context_lines":[{"line_number":855,"context_line":"        lines, err \u003d self._execute("},{"line_number":856,"context_line":"            *cmd, run_as_root\u003dTrue, root_helper\u003dself._root_helper,"},{"line_number":857,"context_line":"            check_exit_code\u003dFalse)"},{"line_number":858,"context_line":"        fs_type \u003d lines.split(\u0027\\n\u0027)[0]"},{"line_number":859,"context_line":"        return fs_type or None"}],"source_content_type":"text/x-python","patch_set":1,"id":"57977e99_3410a9e8","line":858,"range":{"start_line":858,"start_character":0,"end_line":858,"end_character":38},"updated":"2022-07-15 12:21:32.000000000","message":"I was confused at this statement if lines is going to be \u0027\u0027(empty string) based on the comment\nthis statement doesn\u0027t error out in any case (forgot that split returns a list)\n\n\u003e\u003e\u003e lines \u003d \u0027\u0027\n\u003e\u003e\u003e xyz \u003d lines.split(\u0027\\n\u0027)[0]\n\u003e\u003e\u003e xyz","commit_id":"e17bdf969b55aa8d51d7335274b19b3d58c2ed3c"}],"os_brick/tests/initiator/connectors/test_nvmeof.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7eb12291d5d660f29cc17f305945ef214d5ac514","unresolved":true,"context_lines":[{"line_number":992,"context_line":"        self.assertEqual(\u0027\u0027, result)"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"    @mock.patch.object(executor.Executor, \u0027_execute\u0027,"},{"line_number":995,"context_line":"                       return_value\u003d(\u0027\u0027, \u0027There was a big error\u0027))"},{"line_number":996,"context_line":"    def test_get_fs_type_err(self, mock_execute):"},{"line_number":997,"context_line":"        result \u003d self.connector._get_fs_type(NVME_DEVICE_PATH)"},{"line_number":998,"context_line":"        self.assertIsNone(result)"}],"source_content_type":"text/x-python","patch_set":1,"id":"575e8e34_71ce6079","line":995,"range":{"start_line":995,"start_character":42,"end_line":995,"end_character":63},"updated":"2022-07-15 12:21:32.000000000","message":"sounds legit","commit_id":"e17bdf969b55aa8d51d7335274b19b3d58c2ed3c"}]}
