)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"646bd7c48c31a972d172ef9b4fed6a29eae5fde8","unresolved":true,"context_lines":[{"line_number":10,"context_line":"grep and then to awk using a privileged shell, but there\u0027s no need to do"},{"line_number":11,"context_line":"that."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Actually the mdstat file ha 0444 access, so we can read it in Python"},{"line_number":14,"context_line":"directly instead of having to call the privsep daemon to create the"},{"line_number":15,"context_line":"subprocess with the shell."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a4e8dd04_ce003bce","line":13,"updated":"2022-05-23 05:15:30.000000000","message":"nit : file have 0444 access , patch looks good","commit_id":"9aecf31d9ca835718b6313dd4c850d76b6304a0e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"12df48f2b3ee2fdc68d26b7f49358dd8825d272c","unresolved":true,"context_lines":[{"line_number":10,"context_line":"grep and then to awk using a privileged shell, but there\u0027s no need to do"},{"line_number":11,"context_line":"that."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Actually the mdstat file ha 0444 access, so we can read it in Python"},{"line_number":14,"context_line":"directly instead of having to call the privsep daemon to create the"},{"line_number":15,"context_line":"subprocess with the shell."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6a65928a_0f24b90b","line":13,"in_reply_to":"a4e8dd04_ce003bce","updated":"2022-06-14 10:42:34.000000000","message":"Thanks, will fix it if I have to send another patch.","commit_id":"9aecf31d9ca835718b6313dd4c850d76b6304a0e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"b29e265b49a9847451131d21e3c52af990aee45c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4675e410_9abc6b2a","updated":"2022-08-18 01:17:58.000000000","message":"Sorry for the bikeshedding, but I think this can be improved slightly.","commit_id":"763d8cd1de1da0dec2538f8de1e9bf28159483e7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"658bf0c24abb0c892e88c7f43ba140745fb59b5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"387a90b7_798d0ec7","updated":"2022-08-23 15:26:44.000000000","message":"LGTM and confirmed that /proc/mdstat is readable and doesn\u0027t error out with a sample python script in my system.\n\n[rajatdhasmana@192 17:34:59 ~]$ ll /proc/mdstat \n-r--r--r--. 1 root root 0 Aug 23 20:49 /proc/mdstat","commit_id":"da2bfa41f5418cfe3845aed92f2de2c3cfe1947f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"44e58c4f7a801cd84b7fa32d3774948a924d5459","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"253f7208_33791cfa","updated":"2022-08-23 21:18:16.000000000","message":"LGTM.","commit_id":"da2bfa41f5418cfe3845aed92f2de2c3cfe1947f"}],"os_brick/initiator/connectors/nvmeof.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"b29e265b49a9847451131d21e3c52af990aee45c","unresolved":true,"context_lines":[{"line_number":1265,"context_line":"        try:"},{"line_number":1266,"context_line":"            with open(\u0027/proc/mdstat\u0027, \u0027r\u0027) as f:"},{"line_number":1267,"context_line":"                lines \u003d [line.split(\u0027 \u0027)[0]"},{"line_number":1268,"context_line":"                         for line in f.read().split(\u0027\\n\u0027)"},{"line_number":1269,"context_line":"                         if device_name in line]"},{"line_number":1270,"context_line":""},{"line_number":1271,"context_line":"                if lines:"}],"source_content_type":"text/x-python","patch_set":2,"id":"d825af6f_d8181665","line":1268,"updated":"2022-08-18 01:17:58.000000000","message":"Why not\n\n    for line in f\n\nNo need for f.read().split(\u0027\\n\u0027).\n\nAlso, I\u0027m a little concerned about some weird device name or whatnot, so I\u0027d add filtering for lines that have a colon, although this is not what the grep pipeline did in the original, and it\u0027s more prudent to avoid fixes during a re-implementation.","commit_id":"763d8cd1de1da0dec2538f8de1e9bf28159483e7"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"2956cf715bfc44930f9a5564df459956f734e906","unresolved":false,"context_lines":[{"line_number":1265,"context_line":"        try:"},{"line_number":1266,"context_line":"            with open(\u0027/proc/mdstat\u0027, \u0027r\u0027) as f:"},{"line_number":1267,"context_line":"                lines \u003d [line.split(\u0027 \u0027)[0]"},{"line_number":1268,"context_line":"                         for line in f.read().split(\u0027\\n\u0027)"},{"line_number":1269,"context_line":"                         if device_name in line]"},{"line_number":1270,"context_line":""},{"line_number":1271,"context_line":"                if lines:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ef301a1a_6c78bf77","line":1268,"in_reply_to":"0ca9ccad_48b0d4cd","updated":"2022-08-23 14:21:34.000000000","message":"Ack","commit_id":"763d8cd1de1da0dec2538f8de1e9bf28159483e7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c824ae2ca6fd890e0d93c22a7cc704a6cf13aa53","unresolved":true,"context_lines":[{"line_number":1265,"context_line":"        try:"},{"line_number":1266,"context_line":"            with open(\u0027/proc/mdstat\u0027, \u0027r\u0027) as f:"},{"line_number":1267,"context_line":"                lines \u003d [line.split(\u0027 \u0027)[0]"},{"line_number":1268,"context_line":"                         for line in f.read().split(\u0027\\n\u0027)"},{"line_number":1269,"context_line":"                         if device_name in line]"},{"line_number":1270,"context_line":""},{"line_number":1271,"context_line":"                if lines:"}],"source_content_type":"text/x-python","patch_set":2,"id":"0ca9ccad_48b0d4cd","line":1268,"in_reply_to":"d825af6f_d8181665","updated":"2022-08-23 10:18:59.000000000","message":"This patch is just trying to replace existing code with a faster version while preserving the behavior, so I\u0027d rather not filter by colon.\n\nI don\u0027t know why you say that this doesn\u0027t do the same thing it did before.  Could you give an example, please?  Because as far as I know this has the exact same behavior.","commit_id":"763d8cd1de1da0dec2538f8de1e9bf28159483e7"}],"os_brick/tests/initiator/connectors/test_nvmeof.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"b29e265b49a9847451131d21e3c52af990aee45c","unresolved":true,"context_lines":[{"line_number":1707,"context_line":"            \u0027\\nPersonalities : [raid0]\\nmd0 : active raid0 nvme0n1[4] \u0027"},{"line_number":1708,"context_line":"            \u0027nvme1n1[3] nvme2n1[2] nvme3n1[1]\\n      20508171264 blocks super \u0027"},{"line_number":1709,"context_line":"            \u00271.2 level 5, 512k chunk, algorithm 2 [4/4] [UUUU]\\nunused \u0027"},{"line_number":1710,"context_line":"            \u0027devices: \u003cnone\u003e\\n\u0027)"},{"line_number":1711,"context_line":"        mock_fd \u003d mock_open.return_value.__enter__.return_value"},{"line_number":1712,"context_line":"        mock_fd.read.return_value \u003d md_stat_contents"},{"line_number":1713,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f07e27b_4ce471aa","line":1710,"updated":"2022-08-18 01:17:58.000000000","message":"That\u0027s a hostile formallting.","commit_id":"763d8cd1de1da0dec2538f8de1e9bf28159483e7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c824ae2ca6fd890e0d93c22a7cc704a6cf13aa53","unresolved":false,"context_lines":[{"line_number":1707,"context_line":"            \u0027\\nPersonalities : [raid0]\\nmd0 : active raid0 nvme0n1[4] \u0027"},{"line_number":1708,"context_line":"            \u0027nvme1n1[3] nvme2n1[2] nvme3n1[1]\\n      20508171264 blocks super \u0027"},{"line_number":1709,"context_line":"            \u00271.2 level 5, 512k chunk, algorithm 2 [4/4] [UUUU]\\nunused \u0027"},{"line_number":1710,"context_line":"            \u0027devices: \u003cnone\u003e\\n\u0027)"},{"line_number":1711,"context_line":"        mock_fd \u003d mock_open.return_value.__enter__.return_value"},{"line_number":1712,"context_line":"        mock_fd.read.return_value \u003d md_stat_contents"},{"line_number":1713,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"67da147e_e0110f50","line":1710,"in_reply_to":"3f07e27b_4ce471aa","updated":"2022-08-23 10:18:59.000000000","message":"Can\u0027t do much better considering the length of one of the lines...\n\n      20508171264 blocks super 1.2 level 5, 512k chunk, algorithm 2 [4/4] [UUUU]\n      \nI moved it to the beginning of the file, hope that\u0027s more friendly","commit_id":"763d8cd1de1da0dec2538f8de1e9bf28159483e7"}]}