)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e7051ff16727e47cbe272bf10dff37f1c9f7b652","unresolved":true,"context_lines":[{"line_number":25,"context_line":"Closes-Bug: #1961102"},{"line_number":26,"context_line":"Depends-On: I8cda6d9830f39e27ac700b1d8796fe0489fd7c0a"},{"line_number":27,"context_line":"Change-Id: Id872543ce08c934cefbbbdaff6ddc61e3828b1f1"},{"line_number":28,"context_line":"(cherry picked from commit 3ff0e445199e80b3e6f0a6ff826a27321fd86421)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"0bf52f5d_042a27d3","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":68},"updated":"2022-07-26 03:44:31.000000000","message":"Not sure what this is referring to ... the only result when you search on this commit in gerrit is this patch.","commit_id":"9bb343c4ee400ebf976c8dc230dec106f29d0bf4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"817128cef14c18d6043eef8b9b233e4a11abd5ef","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Closes-Bug: #1961102"},{"line_number":26,"context_line":"Depends-On: I8cda6d9830f39e27ac700b1d8796fe0489fd7c0a"},{"line_number":27,"context_line":"Change-Id: Id872543ce08c934cefbbbdaff6ddc61e3828b1f1"},{"line_number":28,"context_line":"(cherry picked from commit 3ff0e445199e80b3e6f0a6ff826a27321fd86421)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"e47010a7_c1c1136c","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":68},"in_reply_to":"0bf52f5d_042a27d3","updated":"2022-07-26 14:28:53.000000000","message":"LOL, I\u0027ll remove this, it was some moving around that I was doing.","commit_id":"9bb343c4ee400ebf976c8dc230dec106f29d0bf4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2c2a418c051365371de4458625e529e383c2dfc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"156a3908_de470ce1","updated":"2022-07-26 03:36:29.000000000","message":"Typo noted in release note.","commit_id":"9bb343c4ee400ebf976c8dc230dec106f29d0bf4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cfac6b80e446fc31d94a022bfe868b9ca4c84fc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"aebc43b0_0a55689b","updated":"2022-07-27 07:19:25.000000000","message":"Nothing major, reiterating Brian\u0027s comment but can be addressed in a followup. LGTM.","commit_id":"1cb6d3e1f16d9bd63186fe1e7fcf706d084fa992"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"413836cf78cee2a8842fb571f3a7b6cf7185c079","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d8fbfb8f_4ecc8ae1","updated":"2022-07-26 23:03:22.000000000","message":"Question inline about a comment in the code, otherwise this looks good to me.","commit_id":"1cb6d3e1f16d9bd63186fe1e7fcf706d084fa992"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fe7f9f93ce04132c7eb991f61da35e5125cac189","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"cfcf3589_0bb4a7f4","updated":"2022-07-27 11:38:15.000000000","message":"recheck","commit_id":"1cb6d3e1f16d9bd63186fe1e7fcf706d084fa992"}],"os_brick/initiator/utils.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cfac6b80e446fc31d94a022bfe868b9ca4c84fc1","unresolved":true,"context_lines":[{"line_number":46,"context_line":"    - None \u003d\u003d\u003e Always lock."},{"line_number":47,"context_line":"    \"\"\""},{"line_number":48,"context_line":"    shared \u003d device.get(\u0027shared_targets\u0027, False)"},{"line_number":49,"context_line":"    if (shared is not None and ISCSI_SUPPORTS_MANUAL_SCAN) or shared is False:"},{"line_number":50,"context_line":"        yield"},{"line_number":51,"context_line":"    else:"},{"line_number":52,"context_line":"        # Cinder passes an OVO, but Nova passes a dictionary, so we use dict"}],"source_content_type":"text/x-python","patch_set":13,"id":"83dae3ba_89372720","line":49,"range":{"start_line":49,"start_character":7,"end_line":49,"end_character":77},"updated":"2022-07-27 07:19:25.000000000","message":"suggestion:\ntook me some time to understand the condition, maybe could\u0027ve been written as,\n\nif shared is False or (shared and ISCSI_SUPPORTS_MANUAL_SCAN)\n\n1) shared is False will quickly yield if it\u0027s false without checking the later condition\n2) if we rule out shared is not false, shared and ISCSI_SUPPORTS_MANUAL_SCAN should be true together","commit_id":"1cb6d3e1f16d9bd63186fe1e7fcf706d084fa992"}],"os_brick/tests/initiator/test_utils.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"413836cf78cee2a8842fb571f3a7b6cf7185c079","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    def test_guard_connection_manual_scan_support_forced(self, mock_lock):"},{"line_number":52,"context_line":"        \"\"\"Guard locks when cinder forces locking.\"\"\""},{"line_number":53,"context_line":"        utils.ISCSI_SUPPORTS_MANUAL_SCAN \u003d True"},{"line_number":54,"context_line":"        # We confirm that shared_targets is ignored"},{"line_number":55,"context_line":"        with utils.guard_connection({\u0027service_uuid\u0027: mock.sentinel.uuid,"},{"line_number":56,"context_line":"                                     \u0027shared_targets\u0027: None}):"},{"line_number":57,"context_line":"            mock_lock.assert_called_once_with(mock.sentinel.uuid, \u0027os-brick-\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"20f7c994_1322f4b6","line":54,"range":{"start_line":54,"start_character":10,"end_line":54,"end_character":51},"updated":"2022-07-26 23:03:22.000000000","message":"I find this comment confusing.  Aren\u0027t we checking that shared_targets is None is honored and the lock is called, even if manual scan is supported (which is when we usually would not lock)?","commit_id":"1cb6d3e1f16d9bd63186fe1e7fcf706d084fa992"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cfac6b80e446fc31d94a022bfe868b9ca4c84fc1","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    def test_guard_connection_manual_scan_support_forced(self, mock_lock):"},{"line_number":52,"context_line":"        \"\"\"Guard locks when cinder forces locking.\"\"\""},{"line_number":53,"context_line":"        utils.ISCSI_SUPPORTS_MANUAL_SCAN \u003d True"},{"line_number":54,"context_line":"        # We confirm that shared_targets is ignored"},{"line_number":55,"context_line":"        with utils.guard_connection({\u0027service_uuid\u0027: mock.sentinel.uuid,"},{"line_number":56,"context_line":"                                     \u0027shared_targets\u0027: None}):"},{"line_number":57,"context_line":"            mock_lock.assert_called_once_with(mock.sentinel.uuid, \u0027os-brick-\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"25fddba5_639ca047","line":54,"range":{"start_line":54,"start_character":10,"end_line":54,"end_character":51},"in_reply_to":"20f7c994_1322f4b6","updated":"2022-07-27 07:19:25.000000000","message":"+1, this should be clarified","commit_id":"1cb6d3e1f16d9bd63186fe1e7fcf706d084fa992"}],"releasenotes/notes/nvmeof-disconnect-83f9aaf17f8c8988.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2c2a418c051365371de4458625e529e383c2dfc1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    NVMe-oF connector `bug #1961102"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/os-brick/+bug/1961102\u003e`_: Fixed leaving"},{"line_number":6,"context_line":"    controller devices (i.e., /dev/nvme0) behind on hosts.  Now NVMe-oF"},{"line_number":7,"context_line":"    subsytems are disconned when disconnecting volumes if the subsytem doesn\u0027t"},{"line_number":8,"context_line":"    have additional volumes present in the host."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"141d6666_964ee36a","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":27},"updated":"2022-07-26 03:36:29.000000000","message":"disconnected","commit_id":"9bb343c4ee400ebf976c8dc230dec106f29d0bf4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"817128cef14c18d6043eef8b9b233e4a11abd5ef","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    NVMe-oF connector `bug #1961102"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/os-brick/+bug/1961102\u003e`_: Fixed leaving"},{"line_number":6,"context_line":"    controller devices (i.e., /dev/nvme0) behind on hosts.  Now NVMe-oF"},{"line_number":7,"context_line":"    subsytems are disconned when disconnecting volumes if the subsytem doesn\u0027t"},{"line_number":8,"context_line":"    have additional volumes present in the host."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bc28ff91_093de73b","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":27},"in_reply_to":"141d6666_964ee36a","updated":"2022-07-26 14:28:53.000000000","message":"Done","commit_id":"9bb343c4ee400ebf976c8dc230dec106f29d0bf4"}]}